- when the first argument is null API should return hipErrorInvalidValue
- but when first and second argument both are null API was returning hipErrorInvalidHandle causing catch2 event tests to fail
Change-Id: I0978ce8b8462e4baa043be75a40b5bc45b036bb6
[ROCm/clr commit: 688288c2e3]
Re-enable __HIPCC_RTC__ in hip_vector_types.h which require
an upstream clang patch, 6823af0ca858b54e09e5be61a19d067ccd0bd6b7.
Once upstream patch has landed in mainline, merge this for
hiprtc functionality.
Change-Id: Ife884e0c3081b307bdadc8bec7804d1d7c60153b
[ROCm/clr commit: e5a1f25424]
- Also revise the implementation of atomicInc/atomicDec based on clang
builtins.
Change-Id: Ia5e06e88c7be1da5f8fc7ac70037a120c604e343
[ROCm/clr commit: 45205c5e53]
Specify for packaging that clinfo is a program. This will set its
default permissions to include OWNER_EXECUTE, GROUP_EXECUTE and
WORLD_EXECUTE.
Change-Id: I986f6db73efa9a3f8ab5bedfb829adccad0759aa
[ROCm/clr commit: 31e688d8f0]
This reverts commit b01fb5d72f.
Rework to support old cmake in order to fix mathlibs' failure.
Change-Id: I605fc633ba28df4fca95ceee83671600dd3f0b72
[ROCm/clr commit: 53b3c8a3fb]
HSA signal callback order is undefined. Make sure start event is
also done before calculating the elapsed time.
Change-Id: Ic69bfe336b20cd62ef35194261a5d0d234bc65ce
[ROCm/clr commit: 910d8bdfde]
Add the CMake support for generating the hiprtc-builtins
library. Replaces the previous execution of shell script.
For backwards compatibility, link hiprtc pre-processed
object to amdhip64, and support versioning in name.
Add libcmt.lib to Windows link step, due to manually
generated .obj from llvm-mc.
Change-Id: I267be3cf4b241840b35f7f27a0b8659530108b0e
[ROCm/clr commit: c42308e2e5]
In file included from /extra/lmoriche/hip-vdi/hip/rocclr/hip_internal.hpp:25,
from /extra/lmoriche/hip-vdi/hip/rocclr/hip_hmm.cpp:22:
/extra/lmoriche/hip-vdi/hip/rocclr/hip_prof_api.h: In constructor ‘api_callbacks_table_t::api_callbacks_table_t()’:
/extra/lmoriche/hip-vdi/hip/rocclr/hip_prof_api.h:72:59: warning: ‘void* memset(void*, int, size_t)’ clearing an object of type ‘struct api_callbacks_table_t::hip_cb_table_t’ with no trivial copy-assignment; use value-initialization instead [-Wclass-memaccess]
72 | memset(&callbacks_table_, 0, sizeof(callbacks_table_));
| ^
/extra/lmoriche/hip-vdi/hip/rocclr/hip_prof_api.h:67:10: note: ‘struct api_callbacks_table_t::hip_cb_table_t’ declared here
67 | struct hip_cb_table_t {
| ^~~~~~~~~~~~~~
Address the above warning by providing default initialization of the
api_callbacks_table_t::hip_cb_table_t class members.
Change-Id: I69ea7c390c28cf3f8aec57f23566d6a3061a0365
[ROCm/clr commit: 0f7a47a95f]
There is no OUTPUT_FILE option for add_custom_command (it is an option
for execute_process). Instead, redirect stdout to the output file.
Change-Id: Ic649bc6c4f709c3c42166500a72fce5014690a47
[ROCm/clr commit: f3a54f0823]
Instead of using inline asm, use clang builtins
for llvm intrinsics.
Change-Id: I30287f5a8de035ccd7e48d10e559a8a2e1d389f7
[ROCm/clr commit: 3fa21c1d49]
Add a hip::Stream::destroyAllStreams static function to destroy all streams
Also call MemObjMap::Purge
Change-Id: I6ee7e3f26ab1f1870a9271c65e99fb818134482b
[ROCm/clr commit: bea4fa8700]
Current packaging assumes that HIP runtime will always be installed in
/opt/rocm/lib. This is false to assume, because some distros like CentOS
will use the lib64 directory instead of lib. Relying on CMake to choose
the library directory for us will default in that case to lib64. Hence
there will be a mismatch between where HIP is installed and where CMake
thinks it is.
Change-Id: I46e405b25bda987e74b095fcb41319f8a504ae41
[ROCm/clr commit: 52ff66f4fc]
Check GPU signal status for event before falling into CPU command
status validation
Change-Id: I66f15752d7dca550c0fa1a2252ec5a63817391c3
[ROCm/clr commit: dd8265fc87]
Currently build is only passing because amdhip64 is being built with
headers from /opt/rocm/include. It should be using the headers from
the hipamd project.
Change-Id: I27cb64b460547ef281d368322afac376fa49db51
[ROCm/clr commit: 37be0e449a]
Correctly reference the new amdocl target.
Do not use hardcoded paths to libamdocl64.so, instead query the path to
it from cmake.
Change-Id: I4738dd8d6d08f9fb72fdd725b6488b81342755a4
[ROCm/clr commit: 6046e6fea4]
-Bsymbolic is required to make sure all AMD OpenCL runtime symbols are
resolved internally, otherwise ld might resolve them using symbols from
the OpenCL ICD. This will cause incorrect functions to be called.
Change-Id: I4ca0326a574ee2e537525bfda96ec20fabfe0158
[ROCm/clr commit: bc5c8df20b]
This patch also includes additional cleanup logic to the installation
rules. The OpenCL ICD already defines its own installation rules, no
need to duplicate them.
Change-Id: Id1c386307a83b82e21f6fa132e41957d9b348fd3
[ROCm/clr commit: c6eadce180]
Remove extra -isystem causing --cuda-device-only flag
to be dropped. Fix missing __hipRTC_header_size symbol.
Add macros which were consumed during pre-processor
generation. Add INT_MAX and CHAR_BIT macros used in
HIP headers.
Change-Id: Id5143e3c8a2b1e7c78658ba84d5ab3b55ac1fa72
[ROCm/clr commit: 7c8e210c26]
Satyanvesh Dittakavi
Aaron En Ye Shi
Michael LIAO
Vladislav Sytchenko
Julia Jiang
Anusha GodavarthySurya
Maneesh Gupta
Rahul Garg
Tao Sang
Sarbojit Sarkar
Jatin
German Andryeyev
Christophe Paquot
Aleksey
pghafari
Saleel Kudchadker