Commit Graph

13402 Commits

Author SHA1 Message Date
cjatin b2a694ae62 SWDEV-277697 - Fix ununsed variable error with -Werror,-Wunused-parameter
Change-Id: Iadd0050e6cf4e4858e1508c1f24f73732a1af443


[ROCm/clr commit: 4d69596c66]
2021-06-03 13:25:07 -04:00
jujiang 1b9da2f32b SWDEV-279885 - correct HIP doc for managed memory
Change-Id: I94bb307dbe12692eb60cce744424fb18deea28ba


[ROCm/clr commit: 0a6d2ea863]
2021-06-03 11:05:18 -04:00
Vladislav Sytchenko 13c6452a0d SWDEV-273235 - Correct linker export file usage
CMake doesn't handle linker export files in a general way well. On
Windows it is able to recognize a .def file and pass it to the linker.
Unfortunately it cannot do the same thing on Linux, so we have to
manually specify it.

Note that CMake can't recognize the current Windows export file due to
the .in suffix, hence why the amdhip.def file is being added. The
hip_hcc.def.in file will be removed later, as the Makefile build still
uses it.

Change-Id: Id3e4645c95959e13f50efd88bc43f3a1d3e50d58


[ROCm/clr commit: e4e9110f97]
2021-06-03 11:00:26 -04:00
Robert Maynard b35dc7a55c SWDEV-288593 - hip-config only adds compile and link options to C++
Change-Id: Iefc7c3597fc8c8864621ad6154352c9dd56a3e74


[ROCm/clr commit: 576af84864]
2021-06-03 00:18:12 -04:00
Vladislav Sytchenko 43b6294afb SWDEV-273235 - Do not use target_link_options()
Some CI systems have a somewhat out of date version of cmake, which
does not have this functionality. Fall back to using
target_link_libraries() instead.

Change-Id: I2410b24bcb6f1be2c2c3303ccd0019b10c914d2e


[ROCm/clr commit: 58c93c8047]
2021-06-02 21:03:28 -04:00
German Andryeyev a073c62d95 SWDEV-240804 - Add hipMemAdvise() extension
Add coarse grain memory extension. The new advice will allow HMM
to disable cache coherency policy to improve performance

Change-Id: I3c792d6a96896b983a7ffccddaa0ded06d183212


[ROCm/clr commit: 2b3a4e711b]
2021-06-02 16:16:14 -04:00
agodavar db5cda77a6 SWDEV-288510 - Add hip shared library path to run-time search for linker
Change-Id: I7eaf712c01556933b881b983a8994f4e06333116


[ROCm/clr commit: 0714bdfbea]
2021-06-02 12:57:12 -04:00
Vladislav Sytchenko 208c198d71 SWDEV-273235 - Correct linker export file usage
CMake doesn't handle linker export files in a general way well. On
Windows it is able to recognize a .def file and pass it to the linker.
Unfortunately it cannot do the same thing on Linux, so we have to
manually specify it.

Note that CMake can't recognize the current Windows export file due to
the .in suffix, hence why the amdocl.def file is being added. The
amdocl.def.in file will be removed later, as the Makefile build still
uses it.

Change-Id: I33a4151af0257d56d46cd27cbd028b34b77b706b


[ROCm/clr commit: 75b232eea2]
2021-06-02 12:56:14 -04:00
Vladislav Sytchenko eb028aa92e SWDEV-288814 - Revert back to old target naming
HIP exports the runtime target as amdhip64. This target was recently
renamed to amdhip. It is unclear as to who uses this target, as HIP
clients need to use the device/host targets instead, but we still need
to support it for backwards compatability.

Change-Id: I68b9798ab967420e0642d50621d3c8b577a05435


[ROCm/clr commit: e037632fbd]
2021-06-01 17:37:30 -04:00
Vladislav Sytchenko 241d5bab38 SWDEV-288814 - Remove dependency on ROCclr
HIP only has a dependency on ROCclr at build time. When exporting HIP,
ROCClr is already embedded into the shared/static library. There is no
reason to search for it.

Change-Id: I8d7e8e58164e5585a1dfc9c998ecf02ca42d8aac


[ROCm/clr commit: 815e8dd2a3]
2021-06-01 17:37:30 -04:00
Vladislav Sytchenko f0e57d7538 SWDEV-273235 - Partial cleanup of HIP installation logic
Don't install HIP source code.

Correctly install the HIP shared library based on platform. On Linux,
it will be installed to lib/, but on Windows it will be installed to
bin/. CMake will handle this for us.

Change-Id: I00cc074ad8e13b1b953b21444f0c2b5f50dc03c0


[ROCm/clr commit: 60e9b25650]
2021-06-01 17:37:30 -04:00
Vladislav Sytchenko 6140159d8f Revert "SWDEV-255979 - Enable __managed__ test for amd platform"
This reverts commit 99188c6f3b.

Change-Id: Ib1be007535dcfb24d9e4eddbdb706d3be4acc20c


[ROCm/clr commit: 59b98a3949]
2021-06-01 17:37:30 -04:00
Vladislav Sytchenko 41a101bd58 SWDEV-273235 - Remove unused logic
git is invoked to populate OPENCL_VERSION_GITDATE, but the value is no
where to be used in the project.

Change-Id: Iceae650e6260c2ccd749f582034fc09205b4af7a


[ROCm/clr commit: 40f87d6d86]
2021-06-01 14:31:21 -04:00
Vladislav Sytchenko 9f54cba1ed SWDEV-273235 - Cleanup OpenCL installation logic
Don't use hardcoded install destinations. CMake will decide where things
should be installed based on platform.

Change-Id: Ifcf956181d3efb32d4ce6191a89c1ea225d0e8cc


[ROCm/clr commit: d53c19cfa5]
2021-06-01 14:31:14 -04:00
Joseph Greathouse 5037dd6a4c SWDEV-288361 - Implement funnel shift operators
Change-Id: I0c73809366f2d21e75f98fdeac7fed0c7591ee34


[ROCm/clr commit: 3212fdf4d6]
2021-06-01 11:10:11 -04:00
cjatin cf86d418c0 SWDEV-277697 - [CatchTest] Disable CXX Extensions (gnu++11 etc) on CMake
Change-Id: I17abd329c16cf0a61316186558828d0524b98281


[ROCm/clr commit: 895e83851c]
2021-06-01 06:48:05 -04:00
Anusha GodavarthySurya b07207b6c4 SWDEV-255979 - Add support for dynamic __managed__ variables
Change-Id: I62b790853ea3ab3b7ac57bab389046c627fdecce


[ROCm/clr commit: 995e6bff13]
2021-06-01 05:09:51 -04:00
agodavar d5896f5826 SWDEV-288708 - Rationalize HIP runtime and device version reporting
Change-Id: I49a7ee1fa9ae3ef5f26d99d18c0b8bb58cb9d5ce


[ROCm/clr commit: c654059c17]
2021-06-01 05:09:36 -04:00
Tao Sang 7aad531c84 SWDEV-276853 - Add kernelVerify
Add kernelVerify for data verification and memory
reading performance checking in kernel.

Change-Id: Id3f9bcad75d643f493daf9d5f47b3a012a427179


[ROCm/clr commit: f7e3347215]
2021-05-31 12:45:10 -04:00
Anusha GodavarthySurya 99188c6f3b SWDEV-255979 - Enable __managed__ test for amd platform
Change-Id: I0cb31c1983e68e9010340770a56fc45b2a619dcd


[ROCm/clr commit: 25f190a645]
2021-05-31 05:35:05 -04:00
Satyanvesh Dittakavi b7003a59a4 SWDEV-286231 - Fix hipMallocManaged tests failure
Test is modified as hipMemAttachHost is accepted now by hipMallocManaged

Change-Id: If73d210297cde7a92960eef57a902dbd6402a173


[ROCm/clr commit: 3488785a89]
2021-05-31 04:10:47 -04:00
Anusha GodavarthySurya 7fd69efe49 SWDEV-287027 - Improve launch bounds error log message
Change-Id: I3229580daa97f141de89bacddfce45cd43f24b19


[ROCm/clr commit: d25dc8af85]
2021-05-31 01:51:58 -04:00
German Andryeyev d100715c28 SWDEV-240804 - Fix typos in the comments
Change-Id: Ic1385daf1e685772b02a11d43fb13f6cde74c4b7


[ROCm/clr commit: 0e11c59272]
2021-05-29 00:31:46 -04:00
Vladislav Sytchenko 58072982e2 SWDEV-273235 - Fix warning in the cmake build
Change-Id: I8f9d51ea676cb015abf47a2998fa053c2d4a6e81


[ROCm/clr commit: 691c77c0f9]
2021-05-28 11:20:52 -04:00
Vladislav Sytchenko fe309cb62e SWDEV-273235 - Disable versioning for Windows
Not yet supported.

Change-Id: I9840120e1e5c40c6d3004229c4a5b06fd42cf4b6


[ROCm/clr commit: 8e9e26b1a9]
2021-05-28 11:20:37 -04:00
Vladislav Sytchenko d6efc45278 SWDEV-273235 - Fix Windows CMake build
Change-Id: Idcf89ac20b4f275de33e9f6edd009706f8c432fb


[ROCm/clr commit: 2884650eb8]
2021-05-28 11:20:23 -04:00
Vladislav Sytchenko 019425fb9a SWDEV-273235 - Restore 2ec524b
Change-Id: Id2d3e54dc4f35974c12ecbec661a005cac90e5b1


[ROCm/clr commit: d013aa2639]
2021-05-28 11:08:17 -04:00
German Andryeyev 9a599494f6 SWDEV-287137 - Add extra blocking marker
HIP should block the stream until callback is done. This change
will introduce extra marker that will block the queue.
Note: MT path doesn't really require extra marker, but the logic
is identical to avoid extra checks for direct dispatch

Change-Id: Ib90fd2d751adf337f5e43ac6098e84767530233b


[ROCm/clr commit: 8716b0f4de]
2021-05-27 21:17:18 -04:00
Vladislav Sytchenko 22cc67a4db SWDEV-273235 - Fix warning in the cmake build
Change-Id: I9840da22fcce11712c32e68f07ad886d08c8b16f


[ROCm/clr commit: ae36b6c0aa]
2021-05-27 18:09:26 -04:00
Vladislav Sytchenko 6b24f92d0f SWDEV-273235 - Initial support for Windows CMake
This change is tied to the ROCclr cmake rework. ROCclr will now be built
as part of HIP itself.

All the dependencies on comgr and rocr have been moved into ROCclr
itself. This allows HIP to pull in all the required compiler/runtime
dependencies by simply linking against ROCclr. Note that ROCclr needs to
be configured from HIP cmake command line. If not, we will default to
LC + ROCr support.

Since HIP depends on ROCclr and ROCclr depends on OpenCL, HIP will
transitevly pull in all the required OpenCL headers. No need to keep a
local copy of them anymore.

Change-Id: Ib39f4929e88da1248be962490c150b10fc7abd3a


[ROCm/clr commit: e34a7e8c0c]
2021-05-27 15:21:05 -04:00
Vladislav Sytchenko f7bbb7b988 SWDEV-273235 - Initial support for Windows CMake
This change is tied to the ROCclr cmake rework. ROCclr will now be built
as part of OpenCL itself.

All the dependencies on comgr and rocr have been moved into ROCclr
itself. This allows OpenCL to pull in all the required compiler/runtime
dependencies by simply linking against ROCclr. Note that ROCclr needs to
be configured from OpenCL cmake command line. If not, we will default to
LC + ROCr support.

Change-Id: I5271302d073aef8cfa617828d218c856711bf9ba


[ROCm/clr commit: 1c16690617]
2021-05-27 13:08:12 -04:00
Jason Tang e24706f99d SWDEV-287945 - LinuxPro: Disable PAL for gfx9+
Change-Id: Ief81629e53a4c0ca529a510dac5063a8885257bf


[ROCm/clr commit: 1b832c0182]
2021-05-27 11:05:43 -04:00
Chauncey Hui a0f432fdc4 SWDEV-2 - Change OpenCL version number from 3314 to 3315
[ROCm/clr commit: be7bb4b63c]
2021-05-27 03:00:06 -04:00
Anusha GodavarthySurya c20cfdcdde SWDEV-288065 - allow hipcc to recognize .C files
Change-Id: I0ec884eb6e083e823cf27ca1251c354a7f3b744c


[ROCm/clr commit: ba28a01258]
2021-05-26 10:25:57 -07:00
German Andryeyev 1184f7af0b SWDEV-287137 - Fix regression with dependent signals
- Make sure barrier with dependent signals issues before queue
index reservation
- Don't issue extra barrier if it's already a barrier command
with dependent signals

Change-Id: I179a8b7adac79eed698f4a4d9eca2606d8e913aa


[ROCm/clr commit: 148a5cac39]
2021-05-26 12:36:56 -04:00
Aaron En Ye Shi 2ec524b86d SWDEV-283266 - Fix Linux Pro build for hiprtc
Linux Pro build uses the LLVM_ROOT variable to
specify where llvm is located. We must use a different
name, HIP_LLVM_ROOT for LLVM's prefix location.

Change-Id: I28baf8672217a438a5dd45829d9af04b3553f615


[ROCm/clr commit: ec22410ca5]
2021-05-26 10:37:44 -04:00
Jason Tang e8ca936563 SWDEV-287332 - Disable NullDevice in HIP
Change-Id: I45c6010d2a3fcd0576438e3c72fbed78dff09b6b


[ROCm/clr commit: 7932b5a562]
2021-05-26 09:27:59 -04:00
Chauncey Hui 5d93ef67af SWDEV-2 - Change OpenCL version number from 3313 to 3314
[ROCm/clr commit: a3f24ec93e]
2021-05-26 03:00:03 -04:00
Tao Sang d3df3bc2a9 SWDEV-288106 - Fix g++/hipMalloc
Fix a typo

Change-Id: I71328687b2dd4a3f563571f2b755079d83dca63e


[ROCm/clr commit: b9d70a3da9]
2021-05-25 17:23:36 -04:00
jujiang c8bdbc1723 SWDEV-286322 - add an attribute file to modify EOL
Change-Id: I5ca49a0107e129a2f949d767d2d6e0169140191d


[ROCm/clr commit: 401fabbf13]
2021-05-25 15:19:29 -04:00
German Andryeyev 3e36acd579 SWDEV-278894 - Use GPU waits for HIP events
Save HW events in amd::Event.
Use HW events for synchronization

Change-Id: I98cf9c2d0ec3c7fcaf254b749ac6c568d7270ae0


[ROCm/clr commit: fa2e154a8b]
2021-05-25 13:41:15 -04:00
Tao Sang da014f748f SWDEV-276853 - Add test for mem perf
Add memory filling performance test for large bar device memory,
hip managed memory, conherent/non-coherent host memory and fine
grained device memory

Change-Id: Id3f9bcad45d643e493daf9d5f47b3a012a427178


[ROCm/clr commit: e594ae6581]
2021-05-25 12:32:44 -04:00
Jatin Chaudhary 650d6031fa SWDEV-277697 - Make sure hipcc can handle standard CXX options when being used with nvcc
Change-Id: I76b1f2943a660eefda858397218a775083b99228


[ROCm/clr commit: bfc6eed3d5]
2021-05-25 07:35:02 -04:00
Jatin Chaudhary 0db4210a86 SWDEV-277697 - [CatchTest] Fix Documentation, Add test to AMD specific, Add HIP Macros, New Binary for multiproc tests
Change-Id: I3783caf85c694b724ed55b778220b8ef9a39f84b


[ROCm/clr commit: 8749e231e6]
2021-05-25 07:12:54 -04:00
Jatin Chaudhary 83e7ce2dce SWDEV-280067 - Document hipErrorNoBinaryForGpu error in hip faq
Change-Id: Ie8cab47ecac5a1b0972041d6e3e58e4fca278c41


[ROCm/clr commit: ed4c4fbcba]
2021-05-25 15:14:08 +05:30
Satyanvesh Dittakavi 6eeee12ccc SWDEV-286830 - Fix hipStreamACb_ThrdBehaviour on windows
use sleep_for which works cross-platform
for other tests as well

Change-Id: I915444d620e9fad0b9eda93bcdd244f9956ab8d5


[ROCm/clr commit: 5738bf4a29]
2021-05-24 03:18:36 -04:00
Aaron En Ye Shi c9f19b9d26 SWDEV-283266 - Workaround RTC macro in vector types
Temporarily disable __HIPCC_RTC__ in hip_vector_types.h
while the upstream clang headers are outdated on mainline.
Once upstream patch has landed in mainline, revert this
change. This is a workaround for hiprtc testing.

Change-Id: Ib2cf6023b71431bbfbe3c699076caa4f90f7170c


[ROCm/clr commit: 414c80644b]
2021-05-21 15:53:59 +00:00
Chauncey Hui ae9cc2d400 SWDEV-2 - Change OpenCL version number from 3312 to 3313
[ROCm/clr commit: af4efc3b22]
2021-05-21 03:00:03 -04:00
Satyanvesh Dittakavi be7955896f SWDEV-278464 - Update unit test hipEventMultiThreaded
Run with multiple threads to catch possible race condition
Disable running the test by default on CI as this takes lot of time

Change-Id: I1c1a66fd5c72f8d2bf7ad120461384488b46abbd


[ROCm/clr commit: 247a1e1fee]
2021-05-21 02:57:14 -04:00
Satyanvesh Dittakavi 09ff27b5c1 SWDEV-285521 - SWDEV-284626 - Fix P2P and Caffe2 test failures
- waitList was released before the awaitcompletion
causing stream sync after the async copies fail

- Enable the hipPeerToPeer_simple test

Change-Id: I1eeaa7e6320ab38c106902078f034dfec4c3f3ea


[ROCm/clr commit: e9ac835e0e]
2021-05-21 02:54:22 -04:00