Commit Graph

13402 Commits

Author SHA1 Message Date
Aryan Salmanpour 7ec4a9af8e [HipPerf] add two subtests for measuring maximum device memory read/write speed
SWDEV-245290 / SWDEV-246220 [HIPPerf] Port OCLPerfDevMemWriteSpeed/OCLPerfDevMemReadSpeed into hip performance subtests

Change-Id: I5dc323c75cebbc17596dcb4ed9492e18c5246868


[ROCm/clr commit: b98727505d]
2020-08-07 14:21:27 -04:00
David Salinas dbeb78fa07 correct -x option in hip::device
Change-Id: I8c288e678b4357019144a024395cda1fcead61fc


[ROCm/clr commit: 996df70de9]
2020-08-07 12:33:43 -04:00
Jason Tang c926997eb8 Use ARCTURUS
Change-Id: Ib25d150c9314180178d5cf00835a06e47c02c2a9


[ROCm/clr commit: 6f8eaff4df]
2020-08-07 11:14:24 -04:00
Aryan Salmanpour 0372607c1b [HipPerf] add a test for measuring shared memory read speed
SWDEV-245290/SWDEV-247330

Change-Id: If78fa0879ff58aab84775e412a86665c7e5959e7


[ROCm/clr commit: 61dafa0397]
2020-08-07 10:07:05 -04:00
Yaxun (Sam) Liu 1ca3e4696e Let hipcc not escape space between obj files extracted from library
hipcc extracts bundles from static libraries and pass them to clang. It should
not escape spaces between objects extracted from library.

Fixes: SWDEV-246544
Change-Id: Iad3902f28a43a3986917ee37a49f10382c329940


[ROCm/clr commit: c1a498c219]
2020-08-07 09:34:27 -04:00
Jatin Chaudhary 492c85b8fb Bring .clang-format file in sync with ROCclr's
Change-Id: I1990722c0779d61f66d79a5d0649d1b64e42eaf7


[ROCm/clr commit: fb2760a8aa]
2020-08-07 05:34:44 -04:00
Jatin Chaudhary 093f0490d6 Fixing the memchannel calculation
Change-Id: Ib5f5931cc0e1ee5b7cb356c2ede0cb951ee8c9de


[ROCm/clr commit: f0d9df0b71]
2020-08-07 05:34:23 -04:00
Jatin Chaudhary bee94be69d Cuda 11 changes: https://docs.nvidia.com/cuda/cuda-runtime-api/structcudaPointerAttributes.html\#structcudaPointerAttributes
Change-Id: I8a5389b88df286043c365a734983a4c5de352102


[ROCm/clr commit: 94bfd485ef]
2020-08-07 05:33:33 -04:00
Jason Tang 04054e9b60 SWDEV-246565 - Remove passing -msram-ecc to Comgr
Change-Id: I1604a0014186a5779561da3ec3eefec65aff5c37


[ROCm/clr commit: f8f6bc16a1]
2020-08-06 12:48:53 -04:00
Julia jiang b2f831ca46 SWDEV-247185-update OpenCL build instructions in Readme
Change-Id: Id2835bfcbc3d19315c688a8160eedf367056ba5f


[ROCm/clr commit: ed1fcc7c63]
2020-08-06 12:10:36 -04:00
Saleel Kudchadker fd7ea936fe Enable queue profile only if we attach a profiler
Submit explicit profile marker for hipEventRecord to record
timestamps. Enable explicit signal profiling if the API specifies
start and stop events.

Toggle this with env var HIP_FORCE_QUEUE_PROFILING=0

Change-Id: Iae449a63ec3ebf6c2880e65d7b1dd1031a29018f


[ROCm/clr commit: dec95e58e3]
2020-08-06 11:28:16 -04:00
Jatin Chaudhary ba5507f650 Adding device memory channel information
Change-Id: I47dfa3daff97b1e3f42484dde5a4aa64244ac544


[ROCm/clr commit: 2f3df8e691]
2020-08-06 06:54:35 -04:00
Payam 1cdf2afd5e adding duration to print log for hip api calls
Change-Id: Icffa8fcacfb8ba24861d980b9553faeee4efec8c


[ROCm/clr commit: c24f884c76]
2020-08-06 06:42:21 -04:00
Saleel Kudchadker 820a456980 Add Queue profling param and toggle for HIP
Use signal timestamps if NDRange command takes forceProfile flag.

Change-Id: Ib7f187d781fd78a7346818afb3344a9378f4c104


[ROCm/clr commit: ec73340348]
2020-08-06 03:09:53 -04:00
Sarbojit Sarkar ee526f9212 Added free device memory info
Recently there were few OOM(out of Memory) issues poped. Adding trace will help know genuine OOM issue. 
Change-Id: Ie2a56bba95cead24caf1af5c807e73c383c2f5d9


[ROCm/clr commit: bc76760452]
2020-08-06 01:16:36 -04:00
Anusha Godavarthy Surya de10e7e1e6 SWDEV-244600 - HIP BLIT code object needs to have reserved symbol name
Change-Id: I8401fea5eab71c0f7414eec0666066d9553a6622


[ROCm/clr commit: 093f7fa3ca]
2020-08-06 01:14:06 -04:00
Jason Tang e1b0edf35c SWDEV-246687 - Do not use std::vector reference as class member cuMask_
The current implementation creates default reference in the stack and assigns it to class member cuMasks_, so whenever the content of the stack changes, cuMask_ would change.

Change-Id: Iefab63c335d504b83c4ae90bd34ae76c6afb8f3c


[ROCm/clr commit: 8ef5da00c7]
2020-08-05 16:57:36 -04:00
Anusha Godavarthy Surya 66be9e86d5 SWDEV-243961 Added overflow check for globalWorkSize
Change-Id: I153d99398eb4619baad8c0a52466e0d5d5f898ca


[ROCm/clr commit: 8481524416]
2020-08-05 11:18:07 -04:00
Chauncey Hui 7f5db8ed81 SWDEV-2 - Change OpenCL version number from 3185 to 3186
[ROCm/clr commit: 6373242a03]
2020-08-05 03:00:05 -04:00
German Andryeyev e34eaf17b9 Process cache coherency before mem dependency tracker
Optimizaiton to remove extra syncs uncovered a bug with the cache
coherency layer, there runtime could lose the track of mem address
if coherency layer performed a sync.

Change-Id: I25647cfa4a4be9cdbd8577ff076a740bbdac79c8


[ROCm/clr commit: 91a25df04f]
2020-08-04 16:33:18 -04:00
Vlad Sytchenko 9d72bf6523 Fix typo
Change-Id: I8b659508f567afa126aeb7749b536b443935e3df


[ROCm/clr commit: 9d0b0c32a9]
2020-08-04 11:15:21 -04:00
Chauncey Hui bebc5b6e80 SWDEV-2 - Change OpenCL version number from 3184 to 3185
[ROCm/clr commit: 8f5698cb17]
2020-07-31 03:00:03 -04:00
Aryan Salmanpour 9fa78dd816 [dtest] disable hipStreamCreateWithPriority test temporarily as it fails randomly on Jenkins
Change-Id: I4edcd555653ef8e7562245da3a6f310d60884fe0


[ROCm/clr commit: cc0f0bae74]
2020-07-30 16:18:04 -04:00
jujiang d308b7006e SWDEV-242207-Update deprecated APIs
Change-Id: Icb64227be0eb44497de99240c0044a162ff3c085


[ROCm/clr commit: 5ac8672fb2]
2020-07-30 15:15:41 -04:00
Rahul Garg ce2da5238a Support empty sources in add_executable and add_library
Change-Id: I1441f2c045aeda2bba99bffe1c99fcc4a59cea9b


[ROCm/clr commit: e3617167f5]
2020-07-30 13:34:46 -04:00
Rahul Garg d66c70a8e1 Bump version to 3.8
Change-Id: I710ee1456aa108eb979eb5bef8f32081dda593d9


[ROCm/clr commit: 2140833421]
2020-07-30 13:30:55 -04:00
Jatin Chaudhary 6c217e7f69 Fixing/Disabling tests on nvcc path
Change-Id: I7ed4a1246943867482ff595d5f98bb25bd79074b


[ROCm/clr commit: d251c2db57]
2020-07-30 00:39:07 -04:00
Freddy Paul 0210995414 hip-rocclr:Remove dependency to rocm-utils
rocm-utils is a meta-pacakge that pull in lot more pacakges than
what is required for hip.

Correct dependency to set as of today will be rocminfo.

Change-Id: I065ca74b4520e0c9ce183d82d6026554ff43e1f0


[ROCm/clr commit: b0438e6e99]
2020-07-28 11:42:09 -04:00
Jason Tang aa179b01a3 SWDEV-243576 - Fix hipMemcpy regression.
If the queue device doesn't match the device on any memory object, use the queue device from the memory object.

Change-Id: I5fdcf00494f8391574f4443332c01788b8da44ef


[ROCm/clr commit: e430506f70]
2020-07-28 03:04:00 -04:00
Jatin Chaudhary 380e2fe752 Removing redundant .hipInfo Install
Change-Id: Id8f7a4668d8b6965a47a464c94c19bc1036f3537


[ROCm/clr commit: 78fcbab8c2]
2020-07-28 02:01:53 -04:00
Rahul Garg 47c57a5a82 Remove libhip_hcc symlinks to libamdhip64
Change-Id: I7b5b47fc7ca9760316c2424c16b454d7919c665c


[ROCm/clr commit: c919a88795]
2020-07-27 23:58:29 +00:00
jujiang e5b39e4056 SWDEV-242344-hipMemcpyAll failed on MGPU
Change-Id: I01671e322c84213964d3d48bd6b5dc704dba731a


[ROCm/clr commit: c1d65e57a1]
2020-07-27 13:30:30 -04:00
Vlad Sytchenko c98a71dc9e Only enable HIP for Vega20 on non-ROCm platforms
SWDEV-245906

All asics will still be supported for developer builds.

Change-Id: I0eac2246162d133fe63449c200d996fe05bd51bd


[ROCm/clr commit: 24c1c48db7]
2020-07-27 13:09:58 -04:00
Chauncey Hui f8c00384fd SWDEV-2 - Change OpenCL version number from 3183 to 3184
[ROCm/clr commit: e793de2ffa]
2020-07-25 03:00:03 -04:00
Payam aef0dc8422 Fix 32bit warning
Change-Id: I4c630d78f7bf23dda85ec8480bb2790864495667


[ROCm/clr commit: 2067de1521]
2020-07-24 13:14:37 -04:00
Tao Sang d7c4f9f492 Remove __gnu_h2f_ieee and __gnu_f2h_ieee
Change-Id: Ide24d245d851e20961020323e52f33322a33fff9


[ROCm/clr commit: e9cc570be8]
2020-07-23 14:50:24 -04:00
Vlad Sytchenko bddfc6a790 2D/3D copy optimizations
SWDEV-244798

If {src/dst} ptr is marked as hipMemoryTypeHost, check if the memory was
prepinned. If it was, upgrade the copy type to hipMemoryTypeDevice to
avoid extra pinning.

Change-Id: Id287ef5b14ae67dfbcf80c4caa1b08a311191948


[ROCm/clr commit: fe6b645f3b]
2020-07-23 11:24:16 -04:00
Chauncey Hui 83ed76f2ac SWDEV-2 - Change OpenCL version number from 3182 to 3183
[ROCm/clr commit: f779f655fd]
2020-07-23 03:00:04 -04:00
Tao Sang 073b1e28d5 Apply constexpr on global constant varaibles
When HIP_ENABLE_DEFERRED_LOADING=0, many global variables will be
referenced but they are not initialized in that early time. The patch
will use constexpr to initialze global constant varables in compile
time.

Change-Id: I9837c42e6bab38a894ece4e0f34b64f81b38fef0


[ROCm/clr commit: f7cc49c0b2]
2020-07-22 22:15:03 -04:00
Tao Sang 44eb207f8d Apply constexpr on global constant varaibles
When HIP_ENABLE_DEFERRED_LOADING=0, many global variables will be
referenced but they are not initialized in that early time. The patch
will use constexpr to initialze global constant varables in compile
time.

Change-Id: I9d538b7abc6a0ce700ec3332b97fc144db5fc1ef


[ROCm/clr commit: fdef6f722f]
2020-07-22 22:14:13 -04:00
Freddy Paul af1916a2f9 Enable STATIC LINKING of COMGR
COMGR_DYN_DLL is used by rocclr to load COMGR as dynamic library.
Need to remove this flag while linking COMGR as static lib by
ROCclr.

Default option is set to link COMGR as dynamic library

Change-Id: I5631a8c1d896bd4d7e5ecf5ef5fa4f631cd2244d


[ROCm/clr commit: 00223c5697]
2020-07-22 16:07:05 -07:00
Jason Tang 11f8a869f1 SWDEV-232197 - Fix PAL build
Change-Id: Iad306077cadfd8de1491ac0a188eee4802d8ce1f


[ROCm/clr commit: 2800fc2fa3]
2020-07-22 17:10:03 -04:00
kjayapra-amd db1fbf23d2 SWDEV-236178 - Remove use of old routines functions()/modules().
Change-Id: I3a1ed967227c91b0d8cdf39e1360ade685e0bc73


[ROCm/clr commit: fd783c1e88]
2020-07-22 14:55:02 -04:00
kjayapra-amd 7aa68bc3cb SWDEV-240800 - Adding initial support for hipDeviceGetP2PAttribute. Some attr support still pending.
Change-Id: I0611aed136270db497dfa374144f6f5e35352a8f


[ROCm/clr commit: 311fc8c513]
2020-07-22 14:54:34 -04:00
Jason Tang fdf3ebad76 SWDEV-232197 - Use TargetID for action_info_set_isa_name()
Change-Id: I6661a2bbc2e55586c1b5029694d67cb54a4f23a6


[ROCm/clr commit: 65f4230494]
2020-07-22 13:47:17 -04:00
Payam d1e3736fc3 modify cmake to strip debug symbols from rel blds
Change-Id: Ia67261fc3c4a20f3f1bbe439a70384a3f6aefa91


[ROCm/clr commit: 274fded47d]
2020-07-22 11:53:54 -04:00
Freddy Paul 872b0bedee Align to new hsa cmake target usage.
HIP or any ROCm component above HIP may not be calling
hsa-runtime directly. OpenCl and HIP are the two components
calling ROCclr and to bring in the transitive dependency of
thunk,ROCR,amd_comgr it is better to have the dependency
chain set correctly in the ROCclr cmake target. With this
change OpenCl or HIP should not be setting ROCR dependency
directly.

This helps to link OpenCl(libamdocl.so) link statically with
comgr,hsa,thunk.

Change-Id: I0d538b7abc6a0ce700ec3332b97fc144db5fc5ff


[ROCm/clr commit: 6b8ae3dd77]
2020-07-22 11:21:09 -04:00
Tao Sang 25c98ea4de Support numa if libnume-dev is installed
Let rocclr decide numa dependence

Change-Id: I65bdfba7ec0d06b550f86632318bcfd1f765cfa9


[ROCm/clr commit: eba78710dc]
2020-07-22 08:55:28 -04:00
Chauncey Hui 705fc47138 SWDEV-2 - Change OpenCL version number from 3181 to 3182
[ROCm/clr commit: c09b1ee0cc]
2020-07-22 03:00:05 -04:00
Alex Xie c6649a8c7f SWDEV-241977 [ROCm QA] Random Soft hang observed while running TF and Caffe2 benchmarks
Change-Id: I42016c11db15411b86e7b8130d6ba557bc22dbb7


[ROCm/clr commit: ce038f3163]
2020-07-22 02:03:48 -04:00