Commit Graph

13402 Commits

Author SHA1 Message Date
German Andryeyev 7fea66c9e9 Host device context should return a valid queue
Host memory allocations use shared device context, which allows
to have access from any device. That breaks default queue detection.

Change-Id: I27ad1234d49ab0ea8f5edd6f2e3ffa93c47d4b1f


[ROCm/clr commit: ef75a3c1db]
2020-07-09 10:56:33 -04:00
sushantkumar14 985e113fdb [dtest] Added hipStreamGetPriority API test
SWDEV-238517 for enhancing hip unit tests

Change-Id: Icff175360815ba6e25a6954a67947b65caff3711


[ROCm/clr commit: 2dc42154c4]
2020-07-09 01:59:44 -04:00
jujiang 3eb6440e59 SWDEV-242207-Update deprecated APIs
Change-Id: I0c1c7f33f75232b210495241d0e5e7e6b90d45f0


[ROCm/clr commit: b90f3732ea]
2020-07-08 15:23:52 -04:00
jujiang da470ad95f SWDEV-241903-Add document HIP_logging.md
Change-Id: I348218218b305e845b7e26afaeb4e287bf0387de


[ROCm/clr commit: e73e0d2fb3]
2020-07-08 11:19:33 -04:00
Chauncey Hui 153229ec2a SWDEV-2 - Change OpenCL version number from 3172 to 3173
[ROCm/clr commit: 1b69c85913]
2020-07-08 03:00:03 -04:00
Rahul Garg 6d8419f433 Bump version to 3.7
Change-Id: Id077c317573e95833c8bc7f16951df776de2a273


[ROCm/clr commit: 27002fd792]
2020-07-08 01:54:05 -04:00
Jatin Chaudhary 260a83c546 Replacing deprecated HSA API calls with newer ones
Change-Id: Iebe2c00e717ab0e47c61611752b717966c719994


[ROCm/clr commit: cd1e364911]
2020-07-08 00:32:24 -04:00
Aryan Salmanpour 8d083a3c61 Always print error message with the returned error code before abort
Change-Id: I8479abc586937a50c90b2785c4ce7364e6e9732b


[ROCm/clr commit: 4a901f3dd3]
2020-07-07 16:28:30 -04:00
Aryan Salmanpour c69f88fe04 add an error message before aborting if a wrong GPU target was used for compilation
Change-Id: I7b41e93d420dbc47978238a681f2956a0def01cb


[ROCm/clr commit: 8f862becd0]
2020-07-07 14:50:44 -04:00
Chauncey Hui bf3fd89566 SWDEV-2 - Change OpenCL version number from 3171 to 3172
[ROCm/clr commit: 5c2e64a43c]
2020-07-07 03:00:03 -04:00
Lakhan singh Thakur 4bf371401d [dtest] Enhancing hipStreamAddCallback() api test
-Scenario-1:: This test case is used to verify if the callback function
              called through  hipStreamAddCallback() api completes the
	      execution in order as hipStreamAddCallback() api queued
	      in their respective streams: hipStreamACb_AltEnqueue.cpp
-Scenario-2:: This test case tests if Host thread continues with next
              command after hipStreamAddCallback() api or wait for
	      callback() call to finish. Ideally Host thread should not
              wait for callback to
              finish: hipStreamACb_ThrdBehaviour.cpp
-Scenario-3:: Streams are launched in individual GPUs with different
              kernel Verify that all the kernels queued are executed
	      before the callback is hit: hipStreamACb_MStrm_Mgpu.cpp
-Scenario-4:: Checks the callback execution in the same order it was
              added. Also, it checks if the number of callbacks
	      executed are same as the number of callbacks added:
	      hipStreamACb_order.cpp
-Scenario-5:: This test case checks whether hipStreamSynchronize() is
              taking less time than the time taken by Callback()
	      function launched by hipStreamAddCallback() api :
	      hipStreamACb_StrmSyncTiming.cpp
-Scenario-6:: This test case is used to check if the runtime is ok when
              hipStreamAddCallback() is called back to back multiple
	      calls: hipStreamACb_MultiCalls.cpp
-Scenario-7:: This test case is used to check the behaviour of HIP when
              multiple hipStreaAddCallback() are called over multiple
	      Threads:hipStreamACb_MultiThread.cpp
              (Currently disabled)

SWDEV-238517 for enhancing hip unit tests

Change-Id: I9c7b7df6766c728b2b201df18726b9fbdd434c06


[ROCm/clr commit: 18f8b15523]
2020-07-07 00:43:32 -04:00
Tao Sang 7591ff8172 Fix static lib crash by setting top init_priority
Set top init_priority on affecting global variables so that
they will be created firstly and destroyed lastly.

Change-Id: Ied59fbecab66ba8195c4a7a02b6bef9fa2fad3af


[ROCm/clr commit: f7bf882981]
2020-07-06 16:54:10 -04:00
Vlad Sytchenko 0611a0502a Add ability to run each ocltst test individually
Now one can run a single test by invoking `make test.ocltst.${module_name}.${test_name}`. Invoking `make test.ocltst.${module_name}` will still run all of the modules tests.

Change-Id: I31b384576cb09800e580e41c12528a276899b6c2
Signed-off-by: Vlad Sytchenko <Vladislav.Sytchenko@amd.com>


[ROCm/clr commit: 3be244fb34]
2020-07-06 15:56:46 -04:00
Michael LIAO 8ad59be46d [hipcc] Only add -x hip on HIP-Clang compilation.
Change-Id: I19704c713ad00f92196d7586498e62f80b8cd177


[ROCm/clr commit: b39195b639]
2020-07-06 15:16:51 -04:00
Tao Sang fa89271aaf Fix crashing of private elf apis in static lib
When rocr and hip-rocclr are static libs, rorc will wrongly reference
private elf apis, then crash will happen. By renaming asm symbol
names of private elf apis, rocr will reference public elf apis, thus
crashing won't happen.

Change-Id: I7cf552f1fae5fe09adeac3aec1a24445f39d406c


[ROCm/clr commit: 2c551e44cc]
2020-07-06 13:41:09 -04:00
Matt Arsenault c9239f4f78 Remove .value_type from code object v3 metadata
This seems to not actually have any function. The OpenCL API test
passes without it, and the way it's produced is problematic.

Change-Id: I384bfa01dee7023484348b184ddd1b2d44a91f7d


[ROCm/clr commit: cfed3f310d]
2020-07-06 11:07:30 -04:00
Matt Arsenault f67b99fc26 Enable warnings on unused functions
There weren't all that many to fix, and it's not even the most
prevalent warning.

Change-Id: I286aaa42e3c4e305b1e1918f302bbf71e41dd47d


[ROCm/clr commit: 3a564bc6cb]
2020-07-06 10:29:29 -04:00
Matt Arsenault 8892ba072f Fix unused function warnings for conditionally used functions
Change-Id: Ied23c571b949abef1816914986f19b14aca3d2f3


[ROCm/clr commit: c56a82fd05]
2020-07-06 10:28:43 -04:00
Matt Arsenault a2b54e7b4a Fix -Wunused-private-field
Change-Id: Iedf121025a33bf08eed310e3d85302f8bf3ac7d9


[ROCm/clr commit: 7124974148]
2020-07-06 10:27:43 -04:00
Matt Arsenault 2c395913a7 Remove unused functions
Change-Id: I55db791019c511de83d8b895e3a48b3d7475aeac


[ROCm/clr commit: 9e3e41ca2e]
2020-07-06 10:27:29 -04:00
Matt Arsenault 3bd3b7298a Fix compiler test for clang
Change-Id: I06e01d3422ec4aa8d0fb8f5d9a44e2a840531a87


[ROCm/clr commit: a430215067]
2020-07-06 10:27:11 -04:00
Yaxun (Sam) Liu aad28fd31d Add pow(float/double/_Float16,int)
Change-Id: Ie65d15cd3df9853a3bbd613d8c7188ae39c327c7


[ROCm/clr commit: b72e8b54e0]
2020-07-06 07:38:57 -04:00
Jatin Chaudhary 718c7142d0 Fix error: cannot pass object of non-trivial type string through variadic function when building in debug mode
Change-Id: Idd55ed422addc815fb56c57b05bd4afa9563f2ac


[ROCm/clr commit: 3173dbdec0]
2020-07-06 00:48:40 -04:00
Chauncey Hui 2bc83df463 SWDEV-2 - Change OpenCL version number from 3170 to 3171
[ROCm/clr commit: f9f7508578]
2020-07-05 03:00:03 -04:00
German Andryeyev 67c2bf6df4 Return always true for P2P validation under ROCr
Change-Id: Id32a5a94a642e708d1d042c5247af38501bec153


[ROCm/clr commit: 059832b526]
2020-07-04 11:38:04 -04:00
Jason Tang 33b063d7d6 SWDEV-242879 - Not to use fixnames
Change-Id: I3d0e2f3fe6c773e020c8bf8cdfd75fd565d61505


[ROCm/clr commit: c371b4e3b0]
2020-07-02 08:15:07 -04:00
kjayapra-amd 5cf8c4331b SWDEV-236178 - Fixing func_attributes that was over written on redesign.
Change-Id: I157913ae4fa4a3a149817e901f10475b7750188b


[ROCm/clr commit: 2f963728f7]
2020-07-01 11:52:45 -04:00
Chauncey Hui 457a9d48f5 SWDEV-2 - Change OpenCL version number from 3169 to 3170
[ROCm/clr commit: f07fedd00a]
2020-07-01 03:00:03 -04:00
Matt Arsenault 4c38d6f0a7 Use option for BUILD_SHARED_LIBS
This avoids blindly overwriting the setting.

Change-Id: I38dff67f406c4547806a96f4ab220a7415d96242


[ROCm/clr commit: 03ed004255]
2020-06-30 15:01:46 -04:00
German Andryeyev f2464edb74 Remove hipMemcpyDeviceToDevice check.
There is hipMemcpyDefault that requires validation also.

Change-Id: I5ae0ffa1c023b7774547acbdc049b84a0c2cb4c5


[ROCm/clr commit: 11b7842f71]
2020-06-30 12:59:54 -04:00
Ronak Chauhan 845c0a5b8a Support passing macros to hipLaunchKernelGGL
This makes hipLaunchKernelGGL take a variable argument list, that will be
expanded before being fed to hipLaunchKernelGGLInternal.

This is different from 4dfef9a25b.

We try to accomodate the case when a kernel template has multiple
type parameters.

Change-Id: I87577d402c92b0f3b51e298f8293f4065e1f6de8


[ROCm/clr commit: 133251a6e1]
2020-06-30 10:44:55 -04:00
Jason Tang c0a9560c1b Fix CentOS build
Change-Id: Id0956f2a876077a3528c4fafc136586b95fdda70


[ROCm/clr commit: 0394f79d4d]
2020-06-29 18:49:48 -04:00
Payam 228d8e7c12 update debug print time to be us
Change-Id: I6f49304414ffc209f0fa1cb7199557c8423fcfa7


[ROCm/clr commit: 07848d7926]
2020-06-29 18:45:24 -04:00
Daniil Fukalov a2e2f9b8c6 Add __attribute__((const)) to grid related functions declarations
This is cherrypick of Daniil Fukalov's PR https://github.com/ROCm-Developer-Tools/HIP/pull/2110
which has been committed to master branch.

Make declarations consistent with https://github.com/RadeonOpenCompute/ROCm-Device-Libs/blob/amd-stg-open/ockl/src/workitem.cl
Without the attribute these functions don't have "readnone" LLVM IR attribute. Without it some optimizations fails, e.g. Loop Invariant Code Motion doesn't hoist these calls out of a loop.

Change-Id: Idb599570d142152cc4f6a3c8986384ad7f0c4729


[ROCm/clr commit: 359ea4fcaf]
2020-06-29 13:33:18 -04:00
Jason Tang 3c0b0d9d92 Not to use fixnames
Change-Id: I50c9503cad1fc072edec989a4f82a27bb7bb3909


[ROCm/clr commit: 4666113db0]
2020-06-28 18:57:16 -04:00
Chauncey Hui 6107041c84 SWDEV-2 - Change OpenCL version number from 3168 to 3169
[ROCm/clr commit: 38ae71d10b]
2020-06-27 03:00:05 -04:00
Aryan Salmanpour 934763278b remove unused argument from enableHostcalls/disableHostcalls functions
Change-Id: I351a6b4e23cd9f118310c5c79b1afcb4758fde1b


[ROCm/clr commit: 34b82eb998]
2020-06-26 16:33:30 -04:00
Vlad Sytchenko 41431f3ae2 Disable failing texture tests
Change-Id: I2fd8ae2ac8c7494911149023c2102025443b7fbd


[ROCm/clr commit: e356f5ff85]
2020-06-26 14:05:24 -04:00
Evgeny 320e5b4e8a HIP-PROF: fixing pointers tracing
Change-Id: Id2c35972e1d134012980c95a3649ddfdf9303494
(cherry picked from commit a19960e79a)


[ROCm/clr commit: 80f9bfc168]
2020-06-26 11:17:29 -04:00
Cole Nelson 684004ca35 packaging/hip-rocclr.txt: multi-version install broken because of 'hip_rocclr'
Versioning understands 'hip-rocclr' not the deprecated 'hip_rocclr'.
Remove this.

Leaving Provides hip-hcc until package shifts settle down.

SWDEV-242143:

Change-Id: I489fa28dd1394625bc6016a3adda4f73d02da202
Signed-off-by: Cole Nelson <cole.nelson@amd.com>


[ROCm/clr commit: 0b7703560a]
2020-06-25 14:17:16 -04:00
rohit pathania 6b04a13e52 [dtest] hipMemcpyWithStream API multithreaded test scenarios
1.hipMemcpyWithStream with one stream
2.hipMemcpyWithStream with two streams
3.hipMemcpyWithStream multiGPU with one stream
4.hipMemcpyWithStream with kind DtoH
5.hipMemcpyWithStream with HtoH
6.hipMemcpyWithStream with DtoD
7.hipMemcpyWithStream with Default kind
8.hipMemcpyWithStream with Default kind on same device
9.hipMemcpyWithStream with DtoD on same device

SWDEV-238517 for enhancing hip unit tests

Change-Id: I5f55a12bdd7c8d28fcb06db94a491c2ad5ee3004


[ROCm/clr commit: c14e95741b]
2020-06-25 12:51:23 -04:00
Ronak Nilesh Chauhan 179a9974f4 Revert "Support passing macros to hipLaunchKernelGGL"
This reverts commit 4dfef9a25b.

Reason for revert: This patch breaks ROCPrim tests

Change-Id: Ib2235f719861c9f4317c33e86b6c1f8bc669cfd4


[ROCm/clr commit: b15e835d9e]
2020-06-24 04:28:46 -04:00
Chauncey Hui fa53a0a233 SWDEV-2 - Change OpenCL version number from 3167 to 3168
[ROCm/clr commit: 01d8a13065]
2020-06-24 03:00:03 -04:00
Tao Sang 9273cfaa15 Support numa policy set by user
Add hostNumaAlloc() to support numa policy set by user

Change-Id: Ib6c3e838aa53e3d9b3db9735c585df46a1c98944


[ROCm/clr commit: da94cd0de1]
2020-06-23 18:57:03 -04:00
Vlad Sytchenko ec1205b497 Revert "Added file logging for rocclr & HIP"
This reverts commit bc5075c2c5.

This change broke the legacy-complib build in p4. It seems that we can't use any flags in debug.cpp.

Change-Id: I17bb83651b85d6f415d9074634b479658fd4c3f9


[ROCm/clr commit: 20c24cae93]
2020-06-23 16:46:56 -04:00
Evgeny 790d14d84b HIP-PROF: fixing pointers tracing
Change-Id: Id2c35972e1d134012980c95a3649ddfdf9303494


[ROCm/clr commit: c148adf362]
2020-06-23 14:02:35 -04:00
kjayapra-amd 39523e2c63 SWDEV-209747 - Staging Copy will not be supported in HIP, adjust test case accordingly.
Change-Id: Iad616ef3990d539cdb82bbd8a22ea2124f7abe50


[ROCm/clr commit: a5c437c82e]
2020-06-23 13:14:17 -04:00
Jason Tang f2084f8fad Remove finding OpenCL library
Change-Id: I44faa5c3d40430ae9c9bc5440252812a8e7f717d


[ROCm/clr commit: 6f2dfea285]
2020-06-23 12:42:42 -04:00
Tao Sang f184916c46 Fix missing numa symbol in building libamdocl64.so
Change-Id: I77eca06345b11b5c8482ab626ef1b60c5fa20ec8


[ROCm/clr commit: 9171896d73]
2020-06-23 11:29:28 -04:00
agodavar 4644558c2b SWDEV-239297:hipMemset fix, getMemoryObject with unaligned ptr
Change-Id: I37b8139c5099d37b42f34d728a3d694fdf9cb55d


[ROCm/clr commit: 6a47458764]
2020-06-23 08:56:09 -04:00