- HIP-Clang follows the standard assert definition by providing
`__assert_fail`. But, `assert` macro is added as an HCC-specific
workaround due to the missing implementation. Only enable that on the
HCC compilation to avoid unexpected behaviors on HIP-Clang
compilation.
Change-Id: I1c9a707baff9b85c30faef58c52ebfe07e3fc3fc
[ROCm/clr commit: 41aedf5273]
This makes hipLaunchKernelGGL take a variable argument list, that will be
expanded before being fed to hipLaunchKernelGGLInternal.
Change-Id: Id76e2bf91acd5d68f56a24fc39f219f2eeb06d33
[ROCm/clr commit: fb6bb04f03]
Add hipHostMallocNumaUser flag to hipHostMalloc() in order to support
numa policy set by user.
Change-Id: I6d70ed539a5f97f27187f2242b68849c0e27e4d6
[ROCm/clr commit: 71c64e98a0]
hipChannelFormatDesc contains size of each channel in bits. There's 8 bits per byte, not 4, so we should divide by 8.
Change-Id: I38ae2d28ad54740823c98908ca2afecad0ba0183
[ROCm/clr commit: 81b15ed36e]
- Test with one, two streams
- Test Multi-gpu (one stream per gpu)
- Test D-D (on same device/different devices). Can discover issues
when devices are on same or different root complexes.
- Test H-D/Default
SWDEV-238517 for enhancing hip unit tests
Change-Id: I8031a7eebe2f9c8c0e0996e2c7accb09ac0b96d4
[ROCm/clr commit: 226c438559]
Some apps use P2P transfer without any validation for peer access.
Report an error if runtime has found such a request.
Change-Id: I3bf728f1fc3969697ade97bb1d2f1dce294078e2
[ROCm/clr commit: 01c2727a3a]
Similar to http://gerrit-git.amd.com/c/compute/ec/vdi/+/375385, except no -Wno-strict-aliasing.
With this change only two warnings show up during the build - -Wsign-compare and -Wmisleading-indentation.
Change-Id: Iffa436c65ab6312aeaa6def71ee6af38ed1b4a4e
[ROCm/clr commit: 509a38f50c]
Enabling anything beyond -Wall like -Wextra or -pedantic seems impossible as our code base explodes in thousands of warnings.
-Wno-unused-{variable/function} is not present in the p4 build, but with gcc7.4.0 we get hundreds of instances of this warning being triggered in the code base.
With this change only two warnings show up during the build - -Wsequence-point and -Wunused-but-set-variable. The fix for the first is alredy in review.
Change-Id: I2ff37981377487b0e07fd9490498e38a60792c0c
[ROCm/clr commit: 947dbe82fb]
Similar to http://gerrit-git.amd.com/c/compute/ec/vdi/+/375385, except no -Wno-strict-aliasing.
With this change only one warning shows up during the build - -Wdeprecated-declarations in cltrace.
Change-Id: Ie335eb9c45287ee1006e6bd65d54d67b41f79604
[ROCm/clr commit: ac3848a8e6]
exposing the following hip APIs which have been previously implemented:
hipMemcpy2DFromArray
hipMemcpy2DFromArrayAsync
hipMemcpyAtoH
hipMemcpyHtoA
hipMemcpyParam2DAsync
Change-Id: I3f8635bd4265d2bf5aa2084f4eabb51f74fb18ba
[ROCm/clr commit: 02c62165b8]
Rocr won't return real hops so that we have to deduce hops from
numa distance as a workaround. This will be subject to change
as driver team will provide a long term solution in rocm3.7
Change-Id: Ifb939ed848db190c3d544bb7f30a5821161921e6
[ROCm/clr commit: b14d9e0a36]
- Expose ROCclr interfaces for HIP usage
- ROCr interfaces aren't available in staging, thus control the
build with AMD_HMM_SUPPORT define
Change-Id: Iadc2bcc230e78d3b0dc22b235189c8cc80843446
[ROCm/clr commit: c5afd5d412]
Sarbojit Sarkar
Chauncey Hui
German Andryeyev
Tao Sang
Michael LIAO
Dittakavi Satyanvesh
Jason Tang
Ronak Chauhan
kjayapra-amd
Vlad Sytchenko
Yaxun (Sam) Liu
Aryan Salmanpour
rohit pathania
Saleel Kudchadker
Jenkins