Commit Graph

13402 Commits

Author SHA1 Message Date
Michael LIAO 04d62f3fb6 [vdi] Fix -Wsign-compare warning. NFC.
- TeamCity build failed as `-Werror` is turned on.

Change-Id: Icd2cbd45f60e3c296894e8e73685e1d177f125a8


[ROCm/clr commit: 679f49c904]
2020-04-06 12:16:07 -04:00
German Andryeyev bcb3769d7f Merge "SWDEV-184709 - support hipLaunchCooperativeKernel()" into amd-master-next
[ROCm/clr commit: 056a2d7227]
2020-04-06 11:45:34 -04:00
satyanveshd 672462fcfc fix hipIpcOpenMemHandle (#1998)
[ROCm/clr commit: 20d9986548]
2020-04-06 15:39:49 +05:30
Rahul Garg 76f7af0dda use hsa_executable_get_symbol_by_name in find_kernel_by_name (#1994)
[ROCm/clr commit: f7751db2ee]
2020-04-06 15:39:30 +05:30
Rahul Garg ef7397ae35 Bump version to 3.5 (#1993)
* Switch CI testing from rocm-3.1.x to rocm-3.3.x
* Update hcc workweek for cooperative view
* bump version to 3.5

[ROCm/clr commit: c09c4cd239]
2020-04-06 15:39:10 +05:30
Sarbojit2019 77fd519260 hipEventElapsedTime should respect device (#1992)
Fixes SWDEV-228636.
Also added a unit test to verify this.

[ROCm/clr commit: 3523219b43]
2020-04-06 15:38:25 +05:30
lmoriche 318fbce04d Don't duplicate embedded code objects (#1991)
If the code object is embedded in an already mapped file, and the
lifetime of the mapped file exceeds the lifetime of the executable,
we do not need to make a copy of the binary.

This allows the ROCR to present the code object URI as
file:///path/to/file#offset=X&size=Y.

[ROCm/clr commit: 67830996a9]
2020-04-06 15:37:35 +05:30
Jatin Chaudhary f2ea243fa5 Removing header size from formula (#1988)
Fixed a bug in the elf file size computation.

[ROCm/clr commit: eab81ca91b]
2020-04-06 15:37:07 +05:30
Rahul Garg aae8a4080d Fix 2D and 3D memset (#1987)
[ROCm/clr commit: 017a27214c]
2020-04-06 15:35:59 +05:30
ansurya 6b18a8e068 Initial support for bfloat16 (#1980)
[ROCm/clr commit: ff7aaedca2]
2020-04-06 15:35:43 +05:30
Yaxun (Sam) Liu ecfda14b46 Fix ambiguity of fma for _Float16 for libc++ (#1976)
libc++ defines fma as template function for auto promotion of mixed-type
arguments. libc++ does not handle _Float16 as _Float16 is not a supported
type by C++ standard. As such, it is unlikely we can commit our fix for
_Float16 to libc++ trunk.

Therefore we handle _Float16 with a template specialization of
__numeric_type in HIP headers.

Change-Id: If01960a657ebf1a7a67463cdcf66fab7458dff3c

[ROCm/clr commit: 6f439f0232]
2020-04-06 15:35:18 +05:30
Sameer Sahasrabuddhe 3535475677 SWDEV-227201: Introduce tests for printf on hostcall
Tests that check POSIX specifiers with a single thread:
 - hipPrintfSpecifiers.cpp     : all conversion specifiers
 - hipPrintfFlags.cpp          : common flags that modify conversions
 - hipPrintfAltForms.cpp       : alternate forms ('#')
 - hipPrintfStar.cpp           : additional arguments ('*')
 - hipPrintfWidthPrecision.cpp : floating point details

Tests that check functionality on top of hostcall
 - hipPrintfBasic.cpp       : divergent calls, series of calls, return value, etc
 - hipPrintfManyWaves.cpp   : many waves printing together
 - hipPrintfManyDevices.cpp : many waves on many devices

Change-Id: I35e069f4c542f896999239996dc89eda0faad7b8


[ROCm/clr commit: 01d4117789]
2020-04-06 00:49:34 -04:00
Chauncey Hui 2baff63fc4 SWDEV-2 - Change OpenCL version number from 3117 to 3118
[ROCm/clr commit: 2480be8413]
2020-04-05 03:00:03 -04:00
Payam 97f9e8935b removing file path from LOG_LEVEL and adding time stamp
Change-Id: Ia32f21353adad4dcb4928909361fe0420c502c1e


[ROCm/clr commit: 7052e21c87]
2020-04-04 17:56:16 -04:00
eshcherb 8a0e7adf78 adding HIP_PROF version macro (#2000)
[ROCm/clr commit: e524d1d54a]
2020-04-04 13:10:28 -07:00
Alex Xie 8d5b686e8b SWDEV-229731 - [Lnx][Rocm][Navi]Support images in full Opencl Conformance tests
1. Enable pitch workaround
2. When we use copy image, we don't need to create the custom pitch image
3. wrtBackImageBuffer_ stores device memory object, not amd image object.

Tests:
conformance kernel read / write test pass with this code change.

Change-Id: I7dca3127adde6ac83e78dd270a2256ebed55c60d


[ROCm/clr commit: 43b9863e17]
2020-04-04 09:43:03 -04:00
Alex Xie cd4472490d SWDEV-229731 - [Lnx][ROCm][Navi]Support images in full OpenCL conformance tests
Duplicate similar blit logic from PAL path

Tests:
1D Array image read/write tests and copy image tests passed

Change-Id: I838bbde252ad0108bfeb82c0c2b669881747c0af


[ROCm/clr commit: 3e247d2afd]
2020-04-04 09:28:37 -04:00
Chauncey Hui 7a25082f06 SWDEV-2 - Change OpenCL version number from 3116 to 3117
[ROCm/clr commit: a6708a2c26]
2020-04-04 03:00:06 -04:00
Christophe Paquot e55de39f91 Default HostMalloc to uncached memory
Change-Id: I72e19c7f7820a77fd5afc09f09cfea9acd0b8e84


[ROCm/clr commit: b820c66c55]
2020-04-03 19:19:33 -04:00
Saleel Kudchadker e4fdc74a80 Merge "Wake up commandQueue before returning" into amd-master-next
[ROCm/clr commit: 74dc32537e]
2020-04-03 18:27:03 -04:00
Michael LIAO d3dbeb54ee [vdi] Add hipFreeHost
Change-Id: I8a5b7ff3f0ab4f5674efd6723c18808ad6ef33f5


[ROCm/clr commit: 6fe3edc5a8]
2020-04-03 16:34:28 -04:00
German Andryeyev 0cafe090d2 Merge "SWDEV-184709 - support hipLaunchCooperativeKernel()" into amd-master-next
[ROCm/clr commit: 9e4aeb0f67]
2020-04-03 16:23:05 -04:00
Vladislav Sytchenko 4ca75d8ee2 Take into an account the number of channels...
when querying the element size of an array.

Change-Id: Id57d3374b14d80a59230ec8286704f2fbabb0fae


[ROCm/clr commit: c9084d0ad2]
2020-04-03 15:43:18 -04:00
German Andryeyev d14399f60f SWDEV-184709 - support hipLaunchCooperativeKernel()
- Add validation checks for cooperative launch to pass Cuda test

Change-Id: Ie296f0c3f113909d9a357879db3b2a833ab314c5


[ROCm/clr commit: 5efb3f26c0]
2020-04-03 15:18:21 -04:00
Michael Hong Bin Liao a54b720eba Merge "Fix size type in __hipRegisterVar" into amd-master-next
[ROCm/clr commit: 16ac35c4d5]
2020-04-03 15:12:21 -04:00
Saleel Kudchadker 67c6b46cf0 Wake up commandQueue before returning
Change-Id: I87eb5a22c81a9cb807474a960b5987d5fb6c2b86


[ROCm/clr commit: e2def55164]
2020-04-03 10:23:36 -07:00
Aaron En Ye Shi 074efe1568 Merge "Fix path for hip-clang when using hipcc (#1961)" into amd-master-next
[ROCm/clr commit: 0bb217245c]
2020-04-03 12:28:50 -04:00
German Andryeyev c07677f99d SWDEV-79445 - HIP improvement
- Make sure only one GPU barrier is issued per dispatch
when memory tracking is disabled

Change-Id: I974569ab42a8835304a2930eef87b561a3750327


[ROCm/clr commit: 481cecec78]
2020-04-03 12:21:03 -04:00
Vladislav Sytchenko a6d0416ab6 Merge branch 'amd-master-next' into amd-npi-next
Change-Id: I3b91e45da7cb38c2a2c6d8675e7651de754764ec


[ROCm/clr commit: b82ab8b329]
2020-04-03 12:11:22 -04:00
Michael LIAO efe48959e9 Fix size type in __hipRegisterVar
Change-Id: I6b667600ae8f133583b768ab963318882b84179f


[ROCm/clr commit: d904f30f9e]
2020-04-03 10:51:58 -04:00
Michael Hong Bin Liao 1daf292d78 Merge "[hip] Clean up unnecessary casting." into amd-master-next
[ROCm/clr commit: 66aca97d6f]
2020-04-03 10:50:40 -04:00
kjayapra-amd 817764a12b SWDEV-229840 - Improve Error Codes. RocKernel and RocProgram
Change-Id: I8f785308e0562a50924f8bdd02e88c92a759f01a


[ROCm/clr commit: cd7de89fc3]
2020-04-02 22:30:53 -04:00
Saleel Kudchadker 8c8ad8153f Promote Khronos OpenCL-ICD-Loader master
master as of https://github.com/KhronosGroup/OpenCL-ICD-Loader/
commit/c7fda8bb042760b5ead8650c64445f5972a64ad7

Change-Id: Ia852f55ecf0b0aceff915991328812ed9788698f


[ROCm/clr commit: 49f3835666]
2020-04-02 17:02:58 -04:00
German Andryeyev 8a6d893130 SWDEV-184709 - support hipLaunchCooperativeKernel()
- Enable cooperative tests for single and multiple devices

Change-Id: I54b6713f578b6b5e670f117b17469c0091028c99


[ROCm/clr commit: 2e948e4034]
2020-04-02 12:55:05 -04:00
Michael LIAO 978a25d960 [hip] Clean up unnecessary casting.
Change-Id: I64b08aaef5c67ffb49330c9c605611f1fbd3f5a2


[ROCm/clr commit: e3795436b2]
2020-04-02 12:46:15 -04:00
Paul Fultz II c196ac897b Fix path for hip-clang when using hipcc (#1961)
* Fix path for hip-clang when using hipcc

* Fix typo

* Update regex

Change-Id: I31bbee2e70d58b89191f970f5c6ae7e1c8b40900


[ROCm/clr commit: 58f04fb774]
2020-04-02 12:09:31 -04:00
Paul Fultz II eb2336fd32 Add missing flags for hip::device target on hip-clang (#1230)
This adds the missing compilation flags to hip::device so it can compile with hip-clang compiler.

Change-Id: Ie2b30ea606bfca385a0e84ae03ee0a8d828ad16a


[ROCm/clr commit: 631f82ab82]
2020-04-02 12:09:03 -04:00
Chauncey Hui e8d35db5ac SWDEV-2 - Change OpenCL version number from 3115 to 3116
[ROCm/clr commit: 55fad9b929]
2020-04-02 03:00:03 -04:00
Saleel Kudchadker 22a021d12e Merge "OpenCL2.2 Header changes" into amd-master-next
[ROCm/clr commit: 5a357a795a]
2020-04-02 02:46:49 -04:00
Saleel Kudchadker 5029a7b467 Update OpenCL 2.2 headers
Update headers as of master https://github.com/KhronosGroup/OpenCL-Headers/
commit/9dde5da9c32cbd78656a5e2417c256922e851111

Change-Id: I698a3a1b92730c52b160b51af95469c2b54331c1


[ROCm/clr commit: 4092e3dee3]
2020-04-02 02:46:20 -04:00
Saleel Kudchadker 2dbe0d2391 Change for OpenCL2.2 header promotion
Change-Id: Icd579e5c94af6e8d984a3f6c2606be44dec72e91


[ROCm/clr commit: a97f206ab1]
2020-04-01 16:32:03 -04:00
Vladislav Sytchenko ee88afced4 Add entry points for hipTexObject*() API
Even though the runtime and driver texture object API is one to one, the structs used by these APIs are not. See hipResourceDesc vs HIP_RESOURCE_DESC differences.

These differences are not trivial and most likely won't be able to handled by hipify, so we need new API entry points.

Change-Id: Id4bcb1ad0ae15378dbdb5a2ed07e5ea30f320082


[ROCm/clr commit: a09fadecf2]
2020-04-01 14:51:51 -04:00
Vladislav Sytchenko 9ce8e0eeb8 (SWDEV-210228)
Don't error when querying the number of devices if there are no devices present in the system.

We should just return 0 for the number of devices in this case and let the application handle this situation.

Change-Id: I20614ade5e649f3ce9ddd970d4b38bfe296f6cdb


[ROCm/clr commit: 2a223ecec6]
2020-04-01 13:36:44 -04:00
German Andryeyev 8bda935a71 SWDEV-184709 - support hipLaunchCooperativeKernel()
- Enable cooperative groups support, based on ROCr capability

Change-Id: I975bcea0af7865009eaed24454ce71d897ea8fc4


[ROCm/clr commit: 481d526859]
2020-04-01 12:13:33 -04:00
Chauncey Hui 17a69fc6b9 SWDEV-2 - Change OpenCL version number from 3114 to 3115
[ROCm/clr commit: 39467ad9e6]
2020-04-01 03:00:03 -04:00
eshcherb 2fa4dc4b57 adding hipApiString (#1989)
[ROCm/clr commit: 1e5ea70588]
2020-04-01 12:10:33 +05:30
ansurya 79c1ac76a4 tex1Dfetch behaviour for different address mode and filter mode (#1772)
Fixes github issue: #1754

- When ResourceDesc::resType is hipResourceTypeLinear ignore address mode and filter mode.
- When textureDesc::normalizedCoords is set to zero, AddressModeWrap and AddressModeMirror won't be supported and will be switched to AddressModeClamp.

[ROCm/clr commit: 68f1b814b1]
2020-04-01 12:10:17 +05:30
Saleel Kudchadker 35e7b758e3 Merge "Cleanup stream from hip:Event class." into amd-master-next
[ROCm/clr commit: 99a024fc14]
2020-03-31 20:14:48 -04:00
Vladislav Sytchenko 870a37307f (SWDEV-229354)
This patch is a workaround to support user pitch for hipMemcpy{2D/3D}.

Historically OpenCL didn't support pitch with clEnqueueFillBuffer(), so neither did we in VDI. Adding it now will be slightly nontrivial, since the fill kernel and runtime in many places will need to be modified.

As a temporary workaround for cases when pitch > width, we can just enqueue a fill for each row separately. This implementation is slow, but it satisfies the correctness criteria.

Change-Id: Idfeca349288b51d6ff84a7cf001fb63c6a66818a


[ROCm/clr commit: 6e0722a5d0]
2020-03-31 18:12:56 -04:00
Todd tiantuo Li 7de769dcc9 SWDEV-222615 - delete VirtualGPU::Queue and return NULL when Pal::IDevice::CreateQueue() fails, in order to avoid undefined behavior and crash.
Change-Id: I4b94d3b3b0495530a8bf7840dc77a98aed9aa8ae


[ROCm/clr commit: b96e25c5f8]
2020-03-31 16:50:53 -04:00