Commit-Graf

13402 Incheckningar

Upphovsman SHA1 Meddelande Datum
Reshabh Sharma 69bd482d26 Output file name should not change flags picked for compiler (#1938)
Fixes SWDEV-207362,

The output file name should not contribute to picking up the right flags for the compiler. This fix solves issues when the output has conflicting extensions which confuses hipcc to treat them as the source files and add the required flags for them.

PS: Output file refers to the file followed by -o

Change-Id: I1095966c11143ad73e81fabc35b4e9de5d3afada
Example: hipcc test.o -o test.hip will add the flags for .hip compilation ignoring the fact that it is an output file


[ROCm/clr commit: 36f24a40e5]
2020-03-31 16:13:43 -04:00
Saleel Kudchadker 6629500e70 Cleanup stream from hip:Event class.
Change-Id: I98de07d33bb7fea8f5e2d32b288c15f10ce58902


[ROCm/clr commit: 65722f8cca]
2020-03-31 11:22:00 -07:00
Michael Hong Bin Liao 04fe29d1e0 Merge "[hipcc] Remove the previous workaround." into amd-master-next
[ROCm/clr commit: 9420f56c66]
2020-03-31 10:05:56 -04:00
Chauncey Hui 5d4798bb26 SWDEV-2 - Change OpenCL version number from 3113 to 3114
[ROCm/clr commit: b0164a9819]
2020-03-31 03:00:03 -04:00
Michael LIAO dc0ddc29fe [vdi] Fix hipGetSymbol{Address|Size}
- Use symbol value as the qeury key. Compared to the symbol name, the
  symbol value is more robust as developers may use unqualified or
  qualified identifiers. It also removes the mangling and/or demangling
  requirement for the runtime API.

Change-Id: I9d4259f3842612c7cc98551269fc2092d8b5c19e


[ROCm/clr commit: a14695d4eb]
2020-03-31 00:26:53 -04:00
German Andryeyev 29c091d624 SWDEV-224639 - Device memory is still occupied
- Add cache free on OCL context destroy
- Remove std::mem_fun() usage, since it was removed in c++17

Change-Id: If6acd08f13a2298912ecd78fc025dcf0b32aee54


[ROCm/clr commit: 9f795d750d]
2020-03-30 17:39:21 -04:00
German Andryeyev 14aa72890e SWDEV-184709 - support hipLaunchCooperativeKernel()
Add ROCr cooperative queue allocation

Change-Id: I1384482692f4080d31255b09e0f68a21ccad3da8


[ROCm/clr commit: 7ef8dfdfe7]
2020-03-30 16:09:09 -04:00
Christophe Paquot 1e254f8432 Do not retry to allocate when OOM. Shouldn't be needed since we idle on Free.
SWDEV-229214

Change-Id: I183006f409388e3c7981f2569649d01d6378be46


[ROCm/clr commit: 47718cbf16]
2020-03-30 12:49:48 -07:00
kjayapra-amd bce2b56ea0 SWDEV-216213 - Use different static & dynamic module maps for faster lookup.
Change-Id: Ia605e76a411ad5be04046b9d61f1ac111d49bb4a


[ROCm/clr commit: 7356a74d35]
2020-03-30 14:28:07 -04:00
Anusha Godavarthy Surya 8b0fec4333 Merge "Update Enable/Disable peers to match cuda behaviour" into amd-master-next
[ROCm/clr commit: 9d213070b0]
2020-03-30 13:46:42 -04:00
agodavar d329bd0684 Update Enable/Disable peers to match cuda behaviour
Change-Id: I67194ccf77a0019368579ff7d95b7790fcf228f3


[ROCm/clr commit: 96d119ac77]
2020-03-30 12:49:16 -04:00
Tao Sang 623168a082 Merge "enable HCC printf when using hip-clang" into amd-master-next
[ROCm/clr commit: 44a145b2a3]
2020-03-30 11:37:23 -04:00
Michael LIAO ee25f80e54 [hipcc] Remove the previous workaround.
Change-Id: Ie1c2aa21689bc343c10fd4b699546cf500ced5b2


[ROCm/clr commit: 64bbce8e73]
2020-03-30 10:18:47 -04:00
Michael LIAO 9c361faab3 [vdi] Fix calculation of MaxWaves
- Consider the case where `usedVGPRs` is zero.
- This fixes [SWDEV-228537](http://ontrack-internal.amd.com/browse/SWDEV-228537)

Change-Id: I8675311f5fe24fb59c5d45bada122afefb55b128


[ROCm/clr commit: 55d869df99]
2020-03-30 09:10:16 -04:00
Sarbojit2019 7e05ef29eb Fix for segfault seen in hipMemcpyDtoD (#1964)
* Fixes SWDEV-227444.

[ROCm/clr commit: b55775a49e]
2020-03-28 17:29:49 +05:30
Maneesh Gupta 3d1b086400 Remove address_space(1) typecast and use __ockl_atomic_add_noret_f32 (#1956)
* Remove address_space(1) typecast for ockl_global_atomic_add_f32
* use __ockl_atomic_add_noret_f32

[ROCm/clr commit: 062938a14c]
2020-03-28 17:28:33 +05:30
Sameer Sahasrabuddhe 207d9b3897 enable HCC printf when using hip-clang
This is cherry-picked from PR#1947 that was committed to the
github repo. It allows printf to work with hip-clang and HCC
runtime.

Change-Id: I754753250ea1e694cf3441722e2d4c9d25fa75bc


[ROCm/clr commit: c014c733c6]
2020-03-28 00:18:21 -04:00
Saleel Kudchadker eba4688437 Merge "Check event status before notify" into amd-master-next
[ROCm/clr commit: a5c287554e]
2020-03-27 20:19:40 -04:00
Vladislav Sytchenko d71bdef595 (SWDEV-228794)
Adjust the origin of the copy if the user passes a pointer that wasn't allocated by the runtime.

Change-Id: I0aeb20195ed730857a461a53f537626ec2573fd1


[ROCm/clr commit: 86c969fcea]
2020-03-27 16:33:16 -04:00
Vladislav Sytchenko 3f6db04b75 (SWDEV-228794)
Add hipMallocHost()

Change-Id: Ia3c7c5ca94b39fe30f3a51d1b60782d3472259ff


[ROCm/clr commit: 08729d0f43]
2020-03-27 15:57:48 -04:00
Vladislav Sytchenko 004dff62c4 (SWDEV-228782)
The only requirment from hipMallocPitch() is that the returned pitch is aligned to the HW image pitch alignment. There is no restriction on the size of the allocation, since the memory might not be used for images.

Change-Id: I97438e5fe4012ca4721b14b85f514dbac803c17c


[ROCm/clr commit: 111897dbea]
2020-03-27 15:52:17 -04:00
Tao Sang 0e3a7ed058 Merge "Support hipFuncGetAttributes with hip-clang+Hcc RT" into amd-master-next
[ROCm/clr commit: b2afe3c250]
2020-03-27 14:36:41 -04:00
Saleel Kudchadker 4abf9f5c38 Check event status before notify
Change-Id: I68f6bbbf236e49b859be2d5afbe0c8282fe15dd3


[ROCm/clr commit: fa7dea42b5]
2020-03-27 11:32:46 -07:00
satyanveshd fbc9771f63 [dtests] Added few Negative tests (#1735)
[ROCm/clr commit: 4554bbd9f9]
2020-03-27 14:10:12 +05:30
Siu Chi Chan 922219117b don't expose symbols from code_object_bundle (#1971)
Change-Id: I56479485aad42c3d517fe6d9055be1cd846eeb00

[ROCm/clr commit: 6ab1e864b6]
2020-03-27 14:09:07 +05:30
Sarbojit2019 4ef95f4e73 Fix few memory leaks in HIP (#1969)
[ROCm/clr commit: 4a68ab5a8c]
2020-03-27 14:08:30 +05:30
Jatin Chaudhary d919e2223d Packaging changes to bring them to sync with generated ones (#1918)
[ROCm/clr commit: 2449e0de8b]
2020-03-27 14:08:12 +05:30
Chauncey Hui 782a76511b SWDEV-2 - Change OpenCL version number from 3112 to 3113
[ROCm/clr commit: 771fa3b2ee]
2020-03-27 03:00:03 -04:00
Tao Sang 8218ede5e8 Support hipFuncGetAttributes with hip-clang+Hcc RT
Fix issues of missing kernel function symbols and missing argument list via
using __hipRegister* functions.
Then the following tests can pass,
directed_tests/runtimeApi/module/hipFuncGetAttributes
directed_tests/runtimeApi/module/hipExtLaunchMultiKernelMultiDevice
directed_tests/gcc/LaunchKernel

Change-Id: I52135b61e8283eb4f9f10f77895151e4e55418d9


[ROCm/clr commit: 4a113bb669]
2020-03-26 23:28:35 -04:00
Saleel Kudchadker 09140bb72e OpenCL2.2 Header changes
Change-Id: I3285a8ffc7e34333feb68e925ebd460831c8e3d4


[ROCm/clr commit: 388e656c4e]
2020-03-26 17:35:09 -07:00
Vladislav Sytchenko 96dad9615a Add support for formating hipExtent objects
Change-Id: Iea54a510e81a856c0c450305b3e5a7179ee48295


[ROCm/clr commit: 2b538b09e6]
2020-03-26 14:45:20 -04:00
Vladislav Sytchenko e9eababfdd Enable initial sRGB support
Instead of using the sampler field force_degamma to perform sRGB->linear conversion during pixel sampling, we use an appropriate image format instead. The overhead of this is having to create an image view when creating a texture object from an array.

Change-Id: I1ca368c312c1fd4b6f784a3a1b35b5eeb28070ff


[ROCm/clr commit: 23211f05d6]
2020-03-26 14:45:20 -04:00
Vladislav Sytchenko cfc508eef0 Add initial entry points for mipmapped array API
Change-Id: Icd59cc7323ddcb6773da6105260415a1e6f4cdcb


[ROCm/clr commit: 06bb183558]
2020-03-26 14:45:20 -04:00
Vladislav Sytchenko 21587cb0fa Handle offsets for dptr <-> image copies
Change-Id: I7a4a56ee07a26a741d2aac35502446d248f720ad


[ROCm/clr commit: af1c5a0015]
2020-03-26 14:45:20 -04:00
Vladislav Sytchenko cf49aaa7fc Replace hip::TextureObject with __hip_texture
This avoids the use of extra casts when obtaining a texture object handle.

Change-Id: I42df22bdad0ab9ac6c33cb8b282dee65fe7cfd6e


[ROCm/clr commit: 6cfbe19160]
2020-03-26 14:45:20 -04:00
Vladislav Sytchenko fe369a0e18 Correctly format hipResourceDesc objects
The struct consists of a union - only the active object should be read.

Change-Id: I1c40965b61518acd91a2dcbae92a015ac9be346a


[ROCm/clr commit: 1cacb5c9b7]
2020-03-26 14:45:20 -04:00
Vladislav Sytchenko df2f07ce18 Headers need to export C symbols for texture API
This also adds declarations of all the missing texture APIs.

hipTexRefSet*() functions need to take a textureReference as a ptr for type erasure to work. Runtime has been modified to accomodate this.

This change only applies to VDI.

Change-Id: Icf43cc5bd44dfc2c39084b7fe56d5a793bf7319f


[ROCm/clr commit: 428b56e411]
2020-03-26 14:45:20 -04:00
Vladislav Sytchenko b7f6419f6a Set textureObject to nullptr
This avoids dangling pointers for newly initiazlied textures

Change-Id: Ia444b91fe17fd756ed583ec595ae1febbdfbd034


[ROCm/clr commit: 3ab8ff87cc]
2020-03-26 14:45:20 -04:00
Vladislav Sytchenko d3786bc9b3 Modify formatting for textureReferences
We don't program the numChannels and format members (these are HCC specific), so printing these will only display garbage.

Change-Id: I83dc8be9a3cae2659c64f4594d07c05330d2dd14


[ROCm/clr commit: d662abaf55]
2020-03-26 14:45:20 -04:00
Vladislav Sytchenko c0a3cb04fe Correct typos in texture function declarations
Change-Id: I492995e984eda2e8a5e806c5d4c9c78da09ac483


[ROCm/clr commit: dc015d27c1]
2020-03-26 12:43:17 -04:00
Vladislav Sytchenko 3b75b5fd64 Allow creating texture from unaligned user ptr
All we have to do is align the ptr to HW requirments an if it's not zero, then return the offset to the user.

We currently don't have anywhere to store this offset, so hipGetTextureAlignmentOffset() will still always return 0.

Change-Id: If31998127d99a2a3222a026d88249519d6102505


[ROCm/clr commit: 9823ccf5b0]
2020-03-26 12:43:17 -04:00
jujiang 3ee3f4e045 SWDEV-223160, SWDEV-227911- Fix Memory Copy Peer failure on Navi10 MGPU configuration
Change-Id: I2bf559b87cba638b5af858c2d4fe5a252d16a5d9


[ROCm/clr commit: d392082a30]
2020-03-26 10:13:19 -04:00
Aryan Salmanpour 89d0d9761a [hip] fix a build error when building hip with latest hcc (#1977)
there is a build error when building HIP with latest HCC from GitHub after PR#1935 merged into HIP master branch. this PR changed blockDimX to blockDim and two lines missed this change where added in the current PR.

[ROCm/clr commit: 1a1cdee6ff]
2020-03-26 17:10:42 +05:30
Nick Curtis 37ee2b90d2 Update hip_debugging.md (#1973)
Fix link formatting

[ROCm/clr commit: 8afea30768]
2020-03-26 17:09:56 +05:30
Sarbojit2019 77f9a99ef0 Fix for __usad issue (#1972)
Fixes #1930

[ROCm/clr commit: 13b73692d8]
2020-03-26 17:09:44 +05:30
Benjamin Sherman e13788ff95 Add const qualifiers to HIP_vector_type unary arithmetic operators (#1965)
Resolves issue #1960

[ROCm/clr commit: 09ffe4365d]
2020-03-26 17:09:00 +05:30
Siu Chi Chan b96a6053a5 Initialize all undef symbols with a magic poison (#1962)
[ROCm/clr commit: d822daa3a5]
2020-03-26 17:06:09 +05:30
Sarbojit2019 4f8c29f7dc Fix for segfault seen if invalid kind is passed to hipMemcpy (#1937)
Fixes SWDEV-224941

[ROCm/clr commit: 12448996e3]
2020-03-26 17:04:43 +05:30
Jatin Chaudhary b2615ca010 [dtest] Adding VectorTest (#1732)
Adding unit test for operations of device vector types

[ROCm/clr commit: b696451240]
2020-03-26 17:03:43 +05:30
Evgeny Mankov f629c12514 Merge pull request #1978 from emankov/hipify-clang
[HIPIFY][doc] Update README.md: LLVM 10.0.0 Release is supported

[ROCm/clr commit: f4060340b5]
2020-03-26 11:09:33 +03:00