Commit Graph

5809 Commits

Author SHA1 Message Date
Vladislav Sytchenko 09c28dcbf4 SWDEV-1 - Fix Windows build
Change-Id: I144142b2b31785fe7b1d319fb7e88eb2b41099ac
2021-01-26 15:51:57 -05:00
Aaron En Ye Shi 31e772adb5 SWDEV-263964 - Fix hipconfig to work on Windows
Modify hipconfig and hipcc to properly run Windows compiler
executables. Support Windows Environmental Variables and
AMD Display Adapter info. Update flags to include quotes for
paths that have spaces, such as Program Files.

Change-Id: Ib721b318bd88be7dfa1247a30ce78c7ed6a334e8
2021-01-25 12:53:03 -05:00
Aaron En Ye Shi db43d7a3ac SWDEV-263964 - Add Windows CMake find_package(hip)
Modify hip-config.cmake to support building on Windows
using CMake's find_package(hip). Windows CMake will work
with Ninja Generator and inheritEnvironments clang_cl_x64.

Change-Id: I03d76b5f8d695ce50ecaacb449e4eb1c1ca49700
2021-01-25 12:52:46 -05:00
Joseph Greathouse 51e53b6b56 SWDEV-269756 - Add missing Cooperative Groups error string
Change-Id: I1833f8bb4b48b19bb3d6cac57dda429231cf3562
2021-01-22 15:48:18 -06:00
Tao Sang a0c8c30ae5 SWDEV-268757 - Disable deprecation warning
Disable it as it will fail rocgdb test

Change-Id: Ibf34c780d5bd4278adcedba1d6e057639c258483
2021-01-21 15:35:32 -05:00
Tao Sang 8cf28aa5b3 SWDEV-257056 - Fix cyclic dependence of hip/rocclr libs
Solve upstream building failure due to the cyclic dependence.

Change-Id: Ibf34c789d5bd4278adcedba1d6e057639c258488
2021-01-21 13:00:22 -05:00
jujiang cfca71352a SWDEV-265003 - update HIP document
Change-Id: I1e8ec3ad380330b48d164a2ca60b0a70f7e54ae6
2021-01-20 16:24:20 -05:00
Satyanvesh Dittakavi 8da9f4d432 SWDEV-268989 - Modify atomicAdd double to use clang builtin
Change-Id: If9d40046df2f3f5af7cc1bd6c935fbe7d686e7d8
2021-01-20 02:39:15 -05:00
agodavar 2b84b58c31 SWDEV-267298 - update install script to build hip-rocclr
Change-Id: Ia8d72ebc41184d2fc58aa4e99966ef9b71a7fc26
2021-01-19 11:50:42 -05:00
agodavar f4edf51736 SWDEV-268552 - HIP sample hipDispatchEnqueueRateMT segfaults, updated to use hipModuleLoadData
Change-Id: Ibf34c780d5bd4278adcedba1d6e057637c258485
2021-01-19 09:32:14 -05:00
Tony Tye 6b641fb368 SWDEV-268864 - Use new isa class to access isa related information (part 2)
Change-Id: If7ed535b3012aec3f2cb4eb7ab93d8f5aed9783f
2021-01-19 03:36:22 +00:00
Tony Tye cd1117d627 SWDEV-268864 - Use new isa class to access isa related information
Change-Id: I2122bf85155997d802ca54e456c2dae66b801825
2021-01-18 22:31:01 +00:00
Sameer Sahasrabuddhe 2cac768a07 Implement assert() using the new fprintf_stderr facility
The device library now provides functions to specify the host stderr
stream in a hostcall printf message. This change implements an
assert() macro which can construct such a message. The end result is
that assertions on the device are now correctly printed on the host
stderr instead of stdout.

Change-Id: I85ab8f7848bcf28303cb8dbb8a798bc6aece7d75
2021-01-17 23:54:46 -05:00
David Salinas de3031988d remove extractkernel
Change-Id: I46a380059fa336aa7553669629a21e8aa7717e7b
2021-01-15 11:34:32 -08:00
Satyanvesh Dittakavi 84cda7f9c2 device property __HIP_ARCH_HAS_SHARED_INT64_ATOMICS__ set to 1 as it has compiler support
Change-Id: Ic91c4955d4f2d52d844471f81e6f0d19418018f5
2021-01-15 11:40:09 -05:00
DURGESH KROTTAPALLI d27db0f038 [dtest] Kernel Execution time fix for hipExtLaunchKernelGGL and hipExtModuleLaunchKernel API's
Fix for kernel execution time using clock rate

SWDEV-238517 for enhancing hip unit tests

Change-Id: Id06df31387ecab96f219e0c1fbcdda1609f75605
2021-01-15 01:58:22 -05:00
David Salinas 7e9b9534d3 add new code object tooling: roc-obj-ls and roc-obj-extract
SWDEV-229776

Change-Id: Icb11c4552515d3eff3bcf303c4a470ab90d1dd58
2021-01-14 14:45:46 -05:00
Tao Sang 8fc1ff7d4f Fix building mathlibs failure
Add back
__HIP_PLATFORM_HCC__
__HIP_PLATFORM_NVCC__

Change-Id: I1ae48678eafd849d6c25bcb204c1724b026be22f
2021-01-14 14:03:15 -05:00
Tony Tye 7d35a43165 Use ROCclr Info.targetId_
Use Info.targetId_ instead of Info.name_ so it will work on Windows
PAL driver and ROCm.

Change-Id: I20537899c36c0ee330a4c09136a52e53d9f35e0d
2021-01-14 05:17:20 +00:00
jujiang 32f35bbd2a SWDEV-265003-Update HIP documents
Change-Id: I3aea36f9a817ff0d2a379fc902b1ba7794f9736e
2021-01-13 17:55:16 -05:00
Rahul Garg 66776ae8de Update dispatch latency with wall time measurements
Change-Id: I73bfed129171d6909b4638f714b694111b31ef56
2021-01-12 22:52:33 +00:00
Tao Sang 149254f7f8 Workarround for rocThrust building failure
Define the following for workarround of rocThrust building failure,
HIP_INCLUDE_HIP_HCC_DETAIL_DRIVER_TYPES_H
HIP_INCLUDE_HIP_HCC_DETAIL_HOST_DEFINES_H

Change-Id: I1ae48677eafd749d6c25bca204c1724b026be22f
2021-01-12 11:31:06 -05:00
Tao Sang 12c976ef63 Fix failure for g++/hipMalloc test
Fix hardcoded /opt/rocm

Change-Id: I1ae48567eafd749d6c25bca204c1724b026be21f
2021-01-11 11:46:17 -05:00
Michael LIAO 6b9c1744e9 Remove checking on double.
- All conversions among floating point types should be allowed.

Change-Id: I6223bece51f5b2a535ab3369c5c4380f18acc74d
2021-01-11 11:33:33 -05:00
Sameer Sahasrabuddhe 3558643c64 Identifiers with a double underscore "anywhere" are reserved
This particular cleanup is limited to just two functions defined in
the HIP headers.

Change-Id: Ib529685265f2fda90e009b24e7e756e0cf363012
2021-01-11 15:09:53 +05:30
Icarus Sparry 468929e539 Allow for /usr/bin/hipcc to be a symlink
SWDEV-267206

If /usr/bin/hipcc is a symlink then resolve it first, and then find
the resulting directory rather than resolving /usr/bin.

Change-Id: I380728ffa05ed813cc793a1d6488aaae81ddbda8
2021-01-11 00:50:20 -05:00
Saleel Kudchadker dab9ae32b2 Update documentation for hipEventCreateWithFlags
Change-Id: I2658bd95df0d3a802cce4ffcb8dfd40e7055b0f7
2021-01-08 16:32:57 -05:00
Rahul Garg 3829645039 Add IPC Events support
Change-Id: Iac2bf3d5e1d9a993bebbb066c20d300d6f05558b
2021-01-08 20:09:26 +00:00
Tao Sang d504a761ad Remove hip-hcc codes: Part four
Remove __HCC__, __HCC_ONLY__, __HCC_CPP__, __HCC_C__,
__HCC_OR_HIP_CLANG__, __HIP_ROCclr__ and their guarded codes.

Remove Hcc codes from directed_tests and samples.

Remove __HIP_PLATFORM_HCC__ and __HIP_PLATFORM_NVCC__ from
some files where they are not necessary.

Add deprecation notice.

Change-Id: I1ae467eafd749d6c25bca204c1724b026be21fce
2021-01-08 10:53:34 -05:00
DURGESH KROTTAPALLI ec794ae051 [dtest] Tests for hipExtLaunchKernelGGL APIs
Added test scenarios for hipExtLaunchKernelGGL
1. verify kernel execution time using events
   passed through argument
2. Verify the API by disabling time flag in
   event creation.

SWDEV-238517 for enhancing hip unit tests

Change-Id: I755adc34a25c58b68041fc927bbffd2a9e6eafde
2021-01-08 00:16:54 -05:00
DURGESH KROTTAPALLI a57968fba9 [dtest] Tests for hipExtModuleLaunchKernel APIs
Added test scenarios for hipExtModuleLaunchKernel/hipModuleLaunchKernel APIs

 1. Negative Test Scenarios for hipExtModuleLaunchKernel API
 2. Negative Test Scenarios for hipModuleLaunchKernel API
 3. hipExtModuleLaunchKernel API Concurrency Verification
    using global variable
 4. hipExtModuleLaunchKernel API Concurrency Verification
    using total time taken by kernels.
 5. hipExtModuleLaunchKernel API verifying the kernel execution time
    of a particular kernel
 6. hipExtModuleLaunchKernel API verifying by disabling the
    time flag during event creation

SWDEV-238517 for enhancing hip unit tests

Change-Id: I33bbab152d47beba62065c461a07cbcacdc01d97
2021-01-08 00:05:57 -05:00
Rupam Chetia 5ba7259ffc [dtest] Enabling all negative tests for hipModule* APIs
Enabling all negative test cases for amd as they are functional now
SWDEV-238517 for enhancing hip unit tests

Change-Id: I0bdbf8c192ef94588403c8f027c0399dd5480a00
2021-01-07 23:50:56 -05:00
Rupam Chetia 328f8ab0ff [dtest] Additional tests for hipDevice APIs
APIs: hipDeviceGetAttribute(), hipGetDeviceProperties(),
      hipDeviceGetByPCIBusId() and hipDeviceGetPCIBusId()
1. New negative test cases for each API.
2. Additional attributes for testing with hipDeviceGetAttribute()

SWDEV-238517  Enhancing hip unit tests

Change-Id: I3c24462426ffaf3a9317b7de9cd33f7c65791a4b
2021-01-07 23:29:14 -05:00
DURGESH KROTTAPALLI b2a93adb82 [dtest] Enhanced tests for hipGetDeviceCount hipSetDevice and hipGetDevice
Added following functional and negative scenario tests for
HIP_VISIBLE_DEVICES (HVD), ROCR_VISIBLE_DEVICES (RVD)
CUDA_VISIBLE_DEVICES(CVD)
1. Verifying HVD and RVD - invalid number in sequence
2. Verifying HVD and RVD - dupliates in the beginning of sequence
3. Verifying HVD and RVD - all the duplicates
4. Device count with RVD(max devices and HVD(min devices)
5. Device count with RVD(min devices and HVD(max devices)
6. Device count - RVD(set), HVD(unset), CVD(set)

SWDEV-238517 for enhancing hip unit tests

Change-Id: Ia83e9e9068cbf8cc61cff17311cda1d1f8a38fee
2021-01-07 23:23:51 -05:00
Rupam Chetia 656a2cb556 [dtest] Tests added for V3 and V4 Code Objects with Static Lds
- Added test for V3 Static Lds code object with sramecc/xnack settings.
- Added test for V4 Static Lds code object.

SWDEV-238517 for enhancing hip unit tests

Change-Id: Ibc4f7e12033dec231d6834ccdd983e3b9e001d60
2021-01-07 23:19:02 -05:00
Jatin Chaudhary 9e35810188 Populate HIP_CLANG_PATH if its not declared
Change-Id: Ibc1f2e9b3389b6cc7a58579cfb293999ad6e9398
2021-01-07 04:15:42 -05:00
Payam 1f9fd14a57 Cleaning lintian warning SWDEV-247996 Part3
Change-Id: I62e5bfc5f17eee12a7a0cfe8ed6fbc35c43ff8c3
2021-01-06 11:56:11 -05:00
agodavar 6838df46eb SWDEV-245381: Updated guarantee error messages to print based on BUILD_TYPE
Change-Id: Ifafbc075d6b9860da040c72859127c4e638a786f
2021-01-05 23:29:50 -05:00
DURGESH KROTTAPALLI 7e6d748f26 [dtest] Tests for hipMemcpy2D and hipMemcpy2DAsync APIs
Added following functional and negative scenario tests
for hipMemcpy2D and hipMemcpy2DAsync APIs
 1. Verifying D2H and H2D functionality
 2. Verifying D2D on same device and peer device
 3. Verifying using pinned host memory on same and peer GPU
 4. Negative test scenarios
 5. Verifying hipMemcpy2DAsync API along with kernel launch

SWDEV-238517  Enhancing hip unit tests

Change-Id: I8f447bc7f6bf13cb895f1809f5a2b501baa8782c
2021-01-05 23:23:09 -05:00
Tao Sang 8a2b0b7424 Remove hip-hcc codes: Part three
1.Rename include/hip/hcc_detail/ as include/hip/amd_detail/

2.Rename include/hip/nvcc_detail/ as include/hip/nvidia_detail/

3.Create __HIP_PLATFORM_AMD__ to replace __HIP_PLATFORM_HCC__

4.Create __HIP_PLATFORM_NVIDIA__ to replace __HIP_PLATFORM_NVCC__

After hcc_detail, nvcc_detail, __HIP_PLATFORM_HCC__ and __HIP_PLATFORM_NVCC__
have been removed from upstream, they will be removed from hip runtime.

Change-Id: I1ae457effd739d6c25bca203c1724b026be21fce
2021-01-05 10:39:31 -05:00
sumanthtg 2624a5654c [dtest] Tests for hipMemset3D/hipMemset3DAsync APIs
Negative, Functional and Regression scenarios for
 - hipMemset3D
 - hipMemset3DAsync

SWDEV-238517 for enhancing hip unit tests

Change-Id: Idc5604f728ca1a96ec13876e006120f7a3d69acf
2021-01-05 07:00:48 -05:00
Satyanvesh Dittakavi 15baf7ef6d SWDEV-263678 - fix rocHPCG mgpu perf drop
Change-Id: I33269fe4f6165d1ed172b19033ab9fcb92f338c3
2021-01-05 00:22:12 -05:00
cjatin 6faffdffd2 Add ELF Flags moved from rocclr
Change-Id: I5febe7bdca80517e9f9492d7930def72db83c14e
2021-01-04 13:43:16 -05:00
Jatin Chaudhary e14dbaeb6e Adding file command as dependency
Change-Id: Ic719c5ce8ad0d99f6a341b5b46927587080fcf2e
2021-01-04 00:03:53 -05:00
Sarbojit Sarkar f64af513a2 Revert "Fix hipmemset to match CUDA behavior"
This reverts commit 9ba5902be4.

Change-Id: I53052b25bac4956f3efd124eadc936197f2e466a
2021-01-01 00:11:58 -05:00
agodavar f3e350cd12 SWDEV-239065 Refactor hipcc, added new perl module hipvars
Change-Id: I2b71ceb2563501c7b2861cd0f2e23d01207b1bc2
2020-12-31 05:41:36 -05:00
agodavar 7dcf2769ae hipmemcpy2D handle height 0
Change-Id: I46bf89e81559c3bfccac0dd0ccd78eee9058c7e3
2020-12-31 01:41:56 -05:00
agodavar e7c85da68b SWDEV-265171 Remove hcc compiler support from hipcc
Change-Id: Ibd06e68dd1f079b2f9e46606bdbfc0a0a780b638
2020-12-30 06:26:09 -05:00
agodavar c5e3f955bf SWDEV-266089: hipStreamAddCallback argument validation
Change-Id: I3e61006796e88b4e2ba029118c95f3499959257b
2020-12-29 05:42:54 -05:00
Sarbojit Sarkar 567a95b4e4 SWDEV-262810: skip duplicate compile flag inclusion
Change-Id: I02ebfb3cbaf6ec25819de0c4952795c6cc949e4d
2020-12-20 23:26:55 -05:00