Commit Graph

39 Commits

Author SHA1 Message Date
coleramos425 cdeb2c7e85 Add custom decorator to avoid using kw_only
Signed-off-by: coleramos425 <colramos@amd.com>
2024-03-01 17:49:22 -06:00
colramos-amd d6f45411eb Python formatting
Signed-off-by: colramos-amd <colramos@amd.com>
2024-03-01 15:50:42 -06:00
Nicholas Curtis 817774be5e print version out of table
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
2024-03-01 15:50:42 -06:00
Nick Curtis 5b5d4c9a23 Update src/utils/specs.py
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Nick Curtis <6463881+skyreflectedinmirrors@users.noreply.github.com>
2024-03-01 15:50:42 -06:00
Nicholas Curtis 200961ffd9 Re-implement machine-specs to contain documentation, units, etc. Print using tabulate
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
2024-03-01 15:50:42 -06:00
colramos-amd 3197553ca6 Add version to specs/sysinfo output in order to throw warning for new fields
Signed-off-by: colramos-amd <colramos@amd.com>
2024-03-01 15:50:42 -06:00
colramos-amd 09f1455308 Added consistent 'Channel' headers to l2_per_chan, removed hardcoded 32 channels, and removed printed Nones (#276)
Signed-off-by: colramos-amd <colramos@amd.com>
2024-03-01 15:50:42 -06:00
colramos-amd c17e39189f Enhance correct_sys_info() func and err checking
Signed-off-by: colramos-amd <colramos@amd.com>
2024-03-01 15:50:42 -06:00
colramos-amd a70dc4999d Hide L2Banks in sysinfo and update roofline module
Signed-off-by: colramos-amd <colramos@amd.com>
2024-03-01 15:50:42 -06:00
colramos-amd bd794abb12 Fix Mi300 clk timings using GRBM_GUI_ACTIVE from #255
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
2024-03-01 15:50:42 -06:00
colramos-amd 2001908fd8 Carry over fixed numSQCs calc from #247
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
2024-03-01 15:50:42 -06:00
colramos-amd 86b6c8e848 Renaming global spec vars. Replacing L2Banks with total_l2_chan (#251)
Signed-off-by: colramos-amd <colramos@amd.com>
2024-03-01 15:50:42 -06:00
colramos-amd 3b1b8d7b5b Reorganize the specs module to reduce duplicate code
Signed-off-by: colramos-amd <colramos@amd.com>
2024-03-01 15:50:42 -06:00
Karl W Schulz f2235b7f1d Fix for rocm-smi not getting mclk for MI100
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2024-02-26 11:47:56 -06:00
Karl W Schulz 79b877d679 code formatting updates
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2024-02-22 16:02:25 -06:00
Nick Curtis 852cc13f2a Fix clocks (#246)
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Co-authored-by: Nicholas Curtis <nicurtis@amd.com>
2024-02-13 20:22:11 -06:00
Nick Curtis c60f031558 Fix hbmBW calculation, (#243)
* Fix hbmBW calculation, currently we're reading the wrong value of the mclk out of rocm-smi

Signed-off-by: Nicholas Curtis <nicurtis@amd.com>

* Fix for earlier smi

Signed-off-by: Nicholas Curtis <nicurtis@amd.com>

---------

Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Co-authored-by: Nicholas Curtis <nicurtis@amd.com>
2024-02-13 20:19:56 -06:00
colramos-amd b7d5d3b64b Modify yaml configs to reflect new combined Top Stats
Signed-off-by: colramos-amd <colramos@amd.com>
2024-02-13 19:56:46 -06:00
colramos-amd 33a2cd34ce Revert sbios fix. Catch commas
Signed-off-by: colramos-amd <colramos@amd.com>
2024-02-08 12:52:07 -06:00
Nick Curtis c8f4f74255 Escape sbios, can have commas on some systems (#241)
* escape sbios, can have commas on some systems

Signed-off-by: Nicholas Curtis <nicurtis@amd.com>

* Prefer to cast to str in original function

Signed-off-by: colramos-amd <colramos@amd.com>

---------

Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Co-authored-by: Nicholas Curtis <nicurtis@amd.com>
Co-authored-by: colramos-amd <colramos@amd.com>
2024-02-08 12:40:52 -06:00
colramos-amd d16f58b797 Add numPipes built-in-var for updated metrics
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
2024-02-06 16:19:40 -06:00
Karl W Schulz eece1f4688 add an optional exit_on_error arg for the run utility and enable for a
subset of calls to rocm-smi

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2024-02-05 16:20:21 -06:00
colramos-amd 194e168414 Modify smi error detection to check for non-zero exit code
Signed-off-by: colramos-amd <colramos@amd.com>
2024-02-02 14:27:08 -06:00
Karl W. Schulz d7b6cf81e6 update headers for 2024 calendar year
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
2024-01-24 17:50:31 -06:00
colramos-amd f49d7f7f0c Patch specs enhancement for Mi300
Signed-off-by: colramos-amd <colramos@amd.com>
2024-01-24 16:30:04 -06:00
colramos-amd e5ac5ccf7d Responding to Karls review
Signed-off-by: colramos-amd <colramos@amd.com>
2024-01-24 16:30:04 -06:00
coleramos425 d9a6832e30 Decode specs using utf-8 for backwards compatibility in rocprof
Signed-off-by: coleramos425 <colramos@amd.com>
2024-01-24 16:30:04 -06:00
colramos-amd 987f612489 Adding sbios, vbios, and partitioning info to specs. Also reorganizing fields.
Co-authored-by: fei.zheng <fei.zheng@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
2024-01-24 16:30:04 -06:00
coleramos425 7c9d317527 Comply to Python formatting
Signed-off-by: coleramos425 <colramos@amd.com>
2023-02-21 13:02:43 -06:00
coleramos425 c4eaa1d45b Specify returncode for rocm-smi error (#85)
Signed-off-by: coleramos425 <colramos@amd.com>
2023-02-21 12:40:41 -06:00
coleramos425 f77173a2f1 Catch exceptions from rocm-smi (#85)
Signed-off-by: coleramos425 <colramos@amd.com>
2023-02-21 09:47:45 -06:00
Karl W. Schulz 574ebcf755 apply "make license" update
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
2023-02-13 14:50:24 -06:00
Karl W. Schulz 3d7a7a6f32 updating copyright header for 2023 using newly-added "make license" target
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
2023-02-13 14:15:27 -06:00
Karl W. Schulz c8fc8e8026 adding license delimiters to headers
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
2023-02-13 10:36:29 -06:00
coleramos425 48df0d6db4 Upgrade python formatting module
Signed-off-by: coleramos425 <colramos@amd.com>
2023-02-07 14:45:22 -06:00
coleramos425 f6dad0cd58 Comply to Python formatting
Signed-off-by: coleramos425 <colramos@amd.com>
2023-01-23 16:08:42 -06:00
coleramos425 00c9ff9493 Merge branch 'dev' into lucky
Signed-off-by: coleramos425 <colramos@amd.com>
2023-01-23 15:28:35 -06:00
Keith Lowery eadd35e5c6 Integrated support for using rocscope with omniperf for top10 (--i-feel-lucky)
Signed-off-by: coleramos425 <colramos@amd.com>
2023-01-23 15:12:15 -06:00
colramos-amd 62d130b458 Initial commit 2022-11-04 14:49:36 -05:00