Rahul Vaidya
0adc5edc74
Fix RHEL10 packaging for rcclras and rccl-UnitTests ( #1831 )
...
Signed-off-by: ravaidya <ravaidya@amd.com >
2025-07-31 11:00:49 -05:00
Nilesh M Negi
bd55f876e9
[DEVICE] Add unroll=2 for gfx950 multi-node ( #1824 )
2025-07-31 02:35:26 -05:00
ycui1984
874cd657ef
Add collective latency profiler ( #1785 )
...
* [LatencyProfiler] Initial commit
* [LatencyProfiler] Add unit tests
* [LatencyProfiler] add more
* [LatencyProfiler] Pass unit tests
* [LatencyProfiler] Add hooks to integrate with meta internal tools
* [LatencyProfiler] Restore install.sh
* [LatencyProfiler] Resolved comments 1. add proper license 2. use proper namespace
* [LatencyProfiler] Add header
2025-07-30 14:59:28 -07:00
Mustafa Abduljabbar
4ce3df8d3a
Optimize alltoall for 64 GPUs and above for gfx942 ( #1828 )
...
Add pxn and p2p net chunksize mi300x tuning
2025-07-30 15:14:43 -04:00
mberenjk
c84ee3d298
Upcast FP8 to Half (FP16) for Sum Operation ( #1775 )
...
* adding hadd and hadd2 support using builtin functions.
---------
Co-authored-by: Marzieh Berenjkoub <mberenjk@amd.com >
2025-07-29 11:33:06 -05:00
awelling2801
9843adaab2
Added tests for Ipcsocket ( #1690 )
...
Co-authored-by: Welling <awelling@ctr2-alola-ctrl-01.amd.com >
2025-07-29 10:03:28 -05:00
awelling2801
e118aadc14
Code coverage improvements for alloc.h ( #1676 )
...
* Added tests for alloc.h
* Added tests for ZeroElementCopy and MemcpyNullSrcOrDstPointer
---------
Co-authored-by: Welling <awelling@ctr2-alola-ctrl-01.amd.com >
2025-07-29 09:19:57 -05:00
peizhang56
fe182d6546
Add Unit Test for bitops.h ( #1821 )
...
* Add Unit Test for bitops.h
* Change the style
* Fix the code review comments
* Add more test cases
2025-07-28 11:25:15 -05:00
Atul Kulkarni
81ec6bff4c
Added new unit tests for src/transport/p2p.cc ( #1774 )
2025-07-25 12:57:57 -05:00
Sarat Kamisetty
783c073a03
passing down NET_OPTIONAL_RECV_COMPLETION hint to n/w plugin to enable optimizations ( #1752 )
...
Co-authored-by: Sarat Kamisetty <sakamiset@amd.com >
2025-07-25 10:26:58 -05:00
Mustafa Abduljabbar
0ce20e7e07
Add optional bf16 software-triggered pipelining for reduceCopyPacks ( #1758 )
...
- Introduced double-buffering to reduce copy overhead and overlap BF16 arithmetic with data prefetching.
- Aimed to improve performance of reduction-based collectives by up to 10%.
- Implemented based on recommendations from Guennadi Riguer (AMD)
- Added --force-reduce-pipeline option to install.sh to activate this optimization for BF16 reductions.
- Feature is disabled by default to prevent regressions with large messages until auto-tuning logic is upstreamed.
---------
Co-authored-by: Jeffrey Novotny <jnovotny@amd.com >
Co-authored-by: Pedram Alizadeh <pmohamma@amd.com >
2025-07-25 10:57:05 -04:00
Atul Kulkarni
1c3d1b3842
Added new unit tests for src/transport/shm.cc ( #1689 )
2025-07-25 05:54:42 -05:00
Arm Patinyasakdikul
3c9c22bb52
Fix segfault when libibverbs returns 0 device. ( #1820 )
...
Fix: SWDEV-543816
2025-07-23 15:18:52 -05:00
Wenkai Du
9a4213356d
Support fused all reduce and elementwise operations ( #1729 )
...
* Support fused all reduce and elementwise operations
Add additional "acc" parameter to RCCL Replayer logs
Add flag which indicates availability of new API
* Fix Recorder json parsing
* Remove unreachable code
* Remove extra acc pointer check
* .
* Revert "[DEVICE] Adding ability to choose unroll factor at runtime (#1734 )"
This reverts commit 9d72be7b2f .
* Use noinline to reduce kernels linking time
* Don't use noinline for gfx942 and gfx950 to avoid perf regression
---------
Co-authored-by: AtlantaPepsi <timhu102@amd.com >
Co-authored-by: BertanDogancay <bertan.dogancay@gmail.com >
2025-07-23 09:04:17 -07:00
alex-breslow-amd
11fabf1de1
Cheaper threadfence for gfx942 in postPeer [1/N]: enable for single node allreduce ( #1766 )
...
Boosts single node bfloat16 allreduce performance by up to 20% for some data sizes and provides gating with the RCCL_GFX942_CHEAP_FENCE_OFF environment variable
2025-07-22 07:15:15 -07:00
Rahul Vaidya
c28d3d26a3
Add datatype validation for MSCCLPP AllGather ( #1816 )
...
Signed-off-by: rahulvaidya20 <ravaidya@amd.com >
2025-07-21 11:50:45 -05:00
Atul Kulkarni
275fdd43c1
Code coverage improvements ( #1665 )
...
* Increased max stack size to 640
* Added new binary for executing unit tests
Added new unit tests for argcheck.cc and alt_rsmi.cc files
Modified the method to execute unit tests to cover static methods
by using a bash script to convert static to non-static functions
and variables on the fly restricted to debug build type.
2025-07-17 11:20:49 -05:00
isaki001
ef6a54ba34
Fix typo in NPKit build that prevents NET_TEST event ( #1807 )
2025-07-16 09:08:06 -05:00
Nilesh M Negi
6632183efe
[GRAPH] Match maxChannels for gfx942 CUs ( #1302 )
2025-07-16 09:07:02 -05:00
Wenkai Du
106024b0db
Fix inline compilation issue with LL ( #1806 )
2025-07-15 08:39:18 -07:00
isaki001
8d0f1a1cef
gfx950 updated on LL thresholds for allreduce/allgather, update treeCorrection ( #1803 )
...
* change LL thresholds for allreduce/allgather and update treeCorrectionFactor
* update allGather LL cutoff
* adjust allgather LL/LL128 thresholds
2025-07-15 09:10:19 -05:00
dependabot[bot]
aafbdad2ab
Bump requests from 2.32.2 to 2.32.4 in /docs/sphinx ( #1738 )
...
Bumps [requests](https://github.com/psf/requests ) from 2.32.2 to 2.32.4.
- [Release notes](https://github.com/psf/requests/releases )
- [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md )
- [Commits](https://github.com/psf/requests/compare/v2.32.2...v2.32.4 )
---
updated-dependencies:
- dependency-name: requests
dependency-version: 2.32.4
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-07-14 10:30:37 -06:00
dependabot[bot]
d4d021c726
Bump tornado from 6.4.2 to 6.5.1 in /docs/sphinx ( #1710 )
...
Bumps [tornado](https://github.com/tornadoweb/tornado ) from 6.4.2 to 6.5.1.
- [Changelog](https://github.com/tornadoweb/tornado/blob/master/docs/releases.rst )
- [Commits](https://github.com/tornadoweb/tornado/compare/v6.4.2...v6.5.1 )
---
updated-dependencies:
- dependency-name: tornado
dependency-version: 6.5.1
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-07-14 10:25:01 -06:00
Wenkai Du
708ad75f7a
Disable P2P net option by default ( #1793 )
2025-07-14 08:55:39 -07:00
Nikhil-Nunna
7abc7538ea
topo_explorer initial readme ( #1797 )
...
* topo_explorer intial readme
* topo_explorer readme update
* topo_explorer readme update
* Added sample output to README
* Update README.md
* Update README.md
---------
Co-authored-by: Mustafa Abduljabbar <mustafa.abduljabbar@amd.com >
2025-07-11 11:28:20 -05:00
Jobbins
7ebd31097c
[rccl] Remove .jenkins folder ( #1754 )
2025-07-11 11:24:06 -05:00
Bertan Dogancay
7158adb57f
[GEN] Fix typo in IFC code gen ( #1796 )
2025-07-11 09:19:39 -04:00
Nilesh M Negi
6b4ad0fd74
[BUILD] Use fmt-header instead of libfmt ( #1791 )
2025-07-10 17:19:53 -05:00
Nilesh M Negi
f839e4edef
[TOOLS] Update p2p-latency-test for gfx950 ( #1730 )
2025-07-10 12:13:29 -05:00
Nilesh M Negi
2c099fe29a
[INIT] Fix fallback for unsupported user-specified runtime unroll factor ( #1780 )
...
* [INIT] Fix fallback for unsupported user-specified runtime unroll factor
* Add CollTrace guard
* Move `commSetUnrollFactor()` to rccl_wrap.cc
* Modify comments in the device-code generator script
2025-07-10 10:56:18 -05:00
Nilesh M Negi
68d6f99e0f
[DEVICE] Fix validation errors for multi-node LL with gfx950 non-coherent system memory ( #1795 )
2025-07-10 09:05:46 -05:00
Mustafa Abduljabbar
058264b3f3
Fix AllReduce regression due to previous max range increase for LL64/LL128 ( #1787 )
...
* Adjust tuning factor impacting more than 2 nodes
* Scale max LL128 size for > 2 nodes
* Retune max LL128 range for N > 2
2025-07-09 19:17:10 -05:00
Atul Kulkarni
a28d5cb986
Enable Google Test's GMOCK feature ( #1773 )
2025-07-09 17:25:44 -05:00
mberenjk
697bee4ee8
Improving build time by removing the gfx11xx and host code from rccl_float8.h ( #1789 )
...
* removing extra build time by removing the gfx11xx arch from using hip_fp8
---------
Co-authored-by: Marzieh Berenjkoub <mberenjk@amd.com >
2025-07-09 14:03:47 -05:00
Bertan Dogancay
9c89573580
[GRAPH] Pass rank instead of busId due to a change in an internal function signature ( #1792 )
2025-07-08 08:45:54 -04:00
Marius Brehler
dac0e528a0
Set GTEST_BOTH_LIBRARIES appropriately ( #1669 )
...
If `find_package()` succeeds to find GTest and `INSTALL_DEPENDENCIES`
is set to OFF, `GTEST_BOTH_LIBRARIES` is not set and thus
`rccl-UnitTests` fails with trying to link unkown symbols.
2025-07-05 20:38:31 -05:00
Bertan Dogancay
e96c8473a1
[DEVICE] Enable PAT algo for RCCL 1ppn ( #1756 )
...
* Enable PAT algo for RCCL 1ppn
2025-07-04 13:45:18 -04:00
Rakesh Roy
dd3b1d816c
Fix chrono build error ( #1790 )
2025-07-04 08:27:30 -05:00
Wenkai Du
ae9642d4bc
msccl: use special send for LL on gfx950 ( #1788 )
2025-07-03 04:16:18 -05:00
ryanhankins
9d35581d5e
Adding #include <dlfcn.h> in nccl_net.h to pass build ( #1786 )
2025-07-02 19:21:53 -05:00
Nilesh M Negi
9e99c18f6e
[MSCCLPP] Disable format checks in MSCCLPP by default ( #1781 )
2025-07-02 09:11:42 -05:00
Wenkai Du
4640ab19b3
Add support for extended fine grained system memory pool ( #1770 )
...
* Add support for extended fine-grained system memory pool
* Use hipHostRegisterUncached
* Add "sc0 sc1" flags for LL store on gfx950
* Update after HIP flag is changed to hipExtHostRegisterUncached
2025-07-01 16:38:49 -05:00
Nilesh M Negi
3e51c41dcb
[BUILD] Fix packaging for RAS ( #1784 )
2025-07-01 16:37:14 -05:00
Nilesh M Negi
8d3a5542fb
[RAS] Add support for RAS client ( #1748 )
...
Enable RAS client binary `rcclras`
2025-06-29 18:53:16 -05:00
isaki001
75d22b47cb
added tuning table for gfx950 ( #1779 )
...
* added tuning table for mi350
* remove erroneous string
2025-06-29 15:45:39 -05:00
Bertan Dogancay
358dc1bc84
Switch to linear channel mapping for 2 nodes ( #1777 )
2025-06-28 09:10:18 -05:00
Arm Patinyasakdikul
35024ca1cb
[topo-expl] update header file location. ( #1769 )
2025-06-27 15:29:37 -05:00
gilbertlee-amd
16101e654f
Fixing HelloRccl include path to RCCL, fixing some warnings ( #1778 )
2025-06-27 09:12:59 -06:00
Arm Patinyasakdikul
265b1b3775
add warning if workFIFO is not available after multiple retries. ( #1772 )
...
* add warning if workFIFO is not available after multiple retries.
* Update src/enqueue.cc
Co-authored-by: corey-derochie-amd <161367113+corey-derochie-amd@users.noreply.github.com >
---------
Co-authored-by: corey-derochie-amd <161367113+corey-derochie-amd@users.noreply.github.com >
2025-06-26 19:49:52 -05:00
Arm Patinyasakdikul
71c788d4d7
Update plugin to look for librccl-net.so. ( #1768 )
2025-06-26 16:59:38 -05:00