Commit Graph

1179 Commits

Author SHA1 Message Date
Sameer Sahasrabuddhe f12c0f1dbb SWDEV-204784: separate printf declaration for vdi/clang
There are now two implementations of printf in HIP:

1. The implemenation for HCC is controlled by the HC_FEATURE_PRINTF
   macro, and it works only with the HCC compiler used in combination
   with the HCC runtime.

2. The implementation for hip-clang requires the VDI runtime, and is
   always enabled with that combination.

Change-Id: Ibaeda7900ffe2ce602ca0094aafed0f1147ac2b6


[ROCm/clr commit: d48738856c]
2020-03-16 04:00:39 -04:00
Vladislav Sytchenko 98761c5721 Fix typo in device __shfl_xor function
Change-Id: I8bcdd53ced00c596a0af013a0c34e37aa67c93ae


[ROCm/clr commit: caea3f9b32]
2020-03-10 13:23:08 -04:00
Vladislav Sytchenko 952502e2ed Add hipDrvMemcpy3D.
This is the equivalent of cuMemcpy3D.

Change-Id: Ib2e06dbd6f5093c931cdfd36c87617f32acffc2d


[ROCm/clr commit: cd76eb7486]
2020-03-09 16:11:25 -04:00
Lad, Aditya eca6c4f001 Merge branch 'master' into amd-master-next
Conflicts:
	CMakeLists.txt
	tests/src/texture/simpleTexture2DLayered.cpp
	tests/src/texture/simpleTexture3D.cpp

Change-Id: I4aa4754d391b5f37ddf15fa0bcfc84d9da020119


[ROCm/clr commit: e7fdb3d796]
2020-03-06 14:10:44 -05:00
agodavar 1c828b7575 Fix hipExtLaunchMultiKernelMultiDevice compilation issue
Fix compilation error on hip-hcc+clang , hip-vdi+clang
Enabled hipExtLaunchMultiKernelMultiDevice test on hip-vdi path
hipExtLaunchMultiKernelMultiDevice common declaration for all paths

Change-Id: I76031840614fce8e12a8e845548fa43a389a741a


[ROCm/clr commit: 5a6c605730]
2020-03-04 15:38:14 -05:00
saleelk 21712e6fb8 Fix HIPRTC headers to export C style symbols (#1879)
[ROCm/clr commit: 40a28e767e]
2020-02-28 16:47:29 +05:30
Rahul Garg 7395bf9ba9 Remove deprecated HIP markers (#1876)
[ROCm/clr commit: 6be7537cf9]
2020-02-28 16:47:15 +05:30
Rahul Garg ff421fb2d2 Add hipDrvOccupancyMaxActiveBlocksPerMultiprocessor[WithFlags] (#1854)
Equivalent to cuOccupancyMaxActiveBlocksPerMultiprocessor[WithFlags].

[ROCm/clr commit: 1c794045e0]
2020-02-28 16:46:55 +05:30
Nick Curtis e5d029b8a4 fix long shuffle implementations for windows (#1895)
Fixes for SWDEV-223694

[ROCm/clr commit: a094c87038]
2020-02-26 15:53:56 +05:30
Rahul Garg 6f1d14c96d Fix hipMemcpy3D (#1798)
Fixes #1790 and #1791. hipMemcpy3D still requires further refactoring for different input and output combinations.

[ROCm/clr commit: ec84c16d75]
2020-02-17 19:35:35 +05:30
Tao Sang 0292fd9991 Temporarily comment out Hcc-specific APIs for CLang compiler
Temporarily comment out Hcc-specific template functions
hipExtLaunchKernelGGL and hipOccupancyMaxPotentialBlockSize for CLang
compiler so that all test cases under hip/samples can be built
successfully for Clang + Hip/Hcc runtime.

Change-Id: Iafc761257be4a7b34eafa6759a01f369570cd6ce


[ROCm/clr commit: 15b91e9f1e]
2020-02-16 22:26:47 -05:00
Nick Curtis e9ee5a3719 Implement long / long long shuffles (#1829)
Implement additional data-types for shuffles (long and long long).
Based upon the double implementation.


[ROCm/clr commit: 5b0f34c59b]
2020-02-15 09:51:09 +05:30
ansurya 708af7e6ac Reduce GPU copying based on arch it runs on (#1751)
Implements SWDEV-213230.

[ROCm/clr commit: 888a7f2a90]
2020-02-13 14:21:51 +05:30
Aryan Salmanpour 89cb17284b fix build error in nvcc path
[ROCm/clr commit: 1c013bab3e]
2020-02-11 12:16:51 -05:00
Aryan Salmanpour e7059e518d Fix a typo causing a build error
[ROCm/clr commit: 504412c1e4]
2020-02-10 11:44:40 -05:00
Aryan Salmanpour 44ce519211 resolve merge conflict
[ROCm/clr commit: dfa565d76f]
2020-02-10 10:30:55 -05:00
Maneesh Gupta a21b1f84cb Revert "Match Occupancy APIs syntax with CUDA (#1625)" (#1857)
Reverting this for now till we figure out how to avoid the build
breakage.

This reverts commit 2c6e880e05.

[ROCm/clr commit: d032637934]
2020-02-10 10:45:28 +05:30
Alex Voicu 7f9f87b0d9 (Maybe) Match alignment between Clang and GCC. (#1789)
Should fix #1740 and the related internal bug.

[ROCm/clr commit: 8f96152d3a]
2020-02-10 10:44:49 +05:30
vsytch e2b6794a07 Device texture functions should not normalize the sampled pixel (#1826)
* Device texture functions should not normalize the sampled pixel. This is already done by HW.
* Add support to use h/w capability for normalized float data convertion for driver API's

Co-authored-by: ansurya <50609411+ansurya@users.noreply.github.com>


[ROCm/clr commit: fa363ae721]
2020-02-05 20:56:17 +05:30
Aryan Salmanpour cbefd62db9 code clean up
[ROCm/clr commit: 75572a4175]
2020-01-31 13:08:25 -05:00
Aryan Salmanpour 2733df36b5 [HIP][HIPIFY] Add some missing flags for cooperative launch and occupancy APIs
[ROCm/clr commit: 6db9b782be]
2020-01-30 15:05:53 -05:00
satyanveshd 2c6e880e05 Match Occupancy APIs syntax with CUDA (#1625)
* Match Occupancy APIs syntax with CUDA and fix tests using these APIs


[ROCm/clr commit: 262ad13dd5]
2020-01-29 13:05:53 -08:00
vsytch 4162b55dbe Add missing texturePitchAlignment member to the hipDeviceProp_t struct. (#1802)
* Add missing texturePitchAlignment member to the hipDeviceProp_t struct.

* Add missing hipDeviceAttributeTexturePitchAlignment enumerator to the hipDeviceAttribute_t enum.

* Initialize texturePitchAlignment to 256. This works for gfx9+, but is technically overaligned in most cases for pre-gfx9.

* Add the texturePitchAlignment property to the NVCC path.


[ROCm/clr commit: 6da0c82b78]
2020-01-27 16:37:00 -08:00
vsytch f1747af7cd Update the HIP_TRSF_* flags to match their Cuda equivalents. (#1801)
[ROCm/clr commit: e419a1609f]
2020-01-24 11:41:15 -08:00
mshivama a49cbb1580 SWDEV-220503: this_grid().thread_rank() gives incorrect result (#1808)
* fix a minor bug while computing this.grid()::thread_rank()

[ROCm/clr commit: 0605426049]
2020-01-24 16:23:28 +05:30
kpyzhov 2d617bba3b Don't use accelerated vector element access for hip-clang. (#1796)
[ROCm/clr commit: 1d6a2fb064]
2020-01-15 18:17:08 -08:00
kpyzhov 8bf4210095 Add missing constructors for Scalar_accessor class. (#1792)
[ROCm/clr commit: 0918614615]
2020-01-14 11:30:21 -08:00
Evgeny Mankov d1d680a1d6 [HIP] Unify hipError_t (Step 3): Sync nvcc path (#1778)
* [HIP] Unify hipError_t (Step 3): Sync nvcc path

* [HIP][fix] Add CUDA 10.x support to nvcc path


[ROCm/clr commit: 9c2fcff9ce]
2020-01-10 13:47:18 +05:30
Maneesh Gupta d814f1e292 Revert PRs that break ROCm builds (#1781)
Fixes SWDEV-218626 and SWDEV-218629

Changes:
- Revert "`static inline` in a header, just like excess sugar in a diet, causes bloat (#1692)"
   This reverts commit 47725baf8c.
- Revert "Fix rocFFT build failure (#1777)"
   This reverts commit f7bac3e057.

[ROCm/clr commit: c091635f5a]
2020-01-08 15:11:58 +05:30
ansurya f7bac3e057 Fix rocFFT build failure (#1777)
Fixes SWDEV-217761

[ROCm/clr commit: cbd8f604ec]
2020-01-07 08:12:37 +05:30
Rahul Garg 1e78733f53 Add hipBindTexture2D on NVCC path (#1773)
[ROCm/clr commit: 534376cb41]
2020-01-06 12:33:50 +05:30
Rahul Garg 32139b7465 Fix hipcc warning related to hipVersion (#1767)
* Fix hipcc warning related to hipVersion
* Rename hipVersion.h to hip_version.h
* Remove HIP_VERSION splitting
* Update .gitignore
- Ignore generated include/hip/hip_version.h
- Removed some stale entries
- Added executables from samples/1_Utils/*/ for consistency with bin/ entries.

[ROCm/clr commit: 3fe1695c3a]
2020-01-06 12:33:23 +05:30
Evgeny Mankov 8c58286a9b Merge pull request #1759 from emankov/master
[HIP] Unify hipError_t (Step 2)

[ROCm/clr commit: ed43699a3a]
2019-12-30 19:21:09 +03:00
Sarbojit2019 4d2ee146e1 Change to generate hipVersion.h (#1726)
HIP_VERSION_MAJOR, HIP_VERSION_MINOR, HIP_VERSION_PATCH and HIP_VERSION pre-processor macros are now defined in hipVersion.h instead of being set by hipcc.

[ROCm/clr commit: 4fd77f8336]
2019-12-30 12:44:24 +05:30
Aryan Salmanpour ed2609b880 [hip] refactoring cooperative kernel launch APIs (#1737)
This PR is a follow-up on PR# #1698 and it makes two more APIs (hipLaunchCooperativeKernel/hipLaunchCooperativeKernelMultiDevice) inline so that they can work correctly with lazy binding.

[ROCm/clr commit: 857052be1e]
2019-12-30 12:42:17 +05:30
Evgeny Mankov d191980c6a [HIP] Clean-up deprecated HIP error codes
hipErrorMemoryAllocation -> hipErrorOutOfMemory
hipErrorInitializationError -> hipErrorNotInitialized
hipErrorMapBufferObjectFailed -> hipErrorMapFailed
hipErrorInvalidResourceHandle -> hipErrorInvalidHandle


[ROCm/clr commit: 4aaa2336a8]
2019-12-23 17:01:35 +03:00
Yaxun (Sam) Liu 1224fa6da5 Add macro __HIP_ENABLE_CUDA_WRAPPER_FOR_OPENMP__ (#1761)
This is to allow force enable cuda wrapper for OpenMP for flexibility

[ROCm/clr commit: 35988729f3]
2019-12-23 19:24:54 +05:30
saleelk 60437b9d64 Fix the return type of demangle function so that its compatible across ABIs (#1744)
[ROCm/clr commit: 1ca75e5f6d]
2019-12-23 19:11:40 +05:30
Alex Voicu 1f762e3970 Fix late-coming issues. (#1724)
Implementation for hipMemcpyWithStream.


[ROCm/clr commit: 150e690a3a]
2019-12-23 19:11:24 +05:30
Maneesh Gupta 36b23663e0 replace array designator C99 (#1694)
* replace array designator C99

* Update texture_functions.h

Highlight valid and invalid values in texFormatToSize

Co-authored-by: Maneesh Gupta <maneesh.gupta@amd.com>


[ROCm/clr commit: 32625638da]
2019-12-23 19:10:24 +05:30
Alex Voicu 47725baf8c static inline in a header, just like excess sugar in a diet, causes bloat (#1692)
[ROCm/clr commit: cf526f5484]
2019-12-23 19:09:38 +05:30
Evgeny Mankov 07db042750 [HIP] Fix typo
[ROCm/clr commit: 4d29423705]
2019-12-23 12:06:44 +03:00
Evgeny Mankov e25a6a39a3 [HIP] Unify hipError_t (Step 2)
Step 2. Make a few hipError codes deprecated
Update hipify-clang, hipify-perl, docs and samples accordingly


[ROCm/clr commit: 9ae76609a1]
2019-12-22 02:05:31 +03:00
Maneesh Gupta 35e4141eab Update texture_functions.h
Highlight valid and invalid values in texFormatToSize

[ROCm/clr commit: 6c7ce07577]
2019-12-21 12:25:36 +05:30
Sarbojit2019 2916c02f7b Fix for windows dtest build failure (#1742)
[ROCm/clr commit: 911d406bf1]
2019-12-19 13:10:43 -08:00
mhbliao 313ab97c35 [hip] Add macro guarding the enum conversion for scalar accessor. (#1748)
- That's a high overhead part, which needs enabling ONLY if necessary.

[ROCm/clr commit: a0a50ac601]
2019-12-19 10:08:37 -08:00
Evgeny Mankov 6c0241f539 [HIP] Unify hipError_t (Step 1)
Step 1. Set the same values for RT error codes as for analogous Driver's

[Reason] RT's and Driver's error codes unification in CUDA 10.2


[ROCm/clr commit: 21b0f64f3a]
2019-12-13 19:40:16 +03:00
mhbliao b967f1210d Only add hipExtLaunchMultiKernelMultiDevice for non-HCC compilers. (#1729)
[ROCm/clr commit: 539370d308]
2019-12-10 10:32:25 -08:00
jglaser 2984be48d2 fix linking of vector types with gcc (#1690)
* fix linking of vector types when linking hipcc objects with gcc

* use __atribute__((vector_size)) with both clang and gcc

and reinstate nonaligned n=3 vector type

* use implicit conversion to value and ext_vector_type when available

* Alternate formulation for GCC compatibility

* Built-in arrays don't mix well with placement new

* Fix typo

* Add conversions to enum

* Fix Scalar_accessor assignment.

* Update hip_vector_types.h

* stir up the underlying_type hideous mess

This fixes the HIP build issue "error: only enumeration types have underlying types".


[ROCm/clr commit: 280a8ebadf]
2019-12-10 09:40:15 +05:30
mhbliao 6643c80e8e Fix hipExtLaunchMultiKernelMultiDevice refactoring. (#1714)
- Use the correct condition for HIP VDI runtime.

[ROCm/clr commit: 209f31525f]
2019-12-06 09:49:17 -08:00