Revīziju grafs

1029 Revīzijas

Autors SHA1 Ziņojums Datums
Cole Ramos 0d15023f69 Tarball on rocm tags and MAINTAINERS guide (#402)
* Package release tarball on rocm tags and add a MAINTAINERS guide to outline release procedure

Signed-off-by: coleramos425 <colramos@amd.com>

* Apply linting feedback

Signed-off-by: coleramos425 <colramos@amd.com>

* Update links in MAINTAINERS for new branches

Signed-off-by: coleramos425 <colramos@amd.com>

* Update MAINTAINERS.md for changelog formatting

Signed-off-by: coleramos425 <colramos@amd.com>

* Update Omniperf ver checker to allow tags with rocm- prefix

Signed-off-by: coleramos425 <colramos@amd.com>

* Add step to packaging workflow to upload release tarball to release

Signed-off-by: coleramos425 <colramos@amd.com>

* Synax change for release name in packaging action

Signed-off-by: coleramos425 <colramos@amd.com>

* Update MAINTAINERS for instuctions on ROCm releases

Signed-off-by: coleramos425 <colramos@amd.com>

* Update softprops pluvin to v2 and remove release name

Removing the release name enables us to modify an existing release with the matching tag

Signed-off-by: coleramos425 <colramos@amd.com>

* Remove draft option on softprops plugin

Signed-off-by: coleramos425 <colramos@amd.com>

---------

Signed-off-by: coleramos425 <colramos@amd.com>
2024-09-25 17:21:40 +00:00
xuchen-amd c48e6e31cf Add the ability to determine GPU model from Chip ID (#423)
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary.

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Add support for MI300X_A1

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Remove MI308X identification using num CUs, and format Python using black.

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Add Read the Docs

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Add sphinx requirement

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Remove gpu_model identification using gpu_arch

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id.

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Fix Python formatting using black.

Signed-off-by: xuchen-amd <xuchen@amd.com>

---------

Signed-off-by: xuchen-amd <xuchen@amd.com>
2024-09-25 17:21:40 +00:00
Daniel Su 7ff385a105 External CI: enable CI triggers (#426)
Signed-off-by: Daniel Su <danielsu@amd.com>
2024-09-25 17:21:40 +00:00
Peter Park ecd69d109b update package manager install docs to include omniperf in PATH (#420)
Signed-off-by: Peter Jun Park <peter.park@amd.com>
2024-09-25 17:21:40 +00:00
coleramos425 bc4d386683 Fix typo and CHANGELOG modification
After meeting with the DevOps team, I've added the Unreleased keyword to new CHANGELOG section per their request

Signed-off-by: coleramos425 <colramos@amd.com>
2024-09-25 17:21:40 +00:00
coleramos425 2aee85cb06 Rollback Grafana version in Docker container to enable deprecated Angular plugin (#416)
Signed-off-by: coleramos425 <colramos@amd.com>
2024-09-25 17:21:40 +00:00
Cole Ramos 68e2cf0973 Add omniperf suffix to MOD_INSTALL_PATH in docs (#414)
If we don't add the suffix omniperf to the install path then the subsequent instruction of module load omniperf will not work

Signed-off-by: coleramos425 <colramos@amd.com>
2024-09-25 17:21:40 +00:00
Peter Jun Park 92cfd5149a mv changes to changelog.md
Signed-off-by: Peter Jun Park <peter.park@amd.com>
2024-09-25 17:21:40 +00:00
David Galiffi 3499b8571d Run Workflows on Release Branches (#409)
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2024-09-25 17:21:40 +00:00
David Galiffi ae6ed4c8a9 Update dependabot.yml target-branch
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2024-09-25 17:21:40 +00:00
David Galiffi 68e5db2dbd Remove dev and main branch from workflows. (#404)
* Remove `dev` and `main` branch from workflows.

Update links in documentation.

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

* `amd-staging` -> `amd-mainline` in docs

Signed-off-by: Peter Jun Park <peter.park@amd.com>

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Signed-off-by: Peter Jun Park <peter.park@amd.com>
Co-authored-by: Peter Jun Park <peter.park@amd.com>
2024-09-25 17:21:39 +00:00
David Galiffi 75a4b51d0d Check Python version on application launch (#393)
* Check that the minimum required Python (3.8) version is used.

Prints a descriptive error message, rather than a cryptic import
failure, if minimum Python version is not met.

Internal ticket SWDEV-477233.


* Disable the RPM mangling of shebangs.

The are changing the `#!/usr/bin/python3` to `#!/usr/libexec/platform-python`.
With this set, omniperf is always using the platform installed version
of python, which is python 3.6 on RHEL 8. Using virtual environments,
like conda, did not work.

* Fix pylint issues

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2024-09-25 17:21:39 +00:00
Jeffrey Novotny b385b1230c Amend the Fix reference links in tutorial includes files commit (#398)
Signed-off-by: Jeffrey Novotny <jnovotny@amd.com>
2024-08-09 09:46:42 -04:00
xuchen-amd 6cea66edaf Enable rocprofv1 for additional socs (#391)
* Enable rocprofv1 for gfx940/941/942.

Signed-off-by: xuchen-amd <xuchen@amd.com>

* Enable rocprofv1 for gfx940/941/942.

Enable rocprofv1 for gfx940/941/942, removing rocscope.
Jira Tracking: https://ontrack-internal.amd.com/browse/SWDEV-474924

Signed-off-by: xuchen-amd <xuchen@amd.com>

---------

Signed-off-by: xuchen-amd <xuchen@amd.com>
2024-08-09 09:46:42 -04:00
benrichard-amd 8bcd0c9b0f Fix formatting
Signed-off-by: benrichard-amd <ben.richard@amd.com>
2024-08-09 09:46:42 -04:00
benrichard-amd 870c4d4687 Fix ctests for MI100 2024-08-09 09:46:42 -04:00
Peter Park e8fc341345 Docs housekeeping post-6.2.0 (#394)
* remove leftover css

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* fix link to panel_config_template.yaml

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* add note in archived docs pointing to latest

Signed-off-by: Peter Jun Park <peter.park@amd.com>

rm repetition

---------

Signed-off-by: Peter Jun Park <peter.park@amd.com>
2024-08-09 09:46:42 -04:00
David Galiffi e176d8eec8 Prep work for branch renaming (#389)
* Add `amd-staging` and `amd-mainline` to workflow.
* Update branch names in documentation
* Change `dev` to `amd-staging` and `main` to `amd-mainline` in documentation.
* Remove references from 2.x from workflows.
* Convert the link to LICENSE to a relative path in CONTRIBUTING.

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2024-08-09 09:46:42 -04:00
benrichard-amd 5cd25714e6 Fix ctests failure on MI200
Same as MI300, the tests were looking for files no longer produced by omniperf.
2024-08-09 09:46:42 -04:00
benrichard-amd f39bf6e18f Fix test failures on MI300X
The ctests were expecting some files to be there, but after the improved
coalescing are no longer output by omniperf.
Z
2024-08-09 09:46:42 -04:00
Peter Park a0dc485ceb Docs: refactor and integrate into ROCm docs portal (#362)
* pip-compile docs/requirements.txt

Signed-off-by: Peter Jun Park <peter.park@amd.com>

Add Sphinx docs config

Signed-off-by: Peter Jun Park <peter.park@amd.com>

Add Sphinx config

Signed-off-by: Peter Jun Park <peter.park@amd.com>

Update docs build config

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* style(conf.py): Apply black formatting to docs/conf.py

Signed-off-by: Sam Wu <22262939+samjwu@users.noreply.github.com>

* Update docs requirements

Signed-off-by: Peter Jun Park <peter.park@amd.com>

Update to rocm-docs-core 1.3.0

Signed-off-by: Peter Jun Park <peter.park@amd.com>

Update docs requirements

Signed-off-by: Peter Jun Park <peter.park@amd.com>

pip-compile requirements

Signed-off-by: Peter Jun Park <peter.park@amd.com>

bump rocm-docs-core to 1.5.0

bump rocm-docs-core to 1.4.1

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* Add dependabot.yml and update CODEOWNERS

Signed-off-by: Peter Jun Park <peter.park@amd.com>

Update toc and conf

Signed-off-by: Peter Jun Park <peter.park@amd.com>

update dependabot

* Port docs to rocm-docs standard

Signed-off-by: Peter Jun Park <peter.park@amd.com>

Add toc and Diataxis cards

Signed-off-by: Peter Jun Park <peter.park@amd.com>

Add basic file structure

Signed-off-by: Peter Jun Park <peter.park@amd.com>

add glossary

Signed-off-by: Peter Jun Park <peter.park@amd.com>

add includes

Signed-off-by: Peter Jun Park <peter.park@amd.com>

Add license.rst

Signed-off-by: Peter Jun Park <peter.park@amd.com>

add compatible hw

Signed-off-by: Peter Jun Park <peter.park@amd.com>

fix spelling and license

Signed-off-by: Peter Jun Park <peter.park@amd.com>

clean up index

Signed-off-by: Peter Jun Park <peter.park@amd.com>

clean up installation guides

Signed-off-by: Peter Jun Park <peter.park@amd.com>

add basic usage (quickstart)

Signed-off-by: Peter Jun Park <peter.park@amd.com>

add ref to global options

update toc

Signed-off-by: Peter Jun Park <peter.park@amd.com>

modularize modes and global options

Signed-off-by: Peter Jun Park <peter.park@amd.com>

add profile mode

Signed-off-by: Peter Jun Park <peter.park@amd.com>

fixes

Signed-off-by: Peter Jun Park <peter.park@amd.com>

reorg and clean up

Signed-off-by: Peter Jun Park <peter.park@amd.com>

add dynamic omniperf version number in installation guide

Signed-off-by: Peter Jun Park <peter.park@amd.com>

add datatemplate

more reorg

Signed-off-by: Peter Jun Park <peter.park@amd.com>

clean up

Signed-off-by: Peter Jun Park <peter.park@amd.com>

reorg images

move profile mode

reorg

reorg

reorg more

fix formatting

fix headings

ref anchor mi2xx note

add extlinks

add extlinks

Signed-off-by: Peter Jun Park <peter.park@amd.com>

black format

fix formatting, anchors

Signed-off-by: Peter Jun Park <peter.park@amd.com>

reorg

fix words and formatting

Signed-off-by: Peter Jun Park <peter.park@amd.com>

formatting

Signed-off-by: Peter Jun Park <peter.park@amd.com>

same

reorg

format

fix formatting

fix toc

Signed-off-by: Peter Jun Park <peter.park@amd.com>

format

* impr internal linking and fix sphinx warnings

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* add spellcheck/linting from rocm-docs-core

Signed-off-by: Peter Jun Park <peter.park@amd.com>

fix rst directives

satisfy spellcheck

fix more spelling

rm unused files

fix spelling and update wordlist

* bump rocm-docs-core to 1.6.0

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* add fixes from @skyreflectedinmirrors and @lpaoletti

Signed-off-by: Peter Jun Park <peter.park@amd.com>

add references to toc

Signed-off-by: Peter Jun Park <peter.park@amd.com>

add more fixes

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* add package manager install section

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* add fixes

Signed-off-by: Peter Jun Park <peter.park@amd.com>

add metadata and fixes

Signed-off-by: Peter Jun Park <peter.park@amd.com>

add fixes

bump to 1.6.1

more fixes

fix fmt in profiling examples

Signed-off-by: Peter Jun Park <peter.park@amd.com>

add missing mem type table

Signed-off-by: Peter Jun Park <peter.park@amd.com>

fix formatting

fmt

* add custom css

Signed-off-by: Peter Jun Park <peter.park@amd.com>

fix css fs

* make images/figs click-to-expand

Signed-off-by: Peter Jun Park <peter.park@amd.com>

add missed image

update

fix link

* update documentation link in README

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* formatting fixes

Signed-off-by: Peter Jun Park <peter.park@amd.com>

more formatting

* fix heading

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* move archived docs

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* exclude archived docs from docs build

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* update archived docs workflow

Signed-off-by: Peter Jun Park <peter.park@amd.com>

move files

update archived docs workflow

Signed-off-by: Peter Jun Park <peter.park@amd.com>

fix version number

clean up workflow

workflow test

workflow test

another workflow test

* rm docs linting

Signed-off-by: Peter Jun Park <peter.park@amd.com>

* Apply cmake-format suggested changes

Signed-off-by: Sam Wu <22262939+samjwu@users.noreply.github.com>

* Apply cmake-format

Signed-off-by: Sam Wu <22262939+samjwu@users.noreply.github.com>

---------

Signed-off-by: Peter Jun Park <peter.park@amd.com>
Signed-off-by: Sam Wu <22262939+samjwu@users.noreply.github.com>
Co-authored-by: Sam Wu <22262939+samjwu@users.noreply.github.com>
2024-08-09 09:46:42 -04:00
benrichard-amd 96803e327c Fix code formatting
Signed-off-by: benrichard-amd <ben.richard@amd.com>
2024-08-09 09:46:42 -04:00
benrichard-amd c5ea1d0ff0 Set correct number of TCC channels for gfx942
Ran into rocprof error:
ROCProfiler: fatal error: input metric'TCC_EA0_RDREQ[16]' not supported on this hardware: gfx942

gfx942 has 16 channels, not 32.

Signed-off-by: benrichard-amd <ben.richard@amd.com>
2024-08-09 09:46:42 -04:00
benrichard-amd 28900f88cb Remove unused method
Signed-off-by: benrichard-amd <ben.richard@amd.com>
2024-08-09 09:46:42 -04:00
benrichard-amd 4723ecb6c9 Update to work with rocprof v1
Signed-off-by: benrichard-amd <ben.richard@amd.com>
2024-08-09 09:46:42 -04:00
benrichard-amd d77d9f1719 Save accumulate counters to SQ_ files
Omniperf analyze expects the accumulate files to be in SQ_*.csv files.

Since these files also contain PMC counters (we are trying to
fit as many counters into each file as possible to minimize runs),
we need to include these SQ_*.csv files in pmc_perf.csv.

Signed-off-by: benrichard-amd <ben.richard@amd.com>
2024-08-09 09:46:42 -04:00
benrichard-amd 241a0949e1 Remove duplicate normal counters
Interleve TCC channel counters in putput file  e.g.  TCC_HIT[0] TCC_ATOMIC[0] ... TCC_HIT[1] TCC_ATOMIC[1]

Signed-off-by: benrichard-amd <ben.richard@amd.com>
2024-08-09 09:46:42 -04:00
benrichard-amd a4fdee488b Interleve TCC channel counters
Signed-off-by: benrichard-amd <ben.richard@amd.com>
2024-08-09 09:46:42 -04:00
benrichard-amd c93fead779 Improve perfmon coalescing
Signed-off-by: benrichard-amd <ben.richard@amd.com>
2024-08-09 09:46:42 -04:00
coleramos425 4532d7df74 Explicitly define Python path in CTest test declaration
Signed-off-by: coleramos425 <colramos@amd.com>
2024-08-09 09:46:42 -04:00
coleramos425 013bf218d0 Comply to Python formatting
Signed-off-by: coleramos425 <colramos@amd.com>
2024-08-09 09:46:42 -04:00
coleramos425 3d5493a3ff Add detail to Omniperf logs
Signed-off-by: coleramos425 <colramos@amd.com>
2024-08-09 09:46:42 -04:00
coleramos425 19a229a9f2 Split rocprofv2 cmd args prior to subprocess call (#347)
Signed-off-by: coleramos425 <colramos@amd.com>
2024-08-09 09:46:42 -04:00
coleramos425 fa90752d0c Fix bug in abs diff calculation for analysis output
Signed-off-by: coleramos425 <colramos@amd.com>
2024-08-09 09:46:42 -04:00
Ben Richard 69e5c32d52 Work around crash when profiling multi-process/multi-GPU application (#376)
* Fix crash in multi-GPU scenario

Exclude -o option when invoking rocprof so that each rocprof process
writes to a different .csv file. Concatenate into a single .csv file
when finished.

Signed-off-by: benrichard-amd <ben.richard@amd.com>

* Only combine csv files when using rocprofv2

rocprofv1 does not have separate csv files

Signed-off-by: benrichard-amd <ben.richard@amd.com>

* Fix indices in combined CSV file

Use ignore_index flag to ensure there are no duplicate indices.

Signed-off-by: benrichard-amd <ben.richard@amd.com>

* Fix Dispatch_ID column and remove unnamed column

-Pandas was inserting an unnamed column (index column)
-Overwrite the Dispatch_ID column so that every row is unique, starting at 0
-Remove fixup_rocprofv2_dispatch_ids as no longer needed

Signed-off-by: benrichard-amd <ben.richard@amd.com>

* Fix code formatting

Signed-off-by: benrichard-amd <ben.richard@amd.com>

* Fix code formatting (for real this time)

Signed-off-by: benrichard-amd <ben.richard@amd.com>

---------

Signed-off-by: benrichard-amd <ben.richard@amd.com>
2024-08-09 09:46:42 -04:00
David Galiffi 98e7d0cfb3 Fixing for packaging (#386)
Should have been checking environment variables for package name
overrides.
Disabled RPM Build's AUTOREQ and AUTOPROV

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2024-07-19 22:16:59 -04:00
coleramos425 6d24a074b4 Upgrade docs package
Signed-off-by: coleramos425 <colramos@amd.com>
2024-06-04 00:33:18 +00:00
coleramos425 d100173739 Update VERSION, CHANGELOG, and citation for next release
Signed-off-by: coleramos425 <colramos@amd.com>
2024-06-04 00:03:43 +00:00
Karl W Schulz 18f96b6b23 set CMAKE_HIP_ARCHITECTURES at configure time so that build matches
desired execution environment

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2024-06-03 17:41:19 -05:00
Karl W Schulz c31ecf2a90 include ENABLE_TESTS=ON for profile tests
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2024-06-03 17:08:48 -05:00
Karl W Schulz 90ff4bf575 wrap up test compilation with an ENABLE_TESTS option
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2024-06-03 16:20:14 -05:00
Karl W Schulz 5077f9e24f update CI to build necessary vcopy binary via new additions to build
system (a la, just run make)

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2024-06-03 16:20:14 -05:00
Karl W Schulz c54d3b34ea change project language to HIP; identify tests as cmake subdir
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2024-06-03 16:20:14 -05:00
Karl W Schulz 382a83f48b adding build-collateral for test subdir
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2024-06-03 16:20:14 -05:00
coleramos425 7046ea15bd Comply to formatting
Signed-off-by: coleramos425 <colramos@amd.com>
2024-06-03 13:47:45 -05:00
coleramos425 1d19ae9483 Detection of MI308X and hardcode mclk to address bug in rocm-smi
Signed-off-by: coleramos425 <colramos@amd.com>
2024-06-03 13:47:45 -05:00
coleramos425 295b344646 Re-implementing HBM stack / XCD info for incoming product sku
Co-authored-by: Nicholas Curtis <nicholas.curtis@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com>
2024-06-03 13:47:45 -05:00
coleramos425 7c06b4d2ae Missing test case
Signed-off-by: coleramos425 <colramos@amd.com>
2024-05-31 22:02:18 +00:00
coleramos425 55a31ef880 Fixing some typos from debug
Signed-off-by: coleramos425 <colramos@amd.com>
2024-05-31 21:46:18 +00:00
coleramos425 9ff90edc10 Comply to Python formatting
Signed-off-by: coleramos425 <colramos@amd.com>
2024-05-31 16:09:58 -05:00