Commit Graph
8 Commits
Author SHA1 Message Date
Jorghi12 54bf67ff22 Fixing a HIP bug that causes DEBUG symbols to be dropped.
I've noticed that in the generated makefiles, we'd have 

if(NOT build_configuration)
    set(build_configuration Debug)
endif()

However, only definitions with all capitals are provided. 

e.g.

set(HIP_HCC_FLAGS_DEBUG -g)

This is because of lines 442 to 448. We capitalize the configuration ${config_upper}.

This PR fixes this bug.

[ROCm/hip commit: 865b015410]
2018-07-23 18:16:00 -04:00
Jorghi12 11cfca95ab Update FindHIP.cmake
Using Bool expression to handle empty case.

[ROCm/hip commit: 2b6a736318]
2018-07-18 23:02:11 -04:00
Jorghi12 6c0d113bba Update FindHIP.cmake
Adding another flag.

[ROCm/hip commit: 584e61b9f3]
2018-07-12 14:17:21 -04:00
Jorghi12 25b5ce36c9 Update FindHIP.cmake
Updating placement.

[ROCm/hip commit: 341c7c4019]
2018-07-12 13:56:08 -04:00
Jorghi12 50ccc9fc63 Update math_functions.h
CUDA also has a function named labs.

[ROCm/hip commit: 6e2b9d0547]
2018-05-26 16:22:10 -04:00
Jorghi12 c46563addc Update math_functions.cpp
CUDA also has a function named labs.

[ROCm/hip commit: ec2edb2c92]
2018-05-26 16:21:14 -04:00
Jorghi12 a82eb2dfa2 Adding double/long int signatures for abs
Adding overloads for abs that are found in cuda's math_functions.

[ROCm/hip commit: 4f6904b5c7]
2018-05-26 00:41:24 -04:00
Jorghi12 2708f3325d Adding double/long int signatures for abs
Adding overloads for abs that are found in cuda's math_functions.

[ROCm/hip commit: 4383d6c6de]
2018-05-26 00:40:14 -04:00