Commit Graph

5318 Commits

Author SHA1 Message Date
Maneesh Gupta 4bd481c762 Revert "[ci] Disable hipLaunchParm.tst for now" (#1087)
[ROCm/hip commit: 797510614e]
2019-07-11 00:24:23 +00:00
Jenkins 1ac0b0710e Merge 'master' into 'amd-master'
Change-Id: I9e1db1ea296de411edef79d9ffd0c050247feb02


[ROCm/hip commit: 682e711379]
2019-07-10 05:36:59 -04:00
Aryan Salmanpour 706d958297 [hip][samples] fix a typo in module_api/defaultDriver sample (#1210)
[ROCm/hip commit: f21601733e]
2019-07-10 03:05:19 +00:00
Aryan Salmanpour d46430b450 Fix a compilation error when templated operator<< fails if 'U' type is std::ostream. (#1209)
[ROCm/hip commit: e87b5a1e8a]
2019-07-10 03:05:04 +00:00
Maneesh Gupta 6b29461f65 [ci] Enable tests on ROCm 2.6 (#1208)
[ROCm/hip commit: b5150c8bc7]
2019-07-10 03:04:52 +00:00
foreman 0122ae9530 P4 to Git Change 1960615 by gandryey@gera-win10 on 2019/07/08 18:05:10
SWDEV-79445 - HIP generic changes and code clean-up
	- Correct elapsed time calculation. Use event start and end.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#13 edit


[ROCm/hip commit: ff4b99311a]
2019-07-08 18:14:01 -04:00
darkbuck 8368ca472d Fix even more typo. (#1204)
[ROCm/hip commit: c8b76a6a63]
2019-07-08 11:00:51 +00:00
Jatin Chaudhary c7f8ffe41e Adding bounds check before hipMemset (#1190)
* Adding bounds check in ihipMemset

* Adding ihipMemPtrGetInfo to hipMemPtrGetInfo


[ROCm/hip commit: 5ed16432f8]
2019-07-08 11:00:38 +00:00
Jenkins d05f4f97e2 Merge 'master' into 'amd-master'
Change-Id: Ibf8b204bd411b938bfc5bbaf7c26823a028e81ad


[ROCm/hip commit: 9bba58f55c]
2019-07-08 05:10:35 -04:00
Evgeny Mankov 8cd7322740 Merge pull request #1206 from emankov/master
[HIPIFY] Statistics to CSV file dumping revise

[ROCm/hip commit: b5a77a6cd8]
2019-07-07 20:58:16 +03:00
Evgeny Mankov 5e8190aa9c [HIPIFY] Statistics to CSV file dumping revise
+ Add option -print-stats-csv to dump statistics to CSV file
+ If -o-dir is specified, CSV file will be dumped there
+ Generate 1 summary file sum_stat.csv in case of multiple sources


[ROCm/hip commit: 3b40e53cff]
2019-07-07 20:55:17 +03:00
Jenkins 22b9feeed5 Merge 'master' into 'amd-master'
Change-Id: Ie33c9467b47fc5d42da71b9bfc2932c26493f9f2


[ROCm/hip commit: a31e485e05]
2019-07-04 10:56:44 -04:00
searlmc1 a82b834fc4 Fix typo ( T in Vec3_cmp = needs to be int ). (#1203)
Typo introduced here:
commit e474469213
Author: Alex Voicu <alexandru.voicu@amd.com>
Date:   Mon Jun 24 20:02:09 2019 -0500

    Put 3-wide vector types on a ketogenic diet. (#1180)

[ROCm/hip commit: a9870f0465]
2019-07-04 00:44:26 +00:00
kpyzhov e1c47e773c Change the type of hipTextureObject_t to pointer to a struct. (#1199)
This is necessary to allow Runtime to perform required texture buffer handling.

[ROCm/hip commit: b6b749f714]
2019-07-04 00:44:06 +00:00
Jannik caf1f4fbb4 Fix call to cuda library (#1197)
* Remove flags parameter from hipOccupancyMaxPotentialBlockSize

This commit makes the hipOccupancyMaxPotentialBlockSize method consistent with hcc path and the CUDA API.


[ROCm/hip commit: 2a1b0ba27d]
2019-07-04 00:43:22 +00:00
Aryan Salmanpour a2655fd90a [hip] Move _criticalData of ihipStream_t class to private section and use criticalData() to access it (#1177)
[ROCm/hip commit: 999f45fc11]
2019-07-04 00:42:19 +00:00
Jenkins f2b8f662b9 Merge 'master' into 'amd-master'
Change-Id: I0230d43dca968ed6a8f7695064b98a3de703143d


[ROCm/hip commit: 1c20b5ba1e]
2019-07-03 19:12:35 -04:00
foreman e48868e55b P4 to Git Change 1940447 by cpaquot@cpaquot-ocl-lc-lnx on 2019/07/03 14:44:49
SWDEV-194872 - [HIP] CUDA and HCC sync after a DeviceToHost async copy.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#60 edit


[ROCm/hip commit: 4a26d801fb]
2019-07-03 14:51:15 -04:00
Maneesh Gupta 01ee58e0c7 Fix sample module_api_global for hip-clang (#1201)
module_api_global relies on a HCC only feature which allows host code
to write to device variables. This feature does not exist in CUDA
or hip-clang, which causes the sample not working in CUDA or hip-clang.

This patch fixes the sample by using standard features of CUDA and
hip-clang. The fixed sample works in HCC, CUDA and hip-clang.

[ROCm/hip commit: 502a734ebf]
2019-07-03 08:52:19 +00:00
Yaxun (Sam) Liu 4d2f0de651 Add __hip_pinned_shadow__ for hip-clang and fix texture reference tests (#1200)
[ROCm/hip commit: 85c3b903df]
2019-07-03 08:51:59 +00:00
Maneesh Gupta b7fe02394f Added missing NULL checks and corrected API return values (#1188)
* Added missing NULL checks and corrected API return values as per validation

* Added missing NULL checks


[ROCm/hip commit: d57946275b]
2019-07-03 08:51:39 +00:00
Jatin Chaudhary 9484eb6831 Adding new unroll example (#1187)
[ROCm/hip commit: 3152af0175]
2019-07-03 08:51:19 +00:00
Yaxun Sam Liu afa71d710c Fix sample module_api_global for hip-clang
module_api_global relies on a HCC only feature which allows host code
to write to device variables. This feature does not exist in CUDA
or hip-clang, which causes the sample not working in CUDA or hip-clang.

This patch fixes the sample by using standard features of CUDA and
hip-clang. The fixed sample works in HCC, CUDA and hip-clang.


[ROCm/hip commit: 60e1733afe]
2019-07-02 16:36:53 -04:00
Jenkins 2375f318c9 Merge 'master' into 'amd-master'
Change-Id: I87a09730ec605e2bf13cde52ab5afb79eaeaaf64


[ROCm/hip commit: 03d20c3e13]
2019-07-01 02:12:30 -07:00
Jenkins fd8df5c83c Merge 'master' into 'amd-master'
Change-Id: Ied8c47046b006252096e0381960b62f5aa95d6d3


[ROCm/hip commit: a25067f240]
2019-06-29 21:09:16 -07:00
eshcherb 9a1e96321e hip_api_name fixed to be inline to suppress not used warning (#1194)
[ROCm/hip commit: e72893a771]
2019-06-30 03:38:43 +00:00
Evgeny Mankov 8e8470a273 Merge pull request #1195 from emankov/master
[HIPIFY] Clang 7.1.0 support

[ROCm/hip commit: 9180537ae0]
2019-06-29 17:25:07 +03:00
Evgeny Mankov eeb66048f3 [HIPIFY] Clang 7.1.0 support
+ Provide patch for clang's bug 38811
+ Update Readme.md accordingly


[ROCm/hip commit: 36cda83066]
2019-06-29 17:23:18 +03:00
foreman d8324e6ed8 P4 to Git Change 1917740 by cpaquot@cpaquot-ocl-lc-lnx on 2019/06/28 12:03:07
SWDEV-193938 - [HIP] RCCL test fails
	Set default stream to null-stream
	In hipStreamWaitEvent if event_ is null, get the last queued command instead.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#12 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.hpp#4 edit


[ROCm/hip commit: e9f58233e1]
2019-06-28 12:09:09 -04:00
foreman e07ddab2d9 P4 to Git Change 1917620 by yaxunl@yaxunl-lc10 on 2019/06/28 07:57:46
SWDEV-145570 - Fix device name mismatch.

	Not only gfx906 can have device name with +xnack etc.
	Other devices e.g. gfx900 could have that too.
	Make the previous fix more generic.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#33 edit


[ROCm/hip commit: 97a079826e]
2019-06-28 08:06:23 -04:00
Anusha Godavarthy Surya 7eedb4d047 Added missing NULL checks
[ROCm/hip commit: 7a4c3f61c8]
2019-06-27 20:19:30 +05:30
Anusha Godavarthy Surya f1d6b56fc4 Added missing NULL checks and corrected API return values as per validation
[ROCm/hip commit: 3d5f6be1c7]
2019-06-27 00:19:05 +05:30
Maneesh Gupta c1b0d625d7 Add dependency on amd_comgr in hip-config-*.cmake.in (#1179)
Change-Id: Ia12a40cd5c89920a50ec714ceae99f60259a6f66

[ROCm/hip commit: 573978625b]
2019-06-26 15:18:11 +05:30
wkwchau 3c963cc0e1 Fixed bug in hipOccupancyMaxPotentialBlockSize for the SGPRs limitation of gfx8 devices (#1176)
[ROCm/hip commit: 47f16264ed]
2019-06-26 15:18:00 +05:30
Maneesh Gupta 7874e84d3d [packaging] Add dependency on comgr to hip_hcc package (#1182)
[ROCm/hip commit: d4a92519eb]
2019-06-25 06:32:46 +05:30
Aaron Enye Shi 52614c2729 Fix dlpi_name info empty when using GCC on ub18 (#1181)
This fixes a bug where GCC++ on Ubuntu 18.04 creates failing executables compared to GCC++ on 16.04 and clang++. While creating function names on Ubuntu 18.04, dl_phdr_info seems to provide a non-zero value for dlpi_addr on initial iteration, and an empty string in dlpi_name. This is causing failure when linking with g++, since the empty string prevents the kernel function from being loaded. Clang++ and GCC on UB16 provide a zero value for dlpi_addr. To fix this, we need to verify both addr and name exists, so that /proc/self/exe can be properly loaded.

[ROCm/hip commit: 77bef86949]
2019-06-25 06:32:29 +05:30
Alex Voicu e474469213 Put 3-wide vector types on a ketogenic diet. (#1180)
* Put 3-wide vector types on a ketogenic diet.

* Remove needless include.

* Do not be narrow-minded.

* Do not be narrow-minded.

* Put the C people on a diet too.


[ROCm/hip commit: 67abac1365]
2019-06-25 06:32:09 +05:30
Jenkins d6f5dc8204 Merge 'master' into 'amd-master'
Change-Id: I81a373b1a9c149e96ede6c72a6c24d99171f8821


[ROCm/hip commit: 7ac69da23e]
2019-06-23 11:47:24 -04:00
foreman 9176cd6664 P4 to Git Change 1879857 by gandryey@gera-win10 on 2019/06/20 18:06:07
SWDEV-184710 - Support hipLaunchCooperativeKernelMultiDevice()
	- Clean-up the loop for the launch on each device
	- Add hipExtLaunchMultiKernelMultiDevice()

	 http://ocltc.amd.com/reviews/r/17573/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#29 edit


[ROCm/hip commit: fd634d58f1]
2019-06-20 18:13:20 -04:00
Evgeny Mankov fc56c3a067 Merge pull request #1175 from emankov/LLVM
[HIPIFY] Fix multiple input files support

[ROCm/hip commit: 00f25833a9]
2019-06-20 18:08:46 +03:00
Evgeny Mankov 7cb92aeb9a [HIPIFY] Fix multiple input files support
Reported in #1168


[ROCm/hip commit: db6571ae75]
2019-06-20 18:05:57 +03:00
Aryan Salmanpour 45fa752888 [hip] implement the hipExtLaunchMultiKernelMultiDevice API (#1165)
* [hip] implement the hipExtLaunchMultiKernelMultiDevice API

* add a guard to check the HCC version for acquire_locked_hsa_queue() API which was introdued in HCC for ROCm 2.5

* modified code based on the requested changes

* changes to lock all streams before launching kernels for each device and unlock them after the dispatches

* check each stream to be valid before starting to lock all the streams


[ROCm/hip commit: 96dc74897d]
2019-06-20 05:59:05 +05:30
wkwchau 40bd111519 Implement the hipOccupancyMaxPotentialBlockSize function (#1162)
* Implement the hipOccupancyMaxPotentialBlockSize function

* Replaced hipGetDeviceProperties() call by ihipGetDeviceProperties() in ihipOccupancyMaxPotentialBlockSize()

* Add test for hipOccupancyMaxPotentialBlockSize in Module API

* Added extern declaration for ihipGetDeviceProperties() to be accessed inside ihipOccupancyMaxPotentialBlockSize()

* fixed hipOccupancyMaxPotentialBlockSize test build issue

* Fix hipOccupancyMaxPotentialBlockSize dtest

* Add BUILD_CMD in hipOccupancyMaxPotentialBlockSize dtest

* Revert "Add BUILD_CMD in hipOccupancyMaxPotentialBlockSize dtest"

This reverts commit 0480ff56f1441fc515d2c26ce33783e303423938.

* Disable hipOccupancyMaxPotentialBlockSize dtest on NVCC

* move extern declaration of ihipGetDeviceProperties to hip_module.cpp

* Update the limiation of 32 wavefronts per CU and 800/512 SGPRs for VI/pre-VI chips to calculate the occupancy


[ROCm/hip commit: d492f1fd6b]
2019-06-20 05:58:29 +05:30
Maneesh Gupta 57e0c02e28 Merge pull request #1164 from gargrahul/cleanup_module_api_samples
Add cleanup code in module api samples

[ROCm/hip commit: ba323cdef1]
2019-06-20 05:57:46 +05:30
Maneesh Gupta 2238e6671e Merge pull request #1173 from icarus-sparry/icarus-sparry-patch-1
Make hip_prof_gen.py compatible with both python 2 and 3

[ROCm/hip commit: a8f8c8994d]
2019-06-19 13:37:02 +05:30
Maneesh Gupta 2a41dc2a64 Merge pull request #1171 from mhbliao/hliao/master/hipcc
[hipcc] Revise include path calculation.

[ROCm/hip commit: 6b83b6bfca]
2019-06-19 13:36:51 +05:30
Maneesh Gupta cd72288515 Merge pull request #1167 from eshcherb/hip_prof_refactoring_190611
prof layer includes refactoring

[ROCm/hip commit: fc074d96d0]
2019-06-19 13:36:33 +05:30
Maneesh Gupta f16a25dd64 Merge pull request #1163 from gargrahul/fix_module_api_kernarg_sample
Fix sample to use kernelargs for launch

[ROCm/hip commit: 0ad0d06930]
2019-06-19 13:36:17 +05:30
Jenkins d3a71b8207 Merge 'master' into 'amd-master'
Change-Id: I640c6dfa3523f006ad0c2e05b325017609192484


[ROCm/hip commit: b3b6ff50cb]
2019-06-18 20:54:26 -04:00
Icarus Sparry b5a26215cc Make hip_prof_gen.py compatible with both python 2 and 3
Convert python 2 constructs to python 3 compatible ones.

In python 3, print is a function, so use write methods (which are always functions) instead.

In python3 keys() returns an iterator, rather than a list. This means you can't change the data structure that is being iterated over. Converting this iterator into a list mimics the python 2 behavior.

[ROCm/hip commit: cc374b2bd3]
2019-06-17 12:03:36 -07:00