Commit Graph

23 Commits

Author SHA1 Message Date
foreman 4ab8c60043 P4 to Git Change 2047424 by lmoriche@lmoriche_opencl_dev2 on 2019/12/17 20:13:01
SWDEV-216705 - [hipclang-vdi-rocm][FBA-80]Test crash when all GPUs are hidden by ROCR_VISIBLE_DEVICES

	Return an error instead of dereferencing a null pointer. This should address the issue described
	in the ticket, but more places need fixing in the runtime to avoid crashes for corner cases.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#26 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#23 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#92 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#58 edit


[ROCm/clr commit: 8d32b426dd]
2019-12-17 20:18:36 -05:00
foreman 8ede471148 P4 to Git Change 2029039 by kjayapra@0_HIPWS_LNX1_ROCM on 2019/11/12 12:52:46
SWDEV-210844 - Implementing hipExtGetLinkTypeAndHopCount

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#22 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.hpp#344 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.hpp#47 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.cpp#141 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.hpp#44 edit


[ROCm/clr commit: 6efa1d4655]
2019-11-12 12:55:17 -05:00
foreman 9121a1eef0 P4 to Git Change 2024544 by cpaquot@cpaquot-ocl-lc-lnx on 2019/11/04 16:35:14
SWDEV-145570 - [HIP] Fetched properties from current device and not default 0 one.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#21 edit


[ROCm/clr commit: cbbe0e78cf]
2019-11-04 16:42:31 -05:00
foreman da45649b24 P4 to Git Change 2021977 by kjayapra@1_HIPWS_LNX1_PAL on 2019/10/30 13:27:19
SWDEV-209747 - Improve HIP Error codes and debug messages.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#24 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#25 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#20 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#18 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#80 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#45 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_peer.cpp#8 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#47 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_profile.cpp#4 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_surface.cpp#6 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#25 edit


[ROCm/clr commit: 234e21e08c]
2019-10-30 13:37:03 -04:00
foreman 9094950684 P4 to Git Change 2009236 by eshcherb@evgeny-hip on 2019/10/07 11:49:55
SWDEV-197287 - HIP tracing layer instrumentation

	hip_prof_str.h - generated header; as a next step a genrator will be integrated in HIP makefile (similar to HIP-HCC)
	prof_protocol.h - temporarily included in HIP sources. Provided by roctracer-proto package. HIP-HCC CMake has parameter to set a path to the header.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/build/Makefile.hip#23 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#23 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#24 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#19 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_error.cpp#3 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#17 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_intercept.cpp#1 add
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#44 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#74 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#43 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_peer.cpp#7 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#44 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_prof_api.h#1 add
... //depot/stg/opencl/drivers/opencl/api/hip/hip_profile.cpp#3 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#25 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_surface.cpp#5 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#21 edit
... //depot/stg/opencl/drivers/opencl/api/hip/prof_protocol.h#1 add
... //depot/stg/opencl/drivers/opencl/hip_prof_gen.py#1 add
... //depot/stg/opencl/drivers/opencl/make/hip.git/include/hip/hcc_detail/hip_prof_str.h#2 delete


[ROCm/clr commit: f8d01cc14e]
2019-10-07 11:55:30 -04:00
foreman aa7ebf73f0 P4 to Git Change 1998982 by cpaquot@cpaquot-ocl-lc-lnx on 2019/09/16 17:49:10
SWDEV-145570 - [HIP] Fix regression from new headers.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#23 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#18 edit


[ROCm/clr commit: 72000beb84]
2019-09-16 17:58:06 -04:00
foreman 9a8f0c273a P4 to Git Change 1979479 by cpaquot@cpaquot-ocl-lc-lnx on 2019/08/07 11:25:59
SWDEV-198424 - [HIP] Implemented missing fields for hipGetDeviceAttribute.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#21 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#17 edit


[ROCm/clr commit: 2f761998c3]
2019-08-07 11:30:59 -04:00
foreman 072d96516e P4 to Git Change 1815146 by cpaquot@cpaquot-ocl-lc-lnx on 2019/06/12 13:43:33
SWDEV-192333 - [HIP] Implemented hipExtMallocWithFlags and hipExtGetLinkTypeAndHopCount

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#16 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#16 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#18 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#59 edit


[ROCm/clr commit: 752a4e57b6]
2019-06-13 12:47:17 -04:00
foreman 76b1d242d2 P4 to Git Change 1809277 by gandryey@gera-win10 on 2019/06/11 17:34:13
SWDEV-180872 - Runtime support changes for Cooperative Group Features
	- Initial implementation of the core functionality. Disabled by default. Use GPU_ENABLE_COOP_GROUPS=1 to enable the feature.
	- Runtime uses device queue for cooperative executions with a synchronization on the launched queue.
	- The current implementation is pure runtime change and it can work if only one app uses this feature. No ROCr/KFD support was added or tested
	- Only inline assembler was tested

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#20 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#15 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#15 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#17 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#28 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#32 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.hpp#338 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#606 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.hpp#171 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palblit.cpp#31 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palblit.hpp#9 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#142 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.hpp#39 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palschedcl.cpp#6 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#135 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.hpp#61 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocblit.cpp#32 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocblit.hpp#12 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.cpp#127 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.hpp#37 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocschedcl.cpp#3 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocvirtual.cpp#75 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocvirtual.hpp#23 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.cpp#94 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.hpp#92 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/flags.hpp#311 edit


[ROCm/clr commit: 623320cd93]
2019-06-12 10:00:38 -04:00
foreman 2d2e37205f P4 to Git Change 1777158 by cpaquot@cpaquot-ocl-lc-lnx on 2019/05/01 17:12:01
SWDEV-188219 - [HIP] Add hipStreamCreateWithPriority. NOP right now.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#14 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#13 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#14 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#17 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/commandqueue.hpp#21 edit


[ROCm/clr commit: ef45e9ab42]
2019-05-01 18:43:47 -04:00
foreman da0c2f7deb P4 to Git Change 1738965 by cpaquot@cpaquot-ocl-lc-lnx on 2019/02/01 13:17:10
SWDEV-145570 - [HIP] Handle multi device setup

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#13 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#21 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#21 edit


[ROCm/clr commit: d7f1cd1fcf]
2019-02-01 13:43:50 -05:00
foreman 4078a0651e P4 to Git Change 1594075 by skudchad@skudchad-lnx on 2018/08/15 14:00:33
SWDEV-145570 - [HIP] Fix some test failures

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#12 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#14 edit


[ROCm/clr commit: ad4ae89d13]
2018-08-15 14:13:08 -04:00
foreman c1bb44fa73 P4 to Git Change 1593706 by skudchad@skudchad_test2_win_opencl on 2018/08/14 18:44:29
SWDEV-145570 - [HIP] Implement hipError*

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/15619/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#13 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#14 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#11 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_error.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#5 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#13 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#41 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#17 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_peer.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#17 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_profile.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#12 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_surface.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#9 edit


[ROCm/clr commit: 2ec2cfd3c1]
2018-08-14 18:54:13 -04:00
foreman d44b3dc620 P4 to Git Change 1553709 by cpaquot@cpaquot-ocl-lc-lnx on 2018/05/11 11:24:30
SWDEV-145570 - [HIP] Make streamSet global and protect it
	By default from the spec, streamSet should be global and not per thread.
	There is a flag to make it per thread but we don't handle this yet. We
	would just add another variable that will be thread local and use it instead.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#12 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#10 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#11 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#8 edit


[ROCm/clr commit: c6b9701abb]
2018-05-11 11:34:01 -04:00
foreman 46dc10bdd8 P4 to Git Change 1550526 by cpaquot@cpaquot-ocl-lc-lnx on 2018/05/04 15:00:44
SWDEV-145570 - [HIP] Missing HIP_INIT_API macro in hipDeviceSynchronize.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#9 edit


[ROCm/clr commit: 05b48c7450]
2018-05-04 15:12:48 -04:00
foreman 8bd2c78f00 P4 to Git Change 1548560 by skudchad@skudchad_rocm on 2018/05/01 18:53:54
SWDEV-145570 - [HIP] - Fix hipDeviceSynchronize.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#8 edit


[ROCm/clr commit: 6bd6d3d4c1]
2018-05-01 19:01:10 -04:00
foreman eea99696ec P4 to Git Change 1548476 by cpaquot@cpaquot-ocl-lc-lnx on 2018/05/01 15:50:51
SWDEV-145570 - [HIP]
	Added support for null stream avoiding creating/destroying dummy streams.
	Added basic event class for hipEvent* support.
	Refactored some common functionality: No more direct access to g_context.
	Support hipStreamSynchronize(0).

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#9 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#7 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#3 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.hpp#1 add
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#8 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#15 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#8 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#9 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#4 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#7 edit


[ROCm/clr commit: c874bb2b90]
2018-05-01 18:10:09 -04:00
foreman 7b013d2b37 P4 to Git Change 1544858 by skudchad@skudchad_rocm on 2018/04/22 21:07:25
SWDEV-144570 - [HIP] - Fix a few APIs and typos.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#6 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#6 edit


[ROCm/clr commit: db522a2fbc]
2018-04-22 21:17:27 -04:00
foreman 430ace7293 P4 to Git Change 1541938 by cpaquot@cpaquot-ocl-lc-lnx on 2018/04/16 18:27:17
SWDEV-145570 - [HIP] Set/GetDevice and Create/DestroyTextureObject
	Implemented Set/GetDevice relying on g_context (current context)
	Implemented create linear/2D texture object function
	Implemented hipDestroyTextureObject

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#5 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#4 edit


[ROCm/clr commit: 17d153a162]
2018-04-16 18:37:17 -04:00
foreman 78f2644004 P4 to Git Change 1536698 by skudchad@skudchad_test2_win_opencl on 2018/04/04 13:18:19
SWDEV-145570 - [HIP] -  Add HIP Memory api skeletons

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/14555/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#4 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#6 edit


[ROCm/clr commit: 1a5f98c021]
2018-04-04 13:24:15 -04:00
foreman ebec35b469 P4 to Git Change 1531138 by cpaquot@cpaquot-ocl-lc-lnx on 2018/03/23 00:10:40
SWDEV-145570 - [HIP] Module
	Check for correct device id in hipDeviceGetAttribute
	Implement hipModuleLoad
	Handle kernelParams in hipModuleLaunchKernel

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#8 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#3 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#5 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#3 edit


[ROCm/clr commit: c531507708]
2018-03-23 00:19:22 -04:00
foreman 27f5bd6d76 P4 to Git Change 1527320 by cpaquot@cpaquot-ocl-lc-lnx on 2018/03/14 18:54:10
SWDEV-145570 - Remove all g_context from runtime device implementation

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#6 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#3 edit


[ROCm/clr commit: 41c27a9e24]
2018-03-14 19:05:10 -04:00
foreman fcccf63e90 P4 to Git Change 1526407 by cpaquot@cpaquot-ocl-lc-lnx on 2018/03/13 12:24:51
SWDEV-145570 - [HIP] Separate device runtime and driver APIs

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#5 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#1 add


[ROCm/clr commit: df8dfbd060]
2018-03-13 12:33:01 -04:00