Commit Graph

14761 Commits

Author SHA1 Message Date
Joseph Macaranas 377c2d17ae Correcting details on source of truth 2025-07-16 11:16:29 -04:00
Pratik Basyal ce3d76674a Architecture data support and diagrams added (#814)
* Architeture data support and diagrams added

* Architecture image added

* CDNA4 Image updated

* Review feedback incorporated

* CDNA 4 partition mode added

* Fei review feedback incorporated

[ROCm/rocprofiler-compute commit: 8099fd352e]
2025-07-16 10:40:11 -04:00
Pratik Basyal 8099fd352e Architecture data support and diagrams added (#814)
* Architeture data support and diagrams added

* Architecture image added

* CDNA4 Image updated

* Review feedback incorporated

* CDNA 4 partition mode added

* Fei review feedback incorporated
2025-07-16 10:40:11 -04:00
Bhardwaj, Gopesh 831f2d16d6 Disabling this test as its not designed for Navi (#96)
* Disabling this test as its not designed for Navi

* Update tests-v2/featuretests/tracer/tracer_gtest.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

[ROCm/rocprofiler commit: 4a3d1848a6]
2025-07-16 11:22:56 +05:30
Bhardwaj, Gopesh 4a3d1848a6 Disabling this test as its not designed for Navi (#96)
* Disabling this test as its not designed for Navi

* Update tests-v2/featuretests/tracer/tracer_gtest.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-07-16 11:22:56 +05:30
Honglei Huang 6c87f5b5ce rocr/driver: add memory residency management interface in driver
This commit introduces MakeMemoryResident and MakeMemoryUnresident
functions to KfdDriver and XdnaDriver classes.

- Added implementations in amd_kfd_driver.cpp
- Added stubs in amd_xdna_driver.cpp returning HSA_STATUS_ERROR
- Updated header files amd_kfd_driver.h and amd_xdna_driver.h
- Removed MakeKfdMemoryResident/Unresident from amd_memory_region.cpp

Signed-off-by: Honglei Huang <Honglei1.Huang@amd.com>
2025-07-16 13:15:45 +08:00
Honglei Huang ab6bda7e96 rocr/driver: add memory registration and deregistration into driver
This commit completes the memory register/deregister interface change.

Removed static RegisterMemory and DeregisterMemory from MemoryRegion class

- Added pure virtual methods to base Driver interface in driver class
- Added implementation in KFD driver
- Modified MemoryRegion Lock and Unlock to use driver interface

Signed-off-by: Honglei Huang <Honglei1.Huang@amd.com>
2025-07-16 13:15:45 +08:00
Honglei Huang 6c390e32cc rocr/driver: add AvailableMemory API to driver
This commit introduces a new AvailableMemory API to the KfdDriver and
 XdnaDriver classes.

- Implemented AvailableMemory in KfdDriver to return the available memory size
  using hsaKmtAvailableMemory.
- Added a stub implementation of AvailableMemory in XdnaDriver that returns an error.
- Updated the GpuAgent class to use the new AvailableMemory API instead of
  directly calling hsaKmtAvailableMemory.

Signed-off-by: Honglei Huang <Honglei1.Huang@amd.com>
2025-07-16 13:15:45 +08:00
Honglei Huang 9c18618847 rocr: add const version of driver() method to Agent class
This change adds a const-qualified version of the driver() method to the Agent
class, allowing const Agent objects to access their associated driver without
modifying the object's state.

Signed-off-by: Honglei Huang <Honglei1.Huang@amd.com>
2025-07-16 13:15:45 +08:00
Honglei Huang 8216787d4c rocr: use driver interface for scratch memory deallocation
Replace direct hsaKmtFreeMemory call with driver's FreeMemory interface
in GpuAgent::ReleaseResources(). This change improves code abstraction
by handling memory deallocation through the unified driver interface.

Signed-off-by: Honglei Huang <Honglei1.Huang@amd.com>
2025-07-16 13:15:45 +08:00
Honglei Huang da8dd9e1e3 rocr/driver: add scratch memory allocation into driver interface
Add AllocateScratchMemory interface to Driver base class and implement it
in both KFD and XDNA drivers. This change encapsulates the low-level
scratch memory allocation details within driver implementations, making
the code more maintainable and the interface cleaner.

The main changes include:
- Add AllocateScratchMemory virtual method to Driver interface
- Implement the interface in KfdDriver with existing allocation logic
- Add stub implementation in XdnaDriver
- Update GpuAgent to use the new interface instead of direct KMT calls

Signed-off-by: Honglei Huang <Honglei1.Huang@amd.com>
2025-07-16 13:15:45 +08:00
David Galiffi 5a767cf272 Remove an undefined submodule from the GOTCHA submodule (#285)
A recursive submodule update, `git submodule uppdate --recursive
--init`,
would fail due to an improperly defined and empty submodule in GOTCHA.

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-systems commit: e9b09b6ade]
2025-07-15 21:32:43 -04:00
David Galiffi e9b09b6ade Remove an undefined submodule from the GOTCHA submodule (#285)
A recursive submodule update, `git submodule uppdate --recursive
--init`,
would fail due to an improperly defined and empty submodule in GOTCHA.

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2025-07-15 21:32:43 -04:00
vedithal-amd 9a442748ea Fix docker testing instructions (#813)
[ROCm/rocprofiler-compute commit: ccb34e8a91]
2025-07-15 17:06:22 -04:00
vedithal-amd ccb34e8a91 Fix docker testing instructions (#813) 2025-07-15 17:06:22 -04:00
Pryor, Adam 816f7a850f [SWDEV-379269] Add all gpus as default to dmon (#211)
Change-Id: Idb17e9018c39479830a4366f2002d02725d66873

Signed-off-by: adapryor <Adam.pryor@amd.com>
2025-07-15 16:03:28 -05:00
Pryor, Adam 010ac416b1 [SWDEV-379269] Add all gpus as default to dmon (#211)
Change-Id: Idb17e9018c39479830a4366f2002d02725d66873

Signed-off-by: adapryor <Adam.pryor@amd.com>

[ROCm/rdc commit: 816f7a850f]
2025-07-15 16:03:28 -05:00
Yiannis Papadopoulos bfe76cf94e rocr: Using MemoryRegion::GetInfo(HSA_REGION_INFO_ALLOC_MAX_SIZE) for HSA_AMD_MEMORY_POOL_INFO_ALLOC_MAX_SIZE 2025-07-15 14:22:56 -05:00
Joseph Macaranas 7af4bd7ddf Add roccv to scope 2025-07-15 15:20:42 -04:00
cfallows-amd 10ead63735 Update workflows for building (#812)
* Update workflows for building testing in pipeline: rhel8 now tests rhel8 and 9, and for both rhel and ubuntu files we are using the same image as rocprofiler-systems which is consistently updated on docker hub.

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

[ROCm/rocprofiler-compute commit: 10c696521d]
2025-07-15 15:12:21 -04:00
cfallows-amd 10c696521d Update workflows for building (#812)
* Update workflows for building testing in pipeline: rhel8 now tests rhel8 and 9, and for both rhel and ubuntu files we are using the same image as rocprofiler-systems which is consistently updated on docker hub.

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-07-15 15:12:21 -04:00
Joseph Macaranas 1b18684171 Add aqlprofile to readme 2025-07-15 14:53:47 -04:00
Wang, Huanran f96cafaa60 [rocprofv3] Sanitize string of command in rocpd (#467)
Sanitize string of command in rocpd

Co-authored-by: Huanran Wang <huanrwan@amd.com>

[ROCm/rocprofiler-sdk commit: 5c45c77ec7]
2025-07-15 13:01:14 -04:00
Wang, Huanran 5c45c77ec7 [rocprofv3] Sanitize string of command in rocpd (#467)
Sanitize string of command in rocpd

Co-authored-by: Huanran Wang <huanrwan@amd.com>
2025-07-15 13:01:14 -04:00
cfallows-amd 930b32e2cb Fix roofline block print during CLI output (#811)
Fix roofline panel in CLI analyze stage when using --block option. Improve roofline CLI output checks and logs.

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

[ROCm/rocprofiler-compute commit: 1d834f4190]
2025-07-15 12:42:27 -04:00
cfallows-amd 1d834f4190 Fix roofline block print during CLI output (#811)
Fix roofline panel in CLI analyze stage when using --block option. Improve roofline CLI output checks and logs.

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-07-15 12:42:27 -04:00
amd-jmacaran c3f8f57c80 Reset state of repo with updated README 2025-07-15 12:29:35 -04:00
Tumakaev, Aleksei b439b4e719 [rocprofv3] Fix incorrect position of Allocation_Size header in memory_allocation csv (#510)
Fix incorrect position of Allocation_Size header in memory_allocation csv

[ROCm/rocprofiler-sdk commit: 4af73d078f]
2025-07-15 18:15:22 +02:00
Tumakaev, Aleksei 4af73d078f [rocprofv3] Fix incorrect position of Allocation_Size header in memory_allocation csv (#510)
Fix incorrect position of Allocation_Size header in memory_allocation csv
2025-07-15 18:15:22 +02:00
xuchen-amd a91363744c Update TUI docs. (#796)
[ROCm/rocprofiler-compute commit: bfb2dc0795]
2025-07-15 11:13:24 -04:00
xuchen-amd bfb2dc0795 Update TUI docs. (#796) 2025-07-15 11:13:24 -04:00
Fei Zheng 1050e0201c Update peak flops for MI350 (#810)
[ROCm/rocprofiler-compute commit: e1da9355c2]
2025-07-15 08:46:13 -06:00
Fei Zheng e1da9355c2 Update peak flops for MI350 (#810) 2025-07-15 08:46:13 -06:00
xuchen-amd 65673617e0 Remove rocm-smi for ROCm 7.1 (#809)
[ROCm/rocprofiler-compute commit: b4b50502e3]
2025-07-15 10:28:53 -04:00
xuchen-amd b4b50502e3 Remove rocm-smi for ROCm 7.1 (#809) 2025-07-15 10:28:53 -04:00
Sajina PK d4da72bf2d Update gotcha submodule from timemory (#277)
* Update gotcha submodule from timemory

* Fix build failure and add copilot suggestions

* Fix formatting errors

[ROCm/rocprofiler-systems commit: d26486ad83]
2025-07-14 21:12:10 -04:00
Sajina PK d26486ad83 Update gotcha submodule from timemory (#277)
* Update gotcha submodule from timemory

* Fix build failure and add copilot suggestions

* Fix formatting errors
2025-07-14 21:12:10 -04:00
darren-amd a5ca94ab9c Fix ROCtx event ranges in trace output (#278)
* Fix marker api traces

* Remove space

* Formatting change

* Small change

* Update Changelog

* Add period to changelog

* Update source/lib/rocprof-sys/library/rocprofiler-sdk.cpp

Co-authored-by: David Galiffi <David.Galiffi@amd.com>

* Fix roctx tests

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-systems commit: c996c23a13]
2025-07-14 19:31:14 -04:00
darren-amd c996c23a13 Fix ROCtx event ranges in trace output (#278)
* Fix marker api traces

* Remove space

* Formatting change

* Small change

* Update Changelog

* Add period to changelog

* Update source/lib/rocprof-sys/library/rocprofiler-sdk.cpp

Co-authored-by: David Galiffi <David.Galiffi@amd.com>

* Fix roctx tests

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-07-14 19:31:14 -04:00
Sajina PK 1892bdef83 Make CMakeFile fixes to align with rocDecode and rocJpeg changes (#281)
[ROCm/rocprofiler-systems commit: be06384250]
2025-07-14 19:23:19 -04:00
Sajina PK be06384250 Make CMakeFile fixes to align with rocDecode and rocJpeg changes (#281) 2025-07-14 19:23:19 -04:00
David Galiffi 20434af022 Adding sqlite-dev to our ci docker images (#280)
[ROCm/rocprofiler-systems commit: 86f025e5fd]
2025-07-14 17:37:47 -04:00
David Galiffi 86f025e5fd Adding sqlite-dev to our ci docker images (#280) 2025-07-14 17:37:47 -04:00
Fei Zheng e0ba0631b0 Update cli doc description (#804)
[ROCm/rocprofiler-compute commit: 5b8d12fde2]
2025-07-14 13:05:01 -06:00
Fei Zheng 5b8d12fde2 Update cli doc description (#804) 2025-07-14 13:05:01 -06:00
Fei Zheng 769caa3124 Update PC sampling doc (#798)
[ROCm/rocprofiler-compute commit: 78c1898ba0]
2025-07-14 13:04:14 -06:00
Fei Zheng 78c1898ba0 Update PC sampling doc (#798) 2025-07-14 13:04:14 -06:00
zichguan-amd 7946ddb647 rocr: check _SC_LEVEL1_DCACHE_LINESIZE before use
Support musl
Fixes ROCm/ROCR-Runtime#318

Signed-off-by: zichguan-amd <zichuan.guan@amd.com>
2025-07-14 14:44:31 -04:00
xuchen-amd 06b24cbfe1 rocm-smi deprecation warning (#806)
[ROCm/rocprofiler-compute commit: a3dc98e251]
2025-07-14 13:35:47 -04:00
xuchen-amd a3dc98e251 rocm-smi deprecation warning (#806) 2025-07-14 13:35:47 -04:00