İşleme Grafiği

4911 İşleme

Yazar SHA1 Mesaj Tarih
Tao Sang 1d22c5b925 Merge "Generating hiprtc lib with hcc+hip-clang" into amd-master-next 2020-02-25 14:46:24 -05:00
Saleel Kudchadker d5938efcce Merge "Use the context variant of getNullStream" into amd-master-next 2020-02-25 13:03:22 -05:00
Saleel Kudchadker 1ccaea7ca8 Use the context variant of getNullStream
Do not create a new queue to call finish in hipFree if none was
created earlier elsewhere.
Change-Id: I87bb191e6b186ddbe607ab29d11e3ae5bc2ac8e6
2020-02-25 00:13:43 -08:00
Payam 02835e5591 changed variable name to VDI
Change-Id: I9ab338b50714b0df2db1fa485134e1dad80b68c0
2020-02-25 02:11:24 -05:00
Christophe Paquot 2bdfc73649 Fixed a few multithreaded potential issues
Also make D2H and H2D keep track of the chain of events
when we need to use a different HostQueue.

Change-Id: I1c5da6ea6104b37ad7aac00f0eb8ea9371e6ba1c
2020-02-24 20:14:10 -08:00
Payam Ghafari 4a2109b3ce Merge "updated hip-targets for hip-vdi" into amd-master-next 2020-02-24 18:15:56 -05:00
Payam ade5994ede updated hip-targets for hip-vdi
Change-Id: Ib65e9011b25e368b8e03db1b4f14aa1ad076f4bc
2020-02-24 17:37:21 -05:00
Payam Ghafari 45b1691e0a Merge "updated lib elf path and clean ups" into amd-master-next 2020-02-24 17:35:36 -05:00
Vladislav Sytchenko b1d2e581ff Reeanble texture tests for VDI
Enable hipBindTex2DPitch and hipBindTexRef1DFetch

Change-Id: I36a3252e25d1ed844967ec117e1f1951004cba11
2020-02-24 15:24:00 -05:00
Vladislav Sytchenko f71817a342 HIP-VDI texture rework
The current texture implementation is based off the one for HIP-HCC. There's a lot of problems with it - only creating images from buffers, hard coding logic and ignoring user parameters. This leads to a whole lot of UB even with simple examples (as seen with RedShift's code).

This CL is aimed to bring the HIP-VDI texture implementation closer to what is described by Cuda.

hipMemcpyAtoA() - image to image copy.
hipMemcpyHtoA()/hipMemcpyDtoA() - buffer to image copy.
hipMemcpyAtoH()/hipMemcpyAtoD() - image to buffer copy.

hipArrayCreate()/hipArray3DCreate()/hipMallocArray()/hipMalloc3DArray() - creates 1D/2D/3D/1D Array/2D Array images.
hipCreateTextureObject() - creates sampler, (optional) creates 1D/2D image from buffer, (optional) creates image views.
hipBindTexture() - creates 1D image from buffer (should create a typed buffer, however this is not compatible with HIP-HCC).
hipBindTexture2D() - creates 2D image form buffer.
hipBindTextureToArray() - creates image view.
hipTexRefSetAddress() - creates 1D image from buffer (should create a typed buffer, however this is not compatible with HIP-HCC).
hipTexRefSetAddress2D() - creates 2D image from buffer.
hipTexRefSetArray() - creates image view.

There are still a lot of  TODOs in the code, here's a few important ones:
1. VDI doesn't support a lot of sampler flags.
2. VDI doesn't support device to image 2D/3D copy.
3. Mipmaps implementation is incomplete.
4. Image view implementation is incomplete.

Change-Id: Ia374ee27aa14f76451fee7667495036f4419a487
2020-02-24 15:23:45 -05:00
Payam 3beac02cbd updated lib elf path and clean ups
Change-Id: Id0b3c295fa8353a5da8517204bf53dab9887defb
2020-02-24 15:09:34 -05:00
Payam Ghafari 9518af6083 Merge "export hip::host and hip::device" into amd-master-next 2020-02-24 13:29:01 -05:00
Jatin Chaudhary 8bf287ef18 Generating hiprtc lib with hcc+hip-clang
Review comments - generate hiprtc lib everytime when HIP_PLATFORM is hcc

Changes for hip-clang

Removing pre processor directive to simplify

Change-Id: Id38ab368362b58ee0458baeb8051fea709ae6bba
2020-02-24 11:44:17 -05:00
Payam e5c8903925 export hip::host and hip::device
Change-Id: If1427a180f91d3f8bae203d956f21cd69345c060
2020-02-21 19:58:42 -05:00
Vladislav Sytchenko 16ffc6fe3e Update hipGetErroName() to match hipError_t
Change-Id: I8f7fe0cca01ddec5d6333ba6e876128276323be9
2020-02-21 18:31:27 -05:00
Vladislav Sytchenko d934d731a0 Fix Windows build
MSVC unlike gcc doesn't add colons for you.

Change-Id: I06d81a9a9b346065d0452fe7117ab82144a06f74
2020-02-21 14:37:41 -05:00
Vladislav Sytchenko 8be685e7b9 Report the HW requirments for pitch alignment
Change-Id: Iaaa9d597dff57cfad5d07d931f881aba1a5f98f1
2020-02-21 11:09:47 -05:00
Vladislav Sytchenko 8c8d963c65 Disable hip{Create/Destroy}SurfaceObject
The current implementation of surd2D{read/write} directly addresses into
the image buffer via the hipArray::data ptr. This is incorrect to do
since we don't know the layout of the image. Also with VDI we won't have
access to the underlying image buffer.

Disable the surface api untill the device functions are switched to
using __ockl_image_{load/store}().

Change-Id: I19a33680176812d5aad3660e9045812061a1c443
2020-02-21 11:09:28 -05:00
Tao Sang ba494c64cf Add __hip_pinned_shadow__ for texture
Add missing __hip_pinned_shadow__ for texture in tex2d_kernel test.

Change-Id: Iefc96084fec8f84a1d1bb979998ffb95b4011f0b
2020-02-20 20:01:28 -05:00
Tao Sang 012a322292 Merge "Make __gnu_h2f_ieee and __gnu_f2h_ieee visible" into amd-master-next 2020-02-20 16:00:18 -05:00
Tao Sang 314766b4c2 Make __gnu_h2f_ieee and __gnu_f2h_ieee visible
Make __gnu_h2f_ieee and __gnu_f2h_ieee visible so that hipTestHalf
test can succeed in Clang compiler + Hcc RT.

Change-Id: I5f7d5db19e559b3b66356f0170a8dbc1e5505f3e
2020-02-20 14:09:53 -05:00
Karthik Jayaprakash 4b2ff6ec91 SWDEV-223674 - Return hipErrorNoBinaryForGpu in case particular binary is not found in clang offload bundler.
Change-Id: Iaa08fcdc8ecb719edd9f81e4a1456ea642f362f4
2020-02-19 20:01:36 -05:00
Christophe Paquot 13bf30569e SWDEV-223262
hipMemcpyWithStream is supposed to be synchronous.

Change-Id: Ie44e37ecc9246e26a6b315c01e88a279f9e42fd7
2020-02-19 14:08:12 -08:00
Christophe Paquot 644dad178c Merge "HIP-HCC + Clang fix failing texture tests(SWDEV-223622)" into amd-master-next 2020-02-19 14:57:14 -05:00
Christophe Paquot be1dc1d217 Merge "Removing gcc test for clang" into amd-master-next 2020-02-19 14:56:03 -05:00
Christophe Paquot 27d79601f0 Merge "Adding a break at right spot to fix a bug in tests which got exposed with clang usage" into amd-master-next 2020-02-19 14:54:15 -05:00
Jatin Chaudhary e1024a249a Removing gcc test for clang
Change-Id: Iccf00221a07be920683207daa9ed0e0949259623
2020-02-19 11:09:47 -05:00
agodavar 63c1d28a4b HIP-HCC + Clang fix failing texture tests(SWDEV-223622)
Change-Id: I1c0a7059c6bba1ea2e39dc6634b32d006c07d1f5
2020-02-19 07:03:57 -05:00
Payam 1079679afa Removed Static lib for hip target
Change-Id: Iea7fc3f26f5d99df622e69aab3898f7bc931fc58
2020-02-19 03:51:55 -05:00
Payam Ghafari e115d20af0 Merge "removing static lib for hip target" into amd-master-next 2020-02-18 19:16:31 -05:00
Tao Sang 40d0884a03 Merge "Temporarily comment out Hcc-specific APIs for CLang compiler" into amd-master-next 2020-02-18 18:50:05 -05:00
Evgeny Shcherbakov 9c4e11f217 Merge "adding 'hipHccModuleLaunchKernel' and 'hipExtModuleLaunchKernel'" into amd-master-next 2020-02-18 18:10:22 -05:00
Tao Sang e34a907b8b Merge "Fix bug of hip/samples/2_Cookbook/7_streams" into amd-master-next 2020-02-18 17:41:34 -05:00
Christophe Paquot b4ad4262cc Introducing hip::Device which wraps around amd::Context and deviceId
Change-Id: Ie35a6edb65c001b35eb9f5d2af26e765dc41c00e
2020-02-18 17:18:56 -05:00
Payam a7a60a8322 removing static lib for hip target
Change-Id: I401f428469d5c1c03278f20c3c24c69636876f7c
2020-02-18 16:46:36 -05:00
Tao Sang 47d3276177 Fix bug of hip/samples/2_Cookbook/7_streams
Initialize Kernel_descriptor with matched function name.

Change-Id: I26911d6bc9b2beae186a9e6f9441ce408521bce9
2020-02-18 13:53:21 -05:00
Karthik Jayaprakash e066cc6f60 SWDEV-223394 - Pass module info from hipModuleGetTexRef to internal Platformstate:: functions.
Change-Id: I7d1ba3f940f595c3fca74a57fa20f484c52d4741
2020-02-18 11:23:03 -05:00
Payam Ghafari f7300f5cbe Merge "updated package generation and removed hiphcc_static as a target for hip-vdi" into amd-master-next 2020-02-18 10:47:47 -05:00
Jatin Chaudhary 96a5d45b0e Adding a break at right spot to fix a bug in tests which got exposed with clang usage
Change-Id: Ibf197f0108eec0bc4b87df8672d24e394a03d1b3
2020-02-18 17:23:45 +05:30
Tao Sang ffb8689462 Merge "Fix bug of hip/samples/0_Intro/hcc_dialects/vadd_hip" into amd-master-next 2020-02-17 22:01:12 -05:00
Christophe Paquot 1f5ae789bb Don't create a marker for start event in hipModuleLaunchKernel
And also don't optimize the case where start==stop event to compute
elapsed time since the command can be a NDRange one.
HIP directed test will need to be fixed for that.

Change-Id: I64fadd6ab8ab1a490e7a2b7165a591df5a5cf3a2
2020-02-17 14:16:31 -08:00
Evgeny 45b1673e26 adding 'hipHccModuleLaunchKernel' and 'hipExtModuleLaunchKernel'
Change-Id: Id9990ed3041b82956872a088ff019ade69d40afb
2020-02-17 16:06:24 -06:00
Payam Ghafari 52e6e35bf4 Merge "updated hipcc to include HSA path for clang builds as well" into amd-master-next 2020-02-17 02:01:37 -05:00
Tao Sang 15b91e9f1e Temporarily comment out Hcc-specific APIs for CLang compiler
Temporarily comment out Hcc-specific template functions
hipExtLaunchKernelGGL and hipOccupancyMaxPotentialBlockSize for CLang
compiler so that all test cases under hip/samples can be built
successfully for Clang + Hip/Hcc runtime.

Change-Id: Iafc761257be4a7b34eafa6759a01f369570cd6ce
2020-02-16 22:26:47 -05:00
Tao Sang 05785772e3 Fix bug of hip/samples/0_Intro/hcc_dialects/vadd_hip
For hipLaunchKernelGGL(), hmod->kernargs is empty, thus we need
insert hmod->kernargs[name_str] which is empty.

Change-Id: I95f818d0525da84452e66c5778f0648a643843c7
2020-02-16 17:58:04 -05:00
Payam 2f9cb366f2 updated package generation and removed hiphcc_static as a target for hip-vdi
Change-Id: I0067dd6341f47a212cb02b8d43d3ea01644c2391
2020-02-16 03:00:59 -05:00
Tao Sang eb8c4d1ce2 Support defaultDriver test with Clang+Hcc Runtime
Fix the following issues:
1.Ignore hidden arguments of kernel functions.
2.Look up both origial function name and function name with .kd postfix
when argments are retrived from module.
3.Addition, fix compiling issue of LaunchKernel test app.

Change-Id: I9400943f2f02433cb4409b19c0cac3626c2bc454
2020-02-15 19:29:13 -05:00
Payam 9bdc203a99 removing oocupancy tests from hip-vdi for now
Change-Id: I06e966d07021af87fa2c195e4bbaf6bcc336658d
2020-02-13 21:40:06 -05:00
Christophe Paquot d6b9b323b8 Merge "hipLaunchByPtr and hipLaunchKernel deviceId potential issue" into amd-master-next 2020-02-13 18:49:06 -05:00
Payam 87cd9451f2 updated hipcc to include HSA path for clang builds as well
Change-Id: Icaaa68fdbe79fb16e4e9fedd420460f1479d7fe0
2020-02-13 16:48:24 -05:00