Commit Graph

75 Commits

Author SHA1 Message Date
Satyanvesh Dittakavi 239fdc3bfd SWDEV-419480 - HIPRTC implementation of standard headers shouldn't be in std namespace
HIPRTC implementation of few type traits are defined in std
namespace which causes conflicts with the std C++ headers when
apps try to include those std headers. Instead, use the
specific implementation of these headers from __hip_internal
namespace to avoid this.

Change-Id: Ia358df159af8783d1eba9a19cd458e192bf7e9e6


[ROCm/clr commit: 353dbe6e3b]
2023-10-16 13:10:55 -04:00
Jaydeep Patel 90e078b5f4 SWDEV-425490 - Move ptrdiff_t & clock_t to hiprtc.cmake.
Change-Id: I7c8ce3c1b8cb11e0253b0f51ae10fca7f0a32017


[ROCm/clr commit: 7150b2eaad]
2023-10-13 00:58:56 -04:00
Jatin Chaudhary 15b062b9b4 SWDEV-306642 - [ABI Break] Add texture/surface/device capabilities device struct entries
- alias hipGetDeviceProperties to hipGetDevicePropertiesR0600
- alias hipDeviceProp_t to hipDeviceProp_tR0600
- remove gcnArch from new device property struct
- add new requested struct members

Change-Id: If3f5dbef3d608487d9f6f419285f4bf577ea9bf0


[ROCm/clr commit: 2989840511]
2023-10-12 11:16:18 -04:00
Satyanvesh Dittakavi 43670ec526 SWDEV-421415 - Pass the right hip major, minor versions to hiprtc builtins
Change-Id: I2ff5787039891d1d3390c996d37bf342e0a88705


[ROCm/clr commit: f5a9a36cf3]
2023-09-26 00:52:54 -04:00
Satyanvesh Dittakavi 3c89a1a293 SWDEV-402080 - Add options such as -Rpass=inline to exe_options in RTC if the user passes it
Change-Id: I12fcf200ed9d3112b014f3d426d5fe504eeca163


[ROCm/clr commit: 2764b85ca5]
2023-09-25 04:03:44 -04:00
Satyanvesh Dittakavi 78a3dc739d SWDEV-395996 - Add HIPRTC support for missing hip headers
hip headers such as hip_math_constants.h, library_types.h,
hip_common.h, channel_descriptor.h, device_functions.h, hip_complex.h,
hip_texture_types.h, math_functions.h, surface_types.h
are added in HIPRTC

Change-Id: I4a4c198449ceb609c3ff55e00b43056c1f085431


[ROCm/clr commit: d7d0f11318]
2023-09-21 03:11:06 -04:00
Jaydeep Patel 5b450d5551 SWDEV-418038 - Drop GPU_ENABLE_WAVE32_MODE from RTC.
Change-Id: Iac11f26714e8b3bae14cbf69933ef7c8c8be47da


[ROCm/clr commit: a37c95d7ed]
2023-09-08 02:13:41 -04:00
Ioannis Assiouras f28fa0277e SWDEV-415937 - Make _IMPORT_PREFIX in hip*targets.cmake point to a relative path
Change-Id: Ib0f4321f2954254d0486d741d057f182cb2481a7


[ROCm/clr commit: 209525d6e4]
2023-08-31 08:10:50 -04:00
kjayapra-amd 76cc68ff80 SWDEV-381625 - Parse compiler and linker options from environment variable.
Change-Id: Id5a012b678e5973c4b64dff84444a909aefae006


[ROCm/clr commit: 6a0f80a03d]
2023-08-29 20:24:27 -04:00
Vikram 5588dc0583 SWDEV-417558 - Fix dynamic linker error caused by SWDEV-378651 fix
Seems the windows linker error seen with https://gerrit-git.amd.com/c/compute/ec/clr/+/886078
also exists for linux, but only appears with dynamic linker. This fixes both usecases.

Change-Id: I1bb6df151eb1e09f75af4d461ead28bcbaa5f236


[ROCm/clr commit: 62464ca4c3]
2023-08-18 02:21:14 -04:00
Vikram 41ee2ee689 SWDEV-378651 - add proper wavefrontsize link time option to hipRTC, in accordance with env variable GPU_ENABLE_WAVE32_MODE
This is a copy of http://gerrit-git.amd.com/c/compute/ec/hipamd/+/841299
Raising this here again since hipamd repo is frozen.

Change-Id: I8722ef55f78a9176e131fd5766fb11101b51f1b5


[ROCm/clr commit: cec579c006]
2023-08-15 00:12:31 -04:00
Satyanvesh Dittakavi c97dd090f0 SWDEV-415439 - Address segfault issues with hiprtcLinkCreate
Change-Id: I5c5898a9d0afadc344ae2fafc371e9ed647cec6e


[ROCm/clr commit: 8ee985a67b]
2023-08-10 08:28:11 -04:00
Ioannis Assiouras 922c988a8a SWDEV-411086 - Provide path ROCM_PATH/llvm via the HINT argument instead of PATH in calls to find_package
PATHS have lower priority than system paths so if there is a clang installation in /usr/local find_package(Clang)
will pick that instead. To fix this provide the llvm path via the HINTS argument instead.

Change-Id: I57794a9a5c5fc26f12c60798fbc8e826c1880e13


[ROCm/clr commit: 238b973a5a]
2023-07-14 04:46:44 -04:00
Ioannis Assiouras 41381e9557 SWDEV-407818 - Fixed bug when opening LinkerFile fstream on windows
Change-Id: If6f083d9fa83066eb2b20ab24dceaa9df7a2f0a0


[ROCm/clr commit: 791cea44f1]
2023-07-07 13:25:04 -04:00
Ioannis Assiouras a1c01b7d34 SWDEV-406894 - Fix segfault when access HIPRTC_JIT_LOG_VERBOSE from options buffer
Change-Id: I24143dfb726d9a71fdb17b03d5b5dd910b54f5bb


[ROCm/clr commit: 0af9788e32]
2023-06-22 00:53:29 -04:00
sdashmiz 2216908962 SWDEV-403638 - Fix warnings
- disable deprecated function use warning
- disalbe size_t to .type' warning
- disable conversion from 'type1' to 'type2' warning

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I64161fd37cf56de3d132102103267ae8da40193a


[ROCm/clr commit: 38a67df312]
2023-06-15 12:17:22 -04:00
Jacob Lambert 911dbabdff SWDEV-380857 - Remove space in "Linker Program" used to set Comgr object name
Not a required change, but it does make dealing with temporary files generated
by Comgr easier.

Change-Id: I9c43138dd2a6c4fea965b57fbce7a087ab2bbd28


[ROCm/clr commit: 1171518b97]
2023-05-30 13:47:26 -04:00
Jacob Lambert 2d9db8a102 SWDEV-371628 - Remove now-redundant Comgr devlib call from hipRTC
Because hipRTC is now using the newer
AMD_COMGR_COMPILE_SOURCE_WITH_DEVICE_LIBS_TO_BC, and now that this
action has been fixed for HIP compilations in Comgr, hipRTC no
longer needs separate Comgr call to link in the device libs.

Change-Id: Ibf9024cbaaab825584566e8d0b5fce60d7063dd8


[ROCm/clr commit: 283dd8352d]
2023-05-23 18:34:59 -04:00
Satyanvesh Dittakavi 82e044cb6a SWDEV-399851 - Add template overload for ToString in HIPRTC
HIPRTC_INIT_API can have nullptr in the arguments and ClPrint
can crash while printing

Change-Id: Iecade5c3867196509c8cc0647b9aa24be0960a02


[ROCm/clr commit: c98fad1edc]
2023-05-16 14:21:19 +00:00
Jatin Chaudhary 9e5b96d567 SWDEV-384013 - Print link options being passed to compiler with AMD_LOG_LEVEL
Change-Id: I556ed434587cff07a634796da51dcbb9ae78ef21


[ROCm/clr commit: 8753db5446]
2023-05-15 15:52:04 -04:00
Jacob Lambert c22413efba SWDEV-380857 - Fix bug when reading bitcode file into vector<char> buffer
The previous implementation using std::copy() resulted in
differences between the in-memory and on-disk representations.
With the updated implementation, we get the same contents.

Change-Id: Iadfae3cd7f7ba99538da2ac4f11f30f5a78260d8


[ROCm/clr commit: b17056cb93]
2023-05-08 16:25:01 -04:00
kjayapra-amd 23584feba4 SWDEV-393910 - Port gfx94x changes to mainline.
Change-Id: Ibf727223bbe5230b132b47c39e0fc1d87cbd3b9c


[ROCm/clr commit: f14e8a2dba]
2023-05-05 15:16:23 -04:00
Ioannis Assiouras 7adb0089c6 SWDEV-397356: Move HIP_API_PRINT after HIP_INIT so that the begin function call gets printed
Change-Id: I99b655596741c19bc483647794ae8b4f6e6f2843


[ROCm/clr commit: d88f0358b0]
2023-05-04 18:46:21 -04:00
Satyanvesh Dittakavi 53dcdf2b46 SWDEV-393060 - Address directed tests build failures with CLR
Change-Id: I76b93ee073d21ec5fae0db5a129ada89f750855d


[ROCm/clr commit: a3104c60e1]
2023-04-14 03:53:51 -04:00
Jaydeep Patel 235eb22491 SWDEV-390439 - SWDEV-387997 - Delete array.
Change-Id: Ica20b005f5db7f4ed65c5ebc51959392671fe320


[ROCm/clr commit: 0f975e6e93]
2023-04-05 16:37:39 +00:00
Jatin Chaudhary 421c4149e4 SWDEV-384013 - Add HIPRTC_JIT_IR_TO_ISA_OPT_EXT
Change-Id: Icfc06c19af32f41d603bf880ab1927bffb391097


[ROCm/clr commit: 300ba5b1f1]
2023-04-05 10:52:48 +00:00
Anusha GodavarthySurya f0dd8a6fe3 SWDEV-386102 - Handle code object v5
Change-Id: I47b840f484d90ca7815fb9c8af959ceaac62cf70


[ROCm/clr commit: 9b84e05427]
2023-03-09 00:19:25 -05:00
Satyanvesh Dittakavi 8947306ffd SWDEV-384714 - Add hipRTC support for amd_hip_fp16
Change-Id: Ib6e2b46908d740909dfc15253965590f496a7068


[ROCm/clr commit: a8c2375fe1]
2023-03-01 06:57:57 -05:00
Konstantin Zhuravlyov f789329113 SWDEV-1 - Add missing gpu cases in getProcName
Change-Id: I16103ab213cc70f388690df85e6a03e7a408384d


[ROCm/clr commit: caf7551dd7]
2023-02-17 15:55:09 -05:00
Satyanvesh Dittakavi 77e78dff33 SWDEV-370552 - Correct the HIPRTC behavior to optimize the ISA only once
Change-Id: Idaf0ea8294657db3666e9548deb6a9629e0ee718


[ROCm/clr commit: 99556449b6]
2023-02-09 11:55:41 -05:00
Satyanvesh Dittakavi d96114fd22 SWDEV-372396 - Address the errors in hiprtc headers with -Werror
Change-Id: Ied553216dfc2ff8b5c72de617cb47b6ca8f52063


[ROCm/clr commit: 0ccd41050b]
2023-01-23 17:25:42 +00:00
Satyanvesh Dittakavi f94a34e128 SWDEV-373231 - Support hip atomics header with HIPRTC
Change-Id: Ic500dfb66ed5ef0c4b672dfd0595409d0e8caaf5


[ROCm/clr commit: 842b9d0b56]
2023-01-17 00:31:07 -05:00
Jacob Lambert 507c87da5f SWDEV-356171 - Adding support for name lowering for bitcodes (-fgpu-rdc) via
Comgr mangled name fetching APIs

Change-Id: I10ce2b1288c459e3e61218d68a270aba2148376e


[ROCm/clr commit: 7dd54c746e]
2023-01-09 14:49:51 -05:00
Juan Manuel MARTINEZ CAAMAÑO f91da83d6a SWDEV-290384 - Missing hiprtcResult case in hiprtcGetErrorString
Change-Id: I11d18ff19f6f6f1b36febf87a586bc9ffb95af10


[ROCm/clr commit: 537df06c4f]
2023-01-06 03:38:44 -05:00
Satyanvesh Dittakavi 54c5fa36d8 SWDEV-375020 - Revert "SWDEV-370552 - Improve hiprtc performance by passing the right flags to comgr"
This reverts commit 96d28fd15d.

Reason: Adding "-Xclang" and "-disable-llvm-passes" in hiprtc
compilation seem to cause perf issues and memory fault in few apps.

Change-Id: I12ff46293c7b7afb24d570351736d884d2881b77


[ROCm/clr commit: 516acd4e60]
2023-01-06 00:09:06 -05:00
Satyanvesh Dittakavi 96d28fd15d SWDEV-370552 - Improve hiprtc performance by passing the right flags to comgr
Change-Id: I99674b033d1248d9b34ac598b4780bd84a38c279


[ROCm/clr commit: 627e689ad7]
2022-12-19 06:16:56 -05:00
kjayapra-amd 67cf4a5107 SWDEV-363865 - Use COMGR path to unbundle code object in HIPRTC.
Change-Id: Ifca29ea0c6ff319c3f584397e542a1658d220c4a


[ROCm/clr commit: 2f8847bfbd]
2022-12-15 07:16:55 -05:00
Jacob Lambert 50a845c43a SWDEV-322000 - Removing scoped locks in code regions with Comgr calls
Comgr now internally locks to avoid multi-threading issues with LLVM

Change-Id: I74b903d373af55c2efade17a9caf31fda3ca1795


[ROCm/clr commit: 2835ff1a63]
2022-12-14 12:40:45 -05:00
Satyanvesh Dittakavi a17cc5c6ba SWDEV-372032 - Support cooperative groups header with HIPRTC
Change-Id: Ia64652fd52b210a4eeee9d38fdfdfa6fdc7163ff


[ROCm/clr commit: 91291e48db]
2022-12-09 04:45:59 -05:00
Satyanvesh Dittakavi ea4ee7ed93 SWDEV-366306 - SWDEV-366314 - Add hip vector types and hip bfloat16 to HIPRTC cmake
Change-Id: If4213c3ca9446afe931c6b111c220033987e0204


[ROCm/clr commit: 88270b34f2]
2022-12-09 04:43:51 -05:00
Satyanvesh Dittakavi db752c6295 SWDEV-370841 - Correct the devicelibs library bitcode used by hiprtc
Change-Id: I1f2ab9ca4ab2947f42e101c37bb3e6a046e32d5b


[ROCm/clr commit: 450d0941ca]
2022-12-01 12:00:36 -05:00
Maneesh Gupta 3a7b8156a3 Revert "SWDEV-330775 - Update search path for LLVM"
This reverts commit f31b0874fd.

Reason for revert: SWDEV-368704

Change-Id: I8c38b4f40285f90f7d99145b970c2a14d051d5bb


[ROCm/clr commit: fab70a41ed]
2022-11-22 09:14:24 -05:00
Siu Chi Chan f31b0874fd SWDEV-330775 - Update search path for LLVM
ROCm's LLVM will be moved into /opt/rocm-<ver>/lib/, teach hipcc and
hipconfig about the new location.

Change-Id: Ie7f17146771aff94c684deb22148226cbb3a2895


[ROCm/clr commit: 3d15f9cbda]
2022-11-14 13:31:07 -05:00
kjayapra-amd acfea3b761 SWDEV-356947 - Create a new thread if current thread is nullptr.
Change-Id: Iebd69f22284041ed450d583471d24cb82fb0e47a


[ROCm/clr commit: cc9427e969]
2022-11-10 22:12:02 -05:00
Satyanvesh Dittakavi 300d7d98f9 SWDEV-364545 - Fix hiprtc cmake target on Windows
Change-Id: I360d0d1ee7f6a0c65a4d6cd07620bfa2a503c19f


[ROCm/clr commit: 1155dbda1e]
2022-11-10 01:23:42 -05:00
kjayapra-amd e380d85f27 SWDEV-355727 - Change in AMDGCN format in bitcode.
Change-Id: Ic32a3e7b866b35a321d8ececc2f6c63f9b23121d


[ROCm/clr commit: 1b902e1809]
2022-10-13 14:19:03 -04:00
Rakesh Roy f149b21399 SWDEV-351969 - TLS Optimization
- Aggregate all TLS(Thread Local Storage) variables into a single class
- This is to improve cache accesses per thread

Change-Id: Ic8361eaeae290fff00254684e309471958365eb9


[ROCm/clr commit: 8b391ef18c]
2022-10-09 22:08:14 -04:00
Satyanvesh Dittakavi a7f33f9237 SWDEV-357250 - hiprtc support with AMD_LOG_LEVEL when linked as separate library
Change-Id: Ieda83af85a9344b4e09d4fe85acc65386db79c39


[ROCm/clr commit: b425e27230]
2022-09-23 05:50:07 -04:00
kjayapra-amd b0825090e9 SWDEV-355727 - Added more rules to target ID comparison in hiprtc.
Change-Id: I56137375c3eb47dd604c7a02bb88f7e3dbe6c04d


[ROCm/clr commit: d870bdb9b1]
2022-09-21 12:18:13 -04:00
Maneesh Gupta 2e860b68a0 Revert "SWDEV-339488 - Address HIPRT tests failure with spaces in the include path"
This reverts commit 147c17cac4.

Change-Id: I10f91ec0205cd4276b141aade5728fdc20030195


[ROCm/clr commit: 8e10332ff1]
2022-09-13 23:06:23 -04:00