Commit Graph

64591 Commits

Author SHA1 Message Date
ajanicijamd 259ef6348b Fixed issues with nic-performance test (#1168)
- On some hosts the wget can finish too soon and PAPI doesn't catch even a single network event.
- On some hosts, there are multiple default NICs and the scripts didn't work in that case.
- The test script was writing the output of wget to /tmp directory, which causes a problem if another user tries to run the same test. Because the output file with the same name already exists in the same directory, but with a different owner, the test fails

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-10-14 23:45:08 -04:00
Gerardo Hernandez bfbc48bb0e SWDEV-536360 - fix bullet points in reduce sync operations section not being displayed on different lines in the browser (#1346) 2025-10-14 22:02:34 +01:00
axie_amdeng dde482d224 rocr: unitialized size variable caused huge memory/space allocation (#1232)
Signed-off-by: Alex Xie <AlexBin.Xie@amd.com>
2025-10-14 16:57:10 -04:00
Mythreya Kuricheti 765d9026c7 [CI][rocprofiler-sdk] Workflow improvements (#1341) 2025-10-14 15:21:55 -05:00
Ajay GunaShekar 0ac37de373 SWDEV-555665 - fix hip-tests for windows (#1028)
* SWDEV-555665 -enable fixed windows tests
2025-10-14 08:39:49 -07:00
Satyanvesh Dittakavi 9d32badcb7 SWDEV-545950 - Update indentation in hip_prof_str.h for hipStreamCopyAttributes (#1352) 2025-10-14 17:35:17 +05:30
Ioannis Assiouras 538ebc5409 SWDEV-556877 - Ensure pinned memory is released if hsa copy fails (#1137) 2025-10-14 10:08:49 +01:00
amd-srinivas1 092279449e SWDEV-546345-[catch2][dtest]-Tests for hipMemSetD2DXX Apis(Memory management) (#896)
* SWDEV-546345-Added tests for memsetd2dxx apis

* SWDEV-546345-Optimized the code.

* SWDEV-546345-Optimized the code.

* SWDEV-546345-Addressed review comments

* SWDEV-546345-Updated code.
2025-10-14 10:47:59 +05:30
SaleelK cc18890fe8 clr: Reset barrier_value_packet_ at init (#1162) 2025-10-13 22:01:46 -07:00
vstojilj f964f45902 SWDEV-553920 - Disable and fix failing tests (#1133) 2025-10-13 16:38:27 +02:00
vstojilj bfedf63575 SWDEV-552537 - Fix nvidia build failures (#1125)
* SWDEV-552537 - Fix nvidia build failures

* Add string header to fix hip-tests

---------

Co-authored-by: Branislav Brzak <branislav.brzak@amd.com>
Co-authored-by: Danylo Lytovchenko <danylo.lytovchenko@amd.com>
2025-10-13 09:20:17 +02:00
amd-srinivas1 b86b676514 SWDEV-553447-[catch2][dtest]-Add hipDeviceMallocUncached to hipMemCreate and hipMemMap flags (#857)
* SWDEV-547367-Updated tests to work with hipMemAllocationTypeUncached

* SWDEV-553447-Updated tests of hipMemMap

* SWDEV-553447-Resolved merge conflicts

---------

Co-authored-by: jainprad <92369414+jainprad@users.noreply.github.com>
2025-10-12 22:05:02 +05:30
Satyanvesh Dittakavi 46e683d41a SWDEV-545950 - Add hipStreamCopyAttributes API Implementation (#914)
* SWDEV-545950 - Add hipStreamCopyAttributes API Implementation

* Add unit test for hipStreamCopyAttributes API

* Add ChangeLog and nvidia mapping for the API

* Update rocprofiler-sdk with new HIP API details

* [rocprofiler-sdk] handle hipStreamCopyAttributes in stream tracing service

- this new HIP function has multiple stream arguments and needs to be skipped because it does not have an explicit create/destroy/set functionality

* Update HIP_RUNTIME_API_TABLE_STEP_VERSION in clr and rocprofiler-sdk

* Resolve merge conflicts

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2025-10-12 19:57:05 +05:30
David Yat Sin 7f79d0febc rocr: Set signal memory allocations to NonPaged (#1219)
Set memory allocation to non-paged to avoid issues caused when CP tries
to access signals after page has been migrated.
2025-10-10 17:35:15 -04:00
Jason Bonnell 082e7adb81 Updated VERSION regex for tarball in Dockerfiles (#1321) 2025-10-10 15:37:13 -04:00
jamessiddeley-amd 64375c23d0 [rocprof-compute] Improve standalone roofline plot generation (#1298)
* ruff formatting

* Update roofline.py function descriptions

* Update height calculation

* Add back cache level filtering in gui_analysis

* Update roofline_calc.py to take in ai_data for ceiling length calc

* format roofline.py

* update roof test cases

* update roofline legend plot table

* fix pdf generate cutoff

---------

Co-authored-by: cfallows-amd <Carrie.Fallows@amd.com>
2025-10-10 14:23:23 -04:00
David Yat Sin 7f2ef6a602 rocr: Return error on signal alloc failure (#1310)
Return HSA_STATUS_ERROR_OUT_OF_RESOURCES when signal allocation fails.
2025-10-10 14:06:31 -04:00
amd-srinivas1 6b8a4a23ba SWDEV-546345-[catch2][dtest]- Tests for memCpyBatchAsync Apis(Memory management) (#1117)
* SWDEV-546345-Added tests for Batch memCpy apis.

* Updated tests to use multiple data types

* SWDEV-546345-Updated tests for different data types

* SWDEV-546345-Updated clang-format

* SWDEV-546345-Updated hipMemcpy3DBatchAsync parameter

* SWDEV-546345 - Updated hipMemcpy3DBatchAsync tests with hipMemLocationTypeHost

---------

Co-authored-by: Rahul Manocha <rmanocha@amd.com>
Co-authored-by: Rambabu Swargam <rambabu.swargam@amd.com>
Co-authored-by: jainprad <92369414+jainprad@users.noreply.github.com>
2025-10-10 22:03:06 +05:30
Istvan Kiss 51452b643f Revise the section on CU & WGP modes (#1255) 2025-10-10 09:14:03 -07:00
Giovanni Lenzi Baraldi 29f8b2c636 [aqlprofile] Bump TT2 header (#1118) 2025-10-10 13:54:38 +02:00
systems-assistant[bot] 9021b43cd1 SWDEV-546347-Added tests for Module Management APIs (#539)
* SWDEV-546347-Added tests for hipModuleGetFunctionCount

* SWDEV-546347-Added tests for hipModuleLoadFatBinary

* SWDEV-546347-Added 3 more tests for hipModuleLoadFatBinary

* SWDEV-546347-Updated hipModuleLoadFatBinary.cc

* SWDEV-546347-Added test for hipModuleGetLoadingMode API

* SWDEV-546347-Clang-format issues

* SWDEV-546347-Removed tests of hipModuleGetLoadingMode API

* SWDEV-546347 - Updated CMake file

* SWDEV-546347-Addressed review comments

* SWDEV-546347-Updated CmakeLists

* SWDEV-546347-Addressed review comments

* SWDEV-546347-Addressed Review comments

---------

Co-authored-by: SrinivasRao Gollamandala <Srinivasarao.Gollamandala@amd.com>
Co-authored-by: systems-assistant[bot] <systems-assistant[bot]@users.noreply.github.com>
Co-authored-by: jainprad <92369414+jainprad@users.noreply.github.com>
Co-authored-by: Rambabu Swargam <rambabu.swargam@amd.com>
2025-10-10 15:29:20 +05:30
Satyanvesh Dittakavi 446fbd3191 SWDEV-557093 - Add hip catch test using nested tile partition (#1180) 2025-10-10 13:16:43 +05:30
Godavarthy Surya, Anusha d3cc2c7668 SWDEV-524745 - Part-III Add multi device support for hip graph (#814)
- Retrieve the list of devices linked to each branch using stream ID x.
- Identify the necessary streams for each device to facilitate graph execution.
- Create the necessary streams for each device to ensure successful graph execution.
- Implement support for launching a multi-device, single-branch graph.

Co-authored-by: Anusha GodavarthySurya <Anusha.GodavarthySurya@amd.com>
2025-10-10 10:27:27 +05:30
Gopesh Bhardwaj 43eaa1d127 [Documentation] Quick reference guide for rocprofv3 (#953)
* quick reference guide for rocprofv3

* Addressed feedback and updated with rocpd information

* rocpd docs update

* rocpd query option

* Addressing feedback

* Fixed misssing newline

* Addressing feedback

* Addressing feedback

* Addressing feedback

* Addressing feedback

* Adding process attachment
2025-10-10 09:36:28 +05:30
David Galiffi 182a750c08 Fix for thread limit tests (#323)
* Fix for thread limit tests. Which are failing due to exceeding the number of threads allowed.

Signed-off-by: Anuj-Kumar Shukla <AnujKumar.Shukla@amd.com>

* Update CMakeLists.txt

* Stopping thread creation after max thread limit

* Adressed review comments

* Update projects/rocprofiler-systems/tests/source/CMakeLists.txt

---------

Signed-off-by: Anuj-Kumar Shukla <AnujKumar.Shukla@amd.com>
Co-authored-by: anujshuk-amd <anujshuk@amd.com>
2025-10-09 19:07:14 -04:00
Pengda Xie d195d925e9 SWDEV-548034 - Separate sdma signal from compute in checkGpuTime (#1201) 2025-10-09 14:55:25 -07:00
amd-hsivasun 3d10a43c02 [Ex CI] Added Azure pipeline tags to README (#959)
* Update README.md

* Update README.md

* Update aqlprofile Pipeline Status
2025-10-09 15:46:06 -04:00
Satyanvesh Dittakavi 6b85dcf227 SWDEV-557093 - Add nested tiled partition in HIP cooperative groups (#1166) 2025-10-10 00:21:44 +05:30
systems-assistant[bot] 1ae36dd856 SWDEV-538181 - Fix 1D buffered image copy (#441)
* SWDEV-538181 - Fix 1D buffered image copy

Fix wrong logics to copy to/from 1D buffered image
in PAL path.

---------

Authored-by: taosang2 <tao.sang@amd.com>
2025-10-09 09:47:11 -04:00
Jatin Chaudhary 22b4ff7aae SWDEV-1 fix issues seen due to test sharding (#1134) 2025-10-09 06:26:05 +01:00
Mythreya Kuricheti fd82a185c2 [CI][rocprofiler-sdk] Add HIP build to CI (#1311) 2025-10-08 21:37:42 -05:00
Geo Min 388edb1b57 [TheRock CI] Adding profiler builds (#1301)
* Adding profiler for TheRock CI

* adding temp test for rocproiler

* Removing subtrees

* PR comment
2025-10-08 14:38:38 -07:00
Jason Bonnell cccc350dc6 [rocprofiler-systems] Add different test coverage for CI/Nightly, add better logging for failures (#1272)
* Try outputting LastTest.log

* Update if condition for outputting log

* Another attempt

* Only run Ubuntu Noble on MI355 in push/PR

* Try exclude matrix

* Move conditional statement in matrix exclusion

* Create ci-matrix.yml file

* Add needs parameter to ubuntu job

* Fix typo in matrix output variable

* Add back pull_request_template.md

* Add back pull_request_template.md
2025-10-08 15:18:56 -04:00
Ethan Trinh 5cc7a7356a SWDEV-553103 - Remove adobe and afterfx workaround (#865) 2025-10-08 13:03:37 -04:00
cadolphe-amd 207a278d41 SWDEV-516307 - Clean up ICD references in HIP (#1019)
Moved default empty dispatch table and associated Platform initialization for HIP from fixme.cpp into the respective struct definitions.
2025-10-08 09:49:35 -04:00
Kian Cossettini 0c53a12a88 [rocprofiler-systems] [ROCpd] Add OMPT callbacks to ROCpd (#1016)
* Add OMPT to ROCpd

* Use correct category

* Added wrapper functions for future control

* Formatting

* Fix naming

* Comment change

* Remove ompt_get_cb_args

* Switched to using region_sample for OMPT

* Remove relic function

* Remove get_use_rocpd that was used in this pr (one still remains)

* Rename ompt_get_args_string and reuse in tool_tracing_callback_stop

* Make lock init and destroy cb instant

* [Prototype] ROCPD Name fix

* [Prototype] ROCPD Name fix P1

* [Prototype] ROCPD Name fix P2

* ROCPD Name fix

* Var name changes

* Rewrite cb overwrite to single function

* [Important] Use parallel_data as key for parallel callback map

* Fix workflow failure

* Make cpp USE_ROCM consistent with hpp and use default constructor if USE_ROCM = 0

* Add missing ROCPROFILER_VERSION check

* Improve readability

* Make ompt storage maps thread local

* Part 1: Variable name fix, memory cleanup, and fixed asserts

* Part 2: Add comments

* Part 3: Add CI_THROW

* Part 4: Formatting

* Part 5: Move #include to cpp
2025-10-07 19:01:25 -04:00
David Galiffi d6bdc53f1a Update rocprofiler-systems-continuous-integration.yml (#1271)
Disabling network test from CI while we investigate it's instability.
2025-10-07 18:55:30 -04:00
German Andryeyev 7ca2497378 rocr: Add AQL queue support under Windows (#1211)
Add 2 extra caps into the thunk interface to indicate
the queue object creation and PM4 emulation
2025-10-07 17:55:08 -04:00
ammallya 7cc026bf98 Adding release trigger (#1295)
* Adding release trigger
2025-10-07 10:43:31 -07:00
Rahul Manocha 27ec19116d SWDEV-557828 - fix hip-tests on cuda (#1152)
Co-authored-by: Rahul Manocha <rmanocha@amd.com>
2025-10-07 08:28:56 -07:00
Ben Richard f578f39f0a Fix web GUI displaying same section multiple times (#1267)
Some sections were being displayed multiple times in the web GUI.

Code to append the section was nested inside the subsection loop,
so each time a new subsction was appened to the section,
the entire section was appended.
2025-10-07 10:29:45 -04:00
Sam Ruscica 135c38b41c SWDEV-553436 Created wrapper functions for file read and file write (#935) 2025-10-07 09:42:22 -04:00
Gopesh Bhardwaj da457c9a43 [Documentation] rocprofv3 attach/detach (#1108)
* Fixing typo in script

* updating docs

* updating docs

* updating docs

* Update projects/rocprofiler-sdk/source/docs/how-to/using-rocprofv3-process-attachment.rst

Co-authored-by: Mark Meserve <mark.meserve@amd.com>

* Update projects/rocprofiler-sdk/source/docs/how-to/using-rocprofv3-process-attachment.rst

Co-authored-by: Mark Meserve <mark.meserve@amd.com>

---------

Co-authored-by: Mark Meserve <mark.meserve@amd.com>
2025-10-07 13:17:55 +05:30
Venkateshwar Reddy Kandula 952d1dabe2 [ROCProfiler-SDK][ROCR] HSA New API changes for HSA_AMD_EXT_API_TABLE_STEP_VERSION 8 (#1182)
* add new hsa ext api for version 8.

* use fmt instead of ostream.

* override rccl from therock

* Update rocprofiler-sdk-continuous_integration.yml

* Update rocprofiler-sdk-continuous_integration.yml

* Update rocprofiler-sdk-continuous_integration.yml

* enable rocr-build

* format

* disable att consecutive-kernels tests.

* Enable ROCR build in code coverage workflow

---------

Co-authored-by: Venkateshwar Reddy Kandula <venkateshwar.kandula1306@gmail.com>
2025-10-06 13:09:39 -05:00
Jason Bonnell ad78611674 rocprofiler-systems Nightly and CI on Ubuntu Jammy/Noble on MI355 and MI325 (#997)
* Initial steps added for rocprofiler-systems-continuous-integration.yml

* Add new line to end of rocprofiler-systems-continuous-integration.yml

* Fix matrix issue in rocprofiler-systems CI workflow

* Update runner to use mi355

* Remove sudo from ROCm download step

* Add Python venv

* Try to install python venv

* Add -y to pip venv install commands

* Add shell: bash to download ROCm step

* Fix issue in if statement

* Fix typo in mv command

* Fix mv command

* Update paths

* add directory in install step

* Use default runner for now while debugging setup

* Add set -e to steps

* debug build step

* Add amdgpu install step

* remove working-directory from amdgpu install step

* add path/ld lib path, add -S argument to run-ci.py

* Fix typo in DCMAKE_PREFIX_PATH

* Add DGPU_TARGETS to run-ci.py command

* add Docker options, remove GPU_TARGETS

* Install amd-smi-lib

* Add DCMAKE_BUILD_TYPE, update path

* Remove mkdir

* Add build dynist cmake arguments

* Update cmake arguments again

* Add missing \ to run-ci.py command

* add libdw dependency

* Add later install step

* Increase timeout of configure/build/test step

* use 16 jobs to try and speed up pipeline time

* Add GHCR image, remove TheRock tarball download step, minor changes for debugging

* Add credentials to container portion of step

* Add package read permissions to ubuntu step

* Update tarball name

* Increase jobs to 16, disable some tests for now due to timeouts

* Modify to only include gpu tests

* Fix configuration

* Enable MPI on run-ci.py run

* Add install MPI step, changed tests to be run

* Enable OMPI flags, enable network counter access

* Use new Docker image names, add privileged option to Docker

* Change cmake build type

* Add fail-fast false option for CI

* Update ROCM_VERSION variable to reflect docker changes

* Specify TARBALL_ROCM_VERSION as separate

* Add MI325 to debug pipeline errors

* Move location of env variables

* Only test on jammy for now, run all tests to assess other issues

* test with branch that contains fix for openmp

* Exclude "ompvv"

We will re-add one ticket is fixed.

* Test: Disable USE_MPI

* Replace TheRock ROCm install with rocm-dev for now

* Try out MI355 noble and MI325 for jammy/noble

* Update amdgpu step to support different ROCm versions

* Remove unused env variables

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-10-06 11:40:58 -04:00
ggottipa-amd c8ab57fe15 correcting typo. (#1222)
fixes SWDEV-557963.
2025-10-06 21:04:55 +05:30
systems-assistant[bot] 774cb67314 SWDEV-489106 - Hip Tests for Linker APIs (#578)
1) Test linking of SPIRV bundled and unbundled code object in runtime
2) Negative Param test for hipLinkAddData API

Change-Id: I7c8167f6d862f5b23f9532f69b6da4fc50e96dcd

Co-authored-by: Rahul Manocha <rmanocha@amd.com>
2025-10-06 08:34:33 -07:00
swargamrambabu e7e38d87f7 SWDEV-546350 - [catch2][dtest] Test cases for hipMemPrefetchAsync_v2 and hipMemAdvise_v2 (#664)
* SWDEV-546350 - [catch2][dtest] Test cases for hipMemPrefetchAsync_v2 and hipMemAdvice_v2

* SWDEV-546350 - Enable tests for NVIDIA, Guard failing tests

* SWDEV-546350 - Add checks for Managed Memory Support

* SWDEV-546350 - Gaurded Numa related things against windows

* SWDEV-546350 - Removed some scenarios which needs fixes, gaurded for NVIDIA

* SWDEV-546350 - Incorporated review comments

* SWDEV-546350 - Corrected File name

* SWDEV-546350 - Resetted to default device, modifed initial data filling ways

---------

Co-authored-by: jainprad <92369414+jainprad@users.noreply.github.com>
2025-10-06 16:59:21 +05:30
Jaydeep 98d6d268a0 SWDEV-556588 - Handle graph node set params and disabled nodes for AQL packet batching. (#1099) 2025-10-06 13:26:12 +05:30
ajanicijamd 02883c3d8d Fixed openmp-vv tests (#1203)
* LD_LIBRARY_PATH was being overridden so tool's libraries could not be found.
2025-10-03 21:33:02 -04:00