Commit-Graf

5781 Incheckningar

Upphovsman SHA1 Meddelande Datum
Tao Sang 2820f91c90 Remove hip-hcc codes: Part four
Remove __HCC__, __HCC_ONLY__, __HCC_CPP__, __HCC_C__,
__HCC_OR_HIP_CLANG__, __HIP_ROCclr__ and their guarded codes.

Remove Hcc codes from directed_tests and samples.

Remove __HIP_PLATFORM_HCC__ and __HIP_PLATFORM_NVCC__ from
some files where they are not necessary.

Add deprecation notice.

Change-Id: I1ae467eafd749d6c25bca204c1724b026be21fce


[ROCm/hip commit: b34dd95124]
2021-01-08 10:53:34 -05:00
DURGESH KROTTAPALLI 2d6af3d103 [dtest] Tests for hipExtLaunchKernelGGL APIs
Added test scenarios for hipExtLaunchKernelGGL
1. verify kernel execution time using events
   passed through argument
2. Verify the API by disabling time flag in
   event creation.

SWDEV-238517 for enhancing hip unit tests

Change-Id: I755adc34a25c58b68041fc927bbffd2a9e6eafde


[ROCm/hip commit: d1c921ffca]
2021-01-08 00:16:54 -05:00
DURGESH KROTTAPALLI d017c25361 [dtest] Tests for hipExtModuleLaunchKernel APIs
Added test scenarios for hipExtModuleLaunchKernel/hipModuleLaunchKernel APIs

 1. Negative Test Scenarios for hipExtModuleLaunchKernel API
 2. Negative Test Scenarios for hipModuleLaunchKernel API
 3. hipExtModuleLaunchKernel API Concurrency Verification
    using global variable
 4. hipExtModuleLaunchKernel API Concurrency Verification
    using total time taken by kernels.
 5. hipExtModuleLaunchKernel API verifying the kernel execution time
    of a particular kernel
 6. hipExtModuleLaunchKernel API verifying by disabling the
    time flag during event creation

SWDEV-238517 for enhancing hip unit tests

Change-Id: I33bbab152d47beba62065c461a07cbcacdc01d97


[ROCm/hip commit: ba3fff4fcd]
2021-01-08 00:05:57 -05:00
Rupam Chetia facdc585cb [dtest] Enabling all negative tests for hipModule* APIs
Enabling all negative test cases for amd as they are functional now
SWDEV-238517 for enhancing hip unit tests

Change-Id: I0bdbf8c192ef94588403c8f027c0399dd5480a00


[ROCm/hip commit: a6d7c7c8ff]
2021-01-07 23:50:56 -05:00
Rupam Chetia 6f39a4f34d [dtest] Additional tests for hipDevice APIs
APIs: hipDeviceGetAttribute(), hipGetDeviceProperties(),
      hipDeviceGetByPCIBusId() and hipDeviceGetPCIBusId()
1. New negative test cases for each API.
2. Additional attributes for testing with hipDeviceGetAttribute()

SWDEV-238517  Enhancing hip unit tests

Change-Id: I3c24462426ffaf3a9317b7de9cd33f7c65791a4b


[ROCm/hip commit: 421df7b02a]
2021-01-07 23:29:14 -05:00
DURGESH KROTTAPALLI 1382775b3a [dtest] Enhanced tests for hipGetDeviceCount hipSetDevice and hipGetDevice
Added following functional and negative scenario tests for
HIP_VISIBLE_DEVICES (HVD), ROCR_VISIBLE_DEVICES (RVD)
CUDA_VISIBLE_DEVICES(CVD)
1. Verifying HVD and RVD - invalid number in sequence
2. Verifying HVD and RVD - dupliates in the beginning of sequence
3. Verifying HVD and RVD - all the duplicates
4. Device count with RVD(max devices and HVD(min devices)
5. Device count with RVD(min devices and HVD(max devices)
6. Device count - RVD(set), HVD(unset), CVD(set)

SWDEV-238517 for enhancing hip unit tests

Change-Id: Ia83e9e9068cbf8cc61cff17311cda1d1f8a38fee


[ROCm/hip commit: f44fe200fd]
2021-01-07 23:23:51 -05:00
Rupam Chetia d9a448a070 [dtest] Tests added for V3 and V4 Code Objects with Static Lds
- Added test for V3 Static Lds code object with sramecc/xnack settings.
- Added test for V4 Static Lds code object.

SWDEV-238517 for enhancing hip unit tests

Change-Id: Ibc4f7e12033dec231d6834ccdd983e3b9e001d60


[ROCm/hip commit: 4c2e91c772]
2021-01-07 23:19:02 -05:00
Jatin Chaudhary 19e55e5536 Populate HIP_CLANG_PATH if its not declared
Change-Id: Ibc1f2e9b3389b6cc7a58579cfb293999ad6e9398


[ROCm/hip commit: 12063cfc45]
2021-01-07 04:15:42 -05:00
Payam ce8c78e5a3 Cleaning lintian warning SWDEV-247996 Part3
Change-Id: I62e5bfc5f17eee12a7a0cfe8ed6fbc35c43ff8c3


[ROCm/hip commit: f9fe063c75]
2021-01-06 11:56:11 -05:00
agodavar add7f87881 SWDEV-245381: Updated guarantee error messages to print based on BUILD_TYPE
Change-Id: Ifafbc075d6b9860da040c72859127c4e638a786f


[ROCm/hip commit: 387d0aa829]
2021-01-05 23:29:50 -05:00
DURGESH KROTTAPALLI c82aa3f29b [dtest] Tests for hipMemcpy2D and hipMemcpy2DAsync APIs
Added following functional and negative scenario tests
for hipMemcpy2D and hipMemcpy2DAsync APIs
 1. Verifying D2H and H2D functionality
 2. Verifying D2D on same device and peer device
 3. Verifying using pinned host memory on same and peer GPU
 4. Negative test scenarios
 5. Verifying hipMemcpy2DAsync API along with kernel launch

SWDEV-238517  Enhancing hip unit tests

Change-Id: I8f447bc7f6bf13cb895f1809f5a2b501baa8782c


[ROCm/hip commit: 7822bf7e42]
2021-01-05 23:23:09 -05:00
Tao Sang c618b6aeff Remove hip-hcc codes: Part three
1.Rename include/hip/hcc_detail/ as include/hip/amd_detail/

2.Rename include/hip/nvcc_detail/ as include/hip/nvidia_detail/

3.Create __HIP_PLATFORM_AMD__ to replace __HIP_PLATFORM_HCC__

4.Create __HIP_PLATFORM_NVIDIA__ to replace __HIP_PLATFORM_NVCC__

After hcc_detail, nvcc_detail, __HIP_PLATFORM_HCC__ and __HIP_PLATFORM_NVCC__
have been removed from upstream, they will be removed from hip runtime.

Change-Id: I1ae457effd739d6c25bca203c1724b026be21fce


[ROCm/hip commit: c2adc70d4d]
2021-01-05 10:39:31 -05:00
sumanthtg 409a10d21f [dtest] Tests for hipMemset3D/hipMemset3DAsync APIs
Negative, Functional and Regression scenarios for
 - hipMemset3D
 - hipMemset3DAsync

SWDEV-238517 for enhancing hip unit tests

Change-Id: Idc5604f728ca1a96ec13876e006120f7a3d69acf


[ROCm/hip commit: f692064d10]
2021-01-05 07:00:48 -05:00
Satyanvesh Dittakavi 5461aac249 SWDEV-263678 - fix rocHPCG mgpu perf drop
Change-Id: I33269fe4f6165d1ed172b19033ab9fcb92f338c3


[ROCm/hip commit: 57dfaab032]
2021-01-05 00:22:12 -05:00
cjatin 80d151d03b Add ELF Flags moved from rocclr
Change-Id: I5febe7bdca80517e9f9492d7930def72db83c14e


[ROCm/hip commit: b96cc0f4c7]
2021-01-04 13:43:16 -05:00
Jatin Chaudhary 95b77b8933 Adding file command as dependency
Change-Id: Ic719c5ce8ad0d99f6a341b5b46927587080fcf2e


[ROCm/hip commit: 45e5e78fcc]
2021-01-04 00:03:53 -05:00
Sarbojit Sarkar c97cd36663 Revert "Fix hipmemset to match CUDA behavior"
This reverts commit f57da595ff.

Change-Id: I53052b25bac4956f3efd124eadc936197f2e466a


[ROCm/hip commit: 36a6baf829]
2021-01-01 00:11:58 -05:00
agodavar e0368a2fba SWDEV-239065 Refactor hipcc, added new perl module hipvars
Change-Id: I2b71ceb2563501c7b2861cd0f2e23d01207b1bc2


[ROCm/hip commit: 547473126e]
2020-12-31 05:41:36 -05:00
agodavar 60998172fb hipmemcpy2D handle height 0
Change-Id: I46bf89e81559c3bfccac0dd0ccd78eee9058c7e3


[ROCm/hip commit: d21cabd890]
2020-12-31 01:41:56 -05:00
agodavar b2af7b1be4 SWDEV-265171 Remove hcc compiler support from hipcc
Change-Id: Ibd06e68dd1f079b2f9e46606bdbfc0a0a780b638


[ROCm/hip commit: ee1d7a339a]
2020-12-30 06:26:09 -05:00
agodavar ccf9c1c482 SWDEV-266089: hipStreamAddCallback argument validation
Change-Id: I3e61006796e88b4e2ba029118c95f3499959257b


[ROCm/hip commit: 2a4568d416]
2020-12-29 05:42:54 -05:00
Sarbojit Sarkar 4088932eec SWDEV-262810: skip duplicate compile flag inclusion
Change-Id: I02ebfb3cbaf6ec25819de0c4952795c6cc949e4d


[ROCm/hip commit: df686db4d8]
2020-12-20 23:26:55 -05:00
Sarbojit Sarkar 3ab852dfe6 SWDEV-265344: fix for dtest build issue
Change-Id: I561546cb792fc0b33c03b17ba2ccf62802f05656


[ROCm/hip commit: 133843bd33]
2020-12-20 23:26:20 -05:00
agodavar 5ae2e9926d SWDEV-263180 : Fix null ptr dereference
Change-Id: Iefc9fa3f195af45a5c5ebe075056246c930a6d84


[ROCm/hip commit: c1dedbd3a0]
2020-12-19 02:02:54 -05:00
jujiang 1ba5585aef SWDEV-265003-Fix hip faq
Change-Id: Ifd29fd9c20ecc905c63fa39fd0768eaca3953aac


[ROCm/hip commit: 021bb7fc61]
2020-12-18 12:21:36 -05:00
Rahul Garg f57da595ff Fix hipmemset to match CUDA behavior
Make hipMemset asynchronous with respect to the host unless
destination pointer refers to pinned host memory.

Change-Id: I5ba230e0cc622aa076dc94692a4c43a57dd2df7b


[ROCm/hip commit: 08f827b28b]
2020-12-17 19:13:31 +00:00
Evgeny 3e7e94ce07 SWDEV-263773 : adding CMAKE_TESTING_TOOL cmake argument
Change-Id: I28df2344d000a0dbef07f45971a9dc92fe07fb27


[ROCm/hip commit: 343f6aafc8]
2020-12-15 17:52:30 -05:00
Evgeny 4156100aee SWDEV-259683 : hipprof: adding hipApiIdByName() method
Change-Id: I1ad2be76efc9fb690ed7c9c2b1091f7eb0c04a31


[ROCm/hip commit: d4df2e880d]
2020-12-15 15:42:10 -05:00
Satyanvesh Dittakavi cc8d3a3188 SWDEV-258754 Fix seg fault hipMemset with device pointer mapped from hipHostRegister
Change-Id: Ifab66b67df172812ebb6eb25c2bac71821f4d614


[ROCm/hip commit: 5b10098da9]
2020-12-15 07:44:34 -05:00
Satyanvesh Dittakavi 390615cc60 Fix hipPointerGetAttributes
Modified hipPointerGetAttributes to support hipHostRegister ptrs and mapped device ptrs from hipHostRegister
Change-Id: I2f4cf12e09578768308f644123d6d4bdccbd77a8


[ROCm/hip commit: a7b5347c90]
2020-12-15 01:40:24 -05:00
jujiang 07aa78a19b SWDEV-249486-Add doxygeny for API hipExtModuleLaunchKernel
Change-Id: Id7451ef4f669238a38ed92ec72008326c85afc4a


[ROCm/hip commit: 942419f217]
2020-12-14 15:34:32 -05:00
Tony 5611739fb3 Correct parsing of target names and supported targets
Change-Id: I6aed72759e6fb4da6834aa80131897dad641e693


[ROCm/hip commit: b573d6233f]
2020-12-14 18:20:56 +00:00
Sarbojit Sarkar 4ff1982a97 Updated review comment
Change-Id: Ic7f9f33dd23c975f2a7a0f0d485a3d2a457c62bb


[ROCm/hip commit: 7c3b1cca22]
2020-12-13 11:30:28 -05:00
Tao Sang 544f512353 Some improvements on hip cmake file
1.Fix unexpected repeated hip runtime lib building
2.Seperate test cmake from top cmake.

Change-Id: I1ae457effd639d6c25bca293c1724b026be21ecd


[ROCm/hip commit: d074c2491f]
2020-12-11 13:32:15 -05:00
Aaron En Ye Shi e2f8d46749 Fix hipTestFMA to support older compiler
The older compiler does not promote integral
arguments to double, instead it uses float.
This patch tries to support the old compiler
headers, and also the newer one.

Change-Id: I01e0b96a82ecddc6230cb5baf2573a318b25445b


[ROCm/hip commit: 09a1c22208]
2020-12-10 14:27:42 -05:00
Rahul Garg a2539f0342 Handle overflow
Fixes SWDEV-261712

Change-Id: I730fcdca8c2640fde9cfdfe2f4b4cf4894807fed


[ROCm/hip commit: 15ecdcf084]
2020-12-09 19:09:43 -05:00
Tao Sang 5d94d2ee98 Remove hip-hcc codes: Part one
Remove hip-hcc codes from hip code base
Simplify hip CMakeLists.txt to exclude hip-hcc
Simplify cmake cmd for hip-rocclr building
Some minor fixes

Change-Id: I1ae357ecfd638d6c25bca293c1724b026be21ecd


[ROCm/hip commit: 186f95ea30]
2020-12-09 15:49:47 -05:00
Aaron En Ye Shi f5829b9eea Add HIP Sample 2_Cookbook/17_llvm_ir_to_executable
HIP supports compiling kernels from LLVM IR into executable.
The device LLVM IR needs to be compiled into a fat binary
object. This device object is embedded into a host object using
llvm-mc directives. Then, any host linker may link the host and
device objects together into an executable. A README was added.

Change-Id: I8ebb6ae86b7ab4290f7cba2eea5584d73a7c453e


[ROCm/hip commit: 8a5b8a36f2]
2020-12-09 15:48:53 -05:00
Aaron En Ye Shi b73fb37615 Add HIP Sample 2_Cookbook/16_assembly_to_executable
HIP supports compiling kernels from assembly into exec.
The device assembly needs to be compiled into a fat binary
object. This device object is embedded into a host object using
llvm-mc directives. Then, any host linker may link the host and
device objects together into an executable. A README is added.

Change-Id: I59d3a8b5363073810ffc3aa0d57f21b0df272369


[ROCm/hip commit: 33f0a41c7a]
2020-12-09 15:48:41 -05:00
Saleel Kudchadker 8c78939796 Honor hipEventDisableTiming event flag
Change-Id: Ia949db96e81b9af467f04ab40d143e8d6faa9394


[ROCm/hip commit: 6da16e90d2]
2020-12-09 15:10:18 -05:00
Jatin Chaudhary be29ce8cbb Updating the gcnArchName to now have target id
Change-Id: Ibd5576e0fb5b46e8f212de4ec57cd96eb1d3c157


[ROCm/hip commit: d056171a20]
2020-12-09 01:22:08 -05:00
Aaron En Ye Shi 9db34cbdd9 Fix hipTestFMA to align with libcxx
The HIP-Clang math headers upstream have been updated
to perform type promotion on math function overloads.
If any argument has integral type, it will be cast to
double.

Change-Id: I38d9e6240c40c4092b946851469498b2ae6500ae


[ROCm/hip commit: 1f0037eefc]
2020-12-08 10:48:29 -08:00
Jatin Chaudhary faa98ed4b9 Adding -Wl,@response_file and @response_file mechanism to hipcc
Change-Id: Ic2053a38034b9366cf82fc01b7ea6b52e0f17077


[ROCm/hip commit: 1242375bf9]
2020-12-07 13:38:35 -05:00
Jatin Chaudhary 446cb45dc4 Adding checks for function, size and params in ihipModuleLaunchKernel to have common message for hipModuleLaunch and hipExtModuleLaunch
Change-Id: I11921ad753930872572571dbfd1c12daba83a725


[ROCm/hip commit: 91ca6e6ab3]
2020-12-07 03:17:14 -05:00
Sudheer Kumar baffa1752d compiler argument update for nvcc
Change-Id: If40caf20543cc29301482deddfb03d6fccb6f3c9


[ROCm/hip commit: 913de5cc5e]
2020-12-06 23:21:14 -05:00
sumanthtg 0d75a5ae15 [dtest] hipOccupancyMaxActiveBlocksPerMultiprocessorWithFlags() - Additional test
Additional test for flag

SWDEV-238517 for enhancing hip unit tests

Change-Id: Ieca443678c122e291b9d4cd16f7198505cd5d6c3


[ROCm/hip commit: 2ae49daff2]
2020-12-06 23:19:23 -05:00
Satyanvesh Dittakavi 9eb0c2d999 Modify atomicAdd float to use clang builtin
SWDEV-261229: Change atomicAdd float implementation to use clang builtin
along with deprecating atomicAddNoRet
Change-Id: I5e98034fec54ee1a2b85d5f56273e34945d49ea3


[ROCm/hip commit: 019c556c7d]
2020-12-03 23:59:10 -05:00
Saleel Kudchadker 1cc4048533 Add a new flag for profilingInfo to record gpu TS
Add a flag to record gpu TS in a marker, also disable marker flush
if there was already a marker submitted before.

Change-Id: I9cdf8e49137690c0050fe9370764dd059855a2f8


[ROCm/hip commit: 390d8c54cb]
2020-12-03 13:45:39 -05:00
agodavar 3cef4c8a97 SWDEV-256810 : hipMemcpy2D API handle width, src/dst pitch 0
Change-Id: I4f60b220624f4235c0c3daf68adcd5a496e93696


[ROCm/hip commit: 77e5c4110e]
2020-12-03 10:34:12 -05:00
Sarbojit Sarkar 4f0fe005b3 SWDEV-258579: hipMemcpy2D better error handling
Change-Id: I09378d6e31da99451e22cbe9276a5ff1ad4a1840


[ROCm/hip commit: 4c1f86699d]
2020-12-03 05:50:42 -05:00