Граф коммитов

4615 Коммитов

Автор SHA1 Сообщение Дата
foreman df9fe63bb9 P4 to Git Change 1203209 by yaxunl@yaxunl_stg_win50 on 2015/10/23 14:39:53
SWDEV-67990 - SPIR-V: Rename SPRV to SPIRV.

Affected files ...

... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/common/frontend_clang.cpp#25 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/common/linker.cpp#134 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/common/v0_8/if_acl.cpp#78 edit
... //depot/stg/opencl/drivers/opencl/compiler/llvm/include/llvm/Support/SPIRV.h#5 edit
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/CMakeLists.txt#10 edit
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/OCL20To12.cpp#4 edit
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/OCL20ToSPIRV.cpp#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/OCL20ToSPRV.cpp#2 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/OCL21ToSPIRV.cpp#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/OCL21ToSPRV.cpp#2 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/OCLUtil.cpp#7 edit
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/OCLUtil.h#6 edit
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/SPIRVInternal.h#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/SPIRVLowerBool.cpp#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/SPIRVLowerOCLBlocks.cpp#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/SPIRVReader.cpp#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/SPIRVToOCL20.cpp#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/SPIRVUtil.cpp#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/SPIRVWriter.cpp#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/SPRVInternal.h#25 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/SPRVLowerBool.cpp#2 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/SPRVLowerOCLBlocks.cpp#5 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/SPRVReader.cpp#35 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/SPRVToOCL20.cpp#6 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/SPRVUtil.cpp#29 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/SPRVWriter.cpp#35 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPIRVBasicBlock.cpp#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPIRVBasicBlock.h#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPIRVDebug.cpp#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPIRVDebug.h#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPIRVDecorate.cpp#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPIRVDecorate.h#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPIRVEntry.cpp#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPIRVEntry.h#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPIRVEnum.h#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPIRVError.h#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPIRVErrorEnum.h#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPIRVExtInst.h#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPIRVFunction.cpp#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPIRVFunction.h#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPIRVInstruction.cpp#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPIRVInstruction.h#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPIRVModule.cpp#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPIRVModule.h#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPIRVOpCode.h#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPIRVOpCodeEnum.h#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPIRVStream.cpp#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPIRVStream.h#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPIRVType.cpp#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPIRVType.h#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPIRVUtil.h#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPIRVValue.cpp#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPIRVValue.h#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPRV.h#2 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPRVBasicBlock.cpp#4 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPRVBasicBlock.h#3 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPRVDebug.cpp#3 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPRVDebug.h#3 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPRVDecorate.cpp#6 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPRVDecorate.h#5 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPRVEntry.cpp#11 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPRVEntry.h#17 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPRVEnum.h#14 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPRVError.h#2 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPRVErrorEnum.h#3 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPRVExtInst.h#5 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPRVFunction.cpp#6 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPRVFunction.h#6 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPRVInstruction.cpp#10 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPRVInstruction.h#27 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPRVModule.cpp#24 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPRVModule.h#16 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPRVOpCode.h#12 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPRVOpCodeEnum.h#7 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPRVStream.cpp#7 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPRVStream.h#8 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPRVType.cpp#8 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPRVType.h#12 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPRVUtil.h#11 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPRVValue.cpp#3 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/SPRVValue.h#13 move/delete
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/SPIRV/libSPIRV/libSPIRV.h#1 move/add
... //depot/stg/opencl/drivers/opencl/compiler/llvm/tools/llvm-spirv/llvm-spirv.cpp#6 edit


[ROCm/clr commit: 02672aa999]
2015-10-23 15:38:21 -04:00
foreman bfde0e65a6 P4 to Git Change 1202994 by johtaylo@johtaylo-JTBUILDER03-increment on 2015/10/23 03:00:11
SWDEV-2 - Change OpenCL version number from 1921 to 1922.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1668 edit


[ROCm/clr commit: ba3f10d5e2]
2015-10-23 03:08:12 -04:00
foreman 4da0804ed5 P4 to Git Change 1202517 by johtaylo@johtaylo-JTBUILDER03-increment on 2015/10/22 03:00:12
SWDEV-2 - Change OpenCL version number from 1920 to 1921.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1667 edit


[ROCm/clr commit: a56ada96ac]
2015-10-22 03:18:59 -04:00
foreman f41340272e P4 to Git Change 1202371 by mbareghe@mbareghe_stg_win30 on 2015/10/21 18:22:36
SWDEV-79399 - OpenCL printf does not print correctly when the printf builtin function is called twice - clear the local printf info each time

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.cpp#305 edit


[ROCm/clr commit: 6800b9f003]
2015-10-21 18:35:09 -04:00
foreman 4870c8d7b7 P4 to Git Change 1202323 by xcui@merged_opencl_jxcwin on 2015/10/21 17:01:58
SWDEV-79347 - added a env variable to change the size of the minimum system memory requirement to avoid downgrade OCL support. The default is 2, which means 2GB

	code review:
	http://ocltc.amd.com/reviews/r/8754/

	precheckin:
	http://ocltc.amd.com:8111/viewModification.html?modId=60516&personal=true&buildTypeId=&tab=vcsModificationBuilds&show_all_builds=true

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/cpu/cpudevice.cpp#278 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#532 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/flags.hpp#243 edit


[ROCm/clr commit: 0bb91b89ba]
2015-10-21 17:35:18 -04:00
foreman 1508bce03f P4 to Git Change 1202262 by asalmanp@asalmanp-opencl-stg on 2015/10/21 15:36:48
SWDEV-79278 - [OpenCL][Baffin/Ellesmere BU] Exposing Baffin and Ellesmere for bring-up with dummy names. The real device names will be exposed later.
	ReviewBoardURL = http://ocltc.amd.com/reviews/r/8752/

Affected files ...

... //depot/stg/opencl/drivers/opencl/compiler/legacy-lib/utils/v0_8/target_mappings.h#3 edit
... //depot/stg/opencl/drivers/opencl/compiler/legacy-lib/utils/v0_8/target_mappings_amdil.h#3 edit
... //depot/stg/opencl/drivers/opencl/compiler/legacy-lib/utils/v0_8/target_mappings_amdil64.h#3 edit
... //depot/stg/opencl/drivers/opencl/compiler/legacy-lib/utils/v0_8/target_mappings_hsail.h#3 edit
... //depot/stg/opencl/drivers/opencl/compiler/legacy-lib/utils/v0_8/target_mappings_hsail64.h#3 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/v0_8/target_mappings.h#35 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/v0_8/target_mappings_amdil.h#30 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/v0_8/target_mappings_amdil64.h#27 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/v0_8/target_mappings_hsail.h#26 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/v0_8/target_mappings_hsail64.h#21 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudefs.hpp#129 edit


[ROCm/clr commit: 71585bb8cc]
2015-10-21 15:49:55 -04:00
foreman e65b9df0f0 P4 to Git Change 1201928 by johtaylo@johtaylo-JTBUILDER03-increment on 2015/10/21 03:00:10
SWDEV-2 - Change OpenCL version number from 1919 to 1920.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1666 edit


[ROCm/clr commit: 12704edd82]
2015-10-21 03:16:56 -04:00
foreman 21014b2703 P4 to Git Change 1201783 by gandryey@gera-w8 on 2015/10/20 18:03:34
SWDEV-79151 - clenqueuereadImage is slow when using a pinned buffer and a row_picth!0
	- Add a check if the provided rowPitch is equal to the actual transfer width. SDMA doesn't support row/slice pitches, thus runtime still has to fall back to compute in other cases

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_memobj.cpp#78 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpublit.cpp#120 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/memory.cpp#122 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/memory.hpp#92 edit


[ROCm/clr commit: 922e14c46d]
2015-10-20 18:37:35 -04:00
foreman ca83b79cff P4 to Git Change 1201765 by rili@rili_opencl_stg on 2015/10/20 17:48:08
SWDEV-79077 - Disable >4GB large single allocation for SI because SI is using AMDIL path which doesn't not support 64bits NDRange yet.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpusettings.cpp#332 edit


[ROCm/clr commit: b817bb5898]
2015-10-20 18:31:32 -04:00
foreman 6c2eebc4d0 P4 to Git Change 1201608 by emankov@em-hsa-amd on 2015/10/20 14:12:09
SWDEV-79234 - ORCA RT: Fix memory leak in Program::addDeviceProgram() on redundant call of createProgram()

	[Synopsis]
	Leak has been observed since CL 1191713:
	ECR #304775 - Remove EG/NI support - Remove devProgramsNoOpt_ field

	[Testing] pre check-in
	          http://ocltc.amd.com:8111/viewModification.html?modId=60549&personal=true&buildTypeId=&tab=vcsModificationBuilds&show_all_builds=true

	[Reviewer] German Andryeyev
	           http://ocltc.amd.com/reviews/r/8741/

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/platform/program.cpp#72 edit


[ROCm/clr commit: cf9c762159]
2015-10-20 14:32:02 -04:00
foreman c39ed65e6e P4 to Git Change 1201593 by kzhuravl@linu-kzhuravl-oclhsa on 2015/10/20 13:37:07
SWDEV-76911 - Boltzmann loader support

	[Loader]
	  - Introduce Context::SegmentFreeze
	    - Called by loader once executable is being frozen
	    - [HRT] Causes memory transfer to appropriate system or local memory
	    - [ORT] Does nothing
	  - Change loading of kernel symbol to read values from the code object
	  - Change debugger backdoor initialization to use Context::SegmentCopy

	[HSA RT]
	  - Remove outdated code
	  - Introduce SegmentMemory, BaseProfileMemory, FullProfileMemory classes
	    - Manage memory allocation/deallocation/copying/freezing
	  - Minor cleanups

	[ORCA RT]
	  - Add empty ORCAHSALoaderContext::SegmentFreeze

	Testing: precheckin (http://ocltc.amd.com:8111/viewModification.html?modId=60551&personal=true&tab=vcsModificationBuilds)
	ReviewBoardURL: http://ocltc.amd.com/reviews/r/8681/

Affected files ...

... //depot/stg/opencl/drivers/opencl/compiler/sc/HSAIL/ext/loader/executable.cpp#14 integrate
... //depot/stg/opencl/drivers/opencl/compiler/sc/HSAIL/ext/loader/executable.hpp#10 integrate
... //depot/stg/opencl/drivers/opencl/compiler/sc/HSAIL/ext/loader/loaders.cpp#4 integrate
... //depot/stg/opencl/drivers/opencl/compiler/sc/HSAIL/ext/loader/loaders.hpp#4 integrate
... //depot/stg/opencl/drivers/opencl/compiler/sc/HSAIL/include/amd_hsa_loader.hpp#6 integrate
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuprogram.hpp#62 edit


[ROCm/clr commit: e3ff5a9c7d]
2015-10-20 13:54:35 -04:00
foreman 3abda1bcae P4 to Git Change 1201490 by xcui@merged_opencl_jxcwin on 2015/10/20 10:47:18
SWDEV-41018 -  if system is equal to or less than 2GB memory, disable CPU and APU for OpenCL, and force the device to be 1.2 if it is a discrete GPU.

	precheckin:
	http://ocltc.amd.com:8111/viewModification.html?modId=60516&personal=true&buildTypeId=&tab=vcsModificationBuilds&show_all_builds=true
	code review:
	http://ocltc.amd.com/reviews/r/8738/

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/cpu/cpudevice.cpp#277 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#531 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpusettings.cpp#331 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpusettings.hpp#95 edit


[ROCm/clr commit: 25bfbb8085]
2015-10-20 11:02:14 -04:00
foreman f996550c29 P4 to Git Change 1201357 by johtaylo@johtaylo-JTBUILDER03-increment on 2015/10/20 03:00:10
SWDEV-2 - Change OpenCL version number from 1918 to 1919.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1665 edit


[ROCm/clr commit: 3b9fcfeb89]
2015-10-20 03:13:34 -04:00
foreman ccf1cea91c P4 to Git Change 1201301 by skudchad@skudchad_test_win_opencl2 on 2015/10/19 19:19:44
SWDEV-77172 - IOMMUv2 changes for Windows 10
	- Pass the GPUVM offset to MonitoredFence GPUVA as well
	- Other minor changes for SVM

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/8729/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDevice.cpp#148 edit


[ROCm/clr commit: 4da269fbb6]
2015-10-19 19:29:07 -04:00
foreman c84b3479f8 P4 to Git Change 1201249 by jatang@jatang-opencl-hsa-stg2 on 2015/10/19 16:47:00
SWDEV-78799 - Fix a division by 0 error.

	Occasionally the profiling duration of some light weight kernel is 0, and would cause division by 0 error to the WLAlgorithmSmooth algorithm. We can just skip collecting this duration for the adaption algorithm.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuwavelimiter.cpp#11 edit


[ROCm/clr commit: b06ee3a1a9]
2015-10-19 17:41:21 -04:00
foreman 2eed23e6b8 P4 to Git Change 1201004 by johtaylo@johtaylo-JTBUILDER03-increment on 2015/10/19 03:00:10
SWDEV-2 - Change OpenCL version number from 1917 to 1918.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1664 edit


[ROCm/clr commit: 8b5af23596]
2015-10-19 05:36:26 -04:00
foreman de1cd3a012 P4 to Git Change 1200947 by johtaylo@johtaylo-JTBUILDER03-increment on 2015/10/18 03:00:12
SWDEV-2 - Change OpenCL version number from 1916 to 1917.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1663 edit


[ROCm/clr commit: 7a1f3e4bc4]
2015-10-18 03:11:22 -04:00
foreman 8569f11ad6 P4 to Git Change 1200936 by johtaylo@johtaylo-JTBUILDER03-increment on 2015/10/17 03:00:10
SWDEV-2 - Change OpenCL version number from 1915 to 1916.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1662 edit


[ROCm/clr commit: 9ab565c5e1]
2015-10-17 03:11:14 -04:00
foreman 4da631e2e2 P4 to Git Change 1200905 by bdhanase@bala_workpc_ocl on 2015/10/16 18:57:48
SWDEV-78103 - If USWC size is less than 1.5 GB, then report 50% else report 75%.

	Reviewed by: German

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#530 edit


[ROCm/clr commit: 54aed91b3b]
2015-10-16 19:04:45 -04:00
foreman df9060dc93 P4 to Git Change 1200677 by mbareghe@mbareghe_stg_win30 on 2015/10/16 10:11:30
SWDEV-78915 - SYCL - segfault building SPIR binary where the kernel name exceeds 255 characters - changed kernel/arg name type from char[] to string to avoid the 256 character limitation.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.cpp#304 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.hpp#122 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuprogram.cpp#211 edit


[ROCm/clr commit: fab877c56d]
2015-10-16 10:20:54 -04:00
foreman 2ca4a95672 P4 to Git Change 1200565 by johtaylo@johtaylo-JTBUILDER03-increment on 2015/10/16 03:00:12
SWDEV-2 - Change OpenCL version number from 1914 to 1915.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1661 edit


[ROCm/clr commit: 108aa6e8ee]
2015-10-16 03:13:47 -04:00
foreman c296a56b07 P4 to Git Change 1200252 by jatang@jatang-opencl-hsa-stg1 on 2015/10/15 11:56:48
SWDEV-56468 - Back out changelist 1200206

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.cpp#303 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.hpp#121 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuvirtual.cpp#387 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuwavelimiter.cpp#10 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuwavelimiter.hpp#7 edit


[ROCm/clr commit: 4b286ad468]
2015-10-15 12:08:34 -04:00
foreman 5a8f670bc5 P4 to Git Change 1200206 by jatang@jatang-opencl-hsa-stg1 on 2015/10/15 10:08:51
SWDEV-56468 - Support wave limiter in HSAIL path.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.cpp#302 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.hpp#120 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuvirtual.cpp#386 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuwavelimiter.cpp#9 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuwavelimiter.hpp#6 edit


[ROCm/clr commit: 19ecdf3fd1]
2015-10-15 10:21:27 -04:00
foreman 284ed2054e P4 to Git Change 1200078 by johtaylo@johtaylo-JTBUILDER03-increment on 2015/10/15 03:00:12
SWDEV-2 - Change OpenCL version number from 1913 to 1914.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1660 edit


[ROCm/clr commit: 4996170c79]
2015-10-15 03:14:10 -04:00
foreman fa50aea123 P4 to Git Change 1199594 by johtaylo@johtaylo-JTBUILDER03-increment on 2015/10/14 03:00:22
SWDEV-2 - Change OpenCL version number from 1912 to 1913.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1659 edit


[ROCm/clr commit: 9e6ad02828]
2015-10-14 03:10:19 -04:00
foreman f5481fdfa3 P4 to Git Change 1199371 by lmoriche@lmoriche_opencl_dev on 2015/10/13 16:29:28
SWDEV-78467 - Add the LiquidFlashFile implementation (except for readBlocks)

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/build/Makefile.api#121 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_lqdflash_amd.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_lqdflash_amd.h#2 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/khronos/headers/opencl2.0/CL/cl_ext.h#19 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/object.hpp#16 edit


[ROCm/clr commit: ff337b0409]
2015-10-13 16:47:28 -04:00
foreman 11f76998d2 P4 to Git Change 1199058 by johtaylo@johtaylo-JTBUILDER03-increment on 2015/10/13 03:00:10
SWDEV-2 - Change OpenCL version number from 1911 to 1912.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1658 edit


[ROCm/clr commit: 042540f231]
2015-10-13 03:07:51 -04:00
foreman 08a0eaacf7 P4 to Git Change 1198818 by johtaylo@johtaylo-JTBUILDER03-increment on 2015/10/12 03:00:12
SWDEV-2 - Change OpenCL version number from 1910 to 1911.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1657 edit


[ROCm/clr commit: bb8e739493]
2015-10-12 03:41:45 -04:00
foreman 22ca65a9a5 P4 to Git Change 1198720 by johtaylo@johtaylo-JTBUILDER03-increment on 2015/10/11 03:00:10
SWDEV-2 - Change OpenCL version number from 1909 to 1910.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1656 edit


[ROCm/clr commit: 9cc03f252a]
2015-10-11 03:11:37 -04:00
foreman f151274d32 P4 to Git Change 1198686 by johtaylo@johtaylo-JTBUILDER03-increment on 2015/10/10 03:00:11
SWDEV-2 - Change OpenCL version number from 1908 to 1909.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1655 edit


[ROCm/clr commit: 63583a8877]
2015-10-10 03:09:01 -04:00
foreman 06030ebec4 P4 to Git Change 1198299 by johtaylo@johtaylo-JTBUILDER03-increment on 2015/10/09 03:00:11
SWDEV-2 - Change OpenCL version number from 1907 to 1908.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1654 edit


[ROCm/clr commit: 5205fd633d]
2015-10-09 03:10:32 -04:00
foreman ff2d1b3000 P4 to Git Change 1198011 by emankov@em-hsa-amd on 2015/10/08 11:16:29
SWDEV-77522 - fix for erroneous CL_DEVICE_VERSION reporting by RT for HSAIL.

	[Synopsis]
	On a CI+ Device (KV, for example) if GPU_HSAIL_ENABLE=1 (which forcing HSAIL) CL_DEVICE_VERSION reported by RT is 1.2; if GPU_HSAIL_ENABLE=0 (default for now), then CL_DEVICE_VERSION = 2.0. It looks like this behaviour exists since then HSAIL was based on EDG, which supports only OpenCL 1.2. Now when HSAIL is based on Clang and supports OpenCL 2.0, there is no need in lowering CL Device Version at all for all CI+ devices nomatter the default path is (HSAIL or AMDIL).

	This bug is a stopper for enabling HSAIL by default for OpenCL 1.2. Actually the problem occurs with OpenCL 2.0 programs when forcing them on HSAIL but with -cl-std=CL2.0 option, since they couldn't be executed on 1.2 device.

	Testing: Pre check-in.

	Reviewer: German Andryeyev

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpusettings.cpp#330 edit


[ROCm/clr commit: 3e0185a205]
2015-10-08 11:27:15 -04:00
foreman 6981732926 P4 to Git Change 1197854 by johtaylo@johtaylo-JTBUILDER03-increment on 2015/10/08 03:00:13
SWDEV-2 - Change OpenCL version number from 1906 to 1907.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1653 edit


[ROCm/clr commit: 74b1183f97]
2015-10-08 03:15:51 -04:00
foreman ced0ffc42c P4 to Git Change 1197728 by xcui@merged_opencl_jxcwin on 2015/10/07 18:15:58
SWDEV-59579 - using existing function to simplify the code.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.cpp#301 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuvirtual.cpp#385 edit


[ROCm/clr commit: bc8a28c577]
2015-10-07 19:24:44 -04:00
foreman c3954f8fdf P4 to Git Change 1197441 by johtaylo@johtaylo-JTBUILDER03-increment on 2015/10/07 03:00:11
SWDEV-2 - Change OpenCL version number from 1905 to 1906.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1652 edit


[ROCm/clr commit: 66a50cca4a]
2015-10-07 03:07:15 -04:00
foreman c7adad3eb0 P4 to Git Change 1197295 by gandryey@gera-ubuntu14 on 2015/10/06 14:50:12
SWDEV-78052 - [CQE-OCL][DTB][QR][LNX]RQ conf test "Multiple device context" fails in few asics due to CL#1196902
	- Restore synchronization on the DMA engine. OCL doesn't require a sync, because resource isn't busy on the CAL device. However without sync there are less CBs available. Conformanace multidevice test will create around 60 queues, instead of 70

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDevice.cpp#147 edit


[ROCm/clr commit: 86bc25cad2]
2015-10-06 15:00:30 -04:00
foreman fb0cfaeef3 P4 to Git Change 1197288 by mbareghe@mbareghe_stg_win30 on 2015/10/06 14:29:07
SWDEV-78024 - SYCL - Issue with printf when printing a string without format specifier - removed the condition to expand printf only if it has more than one arguemnt.

Affected files ...

... //depot/stg/opencl/drivers/opencl/compiler/llvm32/lib/Target/AMDIL/AMDILPrintfConvert.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/compiler/llvm32/test/CodeGen/AMDIL/printf_without_format_specifier.ll#1 add
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuprintf.cpp#39 edit


[ROCm/clr commit: cb963bf9eb]
2015-10-06 14:37:59 -04:00
foreman babb59fc2c P4 to Git Change 1197115 by johtaylo@johtaylo-JTBUILDER03-increment on 2015/10/06 03:00:11
SWDEV-2 - Change OpenCL version number from 1904 to 1905.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1651 edit


[ROCm/clr commit: 8b5fd219a9]
2015-10-06 03:10:19 -04:00
foreman 6039d4e884 P4 to Git Change 1196959 by jatang@jatang-opencl-hsa-stg2 on 2015/10/05 15:47:53
SWDEV-77321 - Change some Wave Limiter variables to 64bit to avoid integer overflow.

	Luxmark v3.0 is getting performance regression due to incorrect adapting result caused by integer overflow:

	ratio_[wave] = trial_[wave] * 100 / reference_[wave];

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuwavelimiter.hpp#5 edit


[ROCm/clr commit: 112a70b4ec]
2015-10-05 15:53:47 -04:00
foreman eb828d74ed P4 to Git Change 1196935 by jatang@jatang-ocl-lnx1 on 2015/10/05 14:37:02
SWDEV-77321 - Runtime to replace metadata LimitWave with WavePerSimdHint.

	Compiler has changed LimitWave to WavePerSimdHint, so runtime need to make corresponding change to have the Wave Limiter continue working.

	WavePerSimdHint=1,...,10 will be dealt with later.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/device.hpp#258 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.cpp#300 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.hpp#119 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuwavelimiter.cpp#8 edit


[ROCm/clr commit: d4d9167613]
2015-10-05 14:48:16 -04:00
foreman 0068d75f03 P4 to Git Change 1196902 by gandryey@gera-dev-w7 on 2015/10/05 13:18:47
SWDEV-77981 - Clean-up CAL map/unmap functionality
	- Keep map information only for SDMA copy. GSL map/unmap doesn't require any tracking
	- simplify the interface to return the address from map()

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuresource.cpp#229 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuresource.hpp#85 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/EventQueue.h#7 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLContext.cpp#80 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDevice.cpp#146 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDevice.h#58 edit


[ROCm/clr commit: 7b6c0331d1]
2015-10-05 13:25:42 -04:00
foreman c773efee15 P4 to Git Change 1196785 by johtaylo@johtaylo-JTBUILDER03-increment on 2015/10/05 03:00:11
SWDEV-2 - Change OpenCL version number from 1903 to 1904.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1650 edit


[ROCm/clr commit: 2d8dd20ed1]
2015-10-05 03:09:44 -04:00
foreman dbfe5b098c P4 to Git Change 1196768 by johtaylo@johtaylo-JTBUILDER03-increment on 2015/10/04 03:00:12
SWDEV-2 - Change OpenCL version number from 1902 to 1903.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1649 edit


[ROCm/clr commit: a19486245f]
2015-10-04 03:09:34 -04:00
foreman 9534cfef40 P4 to Git Change 1196757 by johtaylo@johtaylo-JTBUILDER03-increment on 2015/10/03 03:00:11
SWDEV-2 - Change OpenCL version number from 1901 to 1902.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1648 edit


[ROCm/clr commit: 1acc88b862]
2015-10-03 03:11:07 -04:00
foreman 7b852c18c0 P4 to Git Change 1196584 by gandryey@gera-dev-w7 on 2015/10/02 14:01:41
SWDEV-77880 - Enable memory dependency tracking for HSAIL path
	- Use read/write attribute provided by the compiler for async execution optimization

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.cpp#299 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.hpp#118 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuvirtual.cpp#384 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuvirtual.hpp#136 edit


[ROCm/clr commit: f8648f412d]
2015-10-02 14:19:07 -04:00
foreman 829d3711e9 P4 to Git Change 1196477 by johtaylo@johtaylo-JTBUILDER03-increment on 2015/10/02 03:00:10
SWDEV-2 - Change OpenCL version number from 1900 to 1901.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1647 edit


[ROCm/clr commit: f5c30d2ca0]
2015-10-02 03:08:31 -04:00
foreman 367795798b P4 to Git Change 1196382 by rili@rili_opencl_stg on 2015/10/01 16:18:37
SWDEV-58155 -  Reduce maximum size of queue on device from 16MB to 8MB.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#529 edit


[ROCm/clr commit: 3847ee8ceb]
2015-10-01 16:27:15 -04:00
foreman 5c65ad4b9b P4 to Git Change 1196211 by nhaustov@nhaustov_hsa on 2015/10/01 08:27:23
SWDEV-76911 - Bug 11070: ViennaCL fails in amd::hsa::loader::Executable::Destroy

	Destructors of global variables run in undefined order, so loader cannot
	be global. Encapsulate loader functionality in Loader class and link its lifecycle
	to Runtime.
	In HSA Runtime, create Loader as part of Runtime singleton.
	In ORCA Runtime, create Loader as part of HSAILProgram class.

	Testing: smoke, pre-checkin

Affected files ...

... //depot/stg/opencl/drivers/opencl/compiler/sc/HSAIL/ext/amdhsacod/amdhsacod.cpp#10 integrate
... //depot/stg/opencl/drivers/opencl/compiler/sc/HSAIL/ext/loader/executable.cpp#12 integrate
... //depot/stg/opencl/drivers/opencl/compiler/sc/HSAIL/ext/loader/executable.hpp#8 integrate
... //depot/stg/opencl/drivers/opencl/compiler/sc/HSAIL/include/amd_hsa_loader.hpp#5 integrate
... //depot/stg/opencl/drivers/opencl/compiler/tools/aoc2/aoc2.cpp#78 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuprogram.cpp#210 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuprogram.hpp#61 edit


[ROCm/clr commit: f670ae2f8d]
2015-10-01 08:37:19 -04:00
foreman 99e52b701a P4 to Git Change 1196178 by johtaylo@johtaylo-JTBUILDER03-increment on 2015/10/01 03:00:11
SWDEV-2 - Change OpenCL version number from 1899 to 1900.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1646 edit


[ROCm/clr commit: 90efd5a216]
2015-10-01 03:07:44 -04:00
foreman fb7f0bf1ef P4 to Git Change 1195825 by yaxunl@yaxunl_stg_win50 on 2015/09/30 07:45:04
SWDEV-77682 - Wave Limiter: Add __attribute__((amd_hint_waves_per_simd(n))) to FE for setting waves/simd hint per kernel. 0 for adaptive wave limitting. 1~10 for fixed waves/simd.
	Add query of WavesPerSimdHint metadata to compiler lib. HSAI path shouls use aclQueryInfo RT_WAVES_PER_SIMD_HINT to get the waves/simd hint value.
	This should provide a flexible workaround for bug SWDEV-56552  [CQE OCL][PERF][LNX][QR][G] 19% Perf drop is observed with chunkBp kernel in Carrizo.

Affected files ...

... //depot/stg/opencl/drivers/opencl/compiler/clang/include/clang/Basic/Attr.td#9 edit
... //depot/stg/opencl/drivers/opencl/compiler/clang/lib/CodeGen/CodeGenFunction.cpp#16 edit
... //depot/stg/opencl/drivers/opencl/compiler/clang/lib/Sema/SemaDeclAttr.cpp#8 edit
... //depot/stg/opencl/drivers/opencl/compiler/clc/src/e2lModule.cpp#95 edit
... //depot/stg/opencl/drivers/opencl/compiler/clc/src/e2lModule.h#44 edit
... //depot/stg/opencl/drivers/opencl/compiler/clc/src/oclEntry.cpp#49 edit
... //depot/stg/opencl/drivers/opencl/compiler/clc/src/oclMeta.cpp#32 edit
... //depot/stg/opencl/drivers/opencl/compiler/clc/src/oclMeta.h#32 edit
... //depot/stg/opencl/drivers/opencl/compiler/edg/src/amd_ocl_attribute.c#26 edit
... //depot/stg/opencl/drivers/opencl/compiler/edg/src/attribute.c#29 edit
... //depot/stg/opencl/drivers/opencl/compiler/edg/src/err_codes.h#42 edit
... //depot/stg/opencl/drivers/opencl/compiler/edg/src/err_data.h#56 edit
... //depot/stg/opencl/drivers/opencl/compiler/edg/src/il_def.h#57 edit
... //depot/stg/opencl/drivers/opencl/compiler/edg/src/il_display.c#25 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/common/v0_8/if_acl.cpp#77 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/gpu/MDParser/AMDILMDInterface.h#3 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/gpu/MDParser/AMDILMDParser.l#4 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/gpu/MDParser/AMDILMDTypes.cpp#3 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/gpu/MDParser/lex.yy.cpp#5 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/gpu/metadata.cpp#9 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/include/v0_8/aclEnums.h#23 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/include/v0_8/aclStructs.h#18 edit
... //depot/stg/opencl/drivers/opencl/compiler/llvm/include/llvm/Transforms/IPO/AMDKernelPerfHint.h#4 edit
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/Target/HSAIL/HSAILKernelManager.cpp#37 edit
... //depot/stg/opencl/drivers/opencl/compiler/llvm/lib/Transforms/IPO/AMDKernelPerfHint.cpp#6 edit
... //depot/stg/opencl/drivers/opencl/compiler/llvm32/include/llvm/Transforms/IPO/AMDKernelPerfHint.h#3 edit
... //depot/stg/opencl/drivers/opencl/compiler/llvm32/lib/Target/AMDIL/AMDILKernelManager.cpp#4 edit
... //depot/stg/opencl/drivers/opencl/compiler/llvm32/lib/Transforms/IPO/AMDKernelPerfHint.cpp#6 edit
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/llc/opt/wave_limiter/explicit.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/tlst/llc_opt.tlst#57 edit
... //depot/stg/opencl/drivers/opencl/tests/ocltst/module/complib/CLAssumptionCheck.cpp#44 edit
... //depot/stg/opencl/drivers/opencl/tests/ocltst/module/complib/CLEnumCheck.cpp#48 edit


[ROCm/clr commit: 120b8fba7c]
2015-09-30 10:30:21 -04:00