sdashmiz
2c010dec17
SWDEV-325711: Add userobject functions for graph
...
- add user obj APIs for creating release and retain of user onbjects
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com >
Change-Id: I0bf2999c77e44269565b27c31c7c1461f8a160a2
2022-08-17 14:31:43 -04:00
Laurent Morichetti
a682934251
SWDEV-351980 - Acquire the code object lock in StatCO::getStatFuncName
...
Change-Id: I52ce2530d12fbe47e575feb2aab39bbfdfebd201
2022-08-16 19:43:15 -04:00
Ajay
113cc9ae2a
SWDEV-344168 - hipVmm functionality memory check fix
...
Change-Id: Ia1de96ac9dbcbfb6a94a234aec3bf6cb51961799
2022-08-16 11:04:56 -07:00
kjayapra-amd
9e9754be80
SWDEV-351508 - Change the data_kind to BC from FATBIN, since unbundling happens in runtime now.
...
Change-Id: Iaf6e85637edaa92171edc4edc650a0b4598bf625
2022-08-12 19:52:29 -04:00
Jaydeep Patel
5b6ffb6380
SWDEV-351200 - Validate desc.
...
Change-Id: Ic8690c9a2134ca42f4bec626ca787587a32856fb
2022-08-11 07:17:21 +00:00
Sarbojit Sarkar
db35b25d3f
SWDEV-344210 - Fixed page fault when mempool accessed from remote device
...
Change-Id: I759296a3177560719759f7dd8766e07664285689
2022-08-11 00:02:29 -04:00
Jaydeep Patel
35051e778d
SWDEV-351031 - Any bit other than the rightmost 4 bits shouldn't be set
...
Change-Id: I6c834f491ce393eb37259eabc603220c5b5f164e
2022-08-10 23:30:22 -04:00
Ajay
b380a95597
SWDEV-348678 - hipManagedVar to initialize on all devices
...
Change-Id: Id714b56e89e4930ee067f3a7472a0029057d2711
2022-08-10 16:54:19 +00:00
Satyanvesh Dittakavi
c33a6b4a03
SWDEV-350479 - Add missing hiprtcVersion symbol on Windows
...
Change-Id: Ifcb737adddade80ebe91a50812c96c585d7d3217
2022-08-09 03:15:12 -04:00
Satyanvesh Dittakavi
9299d5febb
SWDEV-336448 - hiprtc dll versioning on windows
...
Change-Id: I6ab6f975bcd7cd2fb27d59d0860a6dbe8434970e
2022-08-09 00:50:21 -04:00
Jaydeep Patel
366050b14f
SWDEV-346382 - Don't fall back to sync for hipMemcpyAsync from host to device.
...
Change-Id: I5aab9041f87c549a03c86e95a39bfa437126a99b
2022-08-05 02:32:55 -04:00
sdashmiz
58c5e17c5f
SWDEV-347595 - return proper error
...
- if flags are not supported
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com >
Change-Id: Id7570d2c5f3d1169da33561f05c278dcd1834db6
2022-08-04 15:57:15 -04:00
kjayapra-amd
4bba4faa0c
SWDEV-346018 - Support unbundling of code object in runtime for hiprtc.
...
Change-Id: Idda30def999b28500738c7b48560d36ca6a8e730
2022-08-03 17:57:29 -04:00
Satyanvesh Dittakavi
958b97b433
SWDEV-2 - Fix hiprtcCompileProgram
...
- hiprtcCompileProgram should create isa with temp name when
program name is not provided along with --save-temps option
Change-Id: I47974e2ac56336c851531622ff7d2a3ffb53455e
2022-08-02 16:16:31 -04:00
Sarbojit Sarkar
0444d20e07
SWDEV-338732 - Made hipMemset* default async
...
Change-Id: I0ebf6473b6825162fc828bb8cac47743e14ffd19
2022-08-02 07:14:57 -04:00
Jaydeep Patel
c61701323e
SWDEV-329516 - Propogate hipErrorSharedObjectInitFailed from getStatFunc.
...
Change-Id: I60160f8d0c0dab20649a4e7c03448f4ae9a9c95b
2022-08-02 01:50:50 -04:00
Laurent Morichetti
9f09ca929e
Improve hip_prof_api.h's readability
...
- Don't pass uint32_t arguments by reference.
- Use nullptr instead of NULL.
- Don't add frivolous typedefs.
- Use correct types when available instead of generic integral types.
- Make all roctracer callbacks extern "C" to prepare for a future change
that will be removing their declaration from hip_runtime_api.h.
- Rename cb/sem sync and release functions -> reader_lock/writer_lock
acquire and release.
Change-Id: If203fee077d421a9782fcd34607a413b8c3dcfc8
2022-08-01 17:11:50 -07:00
Laurent Morichetti
6f78083f2a
Fix a race condition when setting the callbacks
...
When acquiring the reader's lock (sem_sync()...sem_release()), it is
possible for a writer to squeeze by if the reader goes into sync_wait().
The writer could re-acquire the entry.sync between entry.sem > 0 and
entry.sync = 0.
void sync_wait(uint32_t id) {
sem_decrement(id);
while (entry(id).sync.load()) {}
// <--- HERE
sem_increment(id);
}
This could result in both the reader and the writer accessing
{ callback, arg } at the same time, and the reader could read
inconsistent data, for example: { new callback, old arg }.
The solution is to re-test entry.sync when returning from sync_wait():
void sem_sync(uint32_t id) {
sem_increment(id);
- if (entry(id).sync.load() == true) sync_wait(id);
+ while (entry(id).sync.load() == true) sync_wait(id);
}
Change-Id: I22f74f4cb9a5f027aac8aa4ed3e633acc19df4b8
2022-08-01 20:03:10 -04:00
Tao Sang
9f9fd859db
SWDEV-286739 - Support hipDeviceAttributeWallClockRate
...
Part 3: Add missing declaration of wall_clock64() to fix
compiling issue in device code.
Add querying hipDeviceAttributeWallClockRate.
Change-Id: Ie54771c2f58eeaacdc0248bc116ef193f99eb9b9
2022-07-28 13:02:42 -04:00
Maneesh Gupta
d328d72fab
Revert "SWDEV-264166 - Remove gcnArch"
...
This reverts commit ab303e6440 .
Reason for revert: Moved out to future release
Change-Id: I36b046c8681371baa9e0ccb69d46dad633ee5706
2022-07-27 05:22:48 -04:00
Jaydeep Patel
465421e71c
SWDEV-347592 - hipMemAllocationType must be hipMemAllocationTypePinned.
...
Change-Id: I36a5c37c6d66587c6804b60a5f0a88efb60801a4
2022-07-26 23:46:02 -04:00
Jason Tang
ab303e6440
SWDEV-264166 - Remove gcnArch
...
Change-Id: Ief4bdbdd5373adb73a291633067c9a8e11f05a32
2022-07-26 11:49:19 -04:00
Jaydeep Patel
0fed29f77c
SWDEV-347592 - validate hipMemAllocationType & hipMemLocationType
...
Change-Id: Ia8c4d3edc7ad96efa429b3530a118199d4f92902
2022-07-25 23:56:20 -04:00
sdashmiz
66bde8f336
SWDEV-346456 - fix test for get/set attr
...
- test should allow first calling get function
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com >
Change-Id: I365cd6210a01fd5ae3620711694bdc52e0f90b19
2022-07-25 15:17:27 -04:00
sdashmiz
d0b9e0a4ff
SWDEV-346423 - avoid race condition
...
- move removing the array from array set earlier to avoid race condition
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com >
Change-Id: I9003c991e3e0f47ed0509ddfdbeaa145b5a1e0f1
2022-07-25 15:17:10 -04:00
Jaydeep Patel
5b4e0321d4
SWDEV-345020 - The bit channel description should not allow any channels after a zero channel
...
Change-Id: I66e6d25c032d22f9616dc59730f1f094d30c01cf
2022-07-24 21:35:26 -04:00
Sarbojit Sarkar
53be27a84f
SWDEV-343380 - Added hipDrvGetErrorName/String
...
Change-Id: If22d87b64f8ffc870c05482d28c7c91fb2b7d041
2022-07-24 21:32:48 -04:00
Ajay
789e718549
SWDEV-342009 SWDEV-340506 - assertion failures in managed variables
...
Change-Id: Iac884f2e3cece96e605e353a8851274ba578e8be
2022-07-22 11:48:34 -04:00
Satyanvesh Dittakavi
ee27685ac4
SWDEV-340226 - SWDEV-340692 - Fix minor issues with hiprtc Link APIs
...
- hiprtcAddLinkData should accept 0 or null as input name
- hiprtcLinkCreate should accept 0 or null as options ptr
- hiprtcCompile should send -fgpu-rdc option to comgr if its present in the options
Change-Id: I84f6e36df5c99b719ee9c67dfc1b4dbcfd8e3172
2022-07-22 07:23:26 -04:00
Anusha Godavarthy Surya
0e2b348ef4
SWDEV-344166 - Updated HIP APIs to return hipErrorNoDevice when there are no devices in the system
...
Change-Id: I636828ff39d3b404f89bcc6e2cb7348d92c897ff
2022-07-22 06:59:19 -04:00
Satyanvesh Dittakavi
a9935b3257
SWDEV-329802 - Refactor PCH to generate the right warp size on Navi GPUs
...
Change-Id: I817de9c858c152fee1f586303372820066a09dc9
2022-07-22 05:49:59 -04:00
Sarbojit Sarkar
7d23707817
SWDEV-346461 - Fix for QMCPack tes failure
...
Change-Id: I92979f0c16766c28da6b14b6e17364749fe39fe3
2022-07-19 02:13:07 -04:00
Sarbojit Sarkar
323ed5bd82
SWDEV-1 - Fixed hipGetErrorString
...
Change-Id: I7224014b945bafe1cec6d1d0e11184c3459ac1b0
2022-07-18 03:38:28 -04:00
Ammar ELWazir
fb8690f812
SWDEV-345650 - Solving hipKernelNameRefByPtr Stream Issue
...
Stream is not important to get the kernel
name from Function that can be found in
the functions_ map.
Change-Id: I164bc3ebcc5552359856e76204d8b124ba0d2f34
2022-07-15 15:38:39 -04:00
Jaydeep Patel
6b3b62f49e
SWDEV-343168 - Clean ihipMallocPitch
...
Change-Id: Iab1c10ac2aea635ca10cc8bc98141df409ec917c
2022-07-14 01:15:08 -04:00
Sarbojit Sarkar
a4d4289382
SWDEV-345741 - hipDeviceSetLimit windows build error
...
Change-Id: I384541b190f1eb9e045553299215345426c5adc2
2022-07-13 20:37:32 -04:00
sdashmiz
39dbf65782
SWDEV-321698 - add new enum entries to match cuda
...
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com >
Change-Id: If0a17b3234fd90b1f553a075e02280258000d36a
2022-07-13 10:22:06 -04:00
sdashmiz
848ae2c06b
SWDEV-345021 - add check for pointer
...
add check for pAllocateArray
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com >
Change-Id: I6c91295c1fe4cffdf22f6b8c07fe0a592c2f4f70
2022-07-13 10:21:48 -04:00
German Andryeyev
ff23c5b716
SWDEV-311271 - Avoid a crash with the default queue
...
Move device access after the queue look-up
Change-Id: I799f23ff0299b20437c9a8edae42c38daa3e9ceb
2022-07-12 17:01:06 -04:00
Ajay
4274863f5d
SWDEV-327563 - Unit_hipGraphAddKernelNode_Negative null kernelparams fix
...
Change-Id: Id05f8944f41c04036b310b23358c908a8efb5a5b
2022-07-12 12:41:28 -04:00
sdashmiz
030e7702f1
SWDEV-343160 - correct mutual exclusive flags
...
- flags passed should be only one type at a time
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com >
Change-Id: I3e56f036e51d8cc84fe5c18c06cfa11cf785233f
2022-07-12 08:35:39 -04:00
Sarbojit Sarkar
e9961fedd8
SWDEV-323441 - Phase-II : per thread default stream
...
Change-Id: I3c796ddaebcf0223d7faf50c425c1674de215f9d
2022-07-11 12:22:23 -04:00
sdashmiz
2b9e39e901
SWDEV-344165 - correct wrong output
...
some attributes retruns wrong values
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com >
Change-Id: I75ba08cb07aa4abdb48e2e20ad7f58be7422158f
2022-07-11 10:11:25 -04:00
Rakesh Roy
4e6e175f16
SWDEV-344168 - Fix hipMemsetAsync API crash
...
- Return hipErrorInvalidValue if memset size + offset is crossing
allocated memory size
Change-Id: I18bd7bcf90ccfce992acb4535a00a8560c0f684b
2022-07-11 02:23:37 -04:00
Jaydeep
4aa1ffcc45
SWDEV-343168 - return invalidValue if totalsize is more than device's global memory.
...
Change-Id: Ie052b9b75c9813d040fc23959df4146af98b96ed
2022-07-11 02:18:54 -04:00
Tao Sang
2a91d45704
SWDEV-327502 Disable 3D linear filter on Mi200
...
Change-Id: I3f79fb4f3a59cd7335c5ca2363cf1659a0a7f6aa
2022-07-08 11:31:57 -04:00
Sourabh Betigeri
8d48e0e6be
SWDEV-273026 - Fixes to retrieve valid device memory data when device context is changed and p2p is enabled
...
Change-Id: Ie3f0b81f7fc6de8df65ccff35f9aefb8f6abdfbe
2022-07-08 01:45:49 -04:00
Ajay
01ea934b3e
SWDEV-340506 - Unit_hipCreateTextureObject_Pitch2DResource fix
...
Change-Id: I85431036818a3eb24100b1660e806a1c80d847eb
2022-07-07 13:05:08 -04:00
Ajay
eab4ea236c
SWDEV-340506 - Unit_hipMalloc3DArray_Negative fix
...
Change-Id: I1fbf4be8aaef83b36749f1e253b5dba025e7f3cd
2022-07-07 12:17:45 -04:00
Ajay
36a85741de
SWDEV-344440 SWDEV-344433 - null ptr checks for hipMemPoolGetAttribute hipMemPoolSetAttribute
...
Change-Id: I812abb3c74a05c4ec9097b09ee7e9a86b0c91e9b
2022-07-05 18:42:34 +00:00