AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
6,547 Commits 3 Branches 0 Tags
2c010dec17914bf9b795d0abcebc9fb399a8db2d
Commit Graph

1488 Commits

Author SHA1 Message Date
Rakesh Roy 62069a5ae8 SWDEV-342007 - Fix hipArray Allocation APIs 
- Capture error status of ihipImageCreate
- Return hipErrorOutOfMemory when image creation fails

Change-Id: If127a515447cc362d55fccd3eae304271da252d5
 2022-06-30 00:28:47 -04:00
Christophe Paquot bf5826ee93 SWDEV-322620 - Virtual Memory Management 
Use correct granularity for VM address/size

Change-Id: I001f29eabe9503396bbec623df9d5155b882be4f
 2022-06-29 15:59:56 -07:00
Saleel Kudchadker cf07633dc8 SWDEV-301667 - Early return if src == dst for 1D copy 
Change-Id: Icaa334c6579bb5e70e92347f8bc37edcf5adf796
 2022-06-28 14:21:40 -04:00
Ajay 8d1bd607f9 SWDEV-337331 - Windows: DD=0 graph child Node fixes 
Change-Id: Icd7fc3967a202946d3428eba99a1bbf43b9772db
 2022-06-28 11:57:11 -04:00
Sarbojit Sarkar 4b9ea686f6 SWDEV-342831 - Fix hipGetDeviceCount return 
Change-Id: I3b0338a51027258319c1926ac02de8d0af01d498
 2022-06-27 00:39:08 -04:00
Sarbojit Sarkar 1074b22c48 SWDEV-333073 - HIP_INIT_API to handle no return case 
Change-Id: I78d43e88cc196047a4cb5d6fcf756339c0e46e80
 2022-06-24 12:53:18 -04:00
Satyanvesh Dittakavi c6647487e0 SWDEV-336538 - Return hipErrorNotSupported for unsupported APIs 
Change-Id: Ie54771c2f58eebacdc0248bc116ef093f99eb9b8
 2022-06-23 07:31:31 -04:00
Ajay 2962d2ecf1 SWDEV-342542 - Support hipGetStreamDeviceId on Windows 
Change-Id: I3f79fb4f3058cd7335c5ca2363cf1659a0a7f6ad
 2022-06-22 12:18:03 -04:00
Satyanvesh Dittakavi b263ab3248 SWDEV-341360 - Handle named expressions with space in hipRTC 
Change-Id: I1c26855d8a94e0a4d818664ca71094c6992221c9
 2022-06-22 14:19:16 +00:00
sdashmiz 683b28d573 SWDEV-341993 - correct parameters checks 
flags, ptr and stream

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I306be503e8c15db1641eaeeae73e349a99f871ae
 2022-06-22 04:22:55 -04:00
kjayapra-amd 2731d03f03 SWDEV-339995 - Adding hiprtcGetBitcode and hiprtcBitcodeSize changes. 
Change-Id: I378f1ac98de3b11fa3f74161abd036702c7b479b
 2022-06-22 04:17:56 -04:00
Satyanvesh Dittakavi a39ab85e04 SWDEV-340226 - hiprtcLinkAddData should allow empty name 
Change-Id: I2c9a53453223ee4899b0a5d05e1097bc7e0e428e
 2022-06-22 04:15:32 -04:00
Rakesh Roy 21d7f35c84 SWDEV-342025 - Fix hipEventCreateWithFlags API 
- Return hipErrorInvalidValue if hipEventInterprocess flag is set, but hipEventDisableTiming flag isn't set

Change-Id: Ifbb9d83b018c360f312083bb25dba1187bcdaefa
 2022-06-21 10:59:17 -04:00
kjayapra-amd 5d385fa0e2 SWDEV-340226 - Fixing conversion to void* from size_t instead of size_t*. 
Change-Id: Ib7e083395d4fbbe2a6f3012fce5b268e108ad62a
 2022-06-21 06:28:06 -04:00
Sarbojit Sarkar 7f92a98a3c SWDEV-331066- Added hipDeviceSetLimit 
Change-Id: I4de099387ad34ca7c195588274b546649038e2aa
 2022-06-21 06:06:05 +00:00
Jaydeep 26d8603bf3 SWDEV-332607 - If pitch returned from hipMallocPitch is equal to pitch passed to hipMemset2D then height passed to hipMemset2D must be less than or equal to height passed to hipMallocPitch. 
Change-Id: I5f9eb55cede5dff5a9e428d41fe081f043df7049
 2022-06-21 00:10:19 -04:00
Sourabh Betigeri 5ad38a32bf SWDEV-342067 - Fixes a minor coding error to loop through all the entries in the map 
Change-Id: I837cb4868de2acd3e71ca9a745a62ed0bb2d1400
 2022-06-20 19:20:38 -04:00
Jaydeep 1032581ded SWDEV-336548 - Check for valid hipArray pointer in hipFreeArray 
Change-Id: Icf0d47eeca7b5dd390a6a9c53b622b3680688ca4
 2022-06-18 00:56:33 -04:00
Sourabh Betigeri 3ca4c7edf7 SWDEV-341994 - Fixes to returns the right error code to match CUDA spec for hipHostUnregister() 
Change-Id: Ied9b5a15e841d4c201042d116b0ed535f07c17fc
 2022-06-17 12:16:52 -04:00
Jaydeep 0ad84364e0 SWDEV-336542 - Return InvalidValue error for hipArrayCubemap flag. 
Change-Id: I4ca996d7643158d5ccf8cb48ceaead3ceaf9aedf
 2022-06-17 00:25:18 -04:00
kjayapra-amd 5e61b9e762 SWDEV-340226 - Fixing minor issues related to hiprtc Link API changes. 
Change-Id: I18e7ca2a467ccf14d95ffb37b5516dda74f98cf7
 2022-06-16 06:06:38 -07:00
Satyanvesh Dittakavi bf4cf3c369 SWDEV-327563 - Fix the hip runtime library name to load in hiprtc on Windows 
Change-Id: Ib4988dd8677da907bec8e59b1b4ce3e57aad2bb7
 2022-06-16 00:45:43 -04:00
Jaydeep Patel a527c241a2 SWDEV-333581 - Pass free and/or total size_t as nullptr. 
Change-Id: Ib83467a351b6df22ef641c0e82284c7e0fac32e3
 2022-06-15 23:46:34 -04:00
sdashmiz e8194dca76 SWDEV-325711 - add Graph memory APIs skeleton 
- hipDeviceGet/SetGraphMemAttr

- hipDeviceGraphMemTrim

- there is no memory pool for graphs currently

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I11db76ea7ea1c7732175fc93264448052357e8dc
 2022-06-15 14:47:16 -04:00
Sourabh Betigeri c3db564e94 SWDEV-331301 - Fixes to return error if the childGraph topologies of instantiated childGraphNode and to-be updated childGraphNode do not match 
Change-Id: I372317a4df13e5cd352f46525d820246fe4ca8f2
 2022-06-15 13:39:15 -04:00
Jeremy Newton 112b6370a5 SWDEV-335990 - Use GNUInstallDirs 
This is attempt two of bf4df229c9

GNUInstallDirs is used to allow the user to customize the install paths
of HIP, rather than using hardcoded locations.

See documentation for more information:
https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html

Note that libdir must be overriden to "lib" before including
GNUInstallDirs, because by default, cmake tries to detect the libdir
path, but ROCm packaging would like to use lib by default for all
targets. This does not stop the user (or distros) from overriding.

Also note this change does no take into account the changes needed to
non-cmake files, such as perl scripts, so not all paths combinations are
necessarily functional.

Signed-off-by: Jeremy Newton <Jeremy.Newton@amd.com>
Change-Id: I521c44dc34404b136141682c2777257b23ffa6e8
 2022-06-15 13:14:47 -04:00
Saleel Kudchadker 1cea2c0412 SWDEV-335780 - Revert commit 
This reverts commit f6e21144ae.

Change-Id: I589d495b448a5ecc7def9dbca3f70b033a962f45
 2022-06-14 19:08:22 -04:00
Sourabh Betigeri 5549c8cd1b SWDEV-318237 SWDEV-330173 - Fixes kernel parameter corruption when multiple nodes of the same kernelNode exist 
Change-Id: I6437593be46b7b5afc3d77cdd887ad4139978ad3
 2022-06-14 18:06:21 -04:00
haoyuan2 cfe1efd6b0 SWDEV-338564 - fix test hang issue 
only check task finish with valid queue

Change-Id: Ib2bd1360235a07f825a09c57453ccbff7951f17f
 2022-06-14 15:34:30 -04:00
Sourabh Betigeri 2f9e92757c SWDEV-340453 - Fixes coding error. Missing condition in a negative scenario 
Change-Id: Ic4b71e143ec883ca73a2511a367ac034444ec7de
 2022-06-14 12:24:10 -04:00
sdashmiz 13c875eaf0 SWDEV-321698 - remove Memcpy1D type 
- Memcpy1D node type is not complying with cuda

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: If8113f5e699de0c62d98effc4580a2e0fee9a950
 2022-06-13 08:31:02 -04:00
Christophe Paquot faa7ee48ba SWDEV-322620 - Virtual Memory Management 
Implements hipMemRetainAllocationHandle
HIP layer updates the svmPtr of the amd::memory
ROCCLR just manages the MemObjMap
This is because HIP knows the orignal (generic) address of the
physical memory whereas ROCCLR doesn't keep track of that

Change-Id: Ied26d7f814bc468f5cf586c967020737b9aa9e9f
 2022-06-10 17:48:07 -04:00
agunashe 9e7b44511a SWDEV-337331 - Windows graph fixes iteration2 
API fixed hipGraphAddDependencies

Change-Id: I1248c00d788c392c71e64c5070fe09653125bb34
 2022-06-10 16:42:54 -04:00
sdashmiz 8d93ff521f SWDEV-334857 - hipModuleGetTexRef compatibilty issue 
- make the defualt texref value compatible with cuda

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I2ae980e435f3b0fc15b237741e3f2b97c4257e12
 2022-06-10 15:13:29 -04:00
Ajay de026633c0 SWDEV-327563 - support hipStreamWrite32/64 and hipStreamWait32/64 funcs 
Windows complains about undefined symbol for
hipStreamWrite32/64 and hipStreamWait32/64 -
commit hash 08435a972b

Change-Id: I48b9a6591cab3a05baaedbc26030914dd930fb68
 2022-06-09 20:59:46 -04:00
Ajay c06bfa6bef SWDEV-337331 - graph feature on Windows 
Fixes for hipGraphInstantiate OutofMemory issue and
soft hang of hipStreamSynchronize.
Change-Id: Ic2bb97582c5978ef2e4eb3a1b124483aa412838e
 2022-06-09 12:04:51 -04:00
sdashmiz efd2d55e9d SWDEV-318833 - Get and Set attribute for kernel nodes 
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ie51aa4b56661cbb8c5b4eb1dbaad327377084ffb
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
 2022-06-09 09:47:05 -04:00
Aakash Sudhanwa 43c650cf48 Revert "SWDEV-335990 - Use GNUInstallDirs" 
This reverts commit bf4df229c9.

Reason for revert: <Breaking all the staging builds. this is breaking components which are using find_package(HIP)>

Change-Id: Ic7340fb461a5efdd170a0988731e0885538a11d6
 2022-06-07 18:18:06 -04:00
Jeremy Newton bf4df229c9 SWDEV-335990 - Use GNUInstallDirs 
GNUInstallDirs is used to allow the user to customize the install paths
of HIP, rather than using hardcoded locations.

See documentation for more information:
https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html

Note that libdir must be overriden to "lib" before including
GNUInstallDirs, because by default, cmake tries to detect the libdir
path, but ROCm packaging would like to use lib by default for all
targets. This does not stop the user (or distros) from overriding.

Also note this change does no take into account the changes needed to
non-cmake files, such as perl scripts, so not all paths combinations are
necessarily functional.

Signed-off-by: Jeremy Newton <Jeremy.Newton@amd.com>
Change-Id: Iae80f47c47ea0a74fc1c221b6eea82b557601394
 2022-06-06 23:43:05 -04:00
Rakesh Roy e2874d5e22 SWDEV-337776 - Fix hipStreamEndCapture API 
- Return hipErrorInvalidValue when pGraph is nullptr

Change-Id: I8846f4448eb15117f98421632885330f132c4fce
 2022-06-01 00:20:23 -04:00
Sourabh Betigeri 5a057af564 SWDEV-320640 - Fixes to return right error codes in hipStreamUpdateCaptureDependencies() for negative scenarios 
Change-Id: I3c4c54f8955fa9bb17eb595544005fe9f0e8a5f0
 2022-05-31 14:09:22 -04:00
pghafari 8e28413a9e SWDEV-337703 - nullptr check for hipMallocArray 
Change-Id: I3b1077e236ccda346d337109014ef7fd2e693ec6
 2022-05-31 11:19:59 -04:00
pghafari 2870b7ddd5 SWDEV-336550 - added nullptr check for svm 
Change-Id: Icfd7dab1c7818958108385261542526d4545721d
 2022-05-30 16:58:45 -04:00
kjayapra-amd 84f94fd134 SWDEV-290384 - Add Linker API support in hiprtc 
Change-Id: I4621a033a22e4da0201c3804e2b357470a681ab0
 2022-05-24 09:16:14 -04:00
Rakesh Roy 01a5ddebe6 SWDEV-337119 - Validate width isn't exceeding either dpitch or spitch in 
ihipMemcpy2D

Change-Id: I8ac68e033762616a42585b26f0b3aa5bbb29ce9c
 2022-05-18 23:25:14 +05:30
Satyanvesh Dittakavi 8dfa7e7f98 SWDEV-334908 - Guard the __noinline__ macro as it is also supported as keyword by clang 
Change-Id: I314b3ac463ea63132a5107f4f24ce769d8112b9b
 2022-05-18 05:51:32 -04:00
pghafari bb9e52ab9f SWDEV-336576 - updated graph check 
hipGraphExecMemcpyNodeSetParamsFromSymbo was not working in functional
case

Change-Id: I2ad04f6f91519efa075c36fe737a695fa1bc127a
 2022-05-17 17:36:10 -04:00
Christophe Paquot 60656d9fc9 SWDEV-322620 - Virtual Memory Management 
Report virtual memory management support.

Change-Id: I448a66c86ab1b2d28f6052e8896ea505e56eb2d2
 2022-05-17 16:24:53 -04:00
Satyanvesh Dittakavi 8a333a989b SWDEV-332606 - SWDEV-333585 - Fix hipMemcpySymbol* and hipGetSymbol* APIs 
This also fixes the QMCPack staging (SWDEV-335826) test failures related
to hipMemcpyToSymbol

Change-Id: Icc3ff04fb1e17999f5bddf12e1a7266e2289032f
 2022-05-16 04:27:02 -04:00
Tao Sang 4561a207dd SWDEV-319818 - Revert change on hipResourceViewDesc 
Revert part of
http://gerrit-git.amd.com/c/compute/ec/hipamd/+/675588

Change-Id: Iee9dac9f8c50aa9b6a12ca9d8fd792a51973b8cd
 2022-05-12 12:14:13 -04:00