814d55f046
Merge pull request #282 from gargrahul/texture_driver_3d_support
...
Added support for 3D texture driver apis
2017-12-18 15:39:26 +05:30
6293d3f887
Merge pull request #285 from aaronenyeshi/fix-ilogb-unreachable
...
Fix ilogb/ilogbf functions to return int
2017-12-12 10:47:33 +05:30
707aaef99d
Fix ilogb/ilogbf functions to return int
...
This patch will fix hipDoublePrecisionMathDevice test on ThinLTO, which uncovered that hip math_function's ilogb/ilogbf should return type int instead of double. This will match rocdl.
2017-12-05 23:14:10 +00:00
115c7f2b79
Added support for
...
- 3D texture driver APIs
- hipMalloc3D
- hipMemcpy3D for destination other than array
2017-12-05 14:11:13 +05:30
5127ce67e8
This is primarily intended as an additional cleanup of the module functionality, in the aftermath of adopting module based dispatch. The main effort was associated with refactoring the questionable ihipModuleGetSymbol. It was quaintly written and misleading, in that it had little to do with getting symbols, and was exactly retrieving a kernel object. Error handling is modified so as to reduce branching depth. Functions which serve as interfaces to the HSA RT are moved in a separate helper header. Code object readers are properly deleted. Some leftover dead functionality pertaining to associating namespace scope variables with their allocated memory is removed. Executable loading is changed to use a string which holds the ELF image of the code object being loaded, thus avoiding some corner cases where using a istream would fail.
2017-12-03 23:09:06 +00:00
7c0b9a005b
Fix legacy mode detection of the address of an agent allocated variable. In this mode, there exist two executables per each code object, one created by HCC and one created by HIP. Since we dispatch through HCC in legacy mode, we should obtain the address for an agent allocated variable from the latter's executable. Also add two omitted validity checks, whose absence could lead to segfaults when the current process had no .kernel section and / or when an invalid or empty blob was extracted from the latter.
2017-11-30 03:29:04 +00:00
20fc68c9a1
Add missing space (the final frontier).
2017-11-29 21:50:43 +00:00
32e11e7dc6
Revert "Revert adoption of CUDA indexing in general - this can only work with later versions of the compiler, just like module based dispatch, and thus must be guarded against usage in earlier (e.g. 1.6) versions."
...
This reverts commit d2fd1f5
2017-11-29 21:49:10 +00:00
7acb1e6ff6
Use a much simpler guard for version 1.6, which allows for direct CUDA indexing to be used.
2017-11-29 21:47:04 +00:00
d2fd1f5544
Revert adoption of CUDA indexing in general - this can only work with later versions of the compiler, just like module based dispatch, and thus must be guarded against usage in earlier (e.g. 1.6) versions.
2017-11-29 21:01:28 +00:00
b881cf713c
Fix compiler version check.
2017-11-29 03:05:53 +00:00
faa546d194
Fix oversight in selection mechanism which led to erroneous code to be compiled for the grid_launch_GGL component.
2017-11-29 01:37:52 +00:00
89e9399427
Choose whether or not to use functional grid_launch based on the version of HCC used to compile.
2017-11-29 00:17:44 +00:00
6e4ca3fbb4
Change memset kernel to use memcpy instead of placement new. Simplify indexers.
2017-11-28 19:45:47 +00:00
02c2bfc7ef
Re-sync with upstream and re-factor platform global management for texture references.
2017-11-28 19:15:29 +00:00
dc67ca3feb
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
...
# Conflicts:
# src/hip_module.cpp
2017-11-28 17:29:11 +00:00
0da0426f94
Merge pull request #256 from gargrahul/texture_driver_api_support
...
Texture driver APIs support
2017-11-27 13:52:39 -06:00
08f252e4bf
Remove leftover comment.
2017-11-22 19:37:03 +00:00
9866fa250d
Changed function hipMemcpy_2D to hipMemcpyParam2D
2017-11-21 12:36:24 +05:30
9d088d2283
Refactor the __device__ versions of memset and memcpy to be less awkward i.e. not return nullptr as opposed to the destination pointer (it can only be assumed it was done for maximum confusion) and actually unroll as they claim to. Change all of the {to, from}Symbol functions to use hipModuleGetGlobal, as opposed to hc::accelerator::get_symbol_address which is no longer valid with module based dispatch.
2017-11-21 02:40:34 +00:00
7d5a45ac1a
Correct ill-formed merge in earlier commit and adjust for differences with the new CUDA natural indexing mechanism.
2017-11-20 16:33:52 +00:00
c5f2b22d0d
Re-sync with upstream.
2017-11-20 15:34:50 +00:00
c7d60a7a75
Update hipModuleGetTexRef API
2017-11-19 22:10:46 +05:30
cffd0e14eb
This implements the trivial change needed to move back from the hip{Something}_{x, y, z} macros to the natural CUDA syntax of Something.{x, y, z}. This is contained in lines 384-404 in hip_runtime.h. All of the other changes have to do with changing unit tests to use this syntax. The macros are retained for backwards compatibility.
2017-11-19 01:54:12 +00:00
4b19c2aa0c
-Fixed texture driver API sample
...
-Added hipTexRefSetAddress and hipTexRefSetAddress2D APIs
2017-11-15 18:23:28 +05:30
63680edd30
Texture code reorganized
2017-11-14 11:09:35 +05:30
ef09c4918d
Texture driver APIs support
2017-11-09 22:10:55 +05:30
d8e323d4b5
Clean up trailing whitespace so as to reduce noise in #246 .
2017-11-08 00:08:55 +00:00
c2482d1255
This switches HIP from its currently convoluted macro + pfe based dispatch mechanism to a more natural one partially based on the existing module API. The basic idea is that HCC will always correctly emit __global__ functions: as empty-bodied stubs, on host, and as kernels, on device. It then becomes trivial to obtain the mangled name on host, at dispatch, from the function's address, and then to use the mangled name to retrieve the kernel. This should address all problems stemming from serialisation, dubious mismatches due to the manufactured functor, macro-isms et al. It also immediately enables support for generalised globals as a consequence of that being available in the module API. Finally, it will make debug much easier, since the actual names of the __global__ functions will automatically be used in traces etc. One detail is that due to how dispatch works now (hipLaunchKernel and hipLaunchKernelGGL are themselves variadic function templates which deduce the function type of the callee), in certain cases it may be necesssary to insert explicit casts to ensure that the variadic argument list selects a viable overload - this can be observed in some unit tests. Eventually we may be able to remove this limitation, but for now it does not appear terribly onerous. The code is not extremely HIPpie, nor is it fully optimised, but rather is intended as a starting point for the HIP team to make its own.
2017-11-01 15:09:59 +00:00
2e8ec71e40
Merge pull request #222 from bensander/fix_device_prop
...
Fix device prop
2017-10-30 17:58:48 +01:00
f8bdb9f688
add a printf device function
2017-10-23 18:30:08 -04:00
acf89b43d4
Update device properties.
...
- clear properties to defined initial state.
- enable some property flags which are now supported.
2017-10-20 15:52:13 +00:00
68c2146dc3
Fix math ordering for --genco mode.
2017-10-02 21:52:16 +00:00
83d9e889a9
ensure the condition is evaluated before applying the negation operator
2017-09-20 01:38:28 -04:00
40ff42e555
Device side assert support
2017-09-07 20:45:27 +05:30
1a9e588932
Update docs.
...
- Review unsupported comments and refresh.
- Review experimental tag in API.
2017-08-28 15:44:38 -05:00
96e79f97e2
implement __threadfence_system
2017-08-02 08:50:18 +00:00
4f93b99f23
Merge pull request #100 from weixingzhang/texture
...
HIP Texture Support
2017-07-26 19:28:15 -05:00
7a446dcbc5
Renable frexp(f) device math function
...
Change-Id: I53c022b8ddf38cd17ddb42eba457b9020db66395
2017-07-20 14:41:30 +05:30
e671cec367
HIP Texture Support
2017-07-17 15:16:12 -04:00
30ee797dd4
Remove explicit address spaces declarations
2017-07-07 12:46:29 -05:00
0459f3db72
Add hipdbPrintMem - wrapper for hcc memory tracker.
2017-07-03 15:05:30 -05:00
34fcaa23bb
Fixed build error in hipDeviceGetByPCIBusId
...
Change-Id: I33be362910c4c5dca7435fb9c41f427b54f0e9a7
2017-07-01 07:56:30 +05:30
9c229f7530
Refactor hip_hcc.
...
Don't require setting __HIP_PLATFORM_HCC__ ; Instead check if compiler is HCC.
The functions here use HCC-specific functionality so only work with HCC.
ANd they work regardless of the __HIP_PLATFORM_HCC__ setting so don't
require that.
Also remove the "hcc_detail" extra hierarchy level for hip_hcc.h as
it is not necessary. Remove hcc_detail/hip_hcc.h.
2017-06-30 08:26:15 -05:00
1e1654c225
Remove some warning debug info and add weak attribute back to GGL __global__ define
...
Change-Id: I2021b107dda697b1262d44fa1506465e94a3916b
2017-06-27 14:15:16 -05:00
522e059a79
fixed default args for symbol memcpy apis
...
Change-Id: Ie0b63f8b9c5535eb3946bd6af3f30fe71a015244
2017-06-23 19:05:44 -05:00
7912e61502
Clean up old USE_* and RELEASE.md notes.
2017-06-23 18:05:30 -05:00
3c73229916
Abort device function in HIP/HCC, need new HCC
...
Change-Id: I4195ab75e9b7b48c8b8128d6925ddc0fa5e9e009
2017-06-18 12:31:31 +05:30
64bb8d154a
removed bad copy constructor
...
Change-Id: I661991d9d43941a61848b0b8e9879c0bfa811b40
2017-06-16 09:02:26 -05:00
fd36303c24
Additional GGL make_kernel_functor_* macros, contributed by Alex
...
Change-Id: I01aabb7d2b5418fcefb1bbf78eb5d1888dbc5c96
2017-06-14 11:10:52 -05:00
Maneesh Gupta
Aaron En Ye Shi
Rahul Garg
Alex Voicu
Ben Sander
Siu Chi Chan
Weixing Zhang
Wen-Heng (Jack) Chung
Sun, Peng
Aditya Atluri