Commit Graph

5137 Commits

Author SHA1 Message Date
lthakur 435badcb0e Fixed compilation errors being observed on windows 2019-08-07 15:54:46 +05:30
Rahul Garg 59bda14979 Enable temporarily disabled device properties on HIP/VDI 2019-08-06 22:03:19 -04:00
foreman adf865621c P4 to Git Change 1979123 by cpaquot@cpaquot-ocl-lc-lnx on 2019/08/06 17:15:10
SWDEV-198556 - [HIP] Gnarly bug due to macros:
	HIP_RETURN(ret) duplicates ret twice first by setting the last error
	then via LogDebugInfo. So if HIP_RETURN has a function as a parameter,
	the function would get called twice. So ihipMalloc and ihipMemcpy were
	being called twice (and perhaps more functions).
	Also logging the pointer returned by ihipMalloc so we can track memory
	in logs more easily.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#33 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#65 edit
2019-08-06 17:19:28 -04:00
Jenkins a05c22cad3 Merge 'master' into 'amd-master'
Change-Id: Ifbc64e6a162790ce7e2e949904e9d53ef1f6540d
2019-08-06 05:10:19 -04:00
Evgeny Mankov cf8ec29fe2 [HIP][doc] Populate README.md with the supported CUDA APIs links 2019-08-05 16:05:39 +03:00
Evgeny Mankov de1dd33333 Merge pull request #1289 from emankov/master
[HIPIFY][doc] Update README.md
2019-08-05 14:50:43 +03:00
Evgeny Mankov 739e2df224 [HIPIFY][doc] Update README.md
+ cuDNN, Python, and VS supported versions update;
+ testing output update.
2019-08-05 14:49:01 +03:00
Maneesh Gupta 63831417ac Merge pull request #1286 from mangupta/swdev-198753
Partial revert of 'Add HSA_PATH to hip_Includes in cmake and hipconfig (#1260)'
2019-08-05 09:52:47 +00:00
Alex Voicu fbbed603ff Fix hip_throw. (#1285)
* Fix hip_throw.

* Fix typo

* No, really fix typo
2019-08-05 09:52:22 +00:00
Maneesh Gupta 4ee600ed5e Merge pull request #1280 from ROCm-Developer-Tools/fix_dont_break_hcc_just_because
This difference makes absolutely no sense.
2019-08-05 09:51:53 +00:00
Sarbojit2019 3bfff0a23d Enabled gcc for hip host code (#1214)
* Enabled gcc for hip host code

* Adding tests for hip code + (gcc & g++), without kernels

* Excluding nvcc platforms for gcc and g++ tests + Addressing review comments

* minor code clean-up

* Add rocm include path

* Added relative path for library

* Hiding non supported functions for gcc

* Incorporating review comments
2019-08-05 09:51:36 +00:00
Jeff Daily 1eb3dbf065 consolidate thread local storage (#915)
* all thread local access now through single struct

* clean up old commented-out code, more use of GET_TLS()

* fewer calls to GET_TLS by passing tls as a funtion argument

* revert unnecessary change to printf

* fix failing tests due to TLS change

* fix merge conflicts in ihipOccupancyMaxActiveBlocksPerMultiprocessor
2019-08-05 09:51:02 +00:00
Maneesh Gupta 0782e79478 Partial revert of 'Add HSA_PATH to hip_Includes in cmake and hipconfig (#1260)'
Change-Id: I35173f2defe446c0d1e5511e582e9c8722841381
2019-08-05 13:32:46 +05:30
Evgeny Mankov 4bebb52feb Merge pull request #1282 from emankov/hipify-clang
[HIPIFY][fix][#211] Taking into account include guard controlling macro
2019-08-04 16:31:53 +03:00
foreman 44813761ba P4 to Git Change 1978068 by cpaquot@cpaquot-ocl-lc-lnx on 2019/08/03 12:16:57
SWDEV-198546 - [HIP] Implemented basic Ctx APIs that are deprecated.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#20 edit
2019-08-03 12:23:25 -04:00
Evgeny Mankov 25075729f9 [HIPIFY][fix][#211] Taking into account include guard controlling macro
...while including HIP main header file, which is inserted now after #indef controlling macro, or after #pragma once, if it's occurred earlier.

+ Add a couple of unit tests.
ToDo: Check backward compatibility on older clang versions.
2019-08-02 16:46:45 +03:00
Maneesh Gupta f52245d440 Merge pull request #1278 from gargrahul/fix_hipfuncGetAttribute_logstatus
Fix missing logstatus in hipFuncGetAttributes
2019-08-02 10:00:38 +00:00
wkwchau aaec4f73a6 Added CooperativeLaunch and CooperativeMultiDeviceLaunch flag and property for hipDeviceGetAttribute() and hipGetDeviceProperties() (#1247) 2019-08-02 10:00:25 +00:00
Alex Voicu a85b0fe68e This difference makes absolutely no sense. 2019-08-02 12:30:03 +03:00
Jenkins 9fe0bd1a56 Merge 'master' into 'amd-master'
Change-Id: I1e1c4dd98314f65c5d9a53537eafee324c855718
2019-08-02 05:10:20 -04:00
Rahul Garg 474bf0effc Fix missing logstatus in hipFuncGetAttributes 2019-08-02 11:51:34 +05:30
foreman 99d54cb7bd P4 to Git Change 1977240 by wchau@wc_hip_vdi on 2019/08/01 16:35:47
SWDEV-180872 - Runtime support changes for Cooperative Group Features
	- Taking into account of SGPRs usage to determine the block size

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#35 edit
2019-08-01 16:40:24 -04:00
foreman ed497989b9 P4 to Git Change 1977018 by cpaquot@cpaquot-ocl-lc-lnx on 2019/08/01 11:58:59
SWDEV-197462 - [HIP] Add HIP_INIT_API to hipFree to initialize current thread.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#64 edit
2019-08-01 12:06:04 -04:00
wkwchau e7447d5809 Added query of hipDeviceAttributeHdpMemFlushCntl and hipDeviceAttribu… (#1238)
* Added query of hipDeviceAttributeHdpMemFlushCntl and hipDeviceAttributeHdpRegFlushCntl

* Added NVCC blocker for the hip*FlushCntl test cases
2019-08-01 16:03:35 +00:00
Maneesh Gupta adc95002c6 Merge pull request #1277 from mangupta/nvcc_devprop
[nvcc] Populate missing fields in hipGetDeviceProperties
2019-08-01 08:59:58 +00:00
Maneesh Gupta 79358e086a Merge pull request #1276 from vsytch/SWDEV-197675
[hip][tests] Don't use a hardcoded warp size, since it can be dynamically changed.…
2019-08-01 08:59:43 +00:00
Maneesh Gupta be168102c2 Merge pull request #1275 from yxsamliu/fix-std
Fix -std=c++14 for windows
2019-08-01 08:59:27 +00:00
Maneesh Gupta 859fb94f3d Merge pull request #1243 from jeffdaily/master-stream-lock-fix
remove stream locks where it is safe to do so
2019-08-01 08:59:13 +00:00
wkwchau 4b18b321f7 Added support of hipOccupancyMaxActiveBlocksPerMultiprocessor & hipOc… (#1240)
* Added support of hipOccupancyMaxActiveBlocksPerMultiprocessor & hipOccupancyMaxActiveBlocksPerMultiprocessorWithFlags APIs

* Taking into account of SGPR usage to determine the max active blocks in hipOccupancyMaxActiveBlocksPerMultiprocessor()
2019-08-01 08:58:48 +00:00
Maneesh Gupta 3ec381d729 [nvcc] Populate missing fields in hipGetDeviceProperties
Change-Id: Ie90e02674d503e385f144f1ead3d53ff7b49cecc
2019-08-01 13:16:39 +05:30
Vladislav Sytchenko fd3b626386 Don't use a hardcoded warp size, since it can be dynamically changed. Query it from the runtime instead. 2019-07-31 17:04:31 -04:00
Yaxun (Sam) Liu f467cb850e Fix -std=c++14 for windows 2019-07-31 16:36:47 -04:00
Evgeny Mankov 7809783a91 Merge pull request #1274 from emankov/cuDNN
[HIP][doc] Populate CUDA Runtime API doc with CUDA version field
2019-07-31 23:01:32 +03:00
Evgeny Mankov 77e9ade9bc [HIP][doc] Populate CUDA Runtime API doc with CUDA version field
+ CUDA version - version in which API has appeared and (optional) last version before abandoning it; no value in case of earlier versions < 7.5.
+ Fix typos, add missing references.
2019-07-31 22:59:05 +03:00
Maneesh Gupta a4407f13db Merge pull request #1269 from gargrahul/fix_ptr_attr_unkonwn_to_invalid
hipPointerGetAttributes- Change hipErrorUnknown to hipErrorInvalidValue
2019-07-31 15:43:06 +00:00
Maneesh Gupta dec701df03 Merge pull request #1265 from gargrahul/fix_hip_porting_guide_texture_ref_use
[docs]Fix texture reference APIs usage part
2019-07-31 15:42:54 +00:00
Rahul Garg b9e6d72ee6 Add hip init in hipExtLaunchMultiKernelMultiDevice (#1263)
* Add hip init in hipExtLaunchMultiKernelMultiDevice

* Add more logstatus for multiple return paths

* Fix missing i in function name
2019-07-31 15:42:29 +00:00
Rahul Garg 0517c30507 Add HIP init in hipFuncGetAttributes (#1262)
* Add HIP init in hipFuncGetAttributes

* [dtest]Remove explicit hip init call in hipFuncGetAttributes dtest
2019-07-31 15:42:08 +00:00
Jenkins 73fe08d8f0 Merge 'master' into 'amd-master'
Change-Id: Icb10bd2bba7544534e71e3c0e7e6f8ba46a7ee3c
2019-07-31 05:09:32 -04:00
Maneesh Gupta e1376699c3 Merge pull request #1270 from mangupta/ci_stablity
[ci] Disable flaky hipMemoryAllocateCoherentDriver on CI for now
2019-07-31 05:03:25 +00:00
ansurya 0f0b60f57d Testcase to validate signed/unsigned char,short as normalized float (#1267)
* Testcase to validate signed/unsigned char,short as normalized float

* corrected test_common.cpp file path
2019-07-31 05:02:35 +00:00
ansurya 50597e2085 Add HSA_PATH to hip_Includes in cmake and hipconfig (#1260)
* Add HSA_PATH to hip_Includes in cmake and hipconfig

* HSA_PATH to CACHE path,checks for HSA include path

* Removed new lines at EOF
2019-07-31 05:02:20 +00:00
Maneesh Gupta 756d4ba1a0 [ci] Disable flaky hipMemoryAllocateCoherentDriver on CI for now
Change-Id: Ib90dd390ed71d0b3867e5dc36a41988cc4d42a99
2019-07-31 09:35:43 +05:30
Rahul Garg 483aab031f Change hipErrorUnknown to hipErrorInvalidValue 2019-07-31 00:28:30 +05:30
Evgeny Mankov 707fc26ee7 Merge pull request #1268 from emankov/cuDNN
[HIPIFY][DNN][doc] Populate cuDNN API doc with CUDA version field
2019-07-30 20:55:08 +03:00
Evgeny Mankov c48fca494a [HIPIFY][DNN][doc] Populate cuDNN API doc with CUDA version field
+ CUDA version - version in which API has appeared and (optional) last version before abandoning it; no value in case of earlier versions < 7.5.
+ Fix typos.
2019-07-30 20:53:57 +03:00
foreman 00abf507c3 P4 to Git Change 1975700 by jatang@jatang_win_pal_lc on 2019/07/30 11:21:33
SWDEV-1 - Fix HIP build.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/fixme.cpp#2 edit
2019-07-30 11:26:23 -04:00
Jenkins ec934e5124 Merge 'master' into 'amd-master'
Change-Id: I20655a3d9a02b33a9c018ed8b62d1e0d1328e5ca
2019-07-30 09:18:12 -04:00
Rahul Garg ccaea193b2 [docs]Fix texture reference APIs usage part 2019-07-30 02:56:47 +05:30
Evgeny Mankov 0471e10208 Merge pull request #1261 from emankov/cuDNN
[HIPIFY][SPARSE] Sync cuSPARSE 10.1 - HIP - HIPIFY (Step 2 of 2)
2019-07-29 21:14:17 +03:00