Граф коммитов

1263 Коммитов

Автор SHA1 Сообщение Дата
vedithal-amd 354fe5f52c Unified configuration for metrics (#726)
* Show description of metrics during analysis
    * Use --include-cols Description show the Description column in analyze mode (this is hidden by default)
    * Remove tips field from analysis config

* Align metric names in analysis config and documentation

* Add unified config utils/unified_config.yaml

* Add python script utils/split_config.py to auto generate analysis configuration and documentation metrics description
   * Add test case to ensure unified config is older than auto-generated config
   * Auto generate analysis config and documentation metrics description

* Update CONTRIBUTING.md to add instructions to build documentation assets
    * Add docker image and compose file to build documentation

* Update CHANGELOG and Documentation

* Use jinja template instead of hardcoding metric tables in documentation

[ROCm/rocprofiler-compute commit: bb44e90b2d]
2025-07-25 14:01:34 -04:00
xuchen-amd dcdadfd37d Improve --time-unit arg (#807)
[ROCm/rocprofiler-compute commit: 99a6e67bcc]
2025-07-24 12:15:52 -04:00
vedithal-amd 1cf98deedf Fix rocprofv3 supported counters not being detected (#832)
* Fix rocprofv3 supported counters not being detected

* Fix rocprof interface deprecation warning appearing twice

[ROCm/rocprofiler-compute commit: dbcaccb9de]
2025-07-24 11:50:07 -04:00
vedithal-amd 449a6d41a0 Improve baseline comparison (#817)
* Do not force unsupported metrics to be specified in older gpu
  architectures as None

* Remove metrics which are explicitly set to None

* Update CHANGELOG

* Fix analysis configuration to fix baseline comparisons across all gpu
  architectures
    * Add missing 1812 section for gfx908
    * Add missing 1812 section for gfx90a

* Baseline comparision will only show common metrics
   * First workload will be used to set Metric ID index column

[ROCm/rocprofiler-compute commit: d4c316a730]
2025-07-24 11:49:02 -04:00
Fei Zheng b4c626893f Fix L2 read/write/atomic bandwidths on MI350 (#831)
[ROCm/rocprofiler-compute commit: 137f35e700]
2025-07-23 15:46:19 -06:00
vedithal-amd d9da3feadf Improve block filtering to accept metric ids (#821)
* Fix tests
* Update CHANGELOG and documentation

[ROCm/rocprofiler-compute commit: a70ae40ddc]
2025-07-23 16:16:29 -04:00
cfallows-amd f6f3a6ed3e Update standalone roofline intro (#830)
[ROCm/rocprofiler-compute commit: 2a7bbc4cc2]
2025-07-23 15:17:00 -04:00
vedithal-amd 6c8b834f5c Fix tests and formatting (#826)
[ROCm/rocprofiler-compute commit: 068e5aaef4]
2025-07-22 17:49:16 -04:00
vedithal-amd a559d9e8d1 Standalone GUI bugfix (#825)
* Fix barchart elements table ids

* Add HBM bandwidth section to L2 cache report for gfx950

* bugfix for standlone GUI

Co-authored-by: Felix Marty <Felix.Marty@amd.com>

[ROCm/rocprofiler-compute commit: e132b047cd]
2025-07-22 15:31:54 -04:00
vedithal-amd e40141f2ba Fix memory clock detection with amd-smi (#824)
[ROCm/rocprofiler-compute commit: 0fdd186dd5]
2025-07-22 13:46:06 -04:00
vedithal-amd fc2037870f fix build (#823)
[ROCm/rocprofiler-compute commit: c4d129def5]
2025-07-22 13:02:14 -04:00
vedithal-amd 46ae3d36d9 Remove hardware IP block based filtering (#820)
* Analysis report block based filtering is the default now

* Update documentation

* Update CHANGELOG

* Fix tests
    * Replace hardware block based filtering tests with report block
      based filtering tests

[ROCm/rocprofiler-compute commit: 98bb0f4237]
2025-07-21 09:37:35 -04:00
vedithal-amd 2740d18028 Remove MI50/MI60 gfx906 support per documentation (#819)
[ROCm/rocprofiler-compute commit: 537a269e95]
2025-07-18 09:57:33 -04:00
vstojilj eec311b379 Add missing <cassert> include (#800)
Co-authored-by: Anusha GodavarthySurya <Anusha.GodavarthySurya@amd.com>

[ROCm/rocprofiler-compute commit: d2cec00116]
2025-07-16 13:54:39 -04:00
Pratik Basyal 7c228474ac Minor editorial changes data type selection feature (#816)
[ROCm/rocprofiler-compute commit: 24c27462d7]
2025-07-16 12:39:24 -04:00
Pratik Basyal ce3d76674a Architecture data support and diagrams added (#814)
* Architeture data support and diagrams added

* Architecture image added

* CDNA4 Image updated

* Review feedback incorporated

* CDNA 4 partition mode added

* Fei review feedback incorporated

[ROCm/rocprofiler-compute commit: 8099fd352e]
2025-07-16 10:40:11 -04:00
vedithal-amd 9a442748ea Fix docker testing instructions (#813)
[ROCm/rocprofiler-compute commit: ccb34e8a91]
2025-07-15 17:06:22 -04:00
cfallows-amd 10ead63735 Update workflows for building (#812)
* Update workflows for building testing in pipeline: rhel8 now tests rhel8 and 9, and for both rhel and ubuntu files we are using the same image as rocprofiler-systems which is consistently updated on docker hub.

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

[ROCm/rocprofiler-compute commit: 10c696521d]
2025-07-15 15:12:21 -04:00
cfallows-amd 930b32e2cb Fix roofline block print during CLI output (#811)
Fix roofline panel in CLI analyze stage when using --block option. Improve roofline CLI output checks and logs.

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

[ROCm/rocprofiler-compute commit: 1d834f4190]
2025-07-15 12:42:27 -04:00
xuchen-amd a91363744c Update TUI docs. (#796)
[ROCm/rocprofiler-compute commit: bfb2dc0795]
2025-07-15 11:13:24 -04:00
Fei Zheng 1050e0201c Update peak flops for MI350 (#810)
[ROCm/rocprofiler-compute commit: e1da9355c2]
2025-07-15 08:46:13 -06:00
xuchen-amd 65673617e0 Remove rocm-smi for ROCm 7.1 (#809)
[ROCm/rocprofiler-compute commit: b4b50502e3]
2025-07-15 10:28:53 -04:00
Fei Zheng e0ba0631b0 Update cli doc description (#804)
[ROCm/rocprofiler-compute commit: 5b8d12fde2]
2025-07-14 13:05:01 -06:00
Fei Zheng 769caa3124 Update PC sampling doc (#798)
[ROCm/rocprofiler-compute commit: 78c1898ba0]
2025-07-14 13:04:14 -06:00
xuchen-amd 06b24cbfe1 rocm-smi deprecation warning (#806)
[ROCm/rocprofiler-compute commit: a3dc98e251]
2025-07-14 13:35:47 -04:00
Pratik Basyal 2cfcd9baab roofline footnote updated (#808)
[ROCm/rocprofiler-compute commit: 81d95d8e4a]
2025-07-14 13:27:43 -04:00
xuchen-amd 0ac856237a tui user experience improvement (#805)
[ROCm/rocprofiler-compute commit: 23664c72f7]
2025-07-11 16:51:55 -04:00
vedithal-amd ce73a5ef74 Fix roofline and TUI bugs (#803)
* Fix roofline rocm version bug
* Fix utils bug
* Remove unnecessary tests
* Do not check textual-fspicker package in cmake build
* Use rocprofv3 to test MI 100 and fix tests

[ROCm/rocprofiler-compute commit: 000fd4f5b2]
2025-07-09 19:15:46 -04:00
xuchen-amd 9ebbf4bb03 Generalize config path. (#802)
* Generalize config path.

* Fix format.

* Fix typo.

[ROCm/rocprofiler-compute commit: 8585cd8e8f]
2025-07-09 18:57:21 -04:00
vedithal-amd f730199ef7 Fix util tests (#797)
* Fix profile tests
* Update known issue for corrupted memory chart

[ROCm/rocprofiler-compute commit: c51b9d16c3]
2025-07-08 17:15:09 -04:00
cfallows-amd 7862701993 Update roofline bins for rocm7 changes (#755)
* Update current bins to have rocm6 suffix. Add new rocm7 bins, built on rocm7.0 latest due to hip updates.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Re-add rocm version check for roof bins.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Rebuild roofline binaries on top of latest rocm7 (#16379) after recent mainline promotions.
Adjusting version and distro combinations of bins following rocm6 vs rocm 7 supported OS.
*rhel8 not supported on rocm7, also not built anymore
*sles15 not supported on rocm7 but is still being built
*ubuntu stays as 22.04 and above for rocm7

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Minor fixes after testing.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Fixed bad copy after finding it in testing ctest.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Remove runpath from new bin

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Rework target_binary map return in detect_roofline- we should not be returning maps of different sizes or with different keys for the same method. Expected output should be consistent in case we run into bad position, or for testing purposes. Manually tested all possible roofline bin expected cases to comfirm functionality and expected user output.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Update changelog with new roofline distro minimums

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

[ROCm/rocprofiler-compute commit: 3df0d1dded]
2025-07-08 16:51:50 -04:00
xuchen-amd bac7fde4f4 Add tui cmake install. (#794)
[ROCm/rocprofiler-compute commit: 60a50e681b]
2025-07-08 11:18:26 -04:00
Fei Zheng 09ec955554 PC Sampling: fix potential_end_offset (#792)
* fix potential_end_offset

* format code: unrelated

[ROCm/rocprofiler-compute commit: 1b7445faa4]
2025-07-08 08:52:01 -04:00
Fei Zheng c867eaa9cd format with isort (#793)
[ROCm/rocprofiler-compute commit: 239e6550f4]
2025-07-08 08:51:20 -04:00
fxmarty-amd a91e3f74f3 fix normalization (#789)
[ROCm/rocprofiler-compute commit: c58ee9e73b]
2025-07-08 08:50:41 -04:00
cfallows-amd 30466f6bfa Adjust csv output list for test_block_SPI for MI350 (#785)
Adjusting expected output list for test_block_SPI for MI350 series products.
Run formatter.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

[ROCm/rocprofiler-compute commit: 61a9381edf]
2025-07-03 01:58:11 -04:00
jamessiddeley-amd 94ea0fbf2f additional-code-coverage-compute (#763)
* added additional functions to test_utils.py

* added code coverage for db_connector.py

* Update test_profile_general.py

Added additional roofline test cases

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>

* updated coverage mi_gpu_spec.py 73% -> 94%

* added parser.py coverage

* removed redundant comments

* added test_utils and test_db_connector

---------

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>

[ROCm/rocprofiler-compute commit: a6463f5e98]
2025-07-02 13:29:10 -04:00
cfallows-amd e085f3cc54 Fix method return for python version compatibility (#784)
Support for python3.8 and above means union defined in one of the methods was throwing errors for anything less than python3.10. Swapping out | operand for Optional[] resolves errors on systems using <3.10. No functional changes.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

[ROCm/rocprofiler-compute commit: a59b1ea6e6]
2025-07-02 10:36:37 -04:00
vedithal-amd 740fe492c2 Fix rocprofiler sdk list counters (#765)
[ROCm/rocprofiler-compute commit: 894046f283]
2025-07-02 09:41:51 -04:00
xuchen-amd bfe24beec6 Remove cell backgrouund colors. (#778)
[ROCm/rocprofiler-compute commit: 222dbdc6bd]
2025-06-28 10:38:28 -04:00
jamessiddeley-amd 60ace87e1a added 0400 analysis config yaml files (#779)
[ROCm/rocprofiler-compute commit: 1bb7bf4dd4]
2025-06-27 16:21:19 -04:00
vedithal-amd 86e243201e Fix SPI block counter limit (#780)
* Fix SPI counter collection limit

* Update counter collection limits from aqlprofile

* Remove special handling for MI 350 SPI pipe counters

[ROCm/rocprofiler-compute commit: 6e1bbb5efb]
2025-06-27 14:07:56 -04:00
Fei Zheng 2ffaf5b453 Documentation update for FP8 on MI300 (#766)
[ROCm/rocprofiler-compute commit: f5bc717fe1]
2025-06-26 13:35:36 -06:00
vedithal-amd 1d59cbb06d Add support for MI 100 with rocprofiler-sdk (#768)
* Add custom rocprofiler-sdk counter definitions file for MI 100

* Update CHANGELOG to mention that accumulation counters will not be
  collected when profiling on MI 100 using rocprofiler-sdk/rocprofv3

* Migrate accum_counters.yaml to code

[ROCm/rocprofiler-compute commit: a95a45d69a]
2025-06-26 09:03:18 -04:00
David Galiffi 3a703cec00 Provide a version for RPM Obsoletes attribute (#670)
Fix RPM generation warning

[ROCm/rocprofiler-compute commit: 1903e8e748]
2025-06-25 12:36:47 -04:00
Kunal Malviya fba643793b Adding verbose and changing threads (#771)
Co-authored-by: rocm <rocm@rocm-System-Kunal.amd.com>

[ROCm/rocprofiler-compute commit: 661de1d483]
2025-06-25 18:49:46 +05:30
cfallows-amd 429b17a1e0 Add roofline PDF output to general profiling runs (#774)
Change when Roofline PDFs are generated- during general profiling and --roof-only profiling (skip only when --no-roof option is present)

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

[ROCm/rocprofiler-compute commit: 630bc149ff]
2025-06-25 01:19:28 -04:00
dependabot[bot] 8c3c708eef Bump rocm-docs-core from 1.18.2 to 1.21.1 in /docs/sphinx (#775)
Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.18.2 to 1.21.1.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.18.2...v1.21.1)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-version: 1.21.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

[ROCm/rocprofiler-compute commit: 181e4f44c7]
2025-06-24 21:04:16 -04:00
xuchen-amd b7c6c4eaac Fix system sol units, remove units if None value. (#773)
* Fix system sol units.

[ROCm/rocprofiler-compute commit: 74e9853f8e]
2025-06-24 16:37:55 -04:00
xuchen-amd 7ab4a3f03f GUI: prevent big number overflow (#772)
* Prevent number overflow by formatting values.

* Improve value formatting logic based on comments.

[ROCm/rocprofiler-compute commit: 92ce4732bc]
2025-06-24 16:27:06 -04:00