AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
488 Commits 3 Branches 0 Tags
38009bfba4a36371f4e08fb89f6dd95bf8965926
Commit Graph

488 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Laurent Morichetti 38009bfba4 Fix a compilation error with gcc-9.3.0 
On Ubuntu 20.04, in Release mode, gcc fails with this error:

In file included from /usr/include/string.h:495,
                 from /opt/rocm/include/hsa/hsa_api_trace.h:57,
                 from ../roctracer/src/util/hsa_rsrc_factory.h:29,
                 from ../roctracer/src/util/hsa_rsrc_factory.cpp:25:
In function ‘char* strncpy(char*, const char*, size_t)’,
    inlined from ‘const util::AgentInfo* util::HsaRsrcFactory::AddAgentInfo(hsa_agent_t)’ at ../roctracer/src/util/hsa_rsrc_factory.cpp:323:12:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:34: error: ‘char* __builtin___strncpy_chk(char*, const char*, long unsigned int, long unsigned int)’ specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
  106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      |          ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../roctracer/src/util/hsa_rsrc_factory.cpp: In member function ‘const util::AgentInfo* util::HsaRsrcFactory::AddAgentInfo(hsa_agent_t)’:
../roctracer/src/util/hsa_rsrc_factory.cpp:322:39: note: length computed here
  322 |     const int gfxip_label_len = strlen(agent_info->name) - 2;
      |                                 ~~~~~~^~~~~~~~~~~~~~~~~~

The error is caused by the following 2 lines:

    const int gfxip_label_len = strlen(agent_info->name) - 2;
    strncpy(agent_info->gfxip, agent_info->name, gfxip_label_len);

The size argument to strncpy should not depend on the input string.

Since the terminating character is not considered (the copy is at
most len - 2 bytes), using memcpy is preferable. Also, make sure
the destination does not overflow by clamping the size.

Change-Id: I37c5c45418e7c31a017581b6c16e5d47cd61aec5
 2021-04-19 22:57:51 -07:00
Rachida Kebichi 6267df36e4 SWDEV-281008 replace hcc_detail by amd_detail 
Change-Id: I180b18f9e1fae40c923d6210901f06cba14e8f13
 2021-04-14 11:18:38 -04:00
Rachida Kebichi 8c3bd6817e SWDEV-272488 append to CMAKE_CXX_FLAGS instead of override 
Change-Id: Ib5e6856944bf54b2161cba9ac24adda57fdf8a9a
 2021-04-06 15:45:44 -04:00
Evgeny Shcherbakov 26fd08feae Merge "fxing gfxip label" into amd-staging 2021-04-03 01:31:34 -04:00
Rachida Kebichi 06271806d4 SWDEV-255637 support for hsa_amd_memory_async_copy_rect 
Change-Id: I5db6484c30427712c56b59862e748118a3f079c2
 2021-03-31 10:02:06 -04:00
Cole Nelson 3018150e53 Merge "CMakeLists.txt: add ENABLE_LDCONFIG to support multi-version install" into amd-staging 2021-03-30 15:37:50 -04:00
Rachida Kebichi ad5b463912 SWDEV-271503 Fixed core dump 
Change-Id: Ia582a27482581c3b81c42da0add9f6743898da6c
 2021-03-30 14:06:56 -04:00
Evgeny 2287da5e28 fxing gfxip label 
Change-Id: Ic22d828b38da8afc5a232c2f2eb5de5410844b70
 2021-03-28 08:11:58 +00:00
Cole Nelson 16d4a79562 CMakeLists.txt: add ENABLE_LDCONFIG to support multi-version install 
Depends-On: I58fdf1d0b4e864b5a61ffe8e335d430d424811ab
Change-Id: I1eeb778ac58a2c4b588244adc3112ecb1aa15217
Signed-off-by: Cole Nelson <cole.nelson@amd.com>
 2021-03-27 15:36:02 -07:00
Evgeny 1c77416a6c SWDEV-267198 : adding gpu index to hsa_handles file 
Change-Id: I6ddba45ab31fff97a1f85f889c56693accf8f5bc
 2021-03-09 15:37:44 -06:00
Evgeny 912cfd4cf8 SWDEV-251491 : fixing tracing on exit 
Change-Id: I1bf2a6093331e7a08179b9f64394c5c49206ef0e
 2020-12-25 01:49:44 -05:00
Evgeny 99eee45546 SWDEV-251491 : disabling tracing on exit 
Change-Id: Ifd5f0fbad70afa1e79da8b4b9aa639d899cbea76
 2020-12-22 04:55:07 -05:00
Rachida Kebichi 2d31848c44 SWDEV-259683 HIP API records filtering 
Change-Id: I43ca5e022d2c055b6a9bc2c09b4276b490a4b986
 2020-12-16 16:29:36 -05:00
Evgeny Shcherbakov 3e4539c95d Merge "calling python3 explictely" into amd-staging 2020-12-16 16:01:57 -05:00
Evgeny bb5f2231a1 calling python3 explictely 
Change-Id: I3dda55865bafa41cc6670e414b213f13a2a2a7ac
 2020-12-16 14:29:12 -05:00
Evgeny 4baffc8e53 SWDEV-264282 : fixing tracer_tool linking 
Change-Id: I0fd78c01595bbd506f42cf9dfb45f62b2124f704
 2020-12-09 22:18:22 -05:00
Evgeny b83ffeeab8 SWDEV-258731 : cleanup 
Change-Id: Iabcc81576eb8b6c0484eae820c3e25a896da6c5b
 2020-12-02 13:52:57 -06:00
Evgeny Shcherbakov 6a59675f01 Merge "Adding dumping of HSA handles" into amd-staging 2020-12-02 06:35:04 -05:00
Evgeny 7d8fd0606d Adding dumping of HSA handles 
Change-Id: I18e2cfdf2574110bffa09d30c7ac1d3941252939
 2020-12-01 16:45:33 -05:00
Evgeny Shcherbakov 20f3103b72 Merge "adding tests dry run to check if platform is in working state" into amd-staging 2020-11-24 14:00:31 -05:00
Evgeny 6aa28d511f adding tests dry run to check if platform is in working state 
Change-Id: Ic430e3f959119983a65929fc70332e293cc3448d
 2020-11-23 13:09:46 -06:00
Rachida Kebichi ef36218286 SWDEV-255938 NEW - added regex and depth support to ostream ops 
Change-Id: I292255adab3a70fa00a1dd5685b788521687f35b
 2020-11-18 16:48:50 -05:00
Cole Nelson 16ad4e9de7 CMakeList.txt: conformant package names 
Still needs valid email ID in the form of package_name.support@amd.com.
SWDEV-257322

Names complete as built (internal) :
roctracer-dev_1.0.0.40000-crdnnv.444_amd64.deb
roctracer-dev-1.0.0.40000-crdnnv.444.el7.x86_64.rpm

These changes are to satisfy:
http://confluence.amd.com/display/GPUCPT/Package+File+Naming

Change-Id: I5991326eb87d7dfa1304e3b2c5afb78f5a0c0361
Signed-off-by: Cole Nelson <cole.nelson@amd.com>
 2020-11-10 13:06:36 -05:00
Evgeny Shcherbakov d5c138b518 Merge "SWDEV-254329 : extending debug trace with timestamps, cmake option '-DCMAKE_DEBUG_TRACE=1'" into amd-staging 2020-10-20 12:34:23 -04:00
Evgeny 6d2bca792b code obj tests: adding load base 
Change-Id: I5fdb25b67eaae43b3c01cd8de3824f9343c37794
 2020-10-16 17:54:43 -04:00
Evgeny cb3643da05 SWDEV-254329 : extending debug trace with timestamps, cmake option '-DCMAKE_DEBUG_TRACE=1' 
Change-Id: Id16c01a6c00f6384c37fa9b5a9709a5e98e1fb57
 2020-10-14 00:07:12 -04:00
Evgeny 29c63c5281 SWDEV-213367 : codeobj event implementation 
Change-Id: Ibcaca6869ce96d8802c5fa8ba241f43834d6f2a7

update - codeobj event implementation

Change-Id: I4c12f26a19f2b31d9ac2211c3426a0e587a332b3

update2 - codeobj event implementation

Change-Id: Ic877549a83542ae00352503471d881e847ebac9c

test - codeobj event implementation

Change-Id: I0618d3a93de94c3d7467372ba4a3d4ea5520bfc7

URI reference test - codeobj event implementation

Change-Id: I6cf7e8a648cf012cb0708058b118a75e58f992b9

adding test/app - codeobj event implementation

Change-Id: Idf4c197c7b9116ccde5ec50ff47a26a858bfab32

uri test fix - codeobj event implementation

Change-Id: I7c385f82f516d9d8f2cd726366f00be3664006e3

uri test cleanup - codeobj event implementation

Change-Id: I542d5baf88c048c8b4717af843b803cd93e8f3bc

URI buffer fix - codeobj event implementation

Change-Id: Iac65e04c03a0939935c10f53c6b580a2e33878f5

HSA events tests trace-check disabled

Change-Id: I0f4d13aeeceb1d1a6e2191673eacbf9c7ae2ae52
 2020-10-09 08:36:12 -04:00
Evgeny Shcherbakov 02fcb90a4b Merge "hip library loader check" into amd-staging 2020-10-07 19:01:55 -04:00
Evgeny Shcherbakov 330299b7f0 Merge "SWDEV-251491 : gen_ostream_ops.py porting to python3" into amd-staging 2020-10-07 18:54:20 -04:00
Evgeny 9061c4ea41 hip library loader check 
Change-Id: I34957db88932e1ed725a0a0d8ca9a66fecc92e38
 2020-10-07 17:53:51 -04:00
Evgeny ef61a39603 SWDEV-249924 : hip correlation id explicite propogation; tracer debug instrumentation; 
Change-Id: Ibbc411541f5610ce739f3fc1efa1ab7f605220f5

initial commmit

Change-Id: I34b360be62c2083819dc5c3acc8268bd69f2f58a
 2020-10-06 13:25:51 -04:00
Pareshkumar Ghanshyambhai Patel 7b6c94e9e9 Merge "SWDEV-253997 : packaging fix: installing hsa_ostream_ops.h" into amd-staging 2020-10-03 23:06:11 -04:00
Evgeny bb8f2f6785 SWDEV-251491 : disabling hipModuleUnload tracing which is called on exit 
Change-Id: I99c22eec3fea6ac8820d574c44df099febdd27c4
 2020-10-01 12:47:40 -04:00
Evgeny 9562675382 SWDEV-251491 : gen_ostream_ops.py porting to python3 
Change-Id: I7081b6ad21b038040267067bd73d8a44df46e4ff
 2020-10-01 00:52:23 -05:00
Evgeny 1d975e5ba5 SWDEV-253997 : packaging fix: installing hsa_ostream_ops.h 
Change-Id: Ib739cbb7538473afc9744e12d2bd568635e78616
 2020-09-28 13:19:51 -04:00
Evgeny Shcherbakov 093844ba0e Merge "codeobj tracing prof protocol" into amd-staging 2020-09-20 22:17:33 -04:00
Evgeny 8bdf282645 HCC_HOME env cleanup 
Change-Id: I2b00e5d310e6349fc52d5df60aae85f4c06adebe
 2020-09-19 17:50:57 -04:00
Evgeny 6567c48e98 codeobj tracing prof protocol 
Change-Id: Ib49c8ee034fb7481b21f950490e10b350f2a1b79
 2020-09-19 16:49:46 -05:00
Evgeny bada601e64 testing using v3 object 
Change-Id: Ifca31d632726ab83f4c672b46cd9b97f817e757d
 2020-09-16 20:34:42 -04:00
Rachida Kebichi 29da9a744d Fix for trace checker 
Change-Id: Ib8a0df7b7bb0da2e68b5b4d99ce8025de169f317
 2020-09-11 14:26:47 -04:00
Evgeny Shcherbakov 361f099847 Merge "build normalizing - generating under build directory" into amd-staging 2020-09-11 09:42:28 -04:00
Evgeny c9ed0f067d gen_ostream_ops.py fix - ostream operators as inline static 
Change-Id: I9688236b06dd167960662b8eecf1a07c93b43fff
 2020-09-09 01:46:23 -05:00
Evgeny ed1f1b66ac build normalizing - generating under build directory 
Change-Id: Id9203aec7800024bd749059a415fb29b8051005a
 2020-09-07 15:24:58 -05:00
Evgeny e9b8de644e Format ostream ops 
Change-Id: I8c609b1ef82e02f3547541c2cc47dec3a4f1c7b3
 2020-08-28 11:30:18 -05:00
Evgeny 156d9327cc flush-rate option fixed 
Change-Id: I74ff83ebf2a0a4ba414d30b7cb193522f44660ce
 2020-08-20 15:11:38 -05:00
Evgeny ddcb68d0a8 optimized tool stats 
Change-Id: Ia9c06879f6e2e195e589c53299c2cafe96a4bfe5
 2020-08-20 15:11:21 -05:00
Evgeny 2f608e067a incrementing API version because of HIP API changes 
Change-Id: I19e42ca75d8050b44b1cdf70cac7dfdff1ab5d57
 2020-08-15 03:25:57 -04:00
Aaron Enye Shi 28e5d02888 Add --rocm-path to MatrixTranspose test 
Change-Id: Ifd5859b90bf8eb2aff5318000cac60dc1c82e0b1
 2020-08-13 13:15:17 -04:00
Rachida Kebichi d3406bdb7b Merge "Added roctxRangeStart and roctxRangeEnd" into amd-master 2020-08-12 10:32:29 -04:00
Rachida Kebichi da17a158f8 Added roctxRangeStart and roctxRangeEnd 
Change-Id: Id7f81c5a7d7f231c8f0e2323d31c37c827687189

Added roctxRangeStart and roctxRangeEnd

Change-Id: Id7f81c5a7d7f231c8f0e2323d31c37c827687189
 2020-08-11 17:28:03 -04:00