Commit Graph

5526 Commits

Author SHA1 Message Date
Payam 39d681b6be adding duration to print log for hip api calls
Change-Id: Icffa8fcacfb8ba24861d980b9553faeee4efec8c
2020-08-06 06:42:21 -04:00
Sarbojit Sarkar d768406ec4 Added free device memory info
Recently there were few OOM(out of Memory) issues poped. Adding trace will help know genuine OOM issue. 
Change-Id: Ie2a56bba95cead24caf1af5c807e73c383c2f5d9
2020-08-06 01:16:36 -04:00
Anusha Godavarthy Surya 9ea54f7797 SWDEV-243961 Added overflow check for globalWorkSize
Change-Id: I153d99398eb4619baad8c0a52466e0d5d5f898ca
2020-08-05 11:18:07 -04:00
Aryan Salmanpour ee149e4610 [dtest] disable hipStreamCreateWithPriority test temporarily as it fails randomly on Jenkins
Change-Id: I4edcd555653ef8e7562245da3a6f310d60884fe0
2020-07-30 16:18:04 -04:00
jujiang 5f5486d4b1 SWDEV-242207-Update deprecated APIs
Change-Id: Icb64227be0eb44497de99240c0044a162ff3c085
2020-07-30 15:15:41 -04:00
Rahul Garg 3abb559f72 Support empty sources in add_executable and add_library
Change-Id: I1441f2c045aeda2bba99bffe1c99fcc4a59cea9b
2020-07-30 13:34:46 -04:00
Rahul Garg dd82a30348 Bump version to 3.8
Change-Id: I710ee1456aa108eb979eb5bef8f32081dda593d9
2020-07-30 13:30:55 -04:00
Jatin Chaudhary e7eaafe165 Fixing/Disabling tests on nvcc path
Change-Id: I7ed4a1246943867482ff595d5f98bb25bd79074b
2020-07-30 00:39:07 -04:00
Freddy Paul eb94afcff9 hip-rocclr:Remove dependency to rocm-utils
rocm-utils is a meta-pacakge that pull in lot more pacakges than
what is required for hip.

Correct dependency to set as of today will be rocminfo.

Change-Id: I065ca74b4520e0c9ce183d82d6026554ff43e1f0
2020-07-28 11:42:09 -04:00
Jason Tang 678b3eeed5 SWDEV-243576 - Fix hipMemcpy regression.
If the queue device doesn't match the device on any memory object, use the queue device from the memory object.

Change-Id: I5fdcf00494f8391574f4443332c01788b8da44ef
2020-07-28 03:04:00 -04:00
Jatin Chaudhary c5264eaa67 Removing redundant .hipInfo Install
Change-Id: Id8f7a4668d8b6965a47a464c94c19bc1036f3537
2020-07-28 02:01:53 -04:00
Rahul Garg dc904abd8a Remove libhip_hcc symlinks to libamdhip64
Change-Id: I7b5b47fc7ca9760316c2424c16b454d7919c665c
2020-07-27 23:58:29 +00:00
jujiang 448008348e SWDEV-242344-hipMemcpyAll failed on MGPU
Change-Id: I01671e322c84213964d3d48bd6b5dc704dba731a
2020-07-27 13:30:30 -04:00
Tao Sang ef9176db03 Remove __gnu_h2f_ieee and __gnu_f2h_ieee
Change-Id: Ide24d245d851e20961020323e52f33322a33fff9
2020-07-23 14:50:24 -04:00
Vlad Sytchenko ed26013ec1 2D/3D copy optimizations
SWDEV-244798

If {src/dst} ptr is marked as hipMemoryTypeHost, check if the memory was
prepinned. If it was, upgrade the copy type to hipMemoryTypeDevice to
avoid extra pinning.

Change-Id: Id287ef5b14ae67dfbcf80c4caa1b08a311191948
2020-07-23 11:24:16 -04:00
Tao Sang 78f9a70578 Apply constexpr on global constant varaibles
When HIP_ENABLE_DEFERRED_LOADING=0, many global variables will be
referenced but they are not initialized in that early time. The patch
will use constexpr to initialze global constant varables in compile
time.

Change-Id: I9837c42e6bab38a894ece4e0f34b64f81b38fef0
2020-07-22 22:15:03 -04:00
kjayapra-amd dab399f22c SWDEV-236178 - Remove use of old routines functions()/modules().
Change-Id: I3a1ed967227c91b0d8cdf39e1360ade685e0bc73
2020-07-22 14:55:02 -04:00
kjayapra-amd 4d42a969fd SWDEV-240800 - Adding initial support for hipDeviceGetP2PAttribute. Some attr support still pending.
Change-Id: I0611aed136270db497dfa374144f6f5e35352a8f
2020-07-22 14:54:34 -04:00
Payam f8e6b228a7 modify cmake to strip debug symbols from rel blds
Change-Id: Ia67261fc3c4a20f3f1bbe439a70384a3f6aefa91
2020-07-22 11:53:54 -04:00
Tao Sang fc5ccbe13d Support numa if libnume-dev is installed
Let rocclr decide numa dependence

Change-Id: I65bdfba7ec0d06b550f86632318bcfd1f765cfa9
2020-07-22 08:55:28 -04:00
Satyanvesh Dittakavi 8fc4d64d2a SWDEV-244772 - Fix dtest hipMemcpyWithStreamMultiThread.cpp.
hipSetDevice is not used correctly to allocate on multiple devices in mGPU setup.
Due to which hipMalloc was called on the same device on multiple threads leading to out of memory issues on some devices with lesser memory.

Change-Id: I0e5b1bc028b9ecb11bd40c3a5edf715f8bd721ff
2020-07-22 00:52:14 -04:00
Saleel Kudchadker f897f003cf Print devPtr and size for hip*Symbol* api
Change-Id: I07be6949cca005700ee1d1708d86220c793c9728
2020-07-21 13:49:10 -04:00
Rahul Garg 0fdec26a29 Handle size 0 symbols
Change-Id: Ie282b37cf6bbccae4611dfc17c5c7f31977feea7
2020-07-21 10:09:26 -04:00
Aryan Salmanpour 2e72f989bd Add missing stream null check for some hipStreamCreate APIs
Change-Id: I716d71e4ec59b0bd7922869bfa0ed908c22c289e
2020-07-20 18:07:03 -04:00
jujiang 3b7e1b928e SWDEV-242337-Fix hipHostRegister test failure for MGPU
Change-Id: I748dac0c5a47fa00184f065d9ef716573aa70b12
2020-07-20 11:40:49 -04:00
Sudheer Kumar 3626372239 [dtest] Compare hipDeviceGetPCIBusId output with lscpi output
SWDEV-238517 for enhancing hip unit tests

Change-Id: I5507dd19fc22e7f8806655eefaa69fbd61c98f56
2020-07-20 04:31:48 -04:00
German Andryeyev d491dbd796 Grab the event lock before fetching the last command
Hip applications assume that hipEventRecord called from multiple
threads will contain exactly the last queued command to the stream.

Change-Id: I1da3259f143d7670d0870d9a47c08e32336b2222
2020-07-20 02:01:16 -04:00
Ashutosh Mishra 9f3cf75713 Adapting to static libaray changes for hipcc
Since the introduction of BUILD_SHARED_LIBS there is only one target created : libamdhip64
Which is static ( libamdhip64.a ) or Dynamic ( libamdhip64.so ) depending on whichever it is
being compiled for. After this change we do not have any target libamdhip64_static which is
mentioned in the hipcc for linking. Hence cleaning the same.

Change-Id: Ia45c145e17b111b3f6a32299a11962b10f1cc539
2020-07-17 14:42:07 -04:00
jujiang 9f1cd25ade SWDEV-243933-update HIP README document
Change-Id: Ie303698ae92c7fa1b1202c1ee06beda1005ba065
2020-07-17 12:26:05 -04:00
Christophe Paquot 0d83b385d1 Remove use of setLastQueuedCommand
Change-Id: I07bf54dc09905d9a17b059a476df9282eb6f1f51
2020-07-17 11:45:25 -04:00
Evgeny 920e6597b2 cleanup: unneeded '\'
Change-Id: I0276312fdb0e4829d678de4281ccfd12eb7f232e
2020-07-16 01:57:07 -05:00
Ashutosh Mishra ab88cbbb8a Adding "BUILD_SHARED_LIBS" flag to cmake files
JIRA : SWDEV-234471
With this change compilation of the ibamdhip64 to be decied by arguments to build_hip_on_rocclr.sh file
build_hip_on_rocclr.sh -r (current) shall conitnue to create libamdhip64.so;
build_hip_on_rocclr.sh -r a (new) shall create libamdhip64.a
other options remain the same

Changed the targets according to requirement of stage2 dependencies.
Changed find_lib with find_package

Adpated the review comments

Change-Id: I719918f73ab33cd8031a32db6fe9b8adaa1b4b87
2020-07-16 00:29:14 -04:00
Sudheer Kumar 50f285ad67 [dtest] Enhanced tests to cover multiple hipmemset and hipmemsetAsync apis
SWDEV-238517 for enhancing hip unit tests

Change-Id: Iba2c419a4487955f34b4f19abe174ef427d289d8
2020-07-15 01:13:07 -04:00
sushantkumar14 e590f20cbd [dtest] Half2 comparison related tests
Tests heq2, hne2, hle2, hge2, hlt2, hgt2 APIs for functionality
and NaN tests

SWDEV-238517 for enhancing hip unit tests

Change-Id: I88a9a8ead0d00a1261f3d650361d655f2f397e48
2020-07-14 23:53:55 -04:00
mshivama 27e237ef48 Add support for few CUDA compatible reduction operations like __syncthreads_count()
Change-Id: I0917820058f0edad5c0bdd42dea37f06353fc63c
2020-07-14 12:03:14 -04:00
Sarbojit Sarkar b2b5a821df host pointer check [SWDEV-243104, SWDEV-243206]
Change-Id: Id58dabfe5c35e5f8e42d224e700a431a4a97d003
2020-07-14 07:16:12 -04:00
kjayapra-amd 7299eb84ce SWDEV-240165 - Adding a simple test for IPC memory.
Change-Id: Ib33ac20412cafa779fe20ff4df8a76dc22d50421
2020-07-13 10:29:04 -04:00
Tao Sang 66fca8be23 Implement HIP_ENABLE_DEFERRED_LOADING in right way
Change-Id: Ia28dbdea5cde93b3ca69f44c6a3c18ec8a730d42
2020-07-11 18:14:03 -04:00
kjayapra-amd 7233bb75da SWDEV-240165 - Move all amd::MemObjMap_ reference to ROCclr and only allow base ptr to get ipc handle.
Change-Id: I4f11e56ba455a7ce5a066c0e9e49657c5220a211
2020-07-09 21:19:50 -04:00
German Andryeyev b9b982247e Host device context should return a valid queue
Host memory allocations use shared device context, which allows
to have access from any device. That breaks default queue detection.

Change-Id: I27ad1234d49ab0ea8f5edd6f2e3ffa93c47d4b1f
2020-07-09 10:56:33 -04:00
sushantkumar14 77ae61cff7 [dtest] Added hipStreamGetPriority API test
SWDEV-238517 for enhancing hip unit tests

Change-Id: Icff175360815ba6e25a6954a67947b65caff3711
2020-07-09 01:59:44 -04:00
jujiang ba2cd19726 SWDEV-242207-Update deprecated APIs
Change-Id: I0c1c7f33f75232b210495241d0e5e7e6b90d45f0
2020-07-08 15:23:52 -04:00
jujiang f9f0580829 SWDEV-241903-Add document HIP_logging.md
Change-Id: I348218218b305e845b7e26afaeb4e287bf0387de
2020-07-08 11:19:33 -04:00
Rahul Garg 6a277dea45 Bump version to 3.7
Change-Id: Id077c317573e95833c8bc7f16951df776de2a273
2020-07-08 01:54:05 -04:00
Aryan Salmanpour 9121a74ac1 add an error message before aborting if a wrong GPU target was used for compilation
Change-Id: I7b41e93d420dbc47978238a681f2956a0def01cb
2020-07-07 14:50:44 -04:00
Lakhan singh Thakur d613d1d58b [dtest] Enhancing hipStreamAddCallback() api test
-Scenario-1:: This test case is used to verify if the callback function
              called through  hipStreamAddCallback() api completes the
	      execution in order as hipStreamAddCallback() api queued
	      in their respective streams: hipStreamACb_AltEnqueue.cpp
-Scenario-2:: This test case tests if Host thread continues with next
              command after hipStreamAddCallback() api or wait for
	      callback() call to finish. Ideally Host thread should not
              wait for callback to
              finish: hipStreamACb_ThrdBehaviour.cpp
-Scenario-3:: Streams are launched in individual GPUs with different
              kernel Verify that all the kernels queued are executed
	      before the callback is hit: hipStreamACb_MStrm_Mgpu.cpp
-Scenario-4:: Checks the callback execution in the same order it was
              added. Also, it checks if the number of callbacks
	      executed are same as the number of callbacks added:
	      hipStreamACb_order.cpp
-Scenario-5:: This test case checks whether hipStreamSynchronize() is
              taking less time than the time taken by Callback()
	      function launched by hipStreamAddCallback() api :
	      hipStreamACb_StrmSyncTiming.cpp
-Scenario-6:: This test case is used to check if the runtime is ok when
              hipStreamAddCallback() is called back to back multiple
	      calls: hipStreamACb_MultiCalls.cpp
-Scenario-7:: This test case is used to check the behaviour of HIP when
              multiple hipStreaAddCallback() are called over multiple
	      Threads:hipStreamACb_MultiThread.cpp
              (Currently disabled)

SWDEV-238517 for enhancing hip unit tests

Change-Id: I9c7b7df6766c728b2b201df18726b9fbdd434c06
2020-07-07 00:43:32 -04:00
Michael LIAO 5ab67017f5 [hipcc] Only add -x hip on HIP-Clang compilation.
Change-Id: I19704c713ad00f92196d7586498e62f80b8cd177
2020-07-06 15:16:51 -04:00
Yaxun (Sam) Liu 13316e2919 Add pow(float/double/_Float16,int)
Change-Id: Ie65d15cd3df9853a3bbd613d8c7188ae39c327c7
2020-07-06 07:38:57 -04:00
Jatin Chaudhary 24554e6755 Fix error: cannot pass object of non-trivial type string through variadic function when building in debug mode
Change-Id: Idd55ed422addc815fb56c57b05bd4afa9563f2ac
2020-07-06 00:48:40 -04:00
Jason Tang e29b828b7c SWDEV-242879 - Not to use fixnames
Change-Id: I3d0e2f3fe6c773e020c8bf8cdfd75fd565d61505
2020-07-02 08:15:07 -04:00