Commit Graph

64565 Commitit

Tekijä SHA1 Viesti Päivämäärä
amd-hsivasun 3d10a43c02 [Ex CI] Added Azure pipeline tags to README (#959)
* Update README.md

* Update README.md

* Update aqlprofile Pipeline Status
2025-10-09 15:46:06 -04:00
Satyanvesh Dittakavi 6b85dcf227 SWDEV-557093 - Add nested tiled partition in HIP cooperative groups (#1166) 2025-10-10 00:21:44 +05:30
systems-assistant[bot] 1ae36dd856 SWDEV-538181 - Fix 1D buffered image copy (#441)
* SWDEV-538181 - Fix 1D buffered image copy

Fix wrong logics to copy to/from 1D buffered image
in PAL path.

---------

Authored-by: taosang2 <tao.sang@amd.com>
2025-10-09 09:47:11 -04:00
Jatin Chaudhary 22b4ff7aae SWDEV-1 fix issues seen due to test sharding (#1134) 2025-10-09 06:26:05 +01:00
Mythreya Kuricheti fd82a185c2 [CI][rocprofiler-sdk] Add HIP build to CI (#1311) 2025-10-08 21:37:42 -05:00
Geo Min 388edb1b57 [TheRock CI] Adding profiler builds (#1301)
* Adding profiler for TheRock CI

* adding temp test for rocproiler

* Removing subtrees

* PR comment
2025-10-08 14:38:38 -07:00
Jason Bonnell cccc350dc6 [rocprofiler-systems] Add different test coverage for CI/Nightly, add better logging for failures (#1272)
* Try outputting LastTest.log

* Update if condition for outputting log

* Another attempt

* Only run Ubuntu Noble on MI355 in push/PR

* Try exclude matrix

* Move conditional statement in matrix exclusion

* Create ci-matrix.yml file

* Add needs parameter to ubuntu job

* Fix typo in matrix output variable

* Add back pull_request_template.md

* Add back pull_request_template.md
2025-10-08 15:18:56 -04:00
Ethan Trinh 5cc7a7356a SWDEV-553103 - Remove adobe and afterfx workaround (#865) 2025-10-08 13:03:37 -04:00
cadolphe-amd 207a278d41 SWDEV-516307 - Clean up ICD references in HIP (#1019)
Moved default empty dispatch table and associated Platform initialization for HIP from fixme.cpp into the respective struct definitions.
2025-10-08 09:49:35 -04:00
Kian Cossettini 0c53a12a88 [rocprofiler-systems] [ROCpd] Add OMPT callbacks to ROCpd (#1016)
* Add OMPT to ROCpd

* Use correct category

* Added wrapper functions for future control

* Formatting

* Fix naming

* Comment change

* Remove ompt_get_cb_args

* Switched to using region_sample for OMPT

* Remove relic function

* Remove get_use_rocpd that was used in this pr (one still remains)

* Rename ompt_get_args_string and reuse in tool_tracing_callback_stop

* Make lock init and destroy cb instant

* [Prototype] ROCPD Name fix

* [Prototype] ROCPD Name fix P1

* [Prototype] ROCPD Name fix P2

* ROCPD Name fix

* Var name changes

* Rewrite cb overwrite to single function

* [Important] Use parallel_data as key for parallel callback map

* Fix workflow failure

* Make cpp USE_ROCM consistent with hpp and use default constructor if USE_ROCM = 0

* Add missing ROCPROFILER_VERSION check

* Improve readability

* Make ompt storage maps thread local

* Part 1: Variable name fix, memory cleanup, and fixed asserts

* Part 2: Add comments

* Part 3: Add CI_THROW

* Part 4: Formatting

* Part 5: Move #include to cpp
2025-10-07 19:01:25 -04:00
David Galiffi d6bdc53f1a Update rocprofiler-systems-continuous-integration.yml (#1271)
Disabling network test from CI while we investigate it's instability.
2025-10-07 18:55:30 -04:00
German Andryeyev 7ca2497378 rocr: Add AQL queue support under Windows (#1211)
Add 2 extra caps into the thunk interface to indicate
the queue object creation and PM4 emulation
2025-10-07 17:55:08 -04:00
ammallya 7cc026bf98 Adding release trigger (#1295)
* Adding release trigger
2025-10-07 10:43:31 -07:00
Rahul Manocha 27ec19116d SWDEV-557828 - fix hip-tests on cuda (#1152)
Co-authored-by: Rahul Manocha <rmanocha@amd.com>
2025-10-07 08:28:56 -07:00
Ben Richard f578f39f0a Fix web GUI displaying same section multiple times (#1267)
Some sections were being displayed multiple times in the web GUI.

Code to append the section was nested inside the subsection loop,
so each time a new subsction was appened to the section,
the entire section was appended.
2025-10-07 10:29:45 -04:00
Sam Ruscica 135c38b41c SWDEV-553436 Created wrapper functions for file read and file write (#935) 2025-10-07 09:42:22 -04:00
Gopesh Bhardwaj da457c9a43 [Documentation] rocprofv3 attach/detach (#1108)
* Fixing typo in script

* updating docs

* updating docs

* updating docs

* Update projects/rocprofiler-sdk/source/docs/how-to/using-rocprofv3-process-attachment.rst

Co-authored-by: Mark Meserve <mark.meserve@amd.com>

* Update projects/rocprofiler-sdk/source/docs/how-to/using-rocprofv3-process-attachment.rst

Co-authored-by: Mark Meserve <mark.meserve@amd.com>

---------

Co-authored-by: Mark Meserve <mark.meserve@amd.com>
2025-10-07 13:17:55 +05:30
Venkateshwar Reddy Kandula 952d1dabe2 [ROCProfiler-SDK][ROCR] HSA New API changes for HSA_AMD_EXT_API_TABLE_STEP_VERSION 8 (#1182)
* add new hsa ext api for version 8.

* use fmt instead of ostream.

* override rccl from therock

* Update rocprofiler-sdk-continuous_integration.yml

* Update rocprofiler-sdk-continuous_integration.yml

* Update rocprofiler-sdk-continuous_integration.yml

* enable rocr-build

* format

* disable att consecutive-kernels tests.

* Enable ROCR build in code coverage workflow

---------

Co-authored-by: Venkateshwar Reddy Kandula <venkateshwar.kandula1306@gmail.com>
2025-10-06 13:09:39 -05:00
Jason Bonnell ad78611674 rocprofiler-systems Nightly and CI on Ubuntu Jammy/Noble on MI355 and MI325 (#997)
* Initial steps added for rocprofiler-systems-continuous-integration.yml

* Add new line to end of rocprofiler-systems-continuous-integration.yml

* Fix matrix issue in rocprofiler-systems CI workflow

* Update runner to use mi355

* Remove sudo from ROCm download step

* Add Python venv

* Try to install python venv

* Add -y to pip venv install commands

* Add shell: bash to download ROCm step

* Fix issue in if statement

* Fix typo in mv command

* Fix mv command

* Update paths

* add directory in install step

* Use default runner for now while debugging setup

* Add set -e to steps

* debug build step

* Add amdgpu install step

* remove working-directory from amdgpu install step

* add path/ld lib path, add -S argument to run-ci.py

* Fix typo in DCMAKE_PREFIX_PATH

* Add DGPU_TARGETS to run-ci.py command

* add Docker options, remove GPU_TARGETS

* Install amd-smi-lib

* Add DCMAKE_BUILD_TYPE, update path

* Remove mkdir

* Add build dynist cmake arguments

* Update cmake arguments again

* Add missing \ to run-ci.py command

* add libdw dependency

* Add later install step

* Increase timeout of configure/build/test step

* use 16 jobs to try and speed up pipeline time

* Add GHCR image, remove TheRock tarball download step, minor changes for debugging

* Add credentials to container portion of step

* Add package read permissions to ubuntu step

* Update tarball name

* Increase jobs to 16, disable some tests for now due to timeouts

* Modify to only include gpu tests

* Fix configuration

* Enable MPI on run-ci.py run

* Add install MPI step, changed tests to be run

* Enable OMPI flags, enable network counter access

* Use new Docker image names, add privileged option to Docker

* Change cmake build type

* Add fail-fast false option for CI

* Update ROCM_VERSION variable to reflect docker changes

* Specify TARBALL_ROCM_VERSION as separate

* Add MI325 to debug pipeline errors

* Move location of env variables

* Only test on jammy for now, run all tests to assess other issues

* test with branch that contains fix for openmp

* Exclude "ompvv"

We will re-add one ticket is fixed.

* Test: Disable USE_MPI

* Replace TheRock ROCm install with rocm-dev for now

* Try out MI355 noble and MI325 for jammy/noble

* Update amdgpu step to support different ROCm versions

* Remove unused env variables

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-10-06 11:40:58 -04:00
ggottipa-amd c8ab57fe15 correcting typo. (#1222)
fixes SWDEV-557963.
2025-10-06 21:04:55 +05:30
systems-assistant[bot] 774cb67314 SWDEV-489106 - Hip Tests for Linker APIs (#578)
1) Test linking of SPIRV bundled and unbundled code object in runtime
2) Negative Param test for hipLinkAddData API

Change-Id: I7c8167f6d862f5b23f9532f69b6da4fc50e96dcd

Co-authored-by: Rahul Manocha <rmanocha@amd.com>
2025-10-06 08:34:33 -07:00
swargamrambabu e7e38d87f7 SWDEV-546350 - [catch2][dtest] Test cases for hipMemPrefetchAsync_v2 and hipMemAdvise_v2 (#664)
* SWDEV-546350 - [catch2][dtest] Test cases for hipMemPrefetchAsync_v2 and hipMemAdvice_v2

* SWDEV-546350 - Enable tests for NVIDIA, Guard failing tests

* SWDEV-546350 - Add checks for Managed Memory Support

* SWDEV-546350 - Gaurded Numa related things against windows

* SWDEV-546350 - Removed some scenarios which needs fixes, gaurded for NVIDIA

* SWDEV-546350 - Incorporated review comments

* SWDEV-546350 - Corrected File name

* SWDEV-546350 - Resetted to default device, modifed initial data filling ways

---------

Co-authored-by: jainprad <92369414+jainprad@users.noreply.github.com>
2025-10-06 16:59:21 +05:30
Jaydeep 98d6d268a0 SWDEV-556588 - Handle graph node set params and disabled nodes for AQL packet batching. (#1099) 2025-10-06 13:26:12 +05:30
ajanicijamd 02883c3d8d Fixed openmp-vv tests (#1203)
* LD_LIBRARY_PATH was being overridden so tool's libraries could not be found.
2025-10-03 21:33:02 -04:00
Milan Radosavljevic 273919460c Find and include python libs in LD_LIBRARY_PATH for rocprof-sys-python (#1224) 2025-10-03 16:19:16 -04:00
Jason Bonnell f0fd2797b6 Add rocm-version 7.0 to rocprofiler-systems workflows (#1139)
* Adding rocm 7.0 to Ubuntu, Red Hat, and Debian workflows

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-10-03 13:16:21 -04:00
vedithal-amd 4870b2b881 Fix tests (#1213) 2025-10-03 09:52:38 -07:00
systems-assistant[bot] 3a9bf2e9f6 SWDEV-546351 : Added test cases for hipGetDriverEntryPoint api (#525)
* SWDEV-546351 - Added test cases for hipGetDriverEntryPoint api

* SWDEV-546351 - Added test cases for hipGetDriverEntryPoint api

* SWDEV-546351 - Added test cases for hipGetDriverEntryPoint api

* SWDEV-546351 : Added test cases for hipGetDriverEntryPoint api

* addressed review comments Added non-zero check

---------

Co-authored-by: Anavena Venkatesh <Anavena.Venkatesh@amd.com>
Co-authored-by: jainprad <92369414+jainprad@users.noreply.github.com>
2025-10-03 14:12:16 +05:30
Kian Cossettini edfda63701 Remove OMPT category and fix certain preprocessor checks (#1165)
* Part 1: Remove OMPT Category
* Part 2: Properly remove backend choices
* Part 3: Ensure preprocessor checks if user defined var to OFF
2025-10-02 21:08:18 -04:00
David Galiffi c0f8627e7f Update CI Docker files (#1202)
- Add `nlohmann-json-dev` (or equivalent) to CI Docker images for RHEL, SUSE, and Ubuntu.
- Add `gmock-dev` and `gtest-dev` (or equivalent) to CI Docker images for RHEL, SUSE, and Ubuntu.
- Add `--set solver classic` to conda config to resolve an issue setting up the conda environment
- Fix Perfetto package installation on ubuntu noble image.
- Add a check and log error if pip installation fail 

---------

Co-authored-by: jbonnell-amd <jason.bonnell@amd.com>
2025-10-02 21:06:01 -04:00
cfreeamd fb8ab442b6 rocr: Don't assert in hsa_shut_down when no agents (#1115)
* rocr: Don't assert in hsa_shut_down when no agents

Instead, print error message and return an error. Prior to
this patch, the assertion would occur when hsa_shut_down() is
called more than once.

* rocr: Reorder Unload  ASAN clean-up on shut down
2025-10-02 17:20:53 -07:00
cfreeamd 402aa7e253 rocr: Support batching in InterceptQueue store (#1194)
* rocr: Support batching in InterceptQueue store

* Fix comment, loop bounds
2025-10-02 10:37:40 -07:00
cfreeamd 55feeefcff Revert "rocr: Remove QueueProxy (#700)" (#1167)
This reverts commit c34c9826c3,
which was causing test failures.
2025-10-01 18:24:43 -07:00
ammallya 8751d58616 Adding missed linux skip (#1197) 2025-10-01 10:37:47 -07:00
ammallya f7dba2eb5c Adding skip to docs paths (#1196) 2025-10-01 09:57:44 -07:00
habajpai-amd 74fc268a32 Add libomptarget discovery to prevent OpenMP/HIP segfaults (#1043)
This PR fixes a segmentation fault seen when running rocprof-sys-sample with multi-process OpenMP/HIP applications.
The crash was caused by missing libomptarget.so on the runtime loader path or incorrect LD_PRELOAD settings.

Fixes SWDEV-552804

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-10-01 09:51:26 -04:00
Geo Min 36a1fd87af Removing landed patch (#1184) 2025-09-30 16:51:41 -07:00
Geo Min b0a9a2386f [ci] Adding TheRock CI coverage for rocm-core (#868)
* TheRock CI points to rocm systems

* Fixing depth

* Fixing cache path

* Adding core components

* Adding more packages

* try this for windows building

* Add math libs

* Adding core only

* Attempt with no ccache

* adding patching

* Adding ls test

* adding this

* removing ls test

* changing dir name

* Adding cleanup for patch

* Adding ref

* adding correct no include

* Adding new temp branch for testing

* empty commit

* empty commit

* Adding commit hash bump

* Adding new hash for removed patches

* Adding TheRock submodule bump

* trying with compiler removed test

* Try dvc pull windows

* Update .github/workflows/therock-ci-linux.yml

Co-authored-by: Marius Brehler <marius.brehler@gmail.com>

* Adding correct env

* revert to ../

* Adding path

* try new var

* Adding new branch

* Adding correct hash

* Update .github/workflows/therock-ci-linux.yml

Co-authored-by: Marius Brehler <marius.brehler@gmail.com>

* Update .github/workflows/therock-ci-windows.yml

Co-authored-by: Marius Brehler <marius.brehler@gmail.com>

---------

Co-authored-by: Marius Brehler <marius.brehler@gmail.com>
2025-09-30 16:08:50 -07:00
Marius Brehler 026a4e82a3 Rollup of build changes needed for compat with TheRock. (#1086)
* Rollup of build changes needed for compat with TheRock.
* When built for a non-default ROCM location, the HIP headers can't be found by a few targets.
* Uses pkg_check for DRM libraries like ROCR-Runtime does (which avoids accidental fallback to system versions).
* Robust fix for nolink targets
* nolink targets essentially exist for include directories
* all nolink targets are automatically added to rocprofiler-sdk-headers with a $<BUILD_INTERFACE:...> generator expression
* Re-add previously used mechanism to find drm libs

---------

Co-authored-by: Marius Brehler <marius.brehler@amd.com>
Co-authored-by: Stella Laurenzo <stellaraccident@gmail.com>
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2025-09-30 18:39:10 -04:00
Jin Jung c6d44b47d4 Fix VulkanTest::CreateMappedStorage _WIN64 segfault (#1173)
* Fix VulkanTest::CreateMappedStorage _WIN64 segfault

* Fix Indentation
2025-09-30 14:52:05 -07:00
ywang103-amd eeeaa06159 attach/detach: change workload of unit test to accommodate SDK's current limitation (#1169)
* add double mode of workload dynamic_share with on remove sleeping and
set ROCP_TOOL_ATTACH=1 for running workload

* add comment in dynamic_shared.hip to exaplain how to use argv

* refactor the attach/detach profiling time in unit tests
2025-09-30 13:16:43 -07:00
abchoudh-amd f45c8d5f6b Bugfixes for test failure (#1106)
- Bugfixes
- Update test instructions using docker
2025-09-30 15:48:41 -04:00
Jason Bonnell 953fd60e9b rocprofiler GHCR Rename (#1112)
- Rename the GHCR packages for rocprofiler Docker images to reduce the number of packages that will be released on the repository
- Changed package name to only include the OS instead of OS+Version - version moved to the tag instead.
- Updated Dockerfile.*.ci files to specify target ROCm version from tarball in name.
2025-09-30 15:15:12 -04:00
Jason Bonnell cec7ce77d6 Add sudo apt-get update command to workflow (#1177)
- 404 Not Found errors when trying to download dependencies in the Get the latest therock build step. Adding `sudo apt-get update` command first to avoid this.
- Added `sudo apt-get update` to the rocprofiler-sdk-build-ci-docker-images.yml workflow.
2025-09-30 14:09:36 -04:00
Venkateshwar Reddy Kandula c441a87a00 [rocprofiler-sdk][RCCL] RCCL New API changes for RCCL_API_TRACE_VERSION_PATCH = 2 (#985)
- Address build issue with RCCL sync with NCCL commit: ROCm/rccl@08a7be2
- Patch Version Bump-up PR: ROCm/rccl#1916
2025-09-30 12:42:42 -04:00
systems-assistant[bot] d1ee1f0cba Upgrade binutils version from 2.42 to newer 2.44 version (#113)
* Upgrade binutils version from 2.42 to newer 2.44

---------

Co-authored-by: Marjan Antic <marantic@amd.com>
Co-authored-by: Sajina Kandy <sputhala@amd.com>
2025-09-29 14:50:33 -04:00
itrowbri 956daca743 [Docs][rocprofv3]Add Consecutive Kernels Parameter Description to Docs (#1111)
* Add consecutive kernels parameter description

* remove space

* Updated docs and CHANGELOG
2025-09-29 11:21:13 -05:00
Ajay GunaShekar 81775169cc SWDEV-1 - hipcc args: --rocm-path to --hip-path in tests (#998) 2025-09-26 15:35:20 -07:00
Laura Promberger fb3677cad6 fetch_sources: replace flags that the newer version recognizes (#1148)
* fetch_sources: replace flags that the newer version recognizes

* fetch_sources: remove --no-include-rocm-libraries
2025-09-26 11:36:28 -07:00
amd-hsivasun c16b06a7d7 [Ex CI] Enable aqlprofile (#1002)
* [Ex CI] Enable aqlprofile

* [Ex CI] Added PipelineID for aqlprofile
2025-09-26 14:00:41 -04:00