Commit Graph

399 Commits

Author SHA1 Message Date
Anusha GodavarthySurya 3bdedf0cc7 SWDEV-351966 - Dispatch table for hip runtime
Change-Id: Ie4a44fa8cf1ff9c152146070bbbf6b0636d4e325


[ROCm/clr commit: 5e21f0c6bd]
2023-11-22 01:11:19 -05:00
Tao Sang 8f417d910b SWDEV-432180 - Support hipArraySurfaceLoadStore
Make hipExternalMemoryGetMappedMipmappedArray() accept
hipArraySurfaceLoadStore.
Make hipCreateSurfaceObject() check hipArraySurfaceLoadStore
flag. If flag is hipArrayDefault, hipCreateSurfaceObject() will
also pass to prevent failure of catch2/swissknife tests.

Change-Id: Ifb7db2db14e0c2208a9661cfa33887ec61ab26a5


[ROCm/clr commit: 1c442658ca]
2023-11-14 10:17:07 -05:00
Jaydeep Patel 86902b4d96 SWDEV-425248 - numerous bug fixes.
Set flag with hipCtxCreate so that get flags works.
Validate hipHostGetDevicePointer for flags!=0.
Validate mem cpy kind and accommodate new type hipMemcpyDeviceToDeviceNoCU.
Match error code for hipGetChannelDesc.

Change-Id: If09a635ac01bc53f1fe2b7df3f3f9c1b0d69a0ab


[ROCm/clr commit: 8e8fb993de]
2023-11-07 22:49:20 -05:00
Satyanvesh Dittakavi efbe1365b9 SWDEV-430048 - hipMemcpy2D should return success for zero sized arrays
- This matches the CUDA behavior
- The pitch and width checks removed are already covered in ihipmemcpy2D

Change-Id: I03a6921a78b5d89723830d8dde5865fdc6db0379


[ROCm/clr commit: 6d6465cb96]
2023-11-02 00:40:08 -04:00
sdashmiz 9b297f0006 SWDEV-417075 - add hipDrvAddMemCpyNode
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ie631d7b1788f10171a29d463759a3cba3b2b2007

SWDEV-417075 - add hipDrvGraphAddMemcpyNode

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I6bab3310919643e119cd0004276907e223641cfb


[ROCm/clr commit: 9b567e1799]
2023-10-31 09:55:42 -04:00
taosang2 c709808166 SWDEV-364236 - Fix device buffer to/from image issue
Fix offset of device buffer copied to/from image.

Change-Id: I149a8629769cd0d5848ffefb04f1752668a685b9


[ROCm/clr commit: 9a24e1fb30]
2023-10-30 12:17:14 -04:00
Saleel Kudchadker cba9970220 SWDEV-408180 - Address possible cornercases
- Address corner cases that can arise with the new
hipMemcpyDeviceToDeviceNoCU enum
- Better log

Change-Id: I6035b901f8d616741054b7a5ff4f67956329ac57


[ROCm/clr commit: 5662d4037c]
2023-10-23 16:54:08 -04:00
Saleel Kudchadker 4c9f160818 SWDEV-408180 - Add a new hipMemcpyKind
Add hipMemcpyDeviceToDeviceNoCU to force a non blit copy path. This
helps in cases where an app may determine that CU may be busy and copies
with SDMA may be quicker.

Change-Id: I59b415dd8f6022c244e8d75f265464d5c635df1e


[ROCm/clr commit: f316a30e5d]
2023-10-20 13:18:10 -04:00
taosang2 28524520e6 SWDEV-364236 - Fix layered Image issue
Fix wrong logic to get layer index;
Make layered image's layout match cuda spec;
Fix wrong comparision of element size.
Remove amd::BufferRect from ihipMemcpyAtoHCommand()
and ihipMemcpyHtoACommand().
Change-Id: Icc6a4233fbce2e9b2dc6feb79e6bfbd761684c7d


[ROCm/clr commit: 5a0085e516]
2023-10-19 16:06:20 -04:00
sdashmiz 555aacb1fb SWDEV-371332 - [ABI Break] Return success for unregistered ptr
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ie58d16420578e7118997eb40a9fd6a6641b666f3


[ROCm/clr commit: d78aef7f66]
2023-10-15 14:32:24 -04:00
sdashmiz fcfa0d0733 SWDEV-332969 - [ABI Break]Substitute hipArray* with hipArray_t
- hipArray will be an internal struct from rocm6.0

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Icf97fe96b87be8532098cd7f9ceaad099f99c9b9


[ROCm/clr commit: c089ef4a2b]
2023-10-12 12:09:19 -04:00
taosang2 c9b9210059 SWDEV-299127 - Support External Mipmap
Support hipExternalMemoryGetMappedMipmappedArray().
Add ImageExternalBuffer to differiate ImageBuffer.
Currently we only support tiling_optimal mode as
vulkan driver doesn't provide tiling information.

Change-Id: I7e3524cdde53e4df9f728894bcebf4bd3f58d4d9


[ROCm/clr commit: 6398f604b0]
2023-10-05 09:58:17 -04:00
Ioannis Assiouras 0066c6cb6b SWDEV-420222 - Removed implementation of hipMemcpyArray functions
hipMemcpyArrayToArray, hipMemcpyFromArrayAsync, and hipMemcpyToArrayAsync
are deprecated in cuda and are missing the headers in hip_runtime_api.h.
Removed their implementation from hip_memory.cpp.

Change-Id: I9720aec6241515c56c66b7e90a37b2ed53347eb2


[ROCm/clr commit: 2bc6661737]
2023-09-04 13:35:08 +01:00
Satyanvesh Dittakavi bee336d360 SWDEV-416443 - hipPointerGetAttributes should return correct type for managed memory
Change-Id: Ic197cd8c9d3f5405616ed6e4924ed5577e636b94


[ROCm/clr commit: 84eae1f0a9]
2023-08-21 07:47:32 -04:00
taosang2 c4bc05f0d0 SWDEV-408843 - Fix vulkan_interop failure
Fix runtime issues found in  vulkan_interop test

Change-Id: I32c9bed861ddf4fe1d7bba21dce9bd720168c399


[ROCm/clr commit: d2cfb86ddc]
2023-08-11 10:13:56 -04:00
Jaydeep Patel 60e169c0a2 SWDEV-415421 - End is relative to start and so no need to offset.
Change-Id: Icd65227d9879d9ee4e0bd2795f112b4d5e8c8e9e


[ROCm/clr commit: 34d071c767]
2023-08-10 00:41:01 -04:00
Jaydeep Patel 5b51ca53f4 SWDEV-412993 - As origin is passed with start, region should be end.
Change-Id: I7077484d4d8c302fb2f2714cb68c15ba5173eae3


[ROCm/clr commit: a28a5a9a38]
2023-07-28 12:56:53 -04:00
sdashmiz 4dd4970313 SWDEV-408586 - set device active when malloc is called
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ib930d997b7d544d8b6fb42d2fea01fa8a4418e98


[ROCm/clr commit: 173de06658]
2023-07-13 11:39:58 -04:00
taosang2 828c7714e0 SWDEV-408687 - Prevent updating dstXInBytes/srcXInBytes twice
Update pCopy->srcMemoryType and pCopy->dstMemoryType so
 that ihipGetMemcpyParam3DCommand() won't redetect memory
 type. This will prevent dstXInBytes and srcXInBytes getting
 updated twice with offset in hipMemoryTypeUnified type.

Change-Id: Ief4ea81941e25d22bcafd213b3b84a65eb23cf94


[ROCm/clr commit: 56daa6c489]
2023-07-05 09:22:49 -04:00
sdashmiz f07e8cbc95 SWDEV-403382 - param sanity check
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ibddb2be7d0543676ed9aed71ebb3f5877662c9ae


[ROCm/clr commit: 5f93a59798]
2023-06-27 19:03:34 -04:00
taosang2 9aa3a87b66 SWDEV-368553 – Add missing mipmap Apis
Add missing mipmap Apis’ implementation.
Fix some bugs of mimpmap apis.
Use hipmipmappedArray to differentiate cuda
and driver apis on Nvidia.
Change-Id: I6079d9f3b2ddf4e42b9a6f7f3902322cfca02cfd


[ROCm/clr commit: f03c11491b]
2023-06-22 17:24:21 -04:00
Saleel Kudchadker 60b9dc4a45 SWDEV-301667 - Better log
Change-Id: I3b5b3593cb0144e56a4ddea2fa29028544a73203


[ROCm/clr commit: b2240bcda5]
2023-06-20 14:26:44 -04:00
Jaydeep Patel cb3642e26e SWDEV-398047 - Disable arena for XNACK.
Change-Id: If6c98490bd5b8146a357f45ed132f687def0877f


[ROCm/clr commit: ffa1deef27]
2023-05-10 23:28:05 -04:00
Ajay 858a32a24a SWDEV-374386 - hipGraphAddMemcpyNode negative cases
validate 3d memcpy params -
pitch, extend - height/width/depth, src/dst offsets and total size

Change-Id: I629fc242264ebbc3e9dbfd9233da8d3a127500b4


[ROCm/clr commit: 22eae6ac9e]
2023-04-28 12:11:24 -04:00
German Andryeyev b2525dfb82 SWDEV-381627 - Move cl_vk_amd.hpp into rocclr
Rename VK interop to ExternalMemory object, since it should handle
DX interops also

Change-Id: I536ec46d3e53ece35234a2e29030393ad411b96d


[ROCm/clr commit: 3e5803c4c0]
2023-04-26 15:25:01 -04:00
Sourabh Betigeri 898340aaa9 SWDEV-392367 - Fixes hipMemGetAddressRange returning device buffer size as 0
Change-Id: I6b5640b544390b2dfc53fad271acc7f30240e274


[ROCm/clr commit: 7aba1cf4cd]
2023-04-25 13:46:52 -04:00
pghafari 0ddd82a5f7 SWDEV-367145 - adding support for timeline semaphore
Change-Id: I654359b48abe8bbaac2def5118d3ad0bb05d9492


[ROCm/clr commit: afa15ddb89]
2023-04-25 10:02:43 -04:00
Jaydeep Patel 3bab75e327 SWDEV-389477 - Check D2D is intra device.
Change-Id: Ibef2a6de82a18357ef35bcd70298478de6b0e380


[ROCm/clr commit: 415fb15c76]
2023-04-19 01:01:12 -04:00
pghafari 82219d2fb1 SWDEV-366992 - adding handle type for vk interop
Change-Id: I79ee0d89b948c21b96709e9e607abe7901621a97


[ROCm/clr commit: 78de2ae692]
2023-04-18 16:59:25 -04:00
taosang2 769f1e166e SWDEV-390626 - Support surface Apis
Change-Id: I1691b82d597bfd722d562778f919ebf8ca530e90


[ROCm/clr commit: 53742adc08]
2023-04-05 16:38:04 +00:00
German 56dedad98b SWDEV-380703 - sync all streams individually
Avoid syncing blocking streams with the default stream,
since that introduces extra command dependencies and
doesn't allow to destroy memory after last submission

Change-Id: I618e9bd2091c4cf9157125612d8c4759030c5a80


[ROCm/clr commit: 1e88d2c52f]
2023-04-05 16:37:49 +00:00
Satyanvesh Dittakavi dded7831c1 SWDEV-374363 - hipImportExternalMemory/Semaphore should return error
when the Memory/Semaphore handle desc type is invalid

Change-Id: If122b05d87cc65974a797da69c134e2ac264d1db


[ROCm/clr commit: 1ed823a477]
2023-04-05 10:56:41 +00:00
Ioannis Assiouras 517e142aeb SWDEV-388661 - Fixed regression in hipMemCpyParam3D when offset is applied
Change-Id: I31273d643aac05f394f505235734c7f098497051


[ROCm/clr commit: 9c04e21b68]
2023-04-05 10:54:34 +00:00
Saleel Kudchadker ce8215feb4 SWDEV-384658 - Optimize D2D memcpy
- Intra device memcpy does not need to perform host side synchronization
- Check alloc flags when determining memory type

Change-Id: Ieff28bd8d62756ffe82905354c4a91e9717e6bd4


[ROCm/clr commit: dfefc97178]
2023-03-09 04:47:11 -05:00
Saleel Kudchadker 71a3807e6f SWDEV-345213 - Use the right accessor
- Use correct accessor to fetch memory objects. This checks the svm map
and arena maps

Change-Id: I84515330bb530cfe2b39abf30e1e659938f06806


[ROCm/clr commit: 8028d327e9]
2023-03-06 19:35:40 -05:00
Anusha GodavarthySurya 2d9f92288c SWDEV-368521 - Return hipErrorNotSupported when Mipmap array create support is not available
Change-Id: I47acfa82ff3f58427b1f5fbb0d2f4aabfff0d6ec


[ROCm/clr commit: 705c56ed31]
2023-03-02 03:05:43 -05:00
Jaydeep Patel 37769589f3 SWDEV-383056 - Don't sync with dst device for hipMemcpyAsync.
Change-Id: I28530e6bd870d617507592576295fc9e7eed1475


[ROCm/clr commit: 57fa5938fe]
2023-02-28 23:21:01 -05:00
Ioannis Assiouras 2633e62801 SWDEV-381402 - Derive hip::Stream from amd::HostQueue
Change-Id: I6c1aca5eb350c32d974ae4ffcc725705355956d8


[ROCm/clr commit: e3633dc8f4]
2023-02-21 18:12:03 -05:00
Rakesh Roy 9c51780b13 SWDEV-338733 - Implement hipArrayGet* APIs
- Add implementation for hipArrayGetInfo, hipArrayGetDescriptor &
  hipArray3DGetDescriptor APIs

Change-Id: I181a472066006bc3bd0d987408ea67e218310983


[ROCm/clr commit: 287d07ccd4]
2023-02-16 23:04:29 -05:00
Ioannis Assiouras 5007a5f15d SWDEV-381402 - convert host_device to host_context of type amd::Context*
Change-Id: Ic1cb9a3fa64e16699fad7e9ec6679f1d34b14bef


[ROCm/clr commit: 8b87ccb8cc]
2023-02-16 17:49:12 -05:00
kjayapra-amd 9c479ada12 SWDEV-376697 - Pass uncached memory flag when hipDeviceMallocUncached memory is requested.
Change-Id: Idc12948047fdb69876e31edf34a8bcda46c9c303


[ROCm/clr commit: 193c5e387e]
2023-02-16 14:05:54 -05:00
Jaydeep Patel 4b3f70a6b4 SWDEV-380405 - Make hipMemcpyPeer async w.r.t. host and let dst device wait till copy finishes by src device.
Change-Id: Idbe25404d0c31b93436e190b548f12f327f47a04


[ROCm/clr commit: 5f231c55e3]
2023-02-07 00:34:45 -05:00
pghafari 5fa035dbd4 SWDEV-369551 - invalid stream check in hipMemcpy
Change-Id: I6762af93cd566a38f7d04994b87a76e744b19043


[ROCm/clr commit: 76b0b4d635]
2023-01-18 20:02:28 -05:00
pghafari 5959057299 SWDEV-374361, SWDEV-374362, SWDEV-374364, SWDEV-374365 - error checking
Change-Id: I0b729976ed794239fa54e1ad2965133b319d2f5d


[ROCm/clr commit: a9cbff0a49]
2023-01-17 23:10:22 -05:00
German Andryeyev 36d240ff89 SWDEV-355281 - Use offset from FindMemObj
Change-Id: I53ce2c1ef2e3a580b8b12312b693c2476f0885d2


[ROCm/clr commit: 39db0ec297]
2023-01-17 10:01:49 -05:00
Jaydeep Patel d74f646173 SWDEV-374360 - Handle free for external memory.
Change-Id: Ibfaf30eef371499a3c1f931a73cce76c83d8f7f3


[ROCm/clr commit: 7eecbdd9db]
2023-01-16 13:07:01 -05:00
Jaydeep Patel ffcff763d2 SWDEV-375366 - SWDEV-375351 - Handle HtoH case for graph mem cpy impl.
Change-Id: I5a8c3c3c22db045f714b0443b8d70a8c6b4a8cea


[ROCm/clr commit: fdecc1b351]
2023-01-16 11:37:57 -05:00
German Andryeyev 9c811dc241 SWDEV-353281 - Initial support of memalloc in graph
Add memory allocation support in graph. Current implementation uses
cache from mempool  to hold the allocations which belong to the graph.
Also the resource tracking is disabled at this moment because mempool
operates with hip::Stream objects, but graph has execution with
amd::HostQueue objects.

Change-Id: I54fe3250126d24f5a26ada975f37d429bb4ef17b


[ROCm/clr commit: eef47ca24a]
2023-01-13 13:06:59 -05:00
Ajay 433f99686b SWDEV-369556 - Unit_hipMemGetAddressRange_Negative cases
- return value for invalid device ptr
- offset greater than size

Change-Id: I8bcf878c3c1c0a29836ea664bfb9048e1114b74e


[ROCm/clr commit: c6a7ce66bb]
2023-01-10 06:57:54 -05:00
kjayapra-amd 5057429e7a SWDEV-361374 - Adding support for hipPointerSetAttributes
Change-Id: I56710b808854acefca07b3b5898deebee38063e9


[ROCm/clr commit: 0c8c08cf51]
2023-01-09 12:36:57 -05:00