Commit Graph

4591 Commits

Author SHA1 Message Date
Mark Searles 81c93d94be Add keyword 'explicit' to avoid ambiguity
Older gcc, e.g., 5.x, see an ambiguity in some calls. Example error
output as seen with gcc 5.5:

In file included from benchmark_wino.cpp:1:
In file included from ./miopen.hpp:13:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/regex:38:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/algorithm:62:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/bits/stl_algo.h:66:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/random:51:
/usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/bits/random.tcc:1324:27: error: call to 'abs' is ambiguous
                    const double __y = -std::abs(__n) * __param._M_sm - 1;
                                        ^~~~~~~~
/opt/rocm/hip/include/hip/hcc_detail/hip_complex.h:345:31: note: candidate function
__DEFINE_HIP_COMPLEX_REAL_FUN(abs, hipCabs)


[ROCm/clr commit: 37cc117bd5]
2018-08-31 10:36:05 -07:00
foreman dd34119493 P4 to Git Change 1600056 by skudchad@skudchad_test2_win_opencl on 2018/08/30 12:04:10
SWDEV-145570 - [HIP] Fix elapsed time calc for hipEvent

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/15717/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#6 edit


[ROCm/clr commit: 4e047235f0]
2018-08-30 12:17:57 -04:00
Maneesh Gupta 0ae3d1b453 Merge pull request #564 from phani544/hipClangClass8B
Adding class size>8bytes tests

[ROCm/clr commit: 0b8e209532]
2018-08-30 10:33:47 +05:30
Maneesh Gupta f5bbf5155b Merge pull request #647 from tdd11235813/fix-cmake-build-name
Fixes build-name bug due to reversed string() arguments in cmake.

[ROCm/clr commit: 9060955c89]
2018-08-30 10:32:39 +05:30
Aaron Enye Shi 6ce7e12be9 __forceinline__ needs inline and always_inline
Related to SWDEV-163084


[ROCm/clr commit: decf9beec9]
2018-08-29 18:33:35 +00:00
Aaron Enye Shi 31864c4973 Remove testing bitinsert/extract on nvcc path
[ROCm/clr commit: ecfb2bdeba]
2018-08-29 15:29:53 +00:00
Yaxun Sam Liu 137880f369 Add clock() and clock64()
[ROCm/clr commit: 0f4546deca]
2018-08-29 10:51:00 -04:00
fpadmin 68cdeeba66 Adding class size>8bytes tests
[ROCm/clr commit: 19b5ac131a]
2018-08-29 15:16:43 +05:30
Aaron Enye Shi 7801c309b3 Add tests for bitextract and bitinsert
[ROCm/clr commit: 622342f01d]
2018-08-28 20:01:54 +00:00
Aaron Enye Shi 3a7ad8a604 Add bitinsert64 to device functions
[ROCm/clr commit: 031c0204d8]
2018-08-28 20:01:14 +00:00
Aaron Enye Shi 06a68d3eb6 Clean up and add meaningful variables to bit funcs
[ROCm/clr commit: 24429eabb0]
2018-08-28 18:19:48 +00:00
Yaxun (Sam) Liu 6a648b9d7f Fix documentation about hip-clang macros
[ROCm/clr commit: 4335feba47]
2018-08-28 09:55:18 -04:00
Yaxun (Sam) Liu 9d23e5b9f0 Fix documentation about hip-clang macros
[ROCm/clr commit: 4216c426eb]
2018-08-28 09:48:38 -04:00
Yaxun (Sam) Liu 3dc8693940 Documents hip-clang predefined macros
[ROCm/clr commit: 8b80403ef4]
2018-08-28 09:43:38 -04:00
Maneesh Gupta c2462624b1 [ci] New CI flow
- Removed hcc integration logic for now
- No longer publish docker images to artifactory or docker hub
- Switch to new docker images and new test node

Change-Id: Idb06bf0a52658d1869367cb38bb03ef4f1649103


[ROCm/clr commit: 8c95267bf5]
2018-08-28 12:36:54 +05:30
foreman e23fcf4343 P4 to Git Change 1598666 by cpaquot@cpaquot-ocl-lc-lnx on 2018/08/27 18:36:44
SWDEV-145570 - [HIP] - Multithreading issues
	Add a lock per function so kernel parameters don't get overwritten
	Make execStack_ thread local and remove global lock use for it:
	The compiler uses the same thread to set it up and launch the function

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#16 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#18 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#19 edit


[ROCm/clr commit: 556ef9c0d1]
2018-08-27 18:46:34 -04:00
Matthias Werner c0bdab78aa Fixes build-name bug due to reversed string() arguments in cmake.
[ROCm/clr commit: f7f7140053]
2018-08-27 17:51:12 +02:00
foreman 3578857b4f P4 to Git Change 1597160 by cpaquot@cpaquot-ocl-lc-lnx on 2018/08/22 18:31:15
SWDEV-145570 - [HIP] Implemented hipSurfaceCreate/Destroy APIs.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_surface.cpp#4 edit


[ROCm/clr commit: efd28cf092]
2018-08-22 18:42:22 -04:00
foreman 022725ad50 P4 to Git Change 1596634 by cpaquot@cpaquot-ocl-lc-lnx on 2018/08/21 18:07:55
SWDEV-145570 - [HIP] Implmented hipSurfaceCreate/Destroy APIs

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_surface.cpp#3 edit


[ROCm/clr commit: ec3c61c7fd]
2018-08-21 18:29:16 -04:00
foreman a618047aec P4 to Git Change 1596023 by skudchad@skudchad_test2_win_opencl on 2018/08/20 18:40:38
SWDEV-145570 - [HIP] Fixes to HIP env var logic

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/15653/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#16 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#15 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#18 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.cpp#225 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.hpp#311 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#105 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.cpp#96 edit


[ROCm/clr commit: 188c4e9bd7]
2018-08-20 18:48:00 -04:00
Aaron Enye Shi 13f4ace668 Add bitextract and bitinsert functions
[ROCm/clr commit: fb1da42d0e]
2018-08-20 16:46:12 +00:00
Saleel Kudchadker ec328d9ac8 Check for hipEnvVar at the same level if directed_tests location fails
[ROCm/clr commit: 4946c4357d]
2018-08-17 12:14:42 -07:00
foreman b671e11afd P4 to Git Change 1595124 by skudchad@skudchad_test2_win_opencl on 2018/08/17 14:05:25
SWDEV-145570 - [HIP] Implement environment variables and subsequent changes for HIP. This gets hipEnvVar passing

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/15641/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#15 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.cpp#224 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.hpp#310 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#104 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.cpp#95 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/flags.hpp#297 edit


[ROCm/clr commit: f61e9b7c12]
2018-08-17 14:28:54 -04:00
Yaxun Sam Liu cbb7e4af8b Add HIP_DB=fatbin for debugging fat binary issues
[ROCm/clr commit: ce13c2061a]
2018-08-17 11:53:45 -04:00
Aaron Enye Shi ce3a13cb4f Remove few hcc specific cmake for hip-clang
[ROCm/clr commit: 6e40ec653c]
2018-08-15 21:53:20 +00:00
foreman 4078a0651e P4 to Git Change 1594075 by skudchad@skudchad-lnx on 2018/08/15 14:00:33
SWDEV-145570 - [HIP] Fix some test failures

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#12 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#14 edit


[ROCm/clr commit: ad4ae89d13]
2018-08-15 14:13:08 -04:00
foreman c1bb44fa73 P4 to Git Change 1593706 by skudchad@skudchad_test2_win_opencl on 2018/08/14 18:44:29
SWDEV-145570 - [HIP] Implement hipError*

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/15619/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#13 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#14 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#11 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_error.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#5 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#13 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#41 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#17 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_peer.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#17 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_profile.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#12 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_surface.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#9 edit


[ROCm/clr commit: 2ec2cfd3c1]
2018-08-14 18:54:13 -04:00
Maneesh Gupta 8a1fb05623 [hipcc] Remove libhsakmt from linker flags
Change-Id: I6dc769d09d8c7546fbc594c1eb65f9edf0f0ff58


[ROCm/clr commit: 2f5ee304f8]
2018-08-14 15:31:04 +05:30
foreman 5c6917d511 P4 to Git Change 1592348 by cpaquot@cpaquot-ocl-lc-lnx on 2018/08/10 17:00:39
SWDEV-145570 - [HIP] Do not multiply block and dims for Hcc/Ext kernel module launch

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#16 edit


[ROCm/clr commit: a9a9217b4b]
2018-08-10 17:16:53 -04:00
foreman 577553e1eb P4 to Git Change 1592228 by cpaquot@cpaquot-ocl-lc-lnx on 2018/08/10 13:55:25
SWDEV-145570 - [HIP] Report maxGridSize as INT32_MAX, not UINT32_MAX

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#13 edit


[ROCm/clr commit: 7da2a66713]
2018-08-10 14:10:19 -04:00
foreman 544cb95f1e P4 to Git Change 1592225 by cpaquot@cpaquot-ocl-lc-lnx on 2018/08/10 13:52:21
SWDEV-145570 - [HIP] Report memoryClockRate in kilohertz too.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#12 edit


[ROCm/clr commit: 948f18c9a4]
2018-08-10 14:09:04 -04:00
foreman 9f3b54056d P4 to Git Change 1592223 by cpaquot@cpaquot-ocl-lc-lnx on 2018/08/10 13:50:47
SWDEV-145570 - [HIP] Report clockRate in kilohertz.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#11 edit


[ROCm/clr commit: 28d04d6609]
2018-08-10 14:04:43 -04:00
Yaxun Sam Liu cce9389cd5 Add HIP directed test hipTestGlobalVariable.cpp
[ROCm/clr commit: 41416edd14]
2018-08-10 08:15:36 -04:00
Maneesh Gupta bb9d95188a Merge pull request #621 from ROCm-Developer-Tools/disable_startup_loader
Disable startup loader by default and guard with env var

[ROCm/clr commit: e10fa70173]
2018-08-10 10:18:25 +05:30
Maneesh Gupta 3cb8b82de3 Merge pull request #623 from ROCm-Developer-Tools/tf18
Fix declaration conflict when hip/math_functions.h is included first

[ROCm/clr commit: 546378292d]
2018-08-10 09:36:27 +05:30
Maneesh Gupta 23196fde48 Merge pull request #616 from ROCm-Developer-Tools/hip-clang-static-lib
Let hipcc handle static library for hip-clang

[ROCm/clr commit: 695746421f]
2018-08-10 09:35:22 +05:30
Maneesh Gupta 6337247921 Merge pull request #615 from aaronenyeshi/enable-hip-compiler
Enable HIP_COMPILER to choose HIP-Clang lib links

[ROCm/clr commit: 0123fb816d]
2018-08-10 09:34:51 +05:30
Maneesh Gupta a3e7b7c18e Merge pull request #613 from ROCm-Developer-Tools/hcc-compat
Add HCC compatibility mode for hip-clang

[ROCm/clr commit: a5f9ae90d2]
2018-08-10 09:32:31 +05:30
Maneesh Gupta 4e2e234a56 Merge pull request #617 from gargrahul/genco_remove_adipose_extn
Remove adipose extension from genco output

[ROCm/clr commit: 497610f96c]
2018-08-10 09:31:44 +05:30
Maneesh Gupta f74ececf41 Merge pull request #619 from ROCm-Developer-Tools/revert-pr457
Revert pr457

[ROCm/clr commit: 79e9a2dfa4]
2018-08-10 09:25:57 +05:30
sunway513 3621ec1971 resolve a segfault bug when env var not set; remove startup_kernel_loader class
[ROCm/clr commit: 7c467220a8]
2018-08-09 16:40:26 +00:00
Rahul Garg 1f0d24fa61 Clean up module api samples
[ROCm/clr commit: b6c5d7d71b]
2018-08-08 22:28:13 +05:30
Evgeny Mankov dac14d60b7 [HIPIFY][Complex] Add cuComplex support
+ Add API_COMPLEX support (data types and functions)
+ Add cuComplex_API_supported_by_HIP.md
+ Add cuComplex_Julia.cu test
+ Update README.md


[ROCm/clr commit: ce57b99f9d]
2018-08-08 18:34:57 +03:00
Yaxun Sam Liu d3295e61e2 Fix __HIP_ARCH_* not defined after including math_functions.h
hcc_detail/math_functions.h used to include hcc_detail/hip_runtime.h.

Removing it has caused regression in TensorFlow 1.8.

Put it back for backward compatibiliity.


[ROCm/clr commit: 87de95975a]
2018-08-08 08:55:28 -04:00
Yaxun Sam Liu 6e153a743f Fix __HIP_DEVICE_COMPILE__ not defined when hip/math_functions.h is included
This fixes build failure in TensorFlow 1.8 for HCC


[ROCm/clr commit: 058eb7535b]
2018-08-07 17:14:39 -04:00
Yaxun Sam Liu 6df5aef807 Fix declaration conflict when hip/math_functions.h is included first
This fixes build failure in TensorFlow 1.8 for HCC


[ROCm/clr commit: 69bbf45b44]
2018-08-07 15:44:59 -04:00
foreman ee0e1fafe2 P4 to Git Change 1590010 by skudchad@skudchad_test2_win_opencl on 2018/08/06 21:18:48
SWDEV-145570 - [HIP] - Fix some issues in hip runtime
	- Set stream for event
	- Free mem needs to be reported in bytes but runtime backends reports in Kb

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/15586/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#40 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#15 edit


[ROCm/clr commit: b4ccaeffe1]
2018-08-06 21:24:14 -04:00
sunway513 e1d72394da Add more check to ensure the startup loader only be enabled with the env var set to 1
[ROCm/clr commit: 7d776ae665]
2018-08-04 01:52:27 +00:00
sunway513 ef368c0f43 Add startup loader under HIP_STARTUP_LOADER env var, disable by default
[ROCm/clr commit: 9af862d364]
2018-08-04 01:48:06 +00:00
Wen-Heng (Jack) Chung d7b2bab183 Revert "HIP program state re-initialization logic"
This reverts commit 865fe01b37.


[ROCm/clr commit: 1fe7f1be91]
2018-08-03 17:03:04 -05:00