Wen-Heng (Jack) Chung
fbf97dddb5
Revert "Improve performance of re-initialization logic"
...
This reverts commit 1d1b402e5b .
[ROCm/clr commit: f6178c2159 ]
2018-08-03 17:02:58 -05:00
Wen-Heng (Jack) Chung
1494fc442f
Revert "Keep the map which tracks GPU kernel symbols to grow monotonically"
...
This reverts commit ca62af218c .
[ROCm/clr commit: 329f3b7a5e ]
2018-08-03 17:02:50 -05:00
foreman
4897c229a4
P4 to Git Change 1589138 by cpaquot@cpaquot-ocl-lc-lnx on 2018/08/03 01:04:05
...
SWDEV-145570 - [HIP] Added __gnu_h2f_ieee and __gnu_f2h_ieee
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#9 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#10 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#16 edit
[ROCm/clr commit: f4add6058a ]
2018-08-03 01:15:15 -04:00
Maneesh Gupta
34e14adae2
Merge pull request #588 from Jorghi12/patch-10
...
Fixing a HIP bug that causes DEBUG symbols to be dropped.
[ROCm/clr commit: ac18a3b701 ]
2018-08-03 08:48:56 +05:30
Maneesh Gupta
0f033ca572
Merge pull request #603 from b-sumner/master
...
Drop use of NVCC_COMPAT since it is always set
[ROCm/clr commit: b485957858 ]
2018-08-03 08:45:18 +05:30
Maneesh Gupta
044a73015e
Merge pull request #601 from sarunyap/fix-shareWithAll-mem-dev-mapping
...
Remove device mapping from shareWithAll memory
[ROCm/clr commit: ad44a77ed4 ]
2018-08-03 08:45:04 +05:30
foreman
8819b1de20
P4 to Git Change 1589087 by skudchad@skudchad_rocm on 2018/08/02 20:10:02
...
SWDEV-145570 - [HIP] - hipHccModuleLaunchKernel needs to be a c++ sym
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#9 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#14 edit
[ROCm/clr commit: 678764d113 ]
2018-08-02 20:20:23 -04:00
foreman
934eca953a
P4 to Git Change 1589062 by cpaquot@cpaquot-ocl-lc-lnx on 2018/08/02 18:34:20
...
SWDEV-145570 - [HIP] Fix a segfault exposed by rocBlas.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#39 edit
[ROCm/clr commit: 08a308dd59 ]
2018-08-02 18:52:37 -04:00
foreman
650747dfe6
P4 to Git Change 1589030 by cpaquot@cpaquot-ocl-lc-lnx on 2018/08/02 17:40:15
...
SWDEV-145570 - [HIP] Fixed the underline
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#15 edit
[ROCm/clr commit: 388d597321 ]
2018-08-02 18:00:05 -04:00
foreman
8ca0447f6e
P4 to Git Change 1588779 by cpaquot@cpaquot-ocl-lc-lnx on 2018/08/02 12:25:51
...
SWDEV-145570 - [HIP] Refactored some g_* stuff
Refactored g_functions into a platform state.
Added a _vars for registered variables.
Added an execution stack similar to Hcc-clang.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#14 edit
[ROCm/clr commit: 2ff260c727 ]
2018-08-02 12:33:55 -04:00
Rahul Garg
22d59ba040
Remove adipose extension from genco output
...
[ROCm/clr commit: e9d7584b02 ]
2018-08-02 15:16:36 +05:30
foreman
68f06e9f60
P4 to Git Change 1588556 by skudchad@skudchad_rocm on 2018/08/02 02:04:15
...
SWDEV-145570 - [HIP] - Release eStop if it not a nullptr.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#13 edit
[ROCm/clr commit: e638c1377f ]
2018-08-02 02:18:57 -04:00
foreman
a3fc17658c
P4 to Git Change 1588551 by skudchad@skudchad_rocm on 2018/08/02 01:55:45
...
SWDEV-145570 - [HIP] - Refactor ihipModuleLaunchKernel and add hipModuleLaunchKernelExt
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#8 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#8 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#12 edit
[ROCm/clr commit: 11a91fbe0b ]
2018-08-02 02:14:04 -04:00
Maneesh Gupta
1039c7952c
Merge pull request #610 from aaronenyeshi/enable-hcc-module-launch
...
Enable hipHccModuleLaunchKernel on HIP-Clang
[ROCm/clr commit: 0354367a07 ]
2018-08-02 08:08:46 +05:30
Maneesh Gupta
6de7fd4934
Merge pull request #600 from ROCm-Developer-Tools/enable-texture-functions
...
Enable HIP texture functions with HIP vector types
[ROCm/clr commit: 4544e681ac ]
2018-08-02 08:01:00 +05:30
Maneesh Gupta
f9dbc19d51
Merge pull request #593 from mangupta/patch2-removerdynamic
...
[FindHIP] Remove rdynamic from CMAKE_SHARED_LIBRARY_LINK_HIP_FLAGS
[ROCm/clr commit: 1692af19cc ]
2018-08-02 07:58:34 +05:30
Maneesh Gupta
c440c4d3e8
Merge pull request #514 from luckynikki/GETandALGN
...
[GETandALGN]: Get channel and alignment details
[ROCm/clr commit: 2960739c43 ]
2018-08-02 07:57:50 +05:30
Yaxun Sam Liu
b8bbc4f1fa
Let hipcc handle static library for hip-clang
...
[ROCm/clr commit: 2ba45a23b8 ]
2018-08-01 22:03:01 -04:00
Aaron Enye Shi
da60937c5d
Enable HIP_COMPILER to choose HIP-Clang lib links
...
[ROCm/clr commit: 7560956233 ]
2018-08-01 20:37:46 +00:00
Yaxun Sam Liu
b587661200
Add hc_get_workitem_absolute_id for hip-clang HCC compatibility mode
...
[ROCm/clr commit: 9c28758fa0 ]
2018-08-01 15:14:38 -04:00
Yaxun Sam Liu
2d74df6f34
Add HCC compatibility mode
...
[ROCm/clr commit: b91691966f ]
2018-08-01 15:14:38 -04:00
foreman
7664c89d3e
P4 to Git Change 1588185 by vsytchen@vsytchen-win10 on 2018/08/01 11:46:00
...
SWDEV-145570 - [HIP] Correctly handle calculating the offset when retrieving the amd::Memory object from a prepinned pointer
ReviewBoardURL = http://ocltc.amd.com/reviews/r/15539/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#38 edit
[ROCm/clr commit: 85777ea939 ]
2018-08-01 12:08:35 -04:00
Evgeny Mankov
9ffec20ff2
[HIPIFY][docs] Formatting
...
[ROCm/clr commit: 55ee734b22 ]
2018-08-01 17:29:00 +03:00
lthakur
313cdfd494
Added offset value verification.
...
Added offset value verification.
[ROCm/clr commit: b7a4b2c300 ]
2018-08-01 10:41:30 +05:30
Aaron Enye Shi
83d293a2a4
Enable hipHccModuleLaunchKernel on HIP-Clang
...
[ROCm/clr commit: 0ad36dfa58 ]
2018-07-31 20:38:20 +00:00
Evgeny Mankov
66e24cb0d3
[HIPIFY][FFT] Add cuFFT support
...
+ Add API_FFT support (data types and functions)
+ Add CUFFT_API_supported_by_HIP.md
+ Add simple_cufft.cu test
+ Update README.md
[ROCm/clr commit: c57bfd50e3 ]
2018-07-31 22:25:48 +03:00
foreman
50b6d51a72
P4 to Git Change 1587799 by vsytchen@vsytchen-win10 on 2018/07/31 14:47:31
...
SWDEV-145570 - [HIP] refactor hipMemcpy* functions to correctly handle copies using prepinned memory
The current implementation of hipMemcpy functions picks the copy type based on a flag that the user passes. However, one can use the hipMemcpyHostToDevice/hipMemcpyDeviceToHost flag in a combination with prepinned memory. By using the WriteMemoryCommand/ReadMemoyCommand in this case, we will pin the same host memory twice. This is fine on PAL/Linux, since pinning the same VA range is a noop, but this will start failing once we switch to using device memory with HIP/VDI/HSA.
The solution is to ignore the hipMemcpyKind flag and let the runtime decide what kind of copy is best to do. Except for the case when hipMemcpyHostToHost is passed, since both host pointers may be prepinned.
ReviewBoardURL = http://ocltc.amd.com/reviews/r/15482/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#37 edit
[ROCm/clr commit: b02040e934 ]
2018-07-31 15:07:56 -04:00
Rahul Garg
17e35e382c
Added support for pinned 2D SDMA copy
...
[ROCm/clr commit: 5eb11b58f3 ]
2018-07-31 14:05:35 +05:30
Aaron Enye Shi
9512246b5c
Protect macro TYPEDEF_VECTOR_VALUE_TYPE and prefix __hip_ for vector_value_types
...
[ROCm/clr commit: e42af991d1 ]
2018-07-30 20:41:24 +00:00
Aaron Enye Shi
ad6066eebd
Ensure correct vector value type used in texture
...
Implement the vector value types in terms of SCALAR_TYPE##SIZE_vector_value_type for float, int, uint and sizes 2, 3, 4, 8, and 16.
[ROCm/clr commit: ff1e49d191 ]
2018-07-30 19:43:12 +00:00
Sarunya Pumma
57c15b815d
Remove device mapping from shareWithAll memory
...
When shareWithAll memory (e.g., host memory) is allocated, set appId
in hc::AmPointerInfo to -1 to indicate that this memory is not mapped
to any device. Peer checking in ihipStream_t::canSeeMemory is not
necessary if memory is shared with all devices. Thus, it is skipped.
Note that earlier host memory is always mapped to device 0 and HIP
always performs peer checking for all kinds of hipMemcpy. Since the
peer checking process requires context locking, hipMemcpy from/to host
memory always grabs device 0's context lock. Therefore, if there is
another thread holding the context lock of device 0 (e.g.,
hipDeviceSynchronize on device 0), hipMemcpy will have to wait for the
lock until it can actually perform memcpy. This can significantly
deteriorate execution performance.
Signed-off-by: Sarunya Pumma <sarunya.pumma@amd.com >
[ROCm/clr commit: 84aadb9274 ]
2018-07-28 23:15:16 -07:00
Evgeny Mankov
351f385ea9
[HIPIFY][BLAS] cuBLAS support revise
...
+ doc for CUBLAS API supported by HIP
+ 3 tests: 0 & 1 based indexing, sgemm matmul
[ROCm/clr commit: e00cfefd4f ]
2018-07-28 21:00:44 +03:00
Yaxun Sam Liu
d539617d9b
Do not use std::complex in test hipDeviceMalloc
...
[ROCm/clr commit: fc1ed91ddb ]
2018-07-27 17:07:00 -04:00
Yaxun Sam Liu
ea77788a5f
Fix thread index calculation in __hip_malloc
...
[ROCm/clr commit: f08f26942c ]
2018-07-27 16:24:51 -04:00
Yaxun Sam Liu
9a4744566f
Support malloc/free for hip-clang
...
[ROCm/clr commit: d17dc21c9c ]
2018-07-27 16:24:51 -04:00
Brian Sumner
beb7f13068
Drop use of NVCC_COMPAT since it is always set
...
[ROCm/clr commit: 8d80abb30f ]
2018-07-27 09:29:29 -07:00
Maneesh Gupta
56ebef737b
Merge pull request #596 from mangupta/patch5-fixhiplaunchparm
...
[tests] Fixed hipLaunchParm test on nvcc path
[ROCm/clr commit: 17f612def1 ]
2018-07-26 06:17:50 +05:30
Maneesh Gupta
951d920990
Merge pull request #595 from mangupta/patch4-fixhipStdComplex
...
[tests] Fixed build & disabled run of hipStdComplex on nvcc path
[ROCm/clr commit: 86188f04c8 ]
2018-07-26 06:17:04 +05:30
Maneesh Gupta
e58d3b16b4
Merge pull request #592 from mangupta/patch1-initialize-cudapath
...
[hipcc] Initialize CUDA_PATH before printing
[ROCm/clr commit: ec6995485c ]
2018-07-26 06:16:31 +05:30
Maneesh Gupta
4431a7ad9f
Merge pull request #590 from ROCm-Developer-Tools/fix-ballot-anyall-return
...
Fix return EXIT_FAILURE if ballot or anyall fails
[ROCm/clr commit: ddcb85a77b ]
2018-07-26 06:16:23 +05:30
Aaron Enye Shi
65a1df76dc
Enable HIP texture functions with HIP vector types
...
Include texture_functions.h on HIP-Clang path. Use HIP vector types instead of hc::short_vectors for texture_functions, and remove HCC headers.
[ROCm/clr commit: bf6fdca1e8 ]
2018-07-25 19:52:19 +00:00
Maneesh Gupta
24b33ee4ef
[tests] Fixed hipLaunchParm test on nvcc path
...
- Uses c++11 features. Added it to nvcc options
- Arguments for some kernels exceeded 4096 bytes which is the limit
imposed by nvcc. Reduced BLOCK_DIM_SIZE to 512 to handle this
- Fixed compilation issues on nvcc path
Change-Id: I14f6b28afcb7c6b24a085fd707b2104e2ed64627
[ROCm/clr commit: 51307ac705 ]
2018-07-25 15:41:04 +05:30
Maneesh Gupta
7033561423
[tests] Fixed build & disabled run of hipStdComplex on nvcc path
...
Change-Id: I885e96902faa065f6559183f33b6a7aa1f37e393
[ROCm/clr commit: 843020bfe6 ]
2018-07-25 15:39:45 +05:30
Maneesh Gupta
34bd297a65
[FindHIP] Remove rdynamic from CMAKE_SHARED_LIBRARY_LINK_HIP_FLAGS
...
CMAKE_SHARED_LIBRARY_LINK_CXX_FLAGS contains -rdynamic which does not go
well with nvcc
Change-Id: I10e6d21553de0e43c6a7ae5fb3ec2418087959ff
[ROCm/clr commit: 7a5987e289 ]
2018-07-25 15:32:14 +05:30
Maneesh Gupta
4403d1dc04
[hipcc] Initialize CUDA_PATH before printing
...
Change-Id: Ifd448b628fa4a7055f4a439ed2c817c5f11f9bef
[ROCm/clr commit: 2027675b3f ]
2018-07-25 15:29:57 +05:30
foreman
13338a6873
P4 to Git Change 1584863 by yaxunl@yaxunl-lc10 on 2018/07/24 17:00:42
...
SWDEV-145570 - [HIP] - Update prototype of __hipRegisterVar
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#13 edit
[ROCm/clr commit: 5ac4970a68 ]
2018-07-24 17:14:35 -04:00
Aaron Enye Shi
6353687511
Fix return EXIT_FAILURE if ballot or anyall fails
...
[ROCm/clr commit: 8ab8a37812 ]
2018-07-24 20:39:48 +00:00
Rahul Garg
792b9ebe7c
Null check before setting offset
...
[ROCm/clr commit: f17c897751 ]
2018-07-24 12:25:40 +05:30
Rahul Garg
99758b3064
Set offset in hipGetTextureAlignmentOffset
...
[ROCm/clr commit: 0ec64e8b24 ]
2018-07-24 10:11:26 +05:30
Maneesh Gupta
6d9f3c2cf1
Merge pull request #582 from ROCm-Developer-Tools/set-vdi-path
...
Let hipcc use proper include and lib path for HIP/VDI
[ROCm/clr commit: cab5e80b22 ]
2018-07-24 07:32:54 +05:30