Commit Graph

12278 Commitit

Tekijä SHA1 Viesti Päivämäärä
AravindanC 3f4b70cafd SWDEV-336531 - Fix for relative path issue in debuginfo
Change-Id: Ie36d1a93f40ddc3a42823eb83e041af8c55bcdee
2023-05-17 13:06:26 -04:00
Cordell Bloor e1bed6f354 SWDEV-346940 - Remove default AMDGPU_TARGETS
hipcc and clang++ both have logic to detect the installed hardware
and to automatically select the appropriate AMDGPU target when it is
left unspecified. When the AMDGPU_TARGETS property is initialized with
a set of default values, it results in the addition of an explicit set
of --offload-arch flags being passed. These explicit architecture flags
disable the architecture autodetection in the compiler.

The resulting behaviour from setting fixed defaults makes it unpleasant
to compile with CMake because they increase the build times for projects
unless they are overriden (as most users do not need to build for all
five default architectures). The fixed defaults are also troublesome for
users with hardware not included in the default set (e.g., gfx1011,
gfx1031, gfx1100).

A possible alternative might be to detect the architecture within
hip-config.cmake rather than running the detection logic on each
compiler invocation. However, this approach is simpler.

Change-Id: I9495d766b7eed03852eb4dc72b0aabe4100bc32c
Signed-off-by: Cordell Bloor <Cordell.Bloor@amd.com>
2023-05-16 16:35:09 -06:00
Satyanvesh Dittakavi c98fad1edc SWDEV-399851 - Add template overload for ToString in HIPRTC
HIPRTC_INIT_API can have nullptr in the arguments and ClPrint
can crash while printing

Change-Id: Iecade5c3867196509c8cc0647b9aa24be0960a02
2023-05-16 14:21:19 +00:00
Jatin Chaudhary 8753db5446 SWDEV-384013 - Print link options being passed to compiler with AMD_LOG_LEVEL
Change-Id: I556ed434587cff07a634796da51dcbb9ae78ef21
2023-05-15 15:52:04 -04:00
Ioannis Assiouras a07e38be2f SWDEV-400119 - Return error from globalFreeMemory() if HSA available memory query fails
Change-Id: I33c069fa1e0d31891f64dc8167a24ef9d7ed1426
2023-05-15 11:54:25 +01:00
Jatin Chaudhary 15bafc9a93 SWDEV-395773 - Fix unordered compare functions in fp16 header
Change-Id: I9158420e37cd3151159182223c6645ed84c4fddd
2023-05-11 10:42:13 -04:00
Jatin Chaudhary 6c793ea206 SWDEV-367537 - Add __hip_bfloat16 and vector definitions to match __nv_bfloat16
Change-Id: I1c0f9f5f278c2c3b4e175d9f08831ba458ed856e
2023-05-11 04:45:13 -04:00
Saleel Kudchadker 0b475284e9 SWDEV-398151 - Partly relax static engine allocation
Change-Id: I4903b51a34b597a2e84d771b52cf629f877dba05
2023-05-11 00:52:18 -04:00
Jaydeep Patel ffa1deef27 SWDEV-398047 - Disable arena for XNACK.
Change-Id: If6c98490bd5b8146a357f45ed132f687def0877f
2023-05-10 23:28:05 -04:00
Satyanvesh Dittakavi a7041d15a7 SWDEV-399203 - Use clang pragma only with clang
Change-Id: I21d84ccde07e243b6bc06f1980c24b399e74d1c3
2023-05-10 04:19:51 -04:00
taosang2 7624a48de9 SWDEV-366528 – Fix image memory format updating issue
Add dstMemory format updating.
Separate format updating for srcMemory and dstMemory.

Change-Id: I1692b92d417bbd742d562679f218ebf8ca532e92
2023-05-08 21:43:42 -04:00
Jacob Lambert b17056cb93 SWDEV-380857 - Fix bug when reading bitcode file into vector<char> buffer
The previous implementation using std::copy() resulted in
differences between the in-memory and on-disk representations.
With the updated implementation, we get the same contents.

Change-Id: Iadfae3cd7f7ba99538da2ac4f11f30f5a78260d8
2023-05-08 16:25:01 -04:00
Jaydeep Patel 0eb96cbc59 SWDEV-397168 - Enable dynamic call stack size for PAL.
Change-Id: I8be51ffb48e6a742117491a4bf6f12f152e4a0b3
2023-05-07 23:26:28 -04:00
German 04b696abee SWDEV-353281 - VM support in mempool for graphs
The change enables VM support in graphs on Windows. That allows
to avoid caching of all allocations at the cost of map/unmap
overhead during memory create/destroy.

Change-Id: I792be00fba099e5e5d3cd44a963e1dfd6976a86d
2023-05-05 15:31:26 -04:00
kjayapra-amd f14e8a2dba SWDEV-393910 - Port gfx94x changes to mainline.
Change-Id: Ibf727223bbe5230b132b47c39e0fc1d87cbd3b9c
2023-05-05 15:16:23 -04:00
Ajay 0aa70ee0e1 SWDEV-394488 - cudaStreamGetCaptureInfo_v2 is undefined in CUDA 12.0
hipStreamPerThrdCompilerOptn.cc test fails to build with cudaStreamGetCaptureInfo_v2
in CUDA 12.0.
fix was to change runtime API cudaStreamGetCaptureInfo_v2
to Driver cuStreamGetCaptureInfo_v2

Change-Id: I44a0110770d3246f5345092acae301c9a2f6d520
2023-05-05 10:10:07 -04:00
Jaydeep Patel a167abefe5 SWDEV-396277 - Offset and bit size correction, Considaration of SA ID for Navi.
Correct sm id formula for GFX10 and GFX11.

Change-Id: I2883c139b8e684e0334ccc81f703a09e3ddec588
2023-05-05 01:04:42 -04:00
Ioannis Assiouras d88f0358b0 SWDEV-397356: Move HIP_API_PRINT after HIP_INIT so that the begin function call gets printed
Change-Id: I99b655596741c19bc483647794ae8b4f6e6f2843
2023-05-04 18:46:21 -04:00
Sourabh Betigeri afa28cdf44 SWDEV-393362 - Move setData() from profilingEnd() to profilingBegin() to eliminate a possible data race
- Introduce a state variable to indicate if HwProfiling is enabled to
eliminate a possible data race of vector<> signals_.

Change-Id: Id504cc76d7fa9f7e6455587dd232b60ccbbb735b
2023-05-04 17:19:25 -04:00
Saleel Kudchadker 0a7708f982 SWDEV-301667 - Better log
Change-Id: I7399de7fe7a8840568d02362d2d936173583030c
2023-05-04 16:29:02 -04:00
Ioannis Assiouras 29e0d2f335 SWDEV-398511 - Removed hiprtc_internal.hpp
Change-Id: Ic0751dfeb4936b3e233b44e34d16e0a1605874d7
2023-05-04 16:50:18 +01:00
Ioannis Assiouras 633e720da4 SWDEV-393199 - Added new include file for opengl interop mappings for nvidia
Change-Id: I2e955a9dd06539939188a5f2e1dde4f173af1202
2023-05-03 19:43:24 -04:00
kjayapra-amd 7f41a96ffb SWDEV-378006 - Adding a new guarantee macro to support printing args.
Change-Id: I2083ddaf8058759bdace7d3bb1e8e3670cbeddd2
2023-05-03 12:43:16 -04:00
Jaydeep Patel 82e4859e03 SWDEV-392870 - Enable p2p support for image using PAL.
Change-Id: I3acbbc01ee11e488e93204814361b8c3431bca4f
2023-05-03 00:34:08 -04:00
Jatin Chaudhary c585aefdb7 SWDEV-376453 - Changes to fix crash seen with HIP and recent compiler change with -O0
Change-Id: I37de83b7449461ce2378741e97ff8fb8da736523
2023-05-02 17:46:38 -04:00
taosang2 381e6520d0 SWDEV-396574 – Refactor texture channel type checking
Create __hip_is_tex_surf_channel_type to replace
__hip_is_tex_channel_type
__hip_is_itex_channel_type
__hip_is_surf_channel_type .

Change-Id: I1692b92d417bad742d562679f218ebf8ca532e31
2023-05-02 10:01:13 -04:00
pghafari 31b362bf6e SWDEV-369567 - dimension check update
Change-Id: I31deb5070d4852db7dd6d37f9a514965f387698e
2023-05-02 08:04:04 -04:00
Jatin Chaudhary 54f73e430b SWDEV-1 - Fix incorrect SGPR usage in VGPR calculation. Pointed out by #58 issue on hipamd public repo
Change-Id: I8c27c0da254521714c92369990aa10f6fc09c246
2023-05-02 03:53:18 -04:00
Jaydeep Patel cbd91bdc19 SWDEV-395559 - Move unsigned short up.
Change-Id: I3373a7bc22e632dc10b94b93ff023444d456b2b7
2023-05-02 00:43:36 -04:00
Saleel Kudchadker 538d453b86 SWDEV-301667 - Cleanup log
Change-Id: I9719ec8b19406a062727937471e7a845a522a0be
2023-05-01 11:07:55 -07:00
Saleel Kudchadker 9775c38725 SWDEV-392427 - Invalidate Barrier Value AQL header
Change-Id: Id8e04ffe44da58641361468957d397af128443bb
2023-05-01 14:06:05 -04:00
taosang2 2f2d02649f SWDEV-396574 – Refactor device mapping functions
Refactor mapFrom(), mapTo(), mapElem(),
__hip_is_surf_channel_type() and
__hip_is_itex_channel_type()

Change-Id: I1692b92d407bad742d562678f218ebf8ca532e91
2023-05-01 13:57:10 -04:00
sdashmiz 544318fffe SWDEV-360031 - Correct APIs behaviour
- correct error for hipStreamWaitEvent when event recorded before
  capture
- correct hipEventSync when event is synced during capture

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I7ecbed5621eaf323846d4ccb20ec112aaa8a5757
2023-05-01 13:38:59 -04:00
victzhan d9c00767dc SWDEV-345751 - fix misinitialize arraySlice in partialMemCopyTo()
Change-Id: I622c368957b1bd39e973f9afa4ee01593dd9e8ac
2023-05-01 13:07:44 -04:00
Alex Xie 42f8b9183d SWDEV-390565 - ocltst test failing
part 2 of the fix

Change-Id: I4ff2cf0f82b5cf57c7ee51a60bbac770a605a837
2023-05-01 12:31:37 -04:00
Alex Xie 475f80ee0e SWDEV-389541 - mipmap tests failed
Change-Id: I8dec8ff9515c55a3a6b16157f7d064b2b109d5f3
2023-05-01 12:31:17 -04:00
Alex Xie a0c1f496a4 SWDEV-390565 - ocltst test failing
Change-Id: I76a12878a1d3c029b771335eb23b129cac125517
2023-05-01 09:37:36 -04:00
German 7ef2da5aba SWDEV-353281 - Move VirtualMem map update to memobj
- The implementation in mempool graphs requires refcounting VA object.
That requires release() to update the map only on the actual destruction.
- Add GPU event tracking for paging operation. Otherwise, runtime
may not always flush IB.

Change-Id: Idf99ffb894321a38e04b490116a7ca435635918d
2023-04-28 17:22:11 -04:00
Ajay 22eae6ac9e SWDEV-374386 - hipGraphAddMemcpyNode negative cases
validate 3d memcpy params -
pitch, extend - height/width/depth, src/dst offsets and total size

Change-Id: I629fc242264ebbc3e9dbfd9233da8d3a127500b4
2023-04-28 12:11:24 -04:00
Maneesh Gupta ccad05fe01 SWDEV-1 - Search for doxygen config in old and new locations
Change-Id: Iebe7295c7200cc164cb32047df96aa70dec75bf4
2023-04-27 04:57:12 -04:00
Saleel Kudchadker 4a73fbec00 SWDEV-355540 - Do not reset core affinities
- Do not reset core affinities when spawning new threads

Change-Id: I26a12075a1ff197bc217aafb9ba18ffbb019ef43
2023-04-26 16:52:37 -04:00
German Andryeyev 3e5803c4c0 SWDEV-381627 - Move cl_vk_amd.hpp into rocclr
Rename VK interop to ExternalMemory object, since it should handle
DX interops also

Change-Id: I536ec46d3e53ece35234a2e29030393ad411b96d
2023-04-26 15:25:01 -04:00
Satyanvesh Dittakavi a67f354cec SWDEV-395413 - Fix fp16 header errors with -Werror in hiprtc
Change-Id: I7875b91758e826b439c67ac9f211a20f9b6133f0
2023-04-26 13:05:20 -04:00
German d05f7734d3 SWDEV-1 - Ignore .vs folder in git on Windows
Change-Id: I6654bd98ec7809a4857cd649d2f2f3c4316160d8
2023-04-25 17:55:08 -04:00
Sourabh Betigeri 7aba1cf4cd SWDEV-392367 - Fixes hipMemGetAddressRange returning device buffer size as 0
Change-Id: I6b5640b544390b2dfc53fad271acc7f30240e274
2023-04-25 13:46:52 -04:00
Jaydeep Patel b6aa27d4a3 SWDEV-389647 - SWDEV-388950 - Check device id same while set params.
GraphMemcpyNodeSetParamsFrom/ToSymbol APIs neew to check device id for
original src/dst is same as what is passed in while set.

Change-Id: If0b610808223dce9115562bb5e9b31c8eaa2df22
2023-04-25 13:24:26 -04:00
taosang2 650b6767c4 SWDEV-390626 - Fix wrong mapping functions
Remove wrong functions
__hipMapFromNativeFloat4()
__hipMapToNativeFloat4()

Replace them with mapFrom() and mapTo()

Change-Id: I1692b92d397bfd732d562778f918ebf8ca532e93
2023-04-25 13:19:00 -04:00
Jacob Lambert 2a9d8b5862 SWDEV-1 - Add missing newlines to debug log output
Change-Id: I6c98d482079c34931cdc0615075eba34f87241f3
2023-04-25 13:10:57 -04:00
German 31697779bb SWDEV-353281 - Don't add the same stream into the list
Change-Id: I7f41de68b669dc759bdb11657dd897ad57e368fc
2023-04-25 10:21:55 -04:00
pghafari afa15ddb89 SWDEV-367145 - adding support for timeline semaphore
Change-Id: I654359b48abe8bbaac2def5118d3ad0bb05d9492
2023-04-25 10:02:43 -04:00