Cordell Bloor
e1bed6f354
SWDEV-346940 - Remove default AMDGPU_TARGETS
...
hipcc and clang++ both have logic to detect the installed hardware
and to automatically select the appropriate AMDGPU target when it is
left unspecified. When the AMDGPU_TARGETS property is initialized with
a set of default values, it results in the addition of an explicit set
of --offload-arch flags being passed. These explicit architecture flags
disable the architecture autodetection in the compiler.
The resulting behaviour from setting fixed defaults makes it unpleasant
to compile with CMake because they increase the build times for projects
unless they are overriden (as most users do not need to build for all
five default architectures). The fixed defaults are also troublesome for
users with hardware not included in the default set (e.g., gfx1011,
gfx1031, gfx1100).
A possible alternative might be to detect the architecture within
hip-config.cmake rather than running the detection logic on each
compiler invocation. However, this approach is simpler.
Change-Id: I9495d766b7eed03852eb4dc72b0aabe4100bc32c
Signed-off-by: Cordell Bloor <Cordell.Bloor@amd.com >
2023-05-16 16:35:09 -06:00
Satyanvesh Dittakavi
c98fad1edc
SWDEV-399851 - Add template overload for ToString in HIPRTC
...
HIPRTC_INIT_API can have nullptr in the arguments and ClPrint
can crash while printing
Change-Id: Iecade5c3867196509c8cc0647b9aa24be0960a02
2023-05-16 14:21:19 +00:00
Jatin Chaudhary
8753db5446
SWDEV-384013 - Print link options being passed to compiler with AMD_LOG_LEVEL
...
Change-Id: I556ed434587cff07a634796da51dcbb9ae78ef21
2023-05-15 15:52:04 -04:00
Jatin Chaudhary
15bafc9a93
SWDEV-395773 - Fix unordered compare functions in fp16 header
...
Change-Id: I9158420e37cd3151159182223c6645ed84c4fddd
2023-05-11 10:42:13 -04:00
Jatin Chaudhary
6c793ea206
SWDEV-367537 - Add __hip_bfloat16 and vector definitions to match __nv_bfloat16
...
Change-Id: I1c0f9f5f278c2c3b4e175d9f08831ba458ed856e
2023-05-11 04:45:13 -04:00
Jaydeep Patel
ffa1deef27
SWDEV-398047 - Disable arena for XNACK.
...
Change-Id: If6c98490bd5b8146a357f45ed132f687def0877f
2023-05-10 23:28:05 -04:00
Satyanvesh Dittakavi
a7041d15a7
SWDEV-399203 - Use clang pragma only with clang
...
Change-Id: I21d84ccde07e243b6bc06f1980c24b399e74d1c3
2023-05-10 04:19:51 -04:00
Jacob Lambert
b17056cb93
SWDEV-380857 - Fix bug when reading bitcode file into vector<char> buffer
...
The previous implementation using std::copy() resulted in
differences between the in-memory and on-disk representations.
With the updated implementation, we get the same contents.
Change-Id: Iadfae3cd7f7ba99538da2ac4f11f30f5a78260d8
2023-05-08 16:25:01 -04:00
German
04b696abee
SWDEV-353281 - VM support in mempool for graphs
...
The change enables VM support in graphs on Windows. That allows
to avoid caching of all allocations at the cost of map/unmap
overhead during memory create/destroy.
Change-Id: I792be00fba099e5e5d3cd44a963e1dfd6976a86d
2023-05-05 15:31:26 -04:00
kjayapra-amd
f14e8a2dba
SWDEV-393910 - Port gfx94x changes to mainline.
...
Change-Id: Ibf727223bbe5230b132b47c39e0fc1d87cbd3b9c
2023-05-05 15:16:23 -04:00
Ajay
0aa70ee0e1
SWDEV-394488 - cudaStreamGetCaptureInfo_v2 is undefined in CUDA 12.0
...
hipStreamPerThrdCompilerOptn.cc test fails to build with cudaStreamGetCaptureInfo_v2
in CUDA 12.0.
fix was to change runtime API cudaStreamGetCaptureInfo_v2
to Driver cuStreamGetCaptureInfo_v2
Change-Id: I44a0110770d3246f5345092acae301c9a2f6d520
2023-05-05 10:10:07 -04:00
Jaydeep Patel
a167abefe5
SWDEV-396277 - Offset and bit size correction, Considaration of SA ID for Navi.
...
Correct sm id formula for GFX10 and GFX11.
Change-Id: I2883c139b8e684e0334ccc81f703a09e3ddec588
2023-05-05 01:04:42 -04:00
Ioannis Assiouras
d88f0358b0
SWDEV-397356: Move HIP_API_PRINT after HIP_INIT so that the begin function call gets printed
...
Change-Id: I99b655596741c19bc483647794ae8b4f6e6f2843
2023-05-04 18:46:21 -04:00
Ioannis Assiouras
29e0d2f335
SWDEV-398511 - Removed hiprtc_internal.hpp
...
Change-Id: Ic0751dfeb4936b3e233b44e34d16e0a1605874d7
2023-05-04 16:50:18 +01:00
Ioannis Assiouras
633e720da4
SWDEV-393199 - Added new include file for opengl interop mappings for nvidia
...
Change-Id: I2e955a9dd06539939188a5f2e1dde4f173af1202
2023-05-03 19:43:24 -04:00
kjayapra-amd
7f41a96ffb
SWDEV-378006 - Adding a new guarantee macro to support printing args.
...
Change-Id: I2083ddaf8058759bdace7d3bb1e8e3670cbeddd2
2023-05-03 12:43:16 -04:00
taosang2
381e6520d0
SWDEV-396574 – Refactor texture channel type checking
...
Create __hip_is_tex_surf_channel_type to replace
__hip_is_tex_channel_type
__hip_is_itex_channel_type
__hip_is_surf_channel_type .
Change-Id: I1692b92d417bad742d562679f218ebf8ca532e31
2023-05-02 10:01:13 -04:00
pghafari
31b362bf6e
SWDEV-369567 - dimension check update
...
Change-Id: I31deb5070d4852db7dd6d37f9a514965f387698e
2023-05-02 08:04:04 -04:00
Jatin Chaudhary
54f73e430b
SWDEV-1 - Fix incorrect SGPR usage in VGPR calculation. Pointed out by #58 issue on hipamd public repo
...
Change-Id: I8c27c0da254521714c92369990aa10f6fc09c246
2023-05-02 03:53:18 -04:00
Jaydeep Patel
cbd91bdc19
SWDEV-395559 - Move unsigned short up.
...
Change-Id: I3373a7bc22e632dc10b94b93ff023444d456b2b7
2023-05-02 00:43:36 -04:00
taosang2
2f2d02649f
SWDEV-396574 – Refactor device mapping functions
...
Refactor mapFrom(), mapTo(), mapElem(),
__hip_is_surf_channel_type() and
__hip_is_itex_channel_type()
Change-Id: I1692b92d407bad742d562678f218ebf8ca532e91
2023-05-01 13:57:10 -04:00
sdashmiz
544318fffe
SWDEV-360031 - Correct APIs behaviour
...
- correct error for hipStreamWaitEvent when event recorded before
capture
- correct hipEventSync when event is synced during capture
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com >
Change-Id: I7ecbed5621eaf323846d4ccb20ec112aaa8a5757
2023-05-01 13:38:59 -04:00
Ajay
22eae6ac9e
SWDEV-374386 - hipGraphAddMemcpyNode negative cases
...
validate 3d memcpy params -
pitch, extend - height/width/depth, src/dst offsets and total size
Change-Id: I629fc242264ebbc3e9dbfd9233da8d3a127500b4
2023-04-28 12:11:24 -04:00
Maneesh Gupta
ccad05fe01
SWDEV-1 - Search for doxygen config in old and new locations
...
Change-Id: Iebe7295c7200cc164cb32047df96aa70dec75bf4
2023-04-27 04:57:12 -04:00
German Andryeyev
3e5803c4c0
SWDEV-381627 - Move cl_vk_amd.hpp into rocclr
...
Rename VK interop to ExternalMemory object, since it should handle
DX interops also
Change-Id: I536ec46d3e53ece35234a2e29030393ad411b96d
2023-04-26 15:25:01 -04:00
Satyanvesh Dittakavi
a67f354cec
SWDEV-395413 - Fix fp16 header errors with -Werror in hiprtc
...
Change-Id: I7875b91758e826b439c67ac9f211a20f9b6133f0
2023-04-26 13:05:20 -04:00
Sourabh Betigeri
7aba1cf4cd
SWDEV-392367 - Fixes hipMemGetAddressRange returning device buffer size as 0
...
Change-Id: I6b5640b544390b2dfc53fad271acc7f30240e274
2023-04-25 13:46:52 -04:00
Jaydeep Patel
b6aa27d4a3
SWDEV-389647 - SWDEV-388950 - Check device id same while set params.
...
GraphMemcpyNodeSetParamsFrom/ToSymbol APIs neew to check device id for
original src/dst is same as what is passed in while set.
Change-Id: If0b610808223dce9115562bb5e9b31c8eaa2df22
2023-04-25 13:24:26 -04:00
taosang2
650b6767c4
SWDEV-390626 - Fix wrong mapping functions
...
Remove wrong functions
__hipMapFromNativeFloat4()
__hipMapToNativeFloat4()
Replace them with mapFrom() and mapTo()
Change-Id: I1692b92d397bfd732d562778f918ebf8ca532e93
2023-04-25 13:19:00 -04:00
German
31697779bb
SWDEV-353281 - Don't add the same stream into the list
...
Change-Id: I7f41de68b669dc759bdb11657dd897ad57e368fc
2023-04-25 10:21:55 -04:00
pghafari
afa15ddb89
SWDEV-367145 - adding support for timeline semaphore
...
Change-Id: I654359b48abe8bbaac2def5118d3ad0bb05d9492
2023-04-25 10:02:43 -04:00
sdashmiz
261ce9837c
SWDEV-387508 - do not treat uuid as string
...
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com >
Change-Id: I4de88330650eba4e4259686cdb5fb089b17aa8e4
2023-04-25 09:52:12 -04:00
Jaydeep Patel
3dfe48b582
SWDEV-390597 - Return No Device error for hipSetDevice and hipSetDeviceFlags.
...
Change-Id: I457b1197a8f1b71a8bbbdf09f193f643c61700b6
2023-04-24 03:50:33 -04:00
Jaydeep Patel
3c5888922e
SWDEV-389648 - Find node and then erase.
...
Change-Id: Iecf78fe6b0645e58b4de6658b59ad1285946b698
2023-04-19 01:05:58 -04:00
Jaydeep Patel
415fb15c76
SWDEV-389477 - Check D2D is intra device.
...
Change-Id: Ibef2a6de82a18357ef35bcd70298478de6b0e380
2023-04-19 01:01:12 -04:00
Jaydeep Patel
2576153acd
SWDEV-388943,SWDEV-388954 - Corrected validations for memcpy kind.
...
Change-Id: I8338111ac46e4eba279d53969d12df3a23552049
2023-04-19 01:00:50 -04:00
Jaydeep Patel
7215451db9
SWDEV-388958 - SWDEV-388929 - Kind can be hipMemcpyDefault for H2D and D2D and srcMemory can be allocated using hipHostMalloc for H2D.
...
Change-Id: I187ff850ebb890b357ee03500105b71468508ea2
2023-04-19 01:00:28 -04:00
Jaydeep Patel
09a081235c
SWDEV-391731 - Check thread local list too.
...
With global flag, In addition to global vector, we need to check
thread local vector too. If both of them are empty then only
return false.
Change-Id: I3a24d16a35c702b34b9a8867dc410ebd80108f25
2023-04-19 01:00:09 -04:00
Jaydeep Patel
e8eb1772f2
SWDEV-391178 - Extern monitor to avoid copy in multithreading.
...
Defining monitor in header cause copy and hence it's moved to cpp.
Change-Id: Ib07bbde2808d9cb2af9349076f777e8a5b28d210
2023-04-19 00:58:49 -04:00
pghafari
78de2ae692
SWDEV-366992 - adding handle type for vk interop
...
Change-Id: I79ee0d89b948c21b96709e9e607abe7901621a97
2023-04-18 16:59:25 -04:00
German Andryeyev
e82eecf33e
SWDEV-231145 - Add a validation for uniform launch
...
Change-Id: I68d61690c50060d9dcca117b248dddf69204a23f
2023-04-18 12:56:09 -04:00
German Andryeyev
73698479a9
SWDEV-382359 - Workaround a non-uniform launch in MIOpen
...
Change-Id: I0abff25fb20143225739e771c4d3bae5c2a054b9
2023-04-18 11:36:10 -04:00
Satyanvesh Dittakavi
a3104c60e1
SWDEV-393060 - Address directed tests build failures with CLR
...
Change-Id: I76b93ee073d21ec5fae0db5a129ada89f750855d
2023-04-14 03:53:51 -04:00
Ajay
e5a300f892
SWDEV-393406 - hip catch/directed tests on nvidia
...
fix the duplicate symbolic link issue
Change-Id: I472dfba80263d0f1d275d8e149007322c8af3f7c
2023-04-10 19:54:23 +00:00
Ajay
5e9545fdfd
SWDEV-361630 - clr to be able to build hip directed tests
...
Change-Id: I85b45c52573683a963ac2b4ee0ec7c79653ecc4d
2023-04-07 14:21:34 -04:00
Ranjith Ramakrishnan
267b342523
SWDEV-351540 - ASAN packaging for hip
...
Package ASAN libraries and license file
Suffix "asan" added to package name
Change-Id: Ia02bb55be0bd415dbd372b39ce884c38d8c3dcbf
2023-04-07 11:54:48 +00:00
taosang2
53742adc08
SWDEV-390626 - Support surface Apis
...
Change-Id: I1691b82d597bfd722d562778f919ebf8ca530e90
2023-04-05 16:38:04 +00:00
German
1e88d2c52f
SWDEV-380703 - sync all streams individually
...
Avoid syncing blocking streams with the default stream,
since that introduces extra command dependencies and
doesn't allow to destroy memory after last submission
Change-Id: I618e9bd2091c4cf9157125612d8c4759030c5a80
2023-04-05 16:37:49 +00:00
Jaydeep Patel
0f975e6e93
SWDEV-390439 - SWDEV-387997 - Delete array.
...
Change-Id: Ica20b005f5db7f4ed65c5ebc51959392671fe320
2023-04-05 16:37:39 +00:00
Jaydeep Patel
4d8fd17985
SWDEV-362365 - Return invalid value if config is not valid.
...
Change-Id: I5f7300060f25536f8d3fd25afc2fe2522b621432
2023-04-05 16:37:28 +00:00