SWDEV-216705 - [hipclang-vdi-rocm][FBA-80]Test crash when all GPUs are hidden by ROCR_VISIBLE_DEVICES
Return an error instead of dereferencing a null pointer. This should address the issue described
in the ticket, but more places need fixing in the runtime to avoid crashes for corner cases.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#26 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#23 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#92 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#58 edit
SWDEV-213031 - Check the functions_ map else interpret as a hip::Function for now. Function may not be a device function and may have been obtaiend via hipModuleGetFunction and thus not in the functions_ map
ReviewBoardURL = http://ocltc.amd.com/reviews/r/18388/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#57 edit
SWDEV-145570 - [hip] special case const char* for logs in case it's a null pointer.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/trace_helper.h#3 edit
SWDEV-214490 - Update HIP RT for texture3D in HIP/PAL on Windows
-Update hipCreateTextureObject
http://ocltc.amd.com/reviews/r/18382/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#91 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#30 edit
SWDEV-213526 - [hip] OOM issue
Delay any access to device layers till HIP API is called by app.
This allows the app to fork the process first and then call HIP which is legal.
Doing hip calls then fork isn't legal nor supported by ROCm.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#25 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#49 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#55 edit
* fix linking of vector types when linking hipcc objects with gcc
* use __atribute__((vector_size)) with both clang and gcc
and reinstate nonaligned n=3 vector type
* use implicit conversion to value and ext_vector_type when available
* Alternate formulation for GCC compatibility
* Built-in arrays don't mix well with placement new
* Fix typo
* Add conversions to enum
* Fix Scalar_accessor assignment.
* Update hip_vector_types.h
* stir up the underlying_type hideous mess
This fixes the HIP build issue "error: only enumeration types have underlying types".
SWDEV-214490 - Update HIP RT for texture3D in HIP/PAL on Windows
-Update hipTexRefSetArray
http://ocltc.amd.com/reviews/r/18356/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#29 edit
Reverting #1673, #1697 and #1707.
Support for hipMemcpyWithStream and memcpy optimizations, will be brought in again once issues seen with these are resolved independently.
SWDEV-214490 - Update HIP RT for texture3D in HIP/PAL on Windows
-Update hipMemcpy3D function
http://ocltc.amd.com/reviews/r/18346/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#90 edit
SWDEV-145570 - Adding back the lazy kernel changes because the OOM issue is because of KFD/RocR.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#53 edit
+ Both Driver API and RT API are supported and synced with each other
+ Update *.md docs and hipify-perl accordingly
+ Add new conversion type "virtual_memory", introduced in Dirver API
[Background] it was found that if lazy linking used for a library that calls hipExtLaunchMultiKernelMultiDevice API then this API can get the wrong program_state object for looking up device kernels leading to a "No device code available" error in this API.
To fix this issue, the API was refactored to be inline and get and pass the correct program_state to an internal hip API to request a multi-device kernel launch.
SWDEV-214490 - Update HIP RT for texture3D in HIP/PAL on Windows
-Update ihipBindTexture
http://ocltc.amd.com/reviews/r/18333/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#89 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#28 edit
+ Update *.md docs and hipify-perl accordingly
[Reason]
Starting with CUDA 10.1 all error codes are merged between Driver and RT APIs
[ToDo]
Do the same merge in HIP API as there is no need in distinguishing return codes by API
SWDEV-214490 - Update HIP RT for texture3D in HIP/PAL on Windows
- Update function hipMemcpy3D for Texture Array
- Add hipArrayCubemap support in hipMalloc3DArray
http://ocltc.amd.com/reviews/r/18328/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#88 edit
SWDEV-213526 - pytorch tests fail with hipErrorOutofMemory
There's a bug in ROCr when loading a lot of kernels and not syncing
So for now, if an allocation fails, sync devices and retry before
returning hipErrorOutOfMemory error.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#86 edit
mhbliao
Evgeny Mankov
foreman
Vladislav Sytchenko
jglaser
Rahul Garg
Maneesh Gupta
Aryan Salmanpour
Siu Chi Chan
Alex Voicu
Jeff Daily
Anusha Godavarthy Surya