306d50291e
Unary operators were too restrictive in the type of their argument. ( #1683 )
2019-11-22 07:54:53 +05:30
562336e733
[HIPIFY] fix typo ( #1681 )
2019-11-22 07:54:37 +05:30
e5fc5aa41c
Fix rocBLAS compilation failure ( #1677 )
...
SWDEV-212749:
o Recent changes to “add support for extended launch” require hip_runtime.h to be include in hip_ext.h
o Order in which external applications include hip_hcc.h/hip_runtime.h causes compilation failure
2019-11-22 07:54:17 +05:30
2ed3a0873c
Use native support for atomic FADD when address is in LDS ( #1591 )
2019-11-22 07:53:48 +05:30
6cabc4898d
P4 to Git Change 2034910 by kjayapra@0_HIPWS_LNX1_ROCM on 2019/11/21 19:28:10
...
SWDEV-145570 - Revering CL#2033779 for now.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#48 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#49 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#51 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.cpp#70 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.hpp#36 edit
2019-11-21 19:33:05 -05:00
d4dde7a27d
fixed directed tests fail when hcc bumped to 3.0 ( #1678 )
...
Handled the HCC version check appropriately as few of the directed tests (SWDEV-212161) were failing when hcc was bumped to 3.0.
2019-11-20 21:37:52 +05:30
022ac3cb0a
General sync memcpy improvements. Add hipMemcpyWithStream ( #1673 )
...
* General sync memcpy improvements. Add `hipMemcpyWithStream`
* Update hip_memory.cpp
2019-11-20 21:36:37 +05:30
13c2a31d7e
Update error codes for hipGetDevice for doxygen and move up null check ( #1668 )
...
* [docs] Update error codes for hipGetDevice
* Move up out ptr check
2019-11-20 21:35:27 +05:30
57b1b03261
Fix helper header when using c++17 ( #1666 )
...
This will fix issue #1621 . It also adds tests for is_callable with c++11, c++14, and c++17.
The fallback implementation was completely broken so I rewrote it so it pass the tests as well. This should be used instead of PR #1631 .
2019-11-20 21:33:42 +05:30
c383f20691
Extend vector type capabilities and add tests to reflect it. ( #1656 )
2019-11-20 21:32:32 +05:30
06167b8112
P4 to Git Change 2033779 by kjayapra@0_HIPWS_LNX1_ROCM on 2019/11/20 07:17:56
...
SWDEV-144570 - Update function global during hipModuleLoad.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#47 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#48 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#50 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.cpp#69 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.hpp#35 edit
2019-11-20 07:24:20 -05:00
8a3c36a424
Revert [HIP] Fixed hipStreamAddCallback ( #1674 )
...
This reverts commit 97fca3439d
2019-11-20 11:55:46 +05:30
e3cee22eeb
P4 to Git Change 2033170 by cpaquot@cpaquot-ocl-lc-lnx on 2019/11/19 13:26:16
...
SWDEV-212215 - HIP-VDI runtime should not lazy load device code objects
Temporarly disable lazy load of code objects for debugger.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#49 edit
2019-11-19 13:34:00 -05:00
dfaaf04611
hipStreamSynchronize can skip marker if stream is empty ( #1667 )
2019-11-19 09:42:43 -08:00
fa1335f419
[dtest] Rename hipExtLaunchMultiKernelMultiDevice dtest ( #1671 )
2019-11-19 09:41:13 -08:00
e158b0b255
hostcall: add tests that are only used by the VDI build ( #1664 )
2019-11-18 19:52:40 -08:00
a45de95113
Fix mathlib and app builds with hip-clang. ( #1665 )
2019-11-18 08:18:20 -08:00
ff31f734fe
Fix gcc build on NVCC path ( #1661 )
...
* Fix gcc build on NVCC path
* Fix CI build errors
* [dtest] Fix texture and surface obj2D tests
2019-11-18 12:19:22 +05:30
cae9b13020
fix complex conjugate for double-complex ( #1659 )
...
The sign in the y component returned from hipConj incorrect for double-complex. Fix to match as in hipConjf above.
2019-11-18 12:19:12 +05:30
7985ad218f
Added null check in hipEventSynchronize ( #1627 )
...
* Added missing null check in hipEventSynchronize
* Minor correction in the Event API description
2019-11-18 12:18:55 +05:30
7bbd420068
Updated hipEnvVarDriver to work with Windows ( #1614 )
...
* Updated hipEnvVarDriver to work with Windows
* Cleaned up a bit of code
* Fixed a part where putenv was used for both win and linux
* Defines moved to test_common.h and cleaned up code
* Cleaned up some macro defines and used const char instead
* Got rid of some excess commenting
* directory paths are unconditional
* Cleaned some duplicate code, and variables are now declared and defined together
2019-11-18 12:18:29 +05:30
99da905509
[dtests] Fixing compilation error in saxpy.cpp ( #1608 )
2019-11-18 12:18:11 +05:30
355d0bdf95
Add support for extended launch syntax. ( #1530 )
...
* Add support for extended launch syntax.
* Add unit test.
* Fix typo
* hipExtLaunchKernelGGL lives in hip_ext.h
Change-Id: Ice32dab0d43475fda65c6a910c11416871a8f2ff
* [dtest] remove redundant include from hipModuleGetGlobal dtest
2019-11-16 22:24:07 -08:00
1ee794c7f3
P4 to Git Change 2031768 by cpaquot@cpaquot-ocl-lc-lnx on 2019/11/16 17:21:58
...
SWDEV-212440 - [HIP] Memory access fault observed on Pytorch while running performance tests with Microbenchmarking script
We need to loop through all the default stream to sync them in case
the app call hipFree on a different current stream and another current stream
is using the memory.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#85 edit
2019-11-16 17:25:59 -05:00
4d0a234183
[ci] Fix failures on nvcc path ( #1654 )
...
Change-Id: I97f6b51314e14965618ab510bf57a2b034183e78
2019-11-15 07:58:40 +05:30
5a03482690
[packaging] Conform to debian package naming rules ( #1647 )
...
* [packaging] Conform to debian package naming rules
* Add hip_hcc metapackage for backward compatibility
2019-11-14 11:40:34 +05:30
8d29a5192d
P4 to Git Change 2029899 by kjayapra@0_HIPWS_LNX1_ROCM on 2019/11/13 12:29:19
...
SWDEV-144570 - Implementing ihipUnbindTextureImpl API.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#35 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#33 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#27 edit
2019-11-13 12:34:13 -05:00
6efa1d4655
P4 to Git Change 2029039 by kjayapra@0_HIPWS_LNX1_ROCM on 2019/11/12 12:52:46
...
SWDEV-210844 - Implementing hipExtGetLinkTypeAndHopCount
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#22 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.hpp#344 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.hpp#47 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.cpp#141 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.hpp#44 edit
2019-11-12 12:55:17 -05:00
bb6f1648ec
[HIPIFY][doc] A few words about LLVM's FileCheck in README.md
2019-11-12 16:04:28 +03:00
0a2682625f
Bump version to 3.0 ( #1648 )
...
Change-Id: Id1e6eb222080a339af938212e74a52c39c305eab
2019-11-10 20:23:58 -08:00
d28ad401c9
Remove redundant declarations.
...
- The revised `hip/hip_ext.h` have that declarations.
2019-11-07 10:11:22 -05:00
7f143585f6
[HIPIFY] Clang style formatting
2019-11-07 12:48:05 +03:00
4d2424ad36
[HIPIFY][fix] Delete canCompileHostAndDeviceInOneJob declaration as well
2019-11-07 11:32:53 +03:00
21c3d25403
[HIPIFY][fix] Abandon canCompileHostAndDeviceInOneJob check for --cuda-compile-host-device option
...
[Reason] It turned out that it is not so: 2 jobs are always
2019-11-07 11:30:40 +03:00
f18e63b8a9
[HIPIFY] Reorder options propagation to clang
...
[Reason] Leave overriding opportunity for -D, -std=c++XX, etc.
2019-11-07 11:21:06 +03:00
854147e911
General hipMemset improvements ( #1495 )
...
* hipMemset et al can use HSA API directly for synchronous cases
* lock and flush stream in hipMemset, hold lock until complete
* move hipMemset async check to front of conditional
* use hsa_amd_memory_fill for additional sync memset cases
code cleanup/review for all memset calls
* Fix inversion of execution mutating value.
* ihipMemsetSync fall back to kernel if HSA memset fails
* Never fallback, never surrender.
* Allow NULL stream.
* Optimise memset kernel. Remove deadwood.
* Update hip_memory.cpp
* Clean up stream logic in sync memset
* Revert "Clean up stream logic in sync memset"
This reverts commit 6117dedf673367f44cc704192573a117a3d92477.
2019-11-07 13:19:54 +05:30
d38cc8efba
Remove native vector support from the GCC case, since it never worked ( #1637 )
2019-11-07 13:19:14 +05:30
97fca3439d
[HIP] Fixed hipStreamAddCallback [SWDEV#165185] ( #1425 )
...
Fixed hipStreamAddCallback() as requested in SWDEV#165185
Added unit test to test the behavior
2019-11-07 13:18:12 +05:30
dc8f556460
Fixed texture 2D mapping for pitched arrays & 3D Texture read ( #1415 )
...
Texture 2D image mapping for pitched arrays:
github issue: Texture Object's Buffer seems to be Misaligned #886
JIRA ticket: SWDEV-199313
SWDEV-151670 : Fixed issue with 3D texture with 4 components
SWDEV-151671 : Issue with 2D layered texture with 4 components
2019-11-07 13:17:46 +05:30
dfee3ae279
Rename hip/hip_hcc.h to hip/hip_ext.h ( #1341 )
...
* Rename hip/hip_hcc.h to hip/hip_ext.h
* Deprecate hip_hcc.h
2019-11-07 13:17:10 +05:30
39587efda6
P4 to Git Change 2026174 by eshcherb@evgeny-hip on 2019/11/06 19:37:26
...
SWDEV-197289 - tracing callbacks call fix
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_prof_api.h#5 edit
2019-11-06 19:47:10 -05:00
6d0c96993d
P4 to Git Change 2026152 by cpaquot@cpaquot-ocl-lc-lnx on 2019/11/06 17:50:08
...
SWDEV-206239 - [HIP] RCCL: finegrain VRAM does not work
Implemented fine grained VRAM allocation via ATOMICS.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#84 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.cpp#138 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.hpp#43 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocmemory.cpp#45 edit
2019-11-06 18:00:44 -05:00
d8e9a09064
Merge pull request #1630 from ROCm-Developer-Tools/hotfix_volatile_accessors
...
__half2 should walk like CUDA and talk like CUDA
2019-11-06 10:25:03 -08:00
5af7ca4445
Merge pull request #1620 from jeffdaily/hipEventRecord_patch
...
fix race condition in hipEventRecord
2019-11-06 10:23:24 -08:00
97a0670d29
[HIPIFY][Win][fix] canCompileHostAndDeviceInOneJob is true only for LLVM >= 10
2019-11-06 19:25:42 +03:00
3f737625ee
[HIPIFY][doc] Update README.md
...
+ Supported versions, testing
2019-11-06 19:18:13 +03:00
b2af1820f5
hipEventRecord only needs one lock; remove locked_eventIsReady
2019-11-06 15:56:32 +00:00
444122dfb9
remove ihipEvent_t::refreshEventStatus(), new hipEventElapsedTime
...
This fixes possible races in hipEventElapsedTime.
2019-11-06 15:46:46 +00:00
4cad5fab78
[HIPIFY][format] Apply clang style formatting in LLVMCompat
2019-11-06 14:43:22 +03:00
3dcae8760d
[HIPIFY] Add a compatibility for CharSourceRange if LLVM < 7
2019-11-06 14:30:39 +03:00
Alex Voicu
Shyam Saladi
ansurya
foreman
satyanveshd
Rahul Garg
Paul Fultz II
Sarbojit2019
Jeff Daily
Sameer Sahasrabuddhe
mhbliao
Nick Curtis
jiabaxie
kjayapra-amd
Maneesh Gupta
Evgeny Mankov
Michael LIAO