Commit Graph

1154 Commits

Author SHA1 Message Date
kpyzhov 2d617bba3b Don't use accelerated vector element access for hip-clang. (#1796)
[ROCm/clr commit: 1d6a2fb064]
2020-01-15 18:17:08 -08:00
kpyzhov 8bf4210095 Add missing constructors for Scalar_accessor class. (#1792)
[ROCm/clr commit: 0918614615]
2020-01-14 11:30:21 -08:00
Evgeny Mankov d1d680a1d6 [HIP] Unify hipError_t (Step 3): Sync nvcc path (#1778)
* [HIP] Unify hipError_t (Step 3): Sync nvcc path

* [HIP][fix] Add CUDA 10.x support to nvcc path


[ROCm/clr commit: 9c2fcff9ce]
2020-01-10 13:47:18 +05:30
Maneesh Gupta d814f1e292 Revert PRs that break ROCm builds (#1781)
Fixes SWDEV-218626 and SWDEV-218629

Changes:
- Revert "`static inline` in a header, just like excess sugar in a diet, causes bloat (#1692)"
   This reverts commit 47725baf8c.
- Revert "Fix rocFFT build failure (#1777)"
   This reverts commit f7bac3e057.

[ROCm/clr commit: c091635f5a]
2020-01-08 15:11:58 +05:30
ansurya f7bac3e057 Fix rocFFT build failure (#1777)
Fixes SWDEV-217761

[ROCm/clr commit: cbd8f604ec]
2020-01-07 08:12:37 +05:30
Rahul Garg 1e78733f53 Add hipBindTexture2D on NVCC path (#1773)
[ROCm/clr commit: 534376cb41]
2020-01-06 12:33:50 +05:30
Rahul Garg 32139b7465 Fix hipcc warning related to hipVersion (#1767)
* Fix hipcc warning related to hipVersion
* Rename hipVersion.h to hip_version.h
* Remove HIP_VERSION splitting
* Update .gitignore
- Ignore generated include/hip/hip_version.h
- Removed some stale entries
- Added executables from samples/1_Utils/*/ for consistency with bin/ entries.

[ROCm/clr commit: 3fe1695c3a]
2020-01-06 12:33:23 +05:30
Evgeny Mankov 8c58286a9b Merge pull request #1759 from emankov/master
[HIP] Unify hipError_t (Step 2)

[ROCm/clr commit: ed43699a3a]
2019-12-30 19:21:09 +03:00
Sarbojit2019 4d2ee146e1 Change to generate hipVersion.h (#1726)
HIP_VERSION_MAJOR, HIP_VERSION_MINOR, HIP_VERSION_PATCH and HIP_VERSION pre-processor macros are now defined in hipVersion.h instead of being set by hipcc.

[ROCm/clr commit: 4fd77f8336]
2019-12-30 12:44:24 +05:30
Aryan Salmanpour ed2609b880 [hip] refactoring cooperative kernel launch APIs (#1737)
This PR is a follow-up on PR# #1698 and it makes two more APIs (hipLaunchCooperativeKernel/hipLaunchCooperativeKernelMultiDevice) inline so that they can work correctly with lazy binding.

[ROCm/clr commit: 857052be1e]
2019-12-30 12:42:17 +05:30
Evgeny Mankov d191980c6a [HIP] Clean-up deprecated HIP error codes
hipErrorMemoryAllocation -> hipErrorOutOfMemory
hipErrorInitializationError -> hipErrorNotInitialized
hipErrorMapBufferObjectFailed -> hipErrorMapFailed
hipErrorInvalidResourceHandle -> hipErrorInvalidHandle


[ROCm/clr commit: 4aaa2336a8]
2019-12-23 17:01:35 +03:00
Yaxun (Sam) Liu 1224fa6da5 Add macro __HIP_ENABLE_CUDA_WRAPPER_FOR_OPENMP__ (#1761)
This is to allow force enable cuda wrapper for OpenMP for flexibility

[ROCm/clr commit: 35988729f3]
2019-12-23 19:24:54 +05:30
saleelk 60437b9d64 Fix the return type of demangle function so that its compatible across ABIs (#1744)
[ROCm/clr commit: 1ca75e5f6d]
2019-12-23 19:11:40 +05:30
Alex Voicu 1f762e3970 Fix late-coming issues. (#1724)
Implementation for hipMemcpyWithStream.


[ROCm/clr commit: 150e690a3a]
2019-12-23 19:11:24 +05:30
Maneesh Gupta 36b23663e0 replace array designator C99 (#1694)
* replace array designator C99

* Update texture_functions.h

Highlight valid and invalid values in texFormatToSize

Co-authored-by: Maneesh Gupta <maneesh.gupta@amd.com>


[ROCm/clr commit: 32625638da]
2019-12-23 19:10:24 +05:30
Alex Voicu 47725baf8c static inline in a header, just like excess sugar in a diet, causes bloat (#1692)
[ROCm/clr commit: cf526f5484]
2019-12-23 19:09:38 +05:30
Evgeny Mankov 07db042750 [HIP] Fix typo
[ROCm/clr commit: 4d29423705]
2019-12-23 12:06:44 +03:00
Evgeny Mankov e25a6a39a3 [HIP] Unify hipError_t (Step 2)
Step 2. Make a few hipError codes deprecated
Update hipify-clang, hipify-perl, docs and samples accordingly


[ROCm/clr commit: 9ae76609a1]
2019-12-22 02:05:31 +03:00
Maneesh Gupta 35e4141eab Update texture_functions.h
Highlight valid and invalid values in texFormatToSize

[ROCm/clr commit: 6c7ce07577]
2019-12-21 12:25:36 +05:30
Sarbojit2019 2916c02f7b Fix for windows dtest build failure (#1742)
[ROCm/clr commit: 911d406bf1]
2019-12-19 13:10:43 -08:00
mhbliao 313ab97c35 [hip] Add macro guarding the enum conversion for scalar accessor. (#1748)
- That's a high overhead part, which needs enabling ONLY if necessary.

[ROCm/clr commit: a0a50ac601]
2019-12-19 10:08:37 -08:00
Evgeny Mankov 6c0241f539 [HIP] Unify hipError_t (Step 1)
Step 1. Set the same values for RT error codes as for analogous Driver's

[Reason] RT's and Driver's error codes unification in CUDA 10.2


[ROCm/clr commit: 21b0f64f3a]
2019-12-13 19:40:16 +03:00
mhbliao b967f1210d Only add hipExtLaunchMultiKernelMultiDevice for non-HCC compilers. (#1729)
[ROCm/clr commit: 539370d308]
2019-12-10 10:32:25 -08:00
jglaser 2984be48d2 fix linking of vector types with gcc (#1690)
* fix linking of vector types when linking hipcc objects with gcc

* use __atribute__((vector_size)) with both clang and gcc

and reinstate nonaligned n=3 vector type

* use implicit conversion to value and ext_vector_type when available

* Alternate formulation for GCC compatibility

* Built-in arrays don't mix well with placement new

* Fix typo

* Add conversions to enum

* Fix Scalar_accessor assignment.

* Update hip_vector_types.h

* stir up the underlying_type hideous mess

This fixes the HIP build issue "error: only enumeration types have underlying types".


[ROCm/clr commit: 280a8ebadf]
2019-12-10 09:40:15 +05:30
mhbliao 6643c80e8e Fix hipExtLaunchMultiKernelMultiDevice refactoring. (#1714)
- Use the correct condition for HIP VDI runtime.

[ROCm/clr commit: 209f31525f]
2019-12-06 09:49:17 -08:00
Rahul Garg 48faf7423a Revert - Changes related to hipMemcpyWithStream (#1718)
Reverting #1673, #1697 and #1707.
Support for hipMemcpyWithStream and memcpy optimizations, will be brought in again once issues seen with these are resolved independently.

[ROCm/clr commit: a369bd4418]
2019-12-06 09:51:53 +05:30
Aryan Salmanpour 2471c1950c [hip] refactoring hipExtLaunchMultiKernelMultiDevice API (#1698)
[Background] it was found that if lazy linking used for a library that calls hipExtLaunchMultiKernelMultiDevice API then this API can get the wrong program_state object for looking up device kernels leading to a "No device code available" error in this API.

To fix this issue, the API was refactored to be inline and get and pass the correct program_state to an internal hip API to request a multi-device kernel launch.

[ROCm/clr commit: 8eaea4d114]
2019-12-04 11:50:51 +05:30
Maneesh Gupta 97850ae9a8 Revert changes for atomic FADD support when address is in LDS (#1701)
This reverts PR #1591 and follow-on PR #1695

[ROCm/clr commit: 4c92bd50c4]
2019-11-29 11:58:12 +05:30
Alex Voicu b26aa2378e Uniform is_shared query. (#1695)
[ROCm/clr commit: 17a4780dc6]
2019-11-28 13:39:05 +05:30
Anusha Godavarthy Surya aec13e0fb3 replace array designator C99
[ROCm/clr commit: bc79c5636b]
2019-11-25 16:51:49 +05:30
Alex Voicu 82b55e6502 Unary operators were too restrictive in the type of their argument. (#1683)
[ROCm/clr commit: 306d50291e]
2019-11-22 07:54:53 +05:30
ansurya 0ece8d0f9b Fix rocBLAS compilation failure (#1677)
SWDEV-212749:
o Recent changes to “add support for extended launch” require hip_runtime.h to be include in hip_ext.h
o Order in which external applications include hip_hcc.h/hip_runtime.h causes compilation failure

[ROCm/clr commit: e5fc5aa41c]
2019-11-22 07:54:17 +05:30
Alex Voicu e1dca187c9 Use native support for atomic FADD when address is in LDS (#1591)
[ROCm/clr commit: 2ed3a0873c]
2019-11-22 07:53:48 +05:30
satyanveshd e2a0a547ff fixed directed tests fail when hcc bumped to 3.0 (#1678)
Handled the HCC version check appropriately as few of the directed tests (SWDEV-212161) were failing when hcc was bumped to 3.0.

[ROCm/clr commit: d4dde7a27d]
2019-11-20 21:37:52 +05:30
Alex Voicu 553a7c2ce3 General sync memcpy improvements. Add hipMemcpyWithStream (#1673)
* General sync memcpy improvements. Add `hipMemcpyWithStream`

* Update hip_memory.cpp


[ROCm/clr commit: 022ac3cb0a]
2019-11-20 21:36:37 +05:30
Rahul Garg 81dd3751a6 Update error codes for hipGetDevice for doxygen and move up null check (#1668)
* [docs] Update error codes for hipGetDevice

* Move up out ptr check


[ROCm/clr commit: 13c2a31d7e]
2019-11-20 21:35:27 +05:30
Paul Fultz II 29bb65f6e0 Fix helper header when using c++17 (#1666)
This will fix issue #1621. It also adds tests for is_callable with c++11, c++14, and c++17.

The fallback implementation was completely broken so I rewrote it so it pass the tests as well. This should be used instead of PR #1631.

[ROCm/clr commit: 57b1b03261]
2019-11-20 21:33:42 +05:30
Alex Voicu 5c27a4f570 Extend vector type capabilities and add tests to reflect it. (#1656)
[ROCm/clr commit: c383f20691]
2019-11-20 21:32:32 +05:30
mhbliao e9f9ecd519 Fix mathlib and app builds with hip-clang. (#1665)
[ROCm/clr commit: a45de95113]
2019-11-18 08:18:20 -08:00
Rahul Garg f524f75b69 Fix gcc build on NVCC path (#1661)
* Fix gcc build on NVCC path

* Fix CI build errors

* [dtest] Fix texture and surface obj2D tests


[ROCm/clr commit: ff31f734fe]
2019-11-18 12:19:22 +05:30
Nick Curtis 5875d98e6f fix complex conjugate for double-complex (#1659)
The sign in the y component returned from hipConj incorrect for double-complex. Fix to match as in hipConjf above.

[ROCm/clr commit: cae9b13020]
2019-11-18 12:19:12 +05:30
Sarbojit2019 7d5bc56ab7 Added null check in hipEventSynchronize (#1627)
* Added missing null check in hipEventSynchronize
* Minor correction in the Event API description


[ROCm/clr commit: 7985ad218f]
2019-11-18 12:18:55 +05:30
Alex Voicu f48b38b0ed Add support for extended launch syntax. (#1530)
* Add support for extended launch syntax.

* Add unit test.

* Fix typo

* hipExtLaunchKernelGGL lives in hip_ext.h

Change-Id: Ice32dab0d43475fda65c6a910c11416871a8f2ff

* [dtest] remove redundant include from hipModuleGetGlobal dtest


[ROCm/clr commit: 355d0bdf95]
2019-11-16 22:24:07 -08:00
Michael LIAO a10e227b56 Remove redundant declarations.
- The revised `hip/hip_ext.h` have that declarations.


[ROCm/clr commit: d28ad401c9]
2019-11-07 10:11:22 -05:00
Alex Voicu 44d2a3bb73 Remove native vector support from the GCC case, since it never worked (#1637)
[ROCm/clr commit: d38cc8efba]
2019-11-07 13:19:14 +05:30
ansurya f5a92e5cb6 Fixed texture 2D mapping for pitched arrays & 3D Texture read (#1415)
Texture 2D image mapping for pitched arrays:
github issue: Texture Object's Buffer seems to be Misaligned #886
JIRA ticket: SWDEV-199313

SWDEV-151670 : Fixed issue with 3D texture with 4 components
SWDEV-151671 : Issue with 2D layered texture with 4 components

[ROCm/clr commit: dc8f556460]
2019-11-07 13:17:46 +05:30
Rahul Garg cf648f7dbe Rename hip/hip_hcc.h to hip/hip_ext.h (#1341)
* Rename hip/hip_hcc.h to hip/hip_ext.h

* Deprecate hip_hcc.h


[ROCm/clr commit: dfee3ae279]
2019-11-07 13:17:10 +05:30
Alex Voicu 7efa901dfa Remove leftover noise.
[ROCm/clr commit: 1df423165b]
2019-11-06 02:46:21 +02:00
Alex Voicu 3ce73d1ef6 __half2 should walk like CUDA and talk like CUDA
[ROCm/clr commit: 55fd1363e2]
2019-11-06 02:43:04 +02:00
Michael LIAO a1b2dcf87d Use portable macro for deprecation message.
[ROCm/clr commit: 7ca43b98d1]
2019-11-05 11:51:00 -05:00