538f18f06c
Merge "HPC : Intermittent hangs are observed while running Gromacs benchmarks" into amd-master-next
2020-05-12 11:21:47 -04:00
54d264c418
Merge "SWDEV-227602 - Fixing hipFuncGetAttribute parameters" into amd-master-next
2020-05-12 10:52:25 -04:00
024764c337
Use find_package to find ROCclr
...
Maintain compatability with the old finding for now for the
convenience of commit order.
Change-Id: I99b236cbb3d61b00650e3da7fe5931d4c4b3fec6
2020-05-12 09:28:19 -04:00
78e27488be
SWDEV-227602 - Fixing hipFuncGetAttribute parameters
...
Change-Id: I46bd079372f453cabfaa2c709e2b30c69400dd33
2020-05-12 09:15:43 -04:00
ab285297e9
Use project relative include dir for generated header paths
...
Change-Id: I8c0834d68e6dac00b41a7059a978cbd2ebb933f9
2020-05-11 21:57:25 -04:00
e48fb337e3
Merge "updating hipDeviceProps_t-< arch flags according to SWDEV-234277" into amd-master-next
2020-05-11 21:28:43 -04:00
6b361bc1a0
HPC : Intermittent hangs are observed while running Gromacs benchmarks
...
SWDEV-235579
Move the lock before destroying the queue as there's a multithreaded race condition if the queue
is being destroy and right after we set queue_ to nullptr, another thread can call ihipWaitStreams
which will then call create on that same stream because queue is now nullptr.
Moving the lock on streamSet prevents this from happening because we would remove the stream from that
list and therefore ihipWait will not try to call asHostQueue which tries to create the queue if not created yet
since the stream won't be in the list anymore
Change-Id: I3108657ab403d39d4123e83294fcf1f0880e5563
2020-05-11 16:35:13 -07:00
33fcc105ea
Merge "Fix runtime failure on windows" into amd-master-next
2020-05-11 18:58:17 -04:00
64f8ff5e70
Fix runtime failure on windows
...
Signed-off-by: Icarus Sparry <icarus.sparry@amd.com >
Change-Id: I6c991a943e04ef29eff2905becbed0038c3b8ab9
Signed-off-by: Icarus Sparry <icarus.sparry@amd.com >
2020-05-11 17:30:47 -04:00
a477612a22
updating hipDeviceProps_t-< arch flags according to SWDEV-234277
...
Change-Id: I6238edf9a2df15a5dfe420dbb8723e10a0725f98
2020-05-11 16:43:13 -04:00
16dbce3776
Start cleaning up rocclr include paths
...
Use target_include_directories instead of global includes.
Change-Id: I3adadc905843f152a548c71b2f12701476065207
2020-05-11 15:24:19 -04:00
d2dd307c7d
Remove some asm declarations for intrinsics
...
This technique should never be used, and only accessed through
__builtins.
There's currently no builtin for groupstaticsize. I left ds_swizzle
since for some reason it switches to the builtin based on __HCC__ or
not.
Change-Id: If1e1394221dba83ea4add6db5e94d6b715552044
2020-05-11 15:20:58 -04:00
fbc03e94c1
Merge "[hip] Fix -Wduplicate-decl-specifier warning. NFC." into amd-master-next
2020-05-11 15:18:57 -04:00
0936d9d64d
Merge "Correct quoting of arguments" into amd-master-next
2020-05-11 11:39:47 -04:00
a2dbcc075c
[hip] Fix -Wduplicate-decl-specifier warning. NFC.
...
Change-Id: Iae48bbb7805c39f1005c920df8e76504426f2d3b
2020-05-11 10:12:33 -04:00
a4f01ffca6
Correct quoting of arguments
...
The hipcc script takes arguments and uses this to build up a new
command. Characters which are special to the shell need to be quoted
to prevent them being interpreted.
In particular adding
--Wl,--enable-new-dtags -Wl,--rpath,'$ORIGIN:$ORIGIN/../lib'
to the command should pass quoted dollar signs into the resulting
string so the shell passes them on, rather than substituting the
values.
The arguments are processed in a conventional loop, but can be altered
during the course of the loop, and also by linker response files.
Tested by running
HIPCC_VERBOSE=7 HIP_COMPILER=clang hipcc --cxxflags \
fred.c -Wl,,--rpath,'$ORIGIN:$ORIGIN:/../lib'
and observing "-Wl,--rpath,\$ORIGIN\:\$ORIGIN\:..\/lib" in the
displayed hipcc-cmd output (and ignoring the errors due to rocm not
being installed)
Change-Id: I26b62f09ff3518cceeb85fa8823bb12a95c1c78e
Signed-off-by: Icarus Sparry <icarus.sparry@amd.com >
2020-05-10 18:16:48 -04:00
fec51e85b0
Correct HIP_FUNC_ATTRIBUTE_NUM_REGS query
...
Change-Id: I526cc7871c690260df0fa8c1b3b4b15fbc5af219
2020-05-09 12:42:30 -04:00
507f6bb0c3
Merge "Don't add a null command to waitList in hipMemcpy" into amd-master-next
2020-05-08 17:01:38 -04:00
3ca2d1e6a9
Don't add a null command to waitList in hipMemcpy
...
SWDEV-235345
Change-Id: Ib1abd0ba6414d081891a9f5209df083c45734aee
2020-05-08 12:43:41 -07:00
1b1c032e9f
Correct HIP_FUNC_ATTRIBUTE_MAX_THREADS_PER_BLOCK query
...
We should be returning the max workgroup size calculated by the compiler.
Change-Id: If86590efbb9b291f470bdbe87e5df992e661c539
2020-05-08 14:36:47 -04:00
a373538d72
Fix confusion in hipFuncGetAttribute()
...
Cuda shared == OpenCL local
Cuda local == OpenCL private
Change-Id: I5a204945ecde35919b9e9def20bbb2662fffea2b
2020-05-08 14:36:36 -04:00
6262ce482f
Don't add llvm includes to rocclr build
...
There are no llvm includes here.
Change-Id: I0567c6e47e717580819f3854782ba08501bd069d
2020-05-08 12:24:49 -04:00
39e9205044
Merge "SWDEV-233950:link to /opt/rocm/hip/lib/cmake left behind during uninstall" into amd-master-next
2020-05-08 12:12:06 -04:00
a9bc94129b
SWDEV-234447:Fix error Use of uninitialized value in concatenation (.)
...
Change-Id: Ia6f8d23f100826438f152c175d10ac3096ee024e
2020-05-08 12:07:24 -04:00
73bc14ec49
Don't write generated version.h to source directory
...
Change-Id: Ib4e7c3171cd227725ae35fed66167df528a4c431
2020-05-08 10:59:28 -04:00
5fbae827c2
SWDEV-234954 - Fix hipconfig on Windows
...
Before setting the HIP_RUNTIME and HIP_COMPILER variables, first check the environment if these are set. We should prioritize the environment settings. For windows, it will be set, and also explicitly call perl when invoking hipconfig.
Change-Id: I89ad267285239e6d8a897dc681c4af5906e7b9d8
2020-05-08 13:27:36 +00:00
7a32fc43a6
SWDEV-233950:link to /opt/rocm/hip/lib/cmake left behind during uninstall
...
Change-Id: Ideb76b73916881469e39b7a0a4d68d7ec098b4a8
Signed-off-by: agodavar <Anusha.GodavarthySurya@amd.com >
2020-05-08 07:36:28 -04:00
3612851809
Enabling hipGetDeviceFlags required in [SWDEV-229170]
...
Change-Id: I998d37e5847f9651345554bada86df6fce86d1eb
2020-05-08 01:37:23 -04:00
af4692f838
Fix generated hip_prof_str.h install again
...
Change-Id: I92ea4bedbcdc92974998c00ca7f0c00098791cb5
2020-05-07 12:40:39 -04:00
73e759eab0
Merge "Fix missed VDI names in hip-on-rocclr" into amd-master-next
2020-05-07 12:30:51 -04:00
0231de3164
Fix hip-config.cmake build error in rocBLAS
...
Change-Id: I097f0dac0f67bfc22e9991350bf63bc7bfa8b269
2020-05-07 12:24:20 -04:00
1c1be71b63
Fix missed VDI names in hip-on-rocclr
...
Change-Id: I830feb37a043656136648e92a0c6f1eaae8402d7
2020-05-07 08:37:28 -04:00
861d07fbd3
Merge "Support performance tests" into amd-master-next
2020-05-07 07:15:09 -04:00
789cc01b58
Merge "Remove HIP_MARKER left overs due to HIP PR 2032" into amd-master-next
2020-05-07 01:36:57 -04:00
137440ac72
Merge "SWDEV-233749 Added support for parallel build and link" into amd-master-next
2020-05-07 00:29:24 -04:00
819677825f
Remove HIP_MARKER left overs due to HIP PR 2032
...
Change-Id: Ieae68dd3b12c92b1d6830619ca4c6ae43c400225
2020-05-06 20:26:18 -04:00
78df96024d
Merge "SWDEV-232464 - Need to initialize image with ptr passed since they can pass image not of type __ClangOffloadBundler." into amd-master-next
2020-05-06 16:42:50 -04:00
076c2ffadf
Merge "Skip iHipWaitActiveStreams if stream is NonBlocking" into amd-master-next
2020-05-06 16:32:51 -04:00
56691fe7e6
SWDEV-233749 Added support for parallel build and link
...
Change-Id: Id227ea1fe7574612c33a8e6d91fc59a29490a35f
2020-05-06 14:54:39 -04:00
5e91bee221
SWDEV-232464 - Need to initialize image with ptr passed since they can pass image not of type __ClangOffloadBundler.
...
Change-Id: I2c50042220a0230bc445ed21728f114a229c53e1
2020-05-06 14:25:43 -04:00
6e972dd3bb
Support performance tests
...
Support performance tests while direct tests commands keep unchanged.
To build performance tests, run "make build_perf".
To run all performance testis, run "make perf".
To run specific tests, for example, run
/usr/bin/ctest -C performance -R performance_tests/perfDispatch --verbose
To run individual test, for example, run
performance_tests/memory/hipPerfMemMallocCpyFree
Change-Id: I168c1b9ef1ec21b392d48648d0c71e8fbd37d57b
2020-05-06 14:06:07 -04:00
f0b49d0560
Skip iHipWaitActiveStreams if stream is NonBlocking
...
SWDEV-234484
Change-Id: I279bdc8485d8218e0aaa89d094c08a84f002a608
2020-05-06 10:36:53 -07:00
bb6922b8a3
Don't use relative include path
...
The header base path is already in the include set.
Change-Id: Id83abaa921d720ae103e3281161b875fcf84493d
2020-05-06 11:59:39 -04:00
6f86a74018
rocclr/CMakeLists.txt: Fixing unresolved merge conflict
...
Change-Id: I09b9a955b0f1ece8d278112a22bc8aef31b57258
Signed-off-by: Aakash Sudhanwa <Aakash.Sudhanwa@amd.com >
2020-05-06 07:24:25 -07:00
c5f76c3de3
name change vdi to rocclr
...
Change-Id: I06d198bbb4a499e153b290b73a92afed3553b252
2020-05-06 09:14:30 -04:00
b1e13d8af2
Merge "SWDEV-229840 - Fixing compilation error with right var name." into amd-master-next
2020-05-05 18:17:22 -04:00
3659399d68
Merge "Fix hipcc for -E" into amd-master-next
2020-05-05 18:00:49 -04:00
18b19e0324
SWDEV-229840 - Fixing compilation error with right var name.
...
Change-Id: I9f5278638271c384874004eb17085d29ca14ec3a
2020-05-05 14:59:24 -04:00
8f53157057
SWDEV-209747 - Add compiletime variable DEV_LOG_ENABLE
...
Change-Id: Ie8ff8abafa6b5e0f83209da42778688a047562c3
2020-05-05 14:48:55 -04:00
09bcd2e378
Fix hipcc for -E
...
-E is for preprocessing only, which should be compile only.
This is required by enabling sccache.
Change-Id: Ia0a0acb6a04abd03a9cb5b3c13cf7446837f37b4
2020-05-05 14:30:25 -04:00
Christophe Paquot
Karthik Jayaprakash
Matt Arsenault
Payam Ghafari
Icarus Sparry
Michael Hong Bin Liao
Vlad Sytchenko
Anusha Godavarthy Surya
Aaron Enye Shi
Sarbojit Sarkar
Aaron En Ye Shi
Tao Sang
Rahul Garg
Aakash Sudhanwa
Yaxun Liu