Commit Graph

4097 Commits

Author SHA1 Message Date
Laurent Morichetti 540a8d6337 Merge branch 'origin/pghafari/hip-vdi' into lmoriche/amd-master-next
Change-Id: I22c145d39f430ca571a981687bcb034ea6e3b8a2


[ROCm/clr commit: 2f1305b9a4]
2020-01-31 07:33:12 -08:00
Laurent Morichetti bb38362f74 Merge HIP/VDI branch 'amd-staging' into lmoriche/amd-master-next
Change-Id: Iabaab4e72815ba483a1330ec6a1130f2b86676f0


[ROCm/clr commit: 6f3e18a764]
2020-01-29 15:02:13 -08:00
foreman 0b193b5b68 P4 to Git Change 2062258 by cpaquot@cpaquot-ocl-lc-lnx on 2020/01/23 16:04:59
SWDEV-145570 - [hip] hipMallocManaged
	Basic implementation of hipMallocManaged behaving like hipHostMalloc for hipMemAttachGlobal.
	Return hipErrorInvalidValue for the hipMemAttachHost for now.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#39 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#37 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#97 edit


[ROCm/clr commit: 1fe8cc8a7e]
2020-01-23 16:13:57 -05:00
foreman 8ec1ee47fa P4 to Git Change 2061101 by skudchad@skudchad_test2_win_opencl on 2020/01/21 16:47:25
SWDEV-219917 - [VDI Cleanup] Remove some direct OpenCL references, introduce a common functionality.

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/18488/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/build/Makefile.hip#30 edit
... //depot/stg/opencl/drivers/opencl/api/hip/fixme.cpp#3 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#51 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hiprtc_internal.hpp#3 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/build/Makefile.api#190 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_common.hpp#25 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_context.cpp#61 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_device.cpp#75 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_execute.cpp#31 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_icd.cpp#36 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_platform_amd.cpp#3 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_program.cpp#54 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#610 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#180 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.cpp#150 edit
... //depot/stg/opencl/drivers/opencl/runtime/include/vdi_agent_amd.h#1 add
... //depot/stg/opencl/drivers/opencl/runtime/include/vdi_common.hpp#1 add
... //depot/stg/opencl/drivers/opencl/runtime/os/os.hpp#32 edit
... //depot/stg/opencl/drivers/opencl/runtime/os/os_posix.cpp#49 edit
... //depot/stg/opencl/drivers/opencl/runtime/os/os_win32.cpp#50 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/agent.cpp#9 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/agent.hpp#7 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/context.cpp#54 edit
... //depot/stg/opencl/drivers/opencl/runtime/runtimedefs#54 edit


[ROCm/clr commit: 0096cc552b]
2020-01-21 16:52:40 -05:00
paulfreddy c9c4645328 Changes for multiple ROCm installation (#1771)
* FBA-29, FBA-69, multiple rocm support, shared library conflicts
Changes to resolve:
1) Multiple rocm release installation support
2) Multiple rocm shared lib conflicts
3) Add the so versioning also

[ROCm/clr commit: c5ed5c71a3]
2020-01-21 14:17:35 +05:30
foreman 74115ddd67 P4 to Git Change 2060446 by vsytchen@vsytchen-ocl-win10-2 on 2020/01/20 18:58:37
SWDEV-215533 - [HIP][Windows]Output mismatch with tex3D()

	When calculating the pitch for hipMallocPitch() align it to the device's image pitch alignment. If we don't, PAL backend will overalign the pitch when creating an image buffer.

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/18496/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#96 edit


[ROCm/clr commit: 37bb58b556]
2020-01-20 19:05:16 -05:00
Evgeny Mankov 99e2be1355 Merge pull request #1795 from aakanksha555/master
[HIPIFY][cmake] Packaging for hipify-clang

[ROCm/clr commit: 30baf8fdf4]
2020-01-20 19:10:20 +03:00
ansurya 7f788181ec Fix texture tests, always pass row pitch to HSA API for linear layout images (#1785)
=> New ROCr calculates pitch as per HSA specification and addrlib is used to check whether HW can support that configuration. Hence few texture tests are failing with HSA_EXT_STATUS_ERROR_IMAGE_PITCH_UNSUPPORTED.

=> Determine pitch for linear images and always pass rowpitch to HSA API's.

[ROCm/clr commit: 688b6e6af0]
2020-01-16 08:54:30 +05:30
kpyzhov 2d617bba3b Don't use accelerated vector element access for hip-clang. (#1796)
[ROCm/clr commit: 1d6a2fb064]
2020-01-15 18:17:08 -08:00
foreman a2ce848fab P4 to Git Change 2057410 by skudchad@skudchad_rocm on 2020/01/15 18:24:33
SWDEV-219341 - Free memory correctly. hiprtcProgram is a pointer by itself. So release *prog

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#10 edit


[ROCm/clr commit: 37c900f2a1]
2020-01-15 18:32:44 -05:00
Aakanksha Patil efc95906b5 [HIPIFY][cmake] Packaging for hipify-clang
[ROCm/clr commit: 545ad0dad3]
2020-01-15 11:39:02 -05:00
kpyzhov 8bf4210095 Add missing constructors for Scalar_accessor class. (#1792)
[ROCm/clr commit: 0918614615]
2020-01-14 11:30:21 -08:00
Evgeny Mankov d7647096f6 [HIPIFY][fix] Add "--" separator in-place if needed
[ROCm/clr commit: df563c966c]
2020-01-13 18:49:28 +03:00
Evgeny Mankov 271c1447e2 [HIPIFY] Sync with hipSPARSE
+ Update hipify-perl and doc accordingly


[ROCm/clr commit: 41beed4839]
2020-01-13 18:34:10 +03:00
foreman f3edec3ec2 P4 to Git Change 2055228 by jujiang@JJ-HIP on 2020/01/10 16:36:01
SWDEV-205925 - Update HIP texture APIs for issue in hipTexRefSetAddress in HIP/PAL on Windows
	-Update HIP texture function parameter to use hipChannelFormatDesc& desc

	http://ocltc.amd.com/reviews/r/18456/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#33 edit


[ROCm/clr commit: ec3fbfd60c]
2020-01-10 16:43:46 -05:00
Jatin Chaudhary 8550b344a2 Remove filesystem dependency in hipRTC (#1749)
Removing dependency on filesystem, so libstdc++fs is no longer required to link

[ROCm/clr commit: 0b211478dd]
2020-01-10 13:47:54 +05:30
Evgeny Mankov d1d680a1d6 [HIP] Unify hipError_t (Step 3): Sync nvcc path (#1778)
* [HIP] Unify hipError_t (Step 3): Sync nvcc path

* [HIP][fix] Add CUDA 10.x support to nvcc path


[ROCm/clr commit: 9c2fcff9ce]
2020-01-10 13:47:18 +05:30
Yaxun (Sam) Liu 87887f6152 Fix test hip_bitextract.cpp (#1784)
The randomly generated offset+width may exceeds 32, which causes
a left shift operation with 32-offset-width. As an unsigned number
that is greater than 32 and causes undefined behavior. When the
test is compiled without -mavx it is still OK. However when
the test is compiled with -mavx, the undefined behavior causes
wrong results and test failure.

This patch adjusts width so that offset+width<=32 always.

[ROCm/clr commit: 55525fa466]
2020-01-10 13:46:57 +05:30
Maneesh Gupta d814f1e292 Revert PRs that break ROCm builds (#1781)
Fixes SWDEV-218626 and SWDEV-218629

Changes:
- Revert "`static inline` in a header, just like excess sugar in a diet, causes bloat (#1692)"
   This reverts commit 47725baf8c.
- Revert "Fix rocFFT build failure (#1777)"
   This reverts commit f7bac3e057.

[ROCm/clr commit: c091635f5a]
2020-01-08 15:11:58 +05:30
foreman cee3002702 P4 to Git Change 2053320 by vsytchen@vsytchen-hip-win10 on 2020/01/07 15:54:34
SWDEV-215533 - [HIP][Windows]Output mismatch with tex3D()

	1. Implement hipMemcpy3DAsync().
	2. Add logic in hipMemcpy3D() to determine based on src/dst parameters if the user intended on calling cudaMemcpy3D() or cuMemcpy3D().

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/18444/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#38 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#36 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#95 edit


[ROCm/clr commit: e5c5338146]
2020-01-07 15:59:02 -05:00
Siu Chi Chan 94ddf110dd Detect when an explicit printf buffer flush is required (#1766)
* Detect when an explicit printf buffer flush is required
in a device/stream synchronization function.

* hip_module.cpp: add missing hc_am.hpp header


[ROCm/clr commit: 26b50e1e1b]
2020-01-07 09:06:38 -08:00
Evgeny Mankov 3181aa0e65 [HIPIFY] main source file refactoring
[ROCm/clr commit: 8fbbaf3779]
2020-01-07 16:25:18 +03:00
ansurya f7bac3e057 Fix rocFFT build failure (#1777)
Fixes SWDEV-217761

[ROCm/clr commit: cbd8f604ec]
2020-01-07 08:12:37 +05:30
satyanveshd 72ce61218b hipMemcpy[To/From]Symbol(Async) fixes (#1774)
[ROCm/clr commit: 9b2f22f7aa]
2020-01-07 08:11:53 +05:30
Rick Ho d3e0b193ae Fix minor explainations in the kernel guide (#1775)
[ROCm/clr commit: ade47bd848]
2020-01-06 12:34:21 +05:30
Rahul Garg 1e78733f53 Add hipBindTexture2D on NVCC path (#1773)
[ROCm/clr commit: 534376cb41]
2020-01-06 12:33:50 +05:30
Rahul Garg 83b9cc743c Fix nested designator warnings (#1768)
[ROCm/clr commit: 178d432b90]
2020-01-06 12:33:34 +05:30
Rahul Garg 32139b7465 Fix hipcc warning related to hipVersion (#1767)
* Fix hipcc warning related to hipVersion
* Rename hipVersion.h to hip_version.h
* Remove HIP_VERSION splitting
* Update .gitignore
- Ignore generated include/hip/hip_version.h
- Removed some stale entries
- Added executables from samples/1_Utils/*/ for consistency with bin/ entries.

[ROCm/clr commit: 3fe1695c3a]
2020-01-06 12:33:23 +05:30
Yaxun (Sam) Liu 382e5716d3 Update HIP-Clang build instruction (#1764)
[ROCm/clr commit: c80c2bf234]
2020-01-06 12:32:47 +05:30
Yaxun (Sam) Liu 024c7d51ea Document FMA settings (#1717)
[ROCm/clr commit: 7dcd5f6329]
2020-01-06 12:32:38 +05:30
foreman 12927b7741 P4 to Git Change 2052191 by skudchad@skudchad_test2_win_opencl on 2020/01/03 15:54:23
SWDEV-213000 - Backout change to notifyCmdQueue as the real issue has been identified

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#53 edit


[ROCm/clr commit: a941903848]
2020-01-03 16:02:59 -05:00
foreman aa2c3a7b66 P4 to Git Change 2051060 by michliao@hliao-dev-00-hip.rocm-workspace on 2019/12/30 16:42:07
SWDEV-145570 - Clean up after `hipError_t` unification.

	- Replace deprecated `hipError_t` enums.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#24 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_error.cpp#4 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#19 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#94 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#52 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#27 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#32 edit
... //depot/stg/opencl/drivers/opencl/api/hip/trace_helper.h#5 edit


[ROCm/clr commit: 955b224ea0]
2019-12-30 16:46:39 -05:00
Evgeny Mankov 8c58286a9b Merge pull request #1759 from emankov/master
[HIP] Unify hipError_t (Step 2)

[ROCm/clr commit: ed43699a3a]
2019-12-30 19:21:09 +03:00
Sarbojit2019 4d2ee146e1 Change to generate hipVersion.h (#1726)
HIP_VERSION_MAJOR, HIP_VERSION_MINOR, HIP_VERSION_PATCH and HIP_VERSION pre-processor macros are now defined in hipVersion.h instead of being set by hipcc.

[ROCm/clr commit: 4fd77f8336]
2019-12-30 12:44:24 +05:30
Aryan Salmanpour ed2609b880 [hip] refactoring cooperative kernel launch APIs (#1737)
This PR is a follow-up on PR# #1698 and it makes two more APIs (hipLaunchCooperativeKernel/hipLaunchCooperativeKernelMultiDevice) inline so that they can work correctly with lazy binding.

[ROCm/clr commit: 857052be1e]
2019-12-30 12:42:17 +05:30
ansurya 56d51a3dc7 Fix texture 3D & 2D layered with N components (#1746)
SWDEV-151670: Issue with 3D texture with 4 components
SWDEV-151671: Issue with 2D layered texture with 4 components

Fixed memcpy when memory is allocated with driver API's.

Github issues: #1755
Fixed 3D default case when array type is not set during memory allocation.

[ROCm/clr commit: 651c7a8e27]
2019-12-30 12:41:42 +05:30
foreman deaa52db30 P4 to Git Change 2049729 by skudchad@skudchad_test2_win_opencl on 2019/12/23 12:36:57
SWDEV-203814 - Change the return type of the hiprtcGetTypeName to have compatibility across ABIs

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/18392/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#9 edit


[ROCm/clr commit: 4185d21347]
2019-12-23 12:42:24 -05:00
Evgeny Mankov f60903178d [HIPIFY][doc] LLVM 9.0.1 is the latest stable release now
+ Tested on Windows and Linux: no changes are needed


[ROCm/clr commit: 2d7e766cc7]
2019-12-23 20:00:33 +03:00
Evgeny Mankov d191980c6a [HIP] Clean-up deprecated HIP error codes
hipErrorMemoryAllocation -> hipErrorOutOfMemory
hipErrorInitializationError -> hipErrorNotInitialized
hipErrorMapBufferObjectFailed -> hipErrorMapFailed
hipErrorInvalidResourceHandle -> hipErrorInvalidHandle


[ROCm/clr commit: 4aaa2336a8]
2019-12-23 17:01:35 +03:00
Yaxun (Sam) Liu 1224fa6da5 Add macro __HIP_ENABLE_CUDA_WRAPPER_FOR_OPENMP__ (#1761)
This is to allow force enable cuda wrapper for OpenMP for flexibility

[ROCm/clr commit: 35988729f3]
2019-12-23 19:24:54 +05:30
saleelk 60437b9d64 Fix the return type of demangle function so that its compatible across ABIs (#1744)
[ROCm/clr commit: 1ca75e5f6d]
2019-12-23 19:11:40 +05:30
Alex Voicu 1f762e3970 Fix late-coming issues. (#1724)
Implementation for hipMemcpyWithStream.


[ROCm/clr commit: 150e690a3a]
2019-12-23 19:11:24 +05:30
Maneesh Gupta 36b23663e0 replace array designator C99 (#1694)
* replace array designator C99

* Update texture_functions.h

Highlight valid and invalid values in texFormatToSize

Co-authored-by: Maneesh Gupta <maneesh.gupta@amd.com>


[ROCm/clr commit: 32625638da]
2019-12-23 19:10:24 +05:30
Alex Voicu 47725baf8c static inline in a header, just like excess sugar in a diet, causes bloat (#1692)
[ROCm/clr commit: cf526f5484]
2019-12-23 19:09:38 +05:30
Evgeny Mankov 07db042750 [HIP] Fix typo
[ROCm/clr commit: 4d29423705]
2019-12-23 12:06:44 +03:00
Evgeny Mankov e25a6a39a3 [HIP] Unify hipError_t (Step 2)
Step 2. Make a few hipError codes deprecated
Update hipify-clang, hipify-perl, docs and samples accordingly


[ROCm/clr commit: 9ae76609a1]
2019-12-22 02:05:31 +03:00
Evgeny Mankov 4bb4b5e291 Merge pull request #1734 from vsytch/win10-hipMemcpy-fixes
Fix OOM issues with hipMemcpy test on Windows

[ROCm/clr commit: 3c6203c814]
2019-12-21 22:02:34 +03:00
Maneesh Gupta 35e4141eab Update texture_functions.h
Highlight valid and invalid values in texFormatToSize

[ROCm/clr commit: 6c7ce07577]
2019-12-21 12:25:36 +05:30
Maneesh Gupta 57b69adc8b bump version to 3.1 (#1756)
* Bump version to 3.1

* [ci] Enable tests on ROCm 3.0


[ROCm/clr commit: 86e590ad62]
2019-12-20 12:10:25 -08:00
foreman 113aa8bb48 P4 to Git Change 2049240 by lmoriche@lmoriche_opencl_dev2 on 2019/12/20 13:54:17
SWDEV-216705 - [hipclang-vdi-rocm][FBA-80]Test crash when all GPUs are hidden by ROCR_VISIBLE_DEVICES

	Return an error instead of dereferencing a null pointer. This should address the issue described
	in the ticket, but more places need fixing in the runtime to avoid crashes for corner cases.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#59 edit


[ROCm/clr commit: ba3da9b3ec]
2019-12-20 13:02:52 -06:00