Commit Graph

4732 Commits

Author SHA1 Message Date
kjayapra-amd 5593475c37 SWDEV-231701 - Remove amd::memory->svm_ptr from MemObj, instead of the ptr to the object.
Change-Id: I5aab450a2320cfa5417c284e2a8454102df6f99d


[ROCm/clr commit: 9ff22151d2]
2020-06-10 11:49:02 -04:00
Dittakavi Satyanvesh a0fbc8fd08 SWDEV-236670 Address Eigen unit test failure by adding __host__ attribute to half2 functions
Change-Id: Ifdc852c30a1b3704871e0ee58cb7a55d3d37fc6e


[ROCm/clr commit: bb785840b9]
2020-06-10 03:01:42 -04:00
Christophe Paquot 4206cfddc5 Do not deferred stream creation now that we multiplex HW queues
SWDEV-239856

Change-Id: I156650faf832f86891f00ee167269509edd844ec


[ROCm/clr commit: 20ae4d709f]
2020-06-09 19:16:25 -04:00
Yaxun (Sam) Liu 0d8425ee5a Fix include path and wrapper header
Currently std::complex and some other std functions require uses to
include hip_runtime.h before any other headers to work, which is not
reliable.

changes are made in clang to fix this issue:
https://reviews.llvm.org/D81176

which requires hipcc and HIP headers to make corresponding changes.

This patch will make sure the clang change will not break
HIP/ROCclr during this transition.

After the transition is done, we can remove explicitly setting
include path for HIP-Clang and HIP header in hipcc and hip config
cmake files and rely on clang driver to set it automatically.

Change-Id: I5d226861c2560ffa6c5ab17343a43cc378048061


[ROCm/clr commit: 0a513d8a02]
2020-06-09 17:37:20 -04:00
jujiang b815322dd6 To fix a format in hip_porting_guide.md
Change-Id: I5faa4ec9b3d17625b7cb5cea86b9f44766b1cfa9


[ROCm/clr commit: 06c6951205]
2020-06-09 13:14:52 -04:00
Rahul Garg 8e4c48bd25 Bump version to 3.6
Change-Id: I739a7bd03a4ed102bbc7c2f60d108e20132f5423


[ROCm/clr commit: 6aab5fa993]
2020-06-09 11:22:20 -04:00
Saleel Kudchadker 3f07846c7e Modify HIP_RETURN to print useful details
Change-Id: I23892c2d9a738b0298cdf24106d688a792937c73


[ROCm/clr commit: fbba37070c]
2020-06-06 02:05:21 -04:00
kjayapra-amd edcdf621b9 SWDEV-239327 - Remove amd_mem_obj during unregistervar
Change-Id: I2130eaa21369b9634a9459680061138c61eaaaa4


[ROCm/clr commit: ee2ff4bc5e]
2020-06-05 23:24:38 -04:00
kjayapra-amd db1b21b1fa SWDEV-235295 - Move addDeviceProgram() to lazy loading
Change-Id: I8fe07e370e58844496e18c858bb528393556854f


[ROCm/clr commit: 1dc24194a3]
2020-06-05 18:03:32 -04:00
Jason Tang 7735b228ec SWDEV-227909 - Add gcnArchName
Change-Id: Iea6d16b5d693dd0d900fa424d7a321c39315430e


[ROCm/clr commit: 14c699e9de]
2020-06-05 15:33:55 -04:00
kjayapra-amd 70e90419a9 SWDEV-234295 - Pass flag to ROCclr to not clear device programs during program::build()
Change-Id: I50b9fa1a96da6895f73fdf4a7c0d3f096b1188da


[ROCm/clr commit: 9261a35be9]
2020-06-05 09:53:11 -04:00
rohit pathania 16af0aebc0 [ dtest ] hipModuleLaunchKernel multiThreaded n multiGPU scenarios
1.Added hipModuleLaunchKernel multithreaded multi GPU scenario.
2.removed hipCtxCreate API from earlier test as it is deprecated.

SWDEV-238517 for enhancing hip unit tests

Change-Id: Id102d80887b6ff61a59938dbeb9fa2a26a3275b2


[ROCm/clr commit: 0920bac577]
2020-06-05 09:40:58 -04:00
Lakhan Singh Thakur bedadf571d [dtest] merge 'Adding the two test cases to cover scenarios observed in SWDEV-181598.'
SWDEV-238517 for enhancing hip unit tests

Change-Id: Ie61145b46c89b2e970af0ab11e22b6f6286ec90f


[ROCm/clr commit: 6f87616103]
2020-06-05 09:10:23 -04:00
Aryan Salmanpour 1c329fee60 Add support for setting hip stream priority
this change follows CUDA convention where lower number is greater priority

Change-Id: I72596a36449e818cbd8c175bf8519c51f46b1610


[ROCm/clr commit: 83b8e1fbac]
2020-06-04 22:50:30 -04:00
Payam 8bdf07bb9c Observed softhang while running hipStreamAddCallbackCatch SWDEV-236746
Workaround hipStream deadlock issue as the same lock was used twice SWDEV-236746

Change-Id: Icc60104ce6edf4cfd2a3a889bab78a6caadd50b7


[ROCm/clr commit: f3ee29cdb2]
2020-06-04 14:11:22 -04:00
Aaron En Ye Shi 4d51dbf4f1 Add gfx908 to hip-config.cmake
Support gfx908 as part of the default AMDGPU_TARGETS. MIGraphX requires this change.

Change-Id: I692f87f27829778e04f59c9ca655c6e8cbc00abc


[ROCm/clr commit: 29c7c9b1c2]
2020-06-04 11:00:09 -04:00
Siu Chi Chan 1f7c745330 add constexpr constructor for vector types
Change-Id: I45bb0537d6a24ee50b548c2fd8b4f20518764813


[ROCm/clr commit: 4b56aaefd6]
2020-06-04 01:57:03 -04:00
Evgeny ecdca97a00 adding hipGetStreamDeviceId() profiling API
Change-Id: I5ccf88ddac123260d7c17defefcf20ff3b2504e2


[ROCm/clr commit: 0c0a8fc108]
2020-06-03 18:57:49 -04:00
Aaron En Ye Shi b2f9e1c299 Add compiler-rt library for __fp16 and _Float16
Similar to HCC, link with compiler-rt to support __fp16 and _Float16 type conversions in ONNX models. This should resolve SWDEV-238491.

Change-Id: Iad8dcff568831719f501f562a04023326ae8036c


[ROCm/clr commit: d93134e727]
2020-06-03 18:53:14 +00:00
Siu Chi Chan 85d781ba65 update device library path
fix device lib directory

add missing --hip-link switch for link phase

Change-Id: I4b2eeb32648ca3cec72ec1f4e3381ce1fc0a90a5


[ROCm/clr commit: c414c70e8f]
2020-06-03 14:44:23 -04:00
Jatin 216873e9c8 Adding changes for hipExtLaunchKernel for rocCLR
Change-Id: Iba52bc3bde7c37f3fb375a55ba0947e87b3cdc9b


[ROCm/clr commit: 126573df4c]
2020-06-02 14:16:41 -04:00
Rahul Garg 247e111c91 Use right perl-which rpm package
Change-Id: I22106a7d1b4b50c99f945bc6416ff3bd8486d15c


[ROCm/clr commit: db471e5ed9]
2020-06-02 02:17:54 -04:00
Aaron En Ye Shi d2bcb05dfb HIP-Clang Temporarily include HIP_HCC_FLAGS for PyT
Change-Id: I0f5895fba69f5bf0c6cc13e9402bdc44726dcc5a


[ROCm/clr commit: a436ab865a]
2020-06-01 15:28:04 -04:00
Aryan Salmanpour e4052cd66b Add support for missig hipStreamGetPriority API
Change-Id: I2be4b055e5f977eb6ecad0b1f5f9535e72345fe7


[ROCm/clr commit: bf11ffd175]
2020-06-01 13:33:14 -04:00
agodavar a3feb53a30 hipMemset dont enqueue command if size bytes is 0
Change-Id: I63bf896f9f23edf254acdf7a8c11c92f8b5ac039


[ROCm/clr commit: 3375920638]
2020-05-30 10:33:44 -04:00
Rahul Garg 3e397c620a Add libfile-which-perl dependency SWDEV-237642
Change-Id: I0799fdcbc58a35c957a3bc69a8a1c6a013a3f57c


[ROCm/clr commit: 27e306686c]
2020-05-29 20:04:23 -04:00
kjayapra-amd 776af02dfe SWDEV-229840 - fixing return HIP_RETURN instances in hip.
Change-Id: I48763d7268bf5649bf2242c962c185f5f4af159c


[ROCm/clr commit: ab17b43d45]
2020-05-29 09:43:58 -04:00
Aryan Salmanpour 5aec64346f [dtest] add a multi stream test for (SWDEV-237846)
Change-Id: I4a1d764df75af7019d0f38313e5e0a6a224818f8


[ROCm/clr commit: 200ab30084]
2020-05-28 23:36:10 -04:00
jujiang 4fad481033 Update document for hip_faq.md, hip_porting_guide.md and hip_terms2.md
Change-Id: I2c019f802ad70ed43f1608cfd3c9067f1573741e


[ROCm/clr commit: 017e3b87b3]
2020-05-28 17:51:58 -04:00
Christophe Paquot c5e4607065 Revert "Call notifyCmdQueue when building the event wait list"
This reverts commit df67d8971a.

Reason for revert: better fix in ROCclr

Change-Id: I9707e69adf42a662c08fe9b3ec7458655d838bdd


[ROCm/clr commit: dfec136725]
2020-05-28 17:01:10 -04:00
kjayapra-amd b91ab37e8d SWDEV-233927 - Crash if binary for current device is not found.
Change-Id: I57281ae6c09110f39155664fca5a83ea57bb62b4


[ROCm/clr commit: f2899243f3]
2020-05-28 16:18:27 -04:00
Joseph Greathouse 9b1faa7db0 Fix a build error on signed/unsigned comparison
Change-Id: Ic79eb4c3ec5c6fd36cea7c4810d990619f08b9e1


[ROCm/clr commit: 766e708535]
2020-05-28 14:27:16 -05:00
kjayapra-amd 640559bdcb SWDEV-236465 - Return error code as soon as global creation fails.
Change-Id: I790b8b4fdd6ab8818bc5b6b9a79e6900b840372d


[ROCm/clr commit: 55cdef8e45]
2020-05-28 13:28:23 -04:00
Joseph Greathouse db6de71b54 Fix occupancy calculation functions in ROCclr path
The hipOccupancyMaxPotentialBlockSize API is meant to return the
number of threads for the highest-occupancy workgroup, and the number
of those workgroups. It was previously calculating the number of
maximum-sized workgroups that would fit on a single CU. This is
a mixture of the API we wanted (to calculate max potential block size)
and the MaxBlocksPerMultiprocessor function.

This patch fixes it up so that the internal occupancy calculation
function works for two uses: the traditional function that calculates
the maximum blocks per multiprocessor when a user passes in a fixed
block size (used for hipMaxBlocksPerMultiprocessor style functions)
and a function that calculates the size of a block that would lead
to maximum occupancy, and how many blocks of that size would be
needed to fill the whole GPU (for hipOccupancyMaxPotentialBlockSize
style functions).

This also updates the occupancy calculation function to prepare for
gfx10, which does not have SGPR-based occupancy limits.

Change-Id: Ie007b3f9d5ebc4e166b50a3a051498af35650f35


[ROCm/clr commit: 90453b68d3]
2020-05-28 10:22:10 -05:00
Evgeny 40f527175f adding hipKernelNameRefByPtr function
Change-Id: Iefc18967b10394b85a207ffdb5bbfe5e3601474d


[ROCm/clr commit: d863edb8ba]
2020-05-28 10:59:48 -04:00
Matt Arsenault 4c698207e3 Attempt to handle case where git isn't available
Git may not be available, and this may not be a git checkout, as would
happen in a release tarball. Doesn't really attempt to get a nicer
version formatting if some of the git subcommands fail.

Change-Id: Ib568cd1310983a43f2664ded72528d7e41f554c0


[ROCm/clr commit: eb31e45123]
2020-05-28 09:23:24 -04:00
Saleel Kudchadker fd522b44ff Fix elapsed time calculation for null stream
SWDEV-237377 - This fixes time calculation where the event may
be recorded on Null stream and work submitted on other streams

Change-Id: Ie36310dea5cee2fed4a514ed01f04db4b47e571c


[ROCm/clr commit: facb05495f]
2020-05-27 18:42:07 -04:00
Michael LIAO 5a6bdf5b02 [hip] Those texture interfaces are C interfaces should be always exposed.
Change-Id: Ie34f1420839b17486346149b1672e70ec0088b54


[ROCm/clr commit: cbe2bedf42]
2020-05-27 15:03:59 -04:00
Christophe Paquot df67d8971a Call notifyCmdQueue when building the event wait list
SWDEV-237846

Change-Id: I8bf70e7ad19903767a080d8c6e516c83b0dc2545


[ROCm/clr commit: 1cfc9d1860]
2020-05-27 12:53:46 -04:00
Sarbojit Sarkar 38f3c57f58 [doc]shfl*sync update
1. Updated FAQ with shft*sync not supported hip_faq.md
2. Corrected some of input parameter description in hcc_details/hip_runtime_api.h
3. Redirect shfl*() to shfl_*_sync() for nvcc path where CUDA > 9.0

Change-Id: I3d8184db5fcc622852c9bad96b706348e8dfc16c


[ROCm/clr commit: e288338e4a]
2020-05-27 02:17:40 -04:00
Aryan Salmanpour 71d0954669 [dtest] add a test for hipExtStreamCreateWithCUMask API
Change-Id: Ib567e559c5ab7d04ac5c300fd7e15eedfc4fb6e6


[ROCm/clr commit: c9b8a19ce0]
2020-05-26 18:15:09 -04:00
Christophe Paquot 20dadcac1e hipDeviceSynchronize needs to sync NonBlocking streams as well
SWDEV-237167

Change-Id: Ie916d8f03ce91e8ef05a2b4edc580a7021520f6f


[ROCm/clr commit: 9611b5a8b4]
2020-05-26 17:59:22 -04:00
Ramesh Errabolu 80ed6bc187 Remove dependency on hsa-ext-rocr-dev package
Change-Id: I1147a299c31ce1ae5978b7312d82fa83d796b019


[ROCm/clr commit: b941f9243f]
2020-05-26 14:40:42 -05:00
Evgeny 6b8d30bfae hip_prof: fixing printing pointer args
Change-Id: I93969723650f7c29d5c00a3809d3701c6a3dca44


[ROCm/clr commit: ed11059230]
2020-05-25 13:17:16 -04:00
kjayapra-amd 76dc2e3c9b SWDEV - 237467 - Return proper hip error codes incase of ROCclr IPC API failures.
Change-Id: I2cc8da543f70bb3d8b82520fa9b2f509d20ce3c0


[ROCm/clr commit: 6bc01b31d6]
2020-05-23 10:51:37 -04:00
Dittakavi Satyanvesh 1e0294968d hipIpcCloseMemHandle checks the status of IpcDetach
Change-Id: Ifbe8e5bbda610a1007f881627d0da1c874d03682


[ROCm/clr commit: ee4688d37e]
2020-05-23 08:47:36 -04:00
Mahesha Shivamallappa 871ac22d36 Add support for cooperative group type - thread_block
Change-Id: If3770b6d6718a638b70f527ae2533d9ef3267ff4


[ROCm/clr commit: f4e6dec3ac]
2020-05-22 23:08:42 -04:00
Matt Arsenault 800ae292c2 Remove ROCclr search hacks
find_package should now be the only way to import ROCclr. Also update
the build example comment.

The build scripts used 2 custom variables to manually specify the
build and source directories for where to find VDI. Once renamed to
ROCclr, these conflicted with the variables automatically set by
find_package(ROCclr). These hacks tried to satisfy this intermediate
step to try satisfying commit ordering problems to get through PSDB.

The INSTALL.md documentation should also be updated, but it's
completely missing any mention of ROCclr now, and still gives
directions for hcc.

Change-Id: I6fc94b6cb36241a9d4f22d24e49523367f803461


[ROCm/clr commit: a98920d9a3]
2020-05-22 15:52:35 -04:00
Vlad Sytchenko b0a332e466 Reenable texture reference tests
Change-Id: I77024476cff77951d61dc48f7e30094d6b47266c


[ROCm/clr commit: 355661b5da]
2020-05-22 14:13:50 -04:00
Tao Sang 5519100f79 Fix square build failure with static lib in Jenkin
When libamdhip64_static.a is built by Jenkin, sample square cannot been
built successfully because libamdhip64_static.a is archiveved in thin
mode. Thus in the patch it will be archiveved in full mode. Meanwhile
libamdhip64_static_temp.a will be useless and thus removed.

Change-Id: Ifd3882598ef0dc5e7af8db0e389e786025ceb455


[ROCm/clr commit: 51b6c1856c]
2020-05-22 11:49:52 -04:00