9b04e88046
Fix bug in GUI kernel filtering
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 0d516f05b4
2024-03-01 15:50:42 -06:00
81c82c1c24
correct small negatives in remote read/write traffic due to running in different passes
...
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
[ROCm/rocprofiler-compute commit: 20d93703fc
2024-03-01 15:50:42 -06:00
1f891f6c89
fix dependency ordering in builtins
...
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
[ROCm/rocprofiler-compute commit: 2c3c5fba35
2024-03-01 15:50:42 -06:00
d91521f2dc
typo
...
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
[ROCm/rocprofiler-compute commit: 18dfc35c14
2024-03-01 15:50:42 -06:00
23b8308a67
catch missing per-XCDs
...
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
[ROCm/rocprofiler-compute commit: c5e4a33c07
2024-03-01 15:50:42 -06:00
78b668f128
Enhance correct_sys_info() func and err checking
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: c17e39189f
2024-03-01 15:50:42 -06:00
98ecb3b590
Remove mean for avg header in inst cache panel
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 17a4d92c63
2024-03-01 15:50:42 -06:00
c27927e4ad
Hide L2Banks in sysinfo and update roofline module
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: a70dc4999d
2024-03-01 15:50:42 -06:00
28202ab4de
Fixing misc Mi300 typos
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 3e59c928e0
2024-03-01 15:50:42 -06:00
fb85918f64
Misc fix for kernel name shortener
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: d2c3d7faf9
2024-03-01 15:50:42 -06:00
f779f50841
Fix Mi300 clk timings using GRBM_GUI_ACTIVE from #255
...
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com >
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: bd794abb12
2024-03-01 15:50:42 -06:00
72f0f86eae
Carry over fixed numSQCs calc from #247
...
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com >
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 2001908fd8
2024-03-01 15:50:42 -06:00
62cafd2bdc
Including remaining metric fixes from #251
...
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com >
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 3ce140d04b
2024-03-01 15:50:42 -06:00
2ecc5a4246
Renaming global spec vars. Replacing L2Banks with total_l2_chan ( #251 )
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 86b6c8e848
2024-03-01 15:50:42 -06:00
5352eafde4
Reorganize the specs module to reduce duplicate code
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 3b1b8d7b5b
2024-03-01 15:50:42 -06:00
f240822ea1
Fix off by one out of range kernel filtering ( #287 )
...
* Fi off by one out of range kernel filtering
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
* reformat
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
---------
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
[ROCm/rocprofiler-compute commit: 4ad124a207
2024-02-29 12:38:37 -06:00
055bda677a
Supress warning: RuntimeWarning: Mean of empty slice ( #271 )
...
* Supress warning: RuntimeWarning: Mean of empty slice
Signed-off-by: Jose Santos <josantos@login1.hpcfund >
* Move import to top
Signed-off-by: Jose Santos <josantos@login1.hpcfund >
* Specify type of RuntimeWarning in catcher. Safer approach
Signed-off-by: colramos-amd <colramos@amd.com >
* Comply to formatting
Signed-off-by: colramos-amd <colramos@amd.com >
---------
Signed-off-by: Jose Santos <josantos@login1.hpcfund >
Signed-off-by: colramos-amd <colramos@amd.com >
Co-authored-by: Jose Santos <josantos@login1.hpcfund >
Co-authored-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: f42aa6c7e0
2024-02-29 12:14:46 -06:00
81141e8ef2
document updated minimum version requirements for ROCm and python
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 2a6285a16b
2024-02-27 15:11:17 -06:00
e35c600d45
Fix for rocm-smi not getting mclk for MI100
...
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: f2235b7f1d
2024-02-26 11:47:56 -06:00
6ac883e20e
more code formatting updates
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 76873dd0c4
2024-02-22 16:02:25 -06:00
e9f8f78f9f
more code formatting updates
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 5a27189c82
2024-02-22 16:02:25 -06:00
4bfcf9b8a8
code formatting updates
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 79b877d679
2024-02-22 16:02:25 -06:00
fba2e174fb
Fix clocks ( #246 )
...
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
Co-authored-by: Nicholas Curtis <nicurtis@amd.com >
[ROCm/rocprofiler-compute commit: 852cc13f2a
2024-02-13 20:22:11 -06:00
0dcd6e35dd
Fix hbmBW calculation, ( #243 )
...
* Fix hbmBW calculation, currently we're reading the wrong value of the mclk out of rocm-smi
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
* Fix for earlier smi
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
---------
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
Co-authored-by: Nicholas Curtis <nicurtis@amd.com >
[ROCm/rocprofiler-compute commit: c60f031558
2024-02-13 20:19:56 -06:00
a5b1082836
Modify yaml configs to reflect new combined Top Stats
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: b7d5d3b64b
2024-02-13 19:56:46 -06:00
96786667ad
Enable the revamped Top Stats section in standalone GUI
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: bd83f68412
2024-02-13 19:18:31 -06:00
85c4cec42e
Combine kernel and dispatch stats in the Top Stats section of analysis
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 2526e14802
2024-02-13 19:17:41 -06:00
6bedf1ebf6
Fix logic for roofline field in sysinfo
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 7bb211a465
2024-02-12 17:07:55 -06:00
8721490218
Revert sbios fix. Catch commas
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 33a2cd34ce
2024-02-08 12:52:07 -06:00
bce1fe532b
Escape sbios, can have commas on some systems ( #241 )
...
* escape sbios, can have commas on some systems
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
* Prefer to cast to str in original function
Signed-off-by: colramos-amd <colramos@amd.com >
---------
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
Signed-off-by: colramos-amd <colramos@amd.com >
Co-authored-by: Nicholas Curtis <nicurtis@amd.com >
Co-authored-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: c8f4f74255
2024-02-08 12:40:52 -06:00
919cf88f8b
Add new l2 cache per channel headers to supported fields
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: d7b78da250
2024-02-06 16:19:40 -06:00
1c85c5666e
Enable standalone GUI with new metric reordering
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 48911111be
2024-02-06 16:19:40 -06:00
2a265ab454
Add numPipes field and omit 'non-functional' counters from configs
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 3b8e08f589
2024-02-06 16:19:40 -06:00
53c69ce86d
Standardize syntax across all metric configs
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 4c9a638e2d
2024-02-06 16:19:40 -06:00
6811aea8e1
Update perfmon config for tcc
...
Co-authored-by: Nick Curtis <nicholas.curtis>
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: f4053bc0a2
2024-02-06 16:19:40 -06:00
149f7ca530
General spell check and typo fixing
...
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com >
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 66fcfd3def
2024-02-06 16:19:40 -06:00
bd22355b96
Add numPipes built-in-var for updated metrics
...
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com >
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: d16f58b797
2024-02-06 16:19:40 -06:00
ef60d67744
Update metrics, handling merge conflicts in L2 cache per channel
...
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com >
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: deef37d5a9
2024-02-06 16:19:40 -06:00
3b0dce88ca
Add full documentation for updated metrics ( #224 )
...
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com >
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 4b8f519e9b
2024-02-06 16:19:40 -06:00
3b28104356
Fix SPGR merge warning and more descriptive CLI output
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: b0cf695976
2024-02-06 16:12:14 -06:00
4a90ef122f
add an optional exit_on_error arg for the run utility and enable for a
...
subset of calls to rocm-smi
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: eece1f4688
2024-02-05 16:20:21 -06:00
595ca9141a
Fix reporting of --roof-only runs in sys_info
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 7556316f02
2024-02-04 12:44:47 -06:00
875ab7257e
Fix reporting of --roof-only runs in sys_info
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 9b464503fe
2024-02-04 12:44:47 -06:00
c40ad2895e
Modify smi error detection to check for non-zero exit code
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 194e168414
2024-02-02 14:27:08 -06:00
4fbbe78d08
Update metric configs incorrectly using legacy rocprof headers
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 4174788e59
2024-02-01 16:22:44 -06:00
3f3e39c0be
profiling: Fix issue in mismatch join detection
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 3ac0f8121b
2024-01-31 12:15:56 -06:00
c0e2d759dd
profile: fix parsing tcc per channel on mi300 ( #234 )
...
Co-authored-by: fei.zheng <fei.zheng@amd.com >
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: f44ce21252
2024-01-31 09:34:50 -06:00
90fc9dced5
Remove old csv_converter module, add new kernel_name_shortener module
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: ad169fa1e8
2024-01-30 11:15:12 -06:00
d8608a07a2
Enable database mode
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: e1867d34d3
2024-01-30 10:43:30 -06:00
edccad450c
Patch roofline debug logging
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: a1bfa83764
2024-01-29 10:22:37 -06:00
colramos-amd
Nicholas Curtis
JoseSantosAMD
Karl W Schulz
Nick Curtis