Commit Graph

11840 Commitit

Tekijä SHA1 Viesti Päivämäärä
Jatin Chaudhary 5698bb89ce SWDEV-367537 - Add missing operators to __hip_bfloat16 implementation
Add __host__ and __device__ to bunch of operator/function matching CUDA
Fix some bugs seen in __hisinf

Change-Id: I9e67e3e3eb2083b463158f3e250e5221c89b2896


[ROCm/clr commit: 86bd518981]
2023-11-06 18:08:37 -05:00
Julia Jiang 313a0e9e66 SWDEV-420793 - Adding more change items in changelog.md
Change-Id: I845be6aba6f7c48ffc8093343116fe8e6c7c7da5


[ROCm/clr commit: ab47f08a04]
2023-11-06 10:19:59 -05:00
Saleel Kudchadker 5f009b7cb1 SWDEV-422207 - Track commands for capture
- Track all captured commands under a new AccumulateCommand
- Add begin() and end() methods to capture commands
- Explicit TS object now passed to certain methods because
profilingBegin() and profilingEnd() now happen separately and thus can
run into threading issues

Change-Id: I171106bdcad72b057836cb2f3fc398db3533119f


[ROCm/clr commit: 40f41f4d0b]
2023-11-03 05:09:04 +00:00
Saleel Kudchadker 1d4bd084b8 SWDEV-301667 - Cleanup unused paths
- Refactor code and cleanup logic for callback saving for event records

Change-Id: I5c56aa8e9c968a5bca70fb07ad1796da318e9e89


[ROCm/clr commit: 1338ff37e8]
2023-11-02 11:43:41 -04:00
Satyanvesh Dittakavi efbe1365b9 SWDEV-430048 - hipMemcpy2D should return success for zero sized arrays
- This matches the CUDA behavior
- The pitch and width checks removed are already covered in ihipmemcpy2D

Change-Id: I03a6921a78b5d89723830d8dde5865fdc6db0379


[ROCm/clr commit: 6d6465cb96]
2023-11-02 00:40:08 -04:00
Ioannis Assiouras b2953b63a9 SWDEV-428408 - Add waitingSignal for hsa_amd_memory_async_copy calls in hsaCopyStaged
Change-Id: I3c42ef1ef3ed2f0b00f0a50d402a32106e5978ba


[ROCm/clr commit: b0c9fb84fd]
2023-11-01 19:43:08 -04:00
taosang2 6ea1a64c56 SWDEV-426270 - Remove duplicated operators
Remove duplicated operators of hipComplexFloat and
hipComplexDouble.
If users need complex number multiplication and division,
they should call
hipCmulf() and hipCdivf() for hipComplexFloat,
hipCmul() and hipCdiv() for hipComplexComplex

SWDEV-428198 - Add missing operators

Add missing operators of vectors in host

Change-Id: Ie58d1642d579e7119997db49a9fd6a6641b666fd


[ROCm/clr commit: d4799b2a3f]
2023-11-01 12:59:28 -04:00
Ioannis Assiouras 16c18d5498 SWDEV-426613 - Do not install hipcc.bat and hipconfig.bat on linux
Change-Id: I0999cf35487686e8c0d863d042f971cf563578c8


[ROCm/clr commit: df0f54ddf1]
2023-11-01 11:54:11 -04:00
sdashmiz 9b297f0006 SWDEV-417075 - add hipDrvAddMemCpyNode
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ie631d7b1788f10171a29d463759a3cba3b2b2007

SWDEV-417075 - add hipDrvGraphAddMemcpyNode

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I6bab3310919643e119cd0004276907e223641cfb


[ROCm/clr commit: 9b567e1799]
2023-10-31 09:55:42 -04:00
taosang2 c709808166 SWDEV-364236 - Fix device buffer to/from image issue
Fix offset of device buffer copied to/from image.

Change-Id: I149a8629769cd0d5848ffefb04f1752668a685b9


[ROCm/clr commit: 9a24e1fb30]
2023-10-30 12:17:14 -04:00
German 005aebbfad SWDEV-429529 - Allocate glb_ctx_ even for one device
Move context allocation into Device::init() method to simplify the logic and handle
HIP_VISIBLE_DEVICES properly

Change-Id: I0fc6f37c7ae39bedbdad0290295d6794c66d6c54


[ROCm/clr commit: a49d633883]
2023-10-27 15:00:15 -04:00
Jaydeep Patel 39ae3fedd5 SWDEV-428198 - Revert "SWDEV-426270 - Remove duplicated operators"
This reverts commit 5f945e937d.

Change-Id: I4973424b5f8d6f2b0d8496dda346b9d6dbba13ae


[ROCm/clr commit: 76e3ffeb81]
2023-10-27 01:51:03 -04:00
Anusha GodavarthySurya d6c3c17c8b SWDEV-422207 - Remove L2 flush when kernelArgs are in device memory
Change-Id: I7b5625cb6d55e83689bff7bbb45be9c517ec4a8d


[ROCm/clr commit: 5fb7536586]
2023-10-26 19:14:58 +00:00
Saleel Kudchadker d03b38ba62 SWDEV-422207 - Fix profiling check
Change-Id: Ia6ca28f0b593ea1680732684dd10f40c0043c973


[ROCm/clr commit: 182f6e2e6d]
2023-10-25 05:37:55 +00:00
Anusha GodavarthySurya d0b8c99103 SWDEV-422207 - Handle nonkernel nodes for graph opt
- Support graph with different types of nodes with single
branch when DEBUG_CLR_GRAPH_PACKET_CAPTURE flag is enabled

Change-Id: I149a8629769cd0d5849ffefb04f1352668a685b6


[ROCm/clr commit: 38d2c56784]
2023-10-24 18:36:06 +00:00
Ajay 57a7c2965b SWDEV-418100 - HIPNV_DIR error for nvidia build
Change-Id: Id1fb67311fb6a0af98de7c2dcef5cfcf29102d14


[ROCm/clr commit: 6926183974]
2023-10-23 18:04:05 -04:00
Saleel Kudchadker cba9970220 SWDEV-408180 - Address possible cornercases
- Address corner cases that can arise with the new
hipMemcpyDeviceToDeviceNoCU enum
- Better log

Change-Id: I6035b901f8d616741054b7a5ff4f67956329ac57


[ROCm/clr commit: 5662d4037c]
2023-10-23 16:54:08 -04:00
Saleel Kudchadker a36851b9ff SWDEV-301667 - Reset addSystemScope_
If we submit a systemScope Barrier, we should reset this flag as there
is no need for dispatch AQL again to flush caches/HDP

Change-Id: I55710feb4ba6650852e785b5cadfa64c6b9ce14e


[ROCm/clr commit: de2b06a7a7]
2023-10-23 16:53:47 -04:00
Julia Jiang 037f46a43f SWDEV-422771 - Update change-log adding HIP_LAUNCHING_BLOCKING and fixed issue for complex operations
Change-Id: Ief712d9c1c400513f39c06a67b83d6ee2ffdd3fd


[ROCm/clr commit: 0371401d13]
2023-10-23 11:20:58 -04:00
kjayapra-amd 87f90197f2 SWDEV-413997 - Fixing multiple access desc cases for hipMemSetAccess.
Change-Id: Iec7d1207ec0a7136e4e74ef2e390f3347e753d40


[ROCm/clr commit: e226ae109b]
2023-10-23 09:44:04 -04:00
Ioannis Assiouras 2da4764fc2 SWDEV-428244 - Set PARAMETERS_MIN_ALIGNMENT to the native alignment
Change-Id: I14d8a0db4e575d6fa816754c52df405de88d9200


[ROCm/clr commit: 7868876db7]
2023-10-21 17:26:46 -04:00
Jaydeep Patel 8229fce863 SWDEV-425568 - Do cpu wait for device sync.
Change-Id: Ia05e09bd10ab623b36c74037e9988e132120dd9f


[ROCm/clr commit: ee00ebc42f]
2023-10-21 01:16:06 -04:00
Saleel Kudchadker 4c9f160818 SWDEV-408180 - Add a new hipMemcpyKind
Add hipMemcpyDeviceToDeviceNoCU to force a non blit copy path. This
helps in cases where an app may determine that CU may be busy and copies
with SDMA may be quicker.

Change-Id: I59b415dd8f6022c244e8d75f265464d5c635df1e


[ROCm/clr commit: f316a30e5d]
2023-10-20 13:18:10 -04:00
taosang2 28524520e6 SWDEV-364236 - Fix layered Image issue
Fix wrong logic to get layer index;
Make layered image's layout match cuda spec;
Fix wrong comparision of element size.
Remove amd::BufferRect from ihipMemcpyAtoHCommand()
and ihipMemcpyHtoACommand().
Change-Id: Icc6a4233fbce2e9b2dc6feb79e6bfbd761684c7d


[ROCm/clr commit: 5a0085e516]
2023-10-19 16:06:20 -04:00
German 648bfdc5cd SWDEV-427689 - Report LUID in Windows
Pass LUID infromation from PAL to HIP device properties.
NodeMask is calculated based on the order of devices in PAL

Change-Id: Ic53707b68b16f392e5284a0105bf1f3941b46653


[ROCm/clr commit: 694fe4bedb]
2023-10-18 15:07:39 -04:00
taosang2 5f945e937d SWDEV-426270 - Remove duplicated operators
Remove duplicated operators of hipComplexFloat and
hipComplexDouble.
If users need complex number multiplication and division,
they should call
hipCmulf() and hipCdivf() for hipComplexFloat,
hipCmul() and hipCdiv() for hipComplexComplex

Change-Id: Ie58d1642d578e7118997db40a9fd6a6641b666fd


[ROCm/clr commit: 0ca61130a2]
2023-10-18 14:56:32 -04:00
Julia Jiang e847e960c2 SWDEV-422771 - Updating change-log for ROCM 6.0
Change-Id: I8a3b016b8a9cedff5b730645fda009c78c5afbb7


[ROCm/clr commit: 583ec06a7b]
2023-10-18 11:20:06 -04:00
German f641a419d0 SWDEV-425441 - Create a fake WGL context
If a WGL context wasn't attachhed to OGL, then OGL fails to return
the entry points for AMD extension.

Change-Id: I2bfa5f4f4d038785282e1c9af455e4593e75d3ff


[ROCm/clr commit: 00b58e2536]
2023-10-18 09:44:09 -04:00
Ioannis Assiouras f43c3ee571 SWDEV-427493 - Fixed segfault after accessing deleted timestamp
Change-Id: I478008f03e2bb4d9ac1f0865605edbf9f8254fea


[ROCm/clr commit: 2d8c65eedf]
2023-10-17 15:24:07 -04:00
Jatin Chaudhary 39fcf57860 SWDEV-306642 - Move the deprecated function/struct to hip_device_deprecated.cpp
Change-Id: Id1f8db09271c537a200bc090ba1feaacfb023b88


[ROCm/clr commit: 56f3b2563c]
2023-10-16 21:42:18 +01:00
Satyanvesh Dittakavi 239fdc3bfd SWDEV-419480 - HIPRTC implementation of standard headers shouldn't be in std namespace
HIPRTC implementation of few type traits are defined in std
namespace which causes conflicts with the std C++ headers when
apps try to include those std headers. Instead, use the
specific implementation of these headers from __hip_internal
namespace to avoid this.

Change-Id: Ia358df159af8783d1eba9a19cd458e192bf7e9e6


[ROCm/clr commit: 353dbe6e3b]
2023-10-16 13:10:55 -04:00
kjayapra-amd 6d8458ba5a SWDEV-413997 - Initial VMM changes for ROCm path.
Change-Id: I4405fd7b53182eb4c4622835c811c0dc08461537


[ROCm/clr commit: 3ef829939a]
2023-10-16 11:29:16 -04:00
Rahul Garg 8b30637507 SWDEV-415029 - [ABI Break] Remove hcc symbols
This reverts commit 34aa551075.

Reason for revert: Bring back original change

Change-Id: Ie20e80f6e9b7d67a28e3a255abaf82018eb61e7a


[ROCm/clr commit: 8fe1d9dda1]
2023-10-16 07:34:43 -04:00
sdashmiz fffa6e3296 SWDEV-389530 - [ABI Break]Match error with cuda
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Id9de54b4fd1be7b6b887a4ebfcc6a3d9a70c7bc9


[ROCm/clr commit: 2d83abaca6]
2023-10-16 07:31:34 -04:00
sdashmiz 555aacb1fb SWDEV-371332 - [ABI Break] Return success for unregistered ptr
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ie58d16420578e7118997eb40a9fd6a6641b666f3


[ROCm/clr commit: d78aef7f66]
2023-10-15 14:32:24 -04:00
Maneesh Gupta 515ea1eb56 SWDEV-418100 - Move nv headers to hipother repo
Change-Id: Ib54546e366b61bdb83789d8264f30f1bfb875605


[ROCm/clr commit: 67dda1ffd6]
2023-10-14 06:56:13 +00:00
Jaydeep Patel 90e078b5f4 SWDEV-425490 - Move ptrdiff_t & clock_t to hiprtc.cmake.
Change-Id: I7c8ce3c1b8cb11e0253b0f51ae10fca7f0a32017


[ROCm/clr commit: 7150b2eaad]
2023-10-13 00:58:56 -04:00
sdashmiz fcfa0d0733 SWDEV-332969 - [ABI Break]Substitute hipArray* with hipArray_t
- hipArray will be an internal struct from rocm6.0

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Icf97fe96b87be8532098cd7f9ceaad099f99c9b9


[ROCm/clr commit: c089ef4a2b]
2023-10-12 12:09:19 -04:00
Jatin Chaudhary 15b062b9b4 SWDEV-306642 - [ABI Break] Add texture/surface/device capabilities device struct entries
- alias hipGetDeviceProperties to hipGetDevicePropertiesR0600
- alias hipDeviceProp_t to hipDeviceProp_tR0600
- remove gcnArch from new device property struct
- add new requested struct members

Change-Id: If3f5dbef3d608487d9f6f419285f4bf577ea9bf0


[ROCm/clr commit: 2989840511]
2023-10-12 11:16:18 -04:00
jiabaxie 4cef95d286 SWDEV-418999 - python script to support profiler with hip versioning
Change-Id: I8f5ad81162581bf3792c2606ba8c6c3a8e0b4bf2


[ROCm/clr commit: 813907c29d]
2023-10-11 13:46:45 -04:00
Rakesh Roy e2e169f47c SWDEV-421667 - Print shared library name which doesn't contain CO for current device
- ML Frameworks link many ROCm component libraries
- It becomes a tedious task to figure out which library HIP is complaining about
- To improve debuggability print out the shared library name

Change-Id: I53c4d66393670356b8cafd3e48075e430f0a45ce


[ROCm/clr commit: 52001adf43]
2023-10-11 10:43:03 -04:00
jiabaxie f25e5e01f3 SWDEV-405983 - adding in HIP_LAUNCH_BLOCKING
Change-Id: I3f9c8a745099aab05155ebe910e727693961a02f


[ROCm/clr commit: 28f0daa34f]
2023-10-10 21:11:13 -04:00
Saleel Kudchadker 0ec2d8847d SWDEV-301667 - Track last used SDMA engine per queue
- Track last SDMA engine per queue, this results in better scheduling
- Reset last SDMA engine upon batch completion. That ensures we dont get
blocked if the same engine is used by another concurrent copy

Change-Id: Id53111980da7ee41d5c932fb44e4aab5b1e065a3


[ROCm/clr commit: bf8baeecb3]
2023-10-10 12:13:11 -04:00
Anusha GodavarthySurya 661b3381da SWDEV-408701 - Avoid adding duplicates when no node is captured in cross stream
Change-Id: Iccbddaf9db73238aa938f8b3e8ec410f4a86d524


[ROCm/clr commit: c7e4e9c2f4]
2023-10-09 13:15:47 -04:00
Rakesh Roy 34aa551075 SWDEV-425967, SWDEV-425968 - Revert "SWDEV-415029 - [ABI Break] Remove hcc symbols"
This reverts commit 088704abeb.

Reason for revert: This causes build failure in hipBLASLt & hipSPARSELt

Change-Id: I59f6aeb8b82261b77eb978e53407bc56be1d0cf1


[ROCm/clr commit: 2535fac296]
2023-10-09 06:30:19 -04:00
Sourabh Betigeri d596ec2073 SWDEV-369792 - Fix to use the roclr context already created when creating hip::Device rather than creating a new context in hip
Change-Id: I6dbccb1a17dee0e9a72ec52cb1a5bb096315fa0f


[ROCm/clr commit: 01aa3557f4]
2023-10-07 14:32:32 -04:00
German Andryeyev bd63f3f614 SWDEV-424603 - Use OR for CPU wait request
Make sure rocclr doesn't overwrite the client's request
for a wait.

Change-Id: I0addf18ea408b7f4ecaa1e04b2877cc0bbbfcc0d


[ROCm/clr commit: fe7b36f3cb]
2023-10-06 16:51:44 -04:00
Jaydeep Patel 38fec06989 SWDEV-425490 - ptrdiff_t differs on windows and linux.
Change-Id: I5b943e869a6552870aa268be898182e806161b3c


[ROCm/clr commit: 46de4256e0]
2023-10-06 16:04:52 -04:00
Alex Xie b444ee5b3b SWDEV-423579 - Move header file to ROCclr
This header file is used by ROCclr and might be used by HIP too.
ROCclr folder is a right place for this header file.

Change-Id: Ie2307331f9bd445f3c295d2ccbfc4924b0fa9510


[ROCm/clr commit: 124de0c519]
2023-10-06 14:54:50 -04:00
German Andryeyev d593231137 SWDEV-424603 - Force CPU wait if profiling
Some pytorch tests use a tracer plugin and rely on profiling information
to be reported right after hipDeviceSynchronize()

Change-Id: Ib021a1e7b1a30b3c24de72627c471810f7f7878d


[ROCm/clr commit: 5438b6362e]
2023-10-06 11:33:06 -04:00