Wykres commitów

3424 Commity

Autor SHA1 Wiadomość Data
Yaxun Sam Liu 598604aa7f hip-clang: update installation guide. 2019-03-30 08:24:49 -04:00
Wen-Heng (Jack) Chung 04915cea2f Make hipModuleGetGlobal be in HIP runtime so it can be discovered at runtime (#981)
* Make hipModuleGetGlobal be in HIP runtime so it can be discovered at runtime

In HIP PR #929, quite a few HIP public APIs were made as inline functions with
hidden visibility. It was necessary to support applications with shared
libraries with GPU kernels launched via hipLaunchKernelGGL(), after HIP runtime
is initialized.

In empirical tests, the implementation has been proved to be a bit too
excessive, especially for hipModuleGetGlobal(). The function is used by another
type of client applications which relies on the existence of this function
within HIP runtime so global symbols from HSA code objects loaded dynamically
at runtime can be retrieved programmtically.

This commit moves hipModuleGetGlobal() back to src/hip_module.cpp, and makes it
visible and not inline, to fulfill requirements for applications
aforementioned. It does not change the behavior of applications depending on
hipLaunchKernelGGL().

* Add HIP_INIT_API into the implementation of hipModuleGetGlobal

Address review comments.

* Fix failing HIP unit tests
2019-03-29 03:45:04 +00:00
Maneesh Gupta f9f4cee347 Merge pull request #992 from gargrahul/handle_d2d_memcpy2d
Handle D2D in memcpy2D
2019-03-28 04:41:36 +00:00
Maneesh Gupta 79f24a1553 Merge pull request #991 from jeffdaily/per_agent_program_state
load program state once per agent
2019-03-28 04:40:46 +00:00
Jeff Daily f5e4fff6cc improve program state commentary
Disambiguate calling many varibles "agent".
More detail in exception message.
Create and discard map placeholders; no need to call std::vector::clear() on map value.
2019-03-27 21:40:27 +00:00
Rahul Garg 50d623981e Handle D2D in memcpy2D 2019-03-28 02:21:45 +05:30
Jeff Daily 2845b4c4b8 load program state once per agent 2019-03-27 18:19:10 +00:00
Maneesh Gupta 93906a072c Merge pull request #987 from gargrahul/fix_hostmalloc_double_device_map
Avoid double mapping of devices to hostMalloc buffer
2019-03-27 05:23:47 +00:00
Maneesh Gupta 178e3ecdca Merge pull request #990 from mhbliao/hliao/master/sw
SWDEV-184380 Fix hcc compilation
2019-03-27 05:23:26 +00:00
Maneesh Gupta 3bcb3a9239 Merge pull request #986 from mhbliao/hliao/master/build
[hip] Fix typo in macro `hipLaunchKernel`
2019-03-27 05:22:44 +00:00
Michael LIAO d355122bf9 SWDEV-184380 Fix hcc compilation
- `hcc` has no builtin. Need to invoke LLVM intrinsic directly.
2019-03-26 15:20:17 -04:00
Rahul Garg 9b38380c03 Let hipHostMalloc always share/map pinned host ptr 2019-03-26 10:19:13 +05:30
Rahul Garg ad11972f47 Avoid double mapping of devices to hostMalloc buffer 2019-03-25 23:07:05 +05:30
Michael LIAO 13655df76e [hip] Fix typo in macro hipLaunchKernel 2019-03-25 12:06:46 -04:00
Maneesh Gupta c20d233585 Merge pull request #970 from mangupta/swdev-172995
hipExtMallocWithFlags implementation
2019-03-25 07:46:53 +00:00
Maneesh Gupta 9de28dfa5a Merge pull request #962 from gargrahul/add_2d_copy_fallback
Add 2D fallback to use copy kernel
2019-03-25 07:46:43 +00:00
Rahul Garg bec3995700 2D Fallback needs hcc workweek 19101 or higher 2019-03-25 12:07:28 +05:30
Maneesh Gupta 45255ab492 hipExtMallocWithFlags needs hcc workweek 19115 or higher 2019-03-25 11:41:20 +05:30
Maneesh Gupta 158eac9374 Merge pull request #982 from ROCm-Developer-Tools/hack_swdev-173477
HACK for SWDEV-173477
2019-03-22 09:14:38 +00:00
Maneesh Gupta f3966c6cb1 Merge pull request #980 from ntrost57/master
fixed loss of accuracy in hipCfma()
2019-03-22 09:14:09 +00:00
Wen-Heng (Jack) Chung cf7ad0f184 HACK for SWDEV-173477
For code objects with global symbols of length 0, ROCR runtime would
ignore them even though they exist in the symbol table. Therefore the
result from read_agent_globals() can't be trusted entirely.

As a workaround to tame applications which depend on the existence of
global symbols with length 0, always return hipSuccess here.

This behavior shall be reverted once ROCR runtime has been fixed to
address SWDEV-173477
2019-03-21 17:18:16 +00:00
Nico Trost 725486fb11 fixed loss of accuracy in hipCfma() 2019-03-21 10:30:10 +01:00
eshcherb 045c6afa2c adding hip_prof_gen verbose log (#977)
* adding hip_prof_gen verbose log

* adding stderr fatal error

* adding no error exit by default

* adding hip_prof_str regeneration dependencies

* adding more informative messages

* fixing error mesage
2019-03-21 05:28:18 +00:00
Maneesh Gupta ce72890dcf Merge pull request #972 from yxsamliu/global
Add declaration of symbol related API for VDI
2019-03-20 05:12:21 +00:00
Maneesh Gupta 54091b5273 Merge pull request #973 from mhbliao/hliao/master/build
[Device Function] Fix typos.
2019-03-20 05:12:14 +00:00
Maneesh Gupta 48d790e205 Merge pull request #974 from yxsamliu/name2
Change HIP dll name to amdhip64.dll on Windows
2019-03-20 05:11:58 +00:00
eshcherb 1229750546 adding prof primitives generator (#967)
* adding prof primitives generator

* minor change, renaming

* minor cosmetic changes, comments correcting and dead code removing

* minor changes and renaming

* minor chane, fixing comments
2019-03-20 05:11:40 +00:00
Siu Chi Chan fa9495841b reimplement HIP_INIT as hip_impl::hip_init(), add hip_init() to some of the inlined API (#966)
* reimplement HIP_INIT as a function, expose it as hip_impl::hip_init()
so that it could be called from hipLaunchKernelGGL and other inlined
HIP functions

* Don't call hip_init from ihipPreLaunchKernel
2019-03-20 05:11:15 +00:00
Yaxun Sam Liu 55f4c416a0 Change HIP dll name to amdhip64.dll on Windows 2019-03-19 16:27:18 -04:00
Michael LIAO f42e84cef7 [Device Function] Fix typos. 2019-03-19 15:32:19 -04:00
Yaxun Sam Liu fb3241a000 Add declaration of symbol related API for VDI 2019-03-19 11:11:49 -04:00
Maneesh Gupta 6ced14e71c Merge pull request #969 from nicholasmalaya/patch-1
Update hip_faq.md
2019-03-19 18:42:05 +05:30
Maneesh Gupta e7453483e2 Merge pull request #965 from mhbliao/hliao/master/immarg
[Device Function] Support immediate argument.
2019-03-19 18:41:31 +05:30
Maneesh Gupta 1500eec5f7 Merge pull request #954 from mhbliao/master
[hip] Re-implement hipLaunchKernelGGL as macros.
2019-03-19 18:39:27 +05:30
Maneesh Gupta e44de376f7 hipExtMallocWithFlags implementation
Change-Id: Iee9e119796472200b2933d5e23be60813f33bc75
2019-03-19 11:59:22 +05:30
Nicholas Malaya b1ec4e0b5f Update hip_faq.md
Making more clear what this list details. In particular, this list is intended to indicate what items for each CUDA release is supported, and which are not.
2019-03-18 14:51:18 -05:00
Michael LIAO b74b4500c4 [Device Function] Support immediate argument.
- `immarg`, immediate argument, is enabled on all AMDGPU intrinsics.
  Revise device functions using these intrinsics with immediate
  arguments.
2019-03-15 12:38:04 -04:00
Maneesh Gupta 41bbd24185 Merge pull request #964 from eshcherb/roctracer-hip-frontend-190314
tracing callback layer update
2019-03-15 16:24:46 +05:30
Evgeny 2aa88a4505 tracing callback layer update 2019-03-14 22:43:52 -05:00
Maneesh Gupta e3726bbf90 Merge pull request #963 from gargrahul/add_module_get_global_test
Test hipModuleGetGlobal
2019-03-15 06:17:50 +05:30
Maneesh Gupta 23170f6af8 Merge pull request #958 from aaronenyeshi/cxxabi-mismatch-workaround
CXX11 ABI Mismatch Workaround
2019-03-15 06:15:46 +05:30
Rahul Garg 46346343af Test hipModuleGetGlobal 2019-03-15 04:08:03 +05:30
Rahul Garg af72cde0a1 Add 2D fallback to use copy kernel 2019-03-14 13:03:06 +05:30
Siu Chi Chan 739d43c5d8 remove visibility hidden attribute 2019-03-13 11:58:32 -04:00
Maneesh Gupta f14c695edb Merge pull request #957 from eshcherb/roctracer-hip-frontend-190311
adding memset32d
2019-03-12 10:58:56 +05:30
Evgeny 0586924ae6 adding memset32d 2019-03-11 21:28:27 -05:00
Siu Chi Chan 5044c9ba49 minor cleanup 2019-03-11 19:51:57 +00:00
Siu Chi Chan f54da9358b remove old style triple name 2019-03-11 19:51:51 +00:00
Siu Chi Chan 30053f6443 move triple_to_hsa_isa into the header 2019-03-11 19:51:44 +00:00
Siu Chi Chan fa564a5345 Fix memory leak introduced by previous change to Agent_global.
Make Agent_global manage the lifetime of the name string
2019-03-11 19:51:32 +00:00