Commit Graph

177 Commits

Author SHA1 Message Date
colramos-amd 4fb2f6e2b4 Update DB module for new sysinfo keys
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 706d3bb9f0]
2024-03-12 12:24:49 -05:00
Karl W Schulz 28f027c7bf move set_locale_encoding() to occur after logging is setup - allows
function to use console_error() directly (https://github.com/AMDResearch/omniperf/pull/308#discussion_r1519914083)

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: e85037fdfb]
2024-03-11 14:19:01 -05:00
Karl W. Schulz 6b0a36cb27 Update src/utils/utils.py
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>

[ROCm/rocprofiler-compute commit: 5e21dc35fd]
2024-03-11 14:19:01 -05:00
Karl W. Schulz d4015bd76b Update src/utils/db_connector.py
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>

[ROCm/rocprofiler-compute commit: ebc9108da0]
2024-03-11 14:19:01 -05:00
Karl W. Schulz ed8d923155 Update src/utils/db_connector.py
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>

[ROCm/rocprofiler-compute commit: 523639a7fd]
2024-03-11 14:19:01 -05:00
Karl W. Schulz f287aa0fc8 Update src/utils/utils.py
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>

[ROCm/rocprofiler-compute commit: 8e45cc897f]
2024-03-11 14:19:01 -05:00
Karl W Schulz 35a983b85a allow color formatter via env variable OMNIPERF_COLOR=1
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 34070394eb]
2024-03-11 14:19:01 -05:00
Karl W Schulz 9d7dde19b0 refactor setting of local encoding; remove from top-level omniperf
wrapper and push into base class via a companion utility function

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 27a57bdafb]
2024-03-11 14:19:01 -05:00
Karl W Schulz 2d84322ea1 update print_status() to use console logger; convert some info logs to debug logs
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 15c86ba424]
2024-03-11 14:19:01 -05:00
Karl W Schulz fdbc5565f3 rework of logger.py setup to introduce another setup_file_handler() -
this function enables file-based logger output for use with profile
mode

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 505e263279]
2024-03-11 14:19:01 -05:00
Karl W Schulz 917b784ead refactor logging initialization into two steps:
(1) setup_logging_handler -> called prior to arg parsing
(2) setup_logging_priority -> called after arg parsing

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: e24e6c35a5]
2024-03-11 14:19:01 -05:00
Karl W Schulz 975c2dad8b add quietmode option to setup_logging function
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: abd3d20cb2]
2024-03-11 14:19:01 -05:00
Karl W Schulz a9cda2ad33 add a exit keyword to console_error function; allows multiple error
lines prior to code exit

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 2b24375e8d]
2024-03-11 14:19:01 -05:00
Karl W Schulz 7756a5b00b updates for run_prof() routine:
* add a profileMode keyword option, used to indent profiling output

* update logic if forked process is not successful, output is
  displayed directly with INFO logging or lower; also dispaly output
  in ERROR mode if the process fails

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 377c642ac2]
2024-03-11 14:19:01 -05:00
Karl W Schulz ab3ce5ecb8 remove duplicate process output within run_prof()
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: dcdef37c34]
2024-03-11 14:19:01 -05:00
Karl W Schulz 89bc098c59 include ERROR delimiter directly for console_error() messsages
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 61267ee262]
2024-03-11 14:19:01 -05:00
Karl W Schulz a5e23e17fe add a profileMode option to capture_subprocess_output() - includes
indented output with profiler selection when enabled

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: cc7a725ae8]
2024-03-11 14:19:01 -05:00
Karl W Schulz 587d55cd9d minor refactor of print_status()
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 6bb4210d94]
2024-03-11 14:19:01 -05:00
Karl W Schulz b948aa6ebf add indent support to console_log()
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 63129e4247]
2024-03-11 14:19:01 -05:00
Karl W Schulz 16f580b992 update setup_logging function to return loglevel; disable inclusion of
loglevel delimiter in output

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: bdfc536ade]
2024-03-11 14:19:01 -05:00
colramos-amd 91434bcebf Fix dangling merge conflict
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 6c5a3623b6]
2024-03-11 14:19:01 -05:00
colramos-amd 98e5e16d0e Fix python formatting
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: f2aac37178]
2024-03-11 14:19:01 -05:00
colramos-amd 00c17f423c Replaced some straggling print statements with log functions
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 771644f5f7]
2024-03-11 14:19:01 -05:00
colramos-amd 569dff3627 Connect verbosity flag to loglevel
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 5ed9a5c902]
2024-03-11 14:19:01 -05:00
colramos-amd a1371462ba All logging should use call new functions
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 5bf38a4fed]
2024-03-11 14:19:01 -05:00
colramos-amd cfdf288cba Dedicated logging function for each log level
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 233905071c]
2024-03-11 14:19:01 -05:00
colramos-amd 39a9961060 Remove outdated remove_workload.py module
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 0611ce4582]
2024-03-11 14:19:01 -05:00
colramos-amd 15aac4690c Standalone logging module for cleaner omniperf_base.py
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 2e09f0be7e]
2024-03-11 14:19:01 -05:00
Cole Ramos 4585750893 Force encoding before Omniperf execution (#299)
* Force encoding before Omniperf execution

Signed-off-by: colramos-amd <colramos@amd.com>

* Fix circular dependency in utils module

Signed-off-by: colramos-amd <colramos@amd.com>

---------

Signed-off-by: colramos-amd <colramos@amd.com>

[ROCm/rocprofiler-compute commit: f4511e7280]
2024-03-06 17:01:07 -06:00
Jason Ray af6567ebdb bump statman-stopwatch to 2.18 (#220)
* Lock Pandas to version 1.4.3 for tutorial

Signed-off-by: colramos-amd <colramos@amd.com>

* Establish connection between kernel related flags in Analyze Mode (#187)

Signed-off-by: colramos-amd <colramos@amd.com>

* Fixing bug in kernel/dispatch filter pytest

Signed-off-by: colramos-amd <colramos@amd.com>

* More CI logic errors fixed

Signed-off-by: colramos-amd <colramos@amd.com>

* Update CHANGES

Signed-off-by: Cole Ramos <colramos@amd.com>

* Update CHANGES

Signed-off-by: Cole Ramos <colramos@amd.com>

* Update README.md

Signed-off-by: Cole Ramos <colramos@amd.com>

* bump statman-stopwatch to 2.18

Signed-off-by: Jason Ray <jayray.net@gmail.com>

* Fix merge mistakes

Signed-off-by: colramos-amd <colramos@amd.com>

---------

Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Jason Ray <jayray.net@gmail.com>
Co-authored-by: colramos-amd <colramos@amd.com>

[ROCm/rocprofiler-compute commit: 994aea9f0e]
2024-03-05 11:16:23 -06:00
colramos-amd 7a8bf7f720 Account for missing GRBM_GUI_ACTIVE in roof-only mode (#103)
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: a44e07d928]
2024-03-05 10:43:24 -06:00
Karl W Schulz 654295db20 apply formatter
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: f94da3228d]
2024-03-03 15:20:21 -06:00
colramos-amd ee3ba49168 Fix typo, patch issue in kernel filtering in standalone GUI, and error on version mismatch
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: ea9783f105]
2024-03-03 14:38:28 -06:00
Karl W Schulz 6d48d79572 apply formatter
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: ca59cbe3a3]
2024-03-02 12:28:34 -06:00
coleramos425 038dd3e27f Fix missing median values
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 7b8cf17254]
2024-03-01 18:00:17 -06:00
coleramos425 d7685d3412 Add custom decorator to avoid using kw_only
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: cdeb2c7e85]
2024-03-01 17:49:22 -06:00
coleramos425 5868974f74 CMake and Python format
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 1dc4553091]
2024-03-01 15:50:42 -06:00
coleramos425 9ebe1b804c Remove hardcoded gfx90a in gen_sysinfo util
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 1c3e7598a6]
2024-03-01 15:50:42 -06:00
coleramos425 a984ddc9b9 More formatting!
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: eaf701abf0]
2024-03-01 15:50:42 -06:00
colramos-amd 9ff07b51ff Python formatting
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: d6f45411eb]
2024-03-01 15:50:42 -06:00
Nicholas Curtis abefd57924 print version out of table
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>


[ROCm/rocprofiler-compute commit: 817774be5e]
2024-03-01 15:50:42 -06:00
Nick Curtis 52ead9ca06 Update src/utils/specs.py
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Nick Curtis <6463881+skyreflectedinmirrors@users.noreply.github.com>

[ROCm/rocprofiler-compute commit: 5b5d4c9a23]
2024-03-01 15:50:42 -06:00
Nicholas Curtis d28432de61 push missing rabulate through get_table_string
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>


[ROCm/rocprofiler-compute commit: de384467f5]
2024-03-01 15:50:42 -06:00
Nicholas Curtis dcb928b7c7 Re-implement machine-specs to contain documentation, units, etc. Print using tabulate
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>


[ROCm/rocprofiler-compute commit: 200961ffd9]
2024-03-01 15:50:42 -06:00
coleramos425 13154a0382 Re-enable multi kernel filtering
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 5ebd2dbc74]
2024-03-01 15:50:42 -06:00
Nicholas Curtis 5f48d2d30d fix for improper display of % of peak for instruction mix panel
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>


[ROCm/rocprofiler-compute commit: c10cc0ede2]
2024-03-01 15:50:42 -06:00
colramos-amd d0908cdc33 Add version to specs/sysinfo output in order to throw warning for new fields
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 3197553ca6]
2024-03-01 15:50:42 -06:00
colramos-amd a46885c5ec Added consistent 'Channel' headers to l2_per_chan, removed hardcoded 32 channels, and removed printed Nones (#276)
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 09f1455308]
2024-03-01 15:50:42 -06:00
colramos-amd 9b04e88046 Fix bug in GUI kernel filtering
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 0d516f05b4]
2024-03-01 15:50:42 -06:00
Nicholas Curtis 81c82c1c24 correct small negatives in remote read/write traffic due to running in different passes
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>


[ROCm/rocprofiler-compute commit: 20d93703fc]
2024-03-01 15:50:42 -06:00