AI/rocm-systems
2
0
Atdalīts 0
Kods Problēmas Izmaiņu pieprasījumi Darbības Pakotnes Projekti Laidieni Vikivietne Aktivitāte
6 772 Revīzijas 3 Atzari 0 Tagi
5fa035dbd41847beab2a42f00777cede6e2ac723
Revīziju grafs

6772 Revīzijas

This Branch
This Branch
Visi atzari
Autors SHA1 Ziņojums Datums
pghafari 5fa035dbd4 SWDEV-369551 - invalid stream check in hipMemcpy 
Change-Id: I6762af93cd566a38f7d04994b87a76e744b19043


[ROCm/clr commit: 76b0b4d635]
 2023-01-18 20:02:28 -05:00
pghafari de904d8716 SWDEV-374381 - updated error check 
for hipGraphAddMemcpyNodeFrom/ToSymbol

Change-Id: I4de063a5a9307148bf4da0e8a2edc1d3b01a8b9a


[ROCm/clr commit: d491ee7385]
 2023-01-18 19:59:32 -05:00
Anusha GodavarthySurya f681854310 SWDEV-376407 - Track manual nodes added during capture 
Change-Id: Ic44f842c303eed0eff08b6ee5922976d96a52c71


[ROCm/clr commit: d422ad0ec1]
 2023-01-18 03:27:41 -05:00
Anusha GodavarthySurya e333f99dec SWDEV-373173 - Handle kernel compilation WGP/cumode in occupancy calculation 
Change-Id: Id0225683a578c3275a35f8f807a57b6379746392


[ROCm/clr commit: ce8f441c14]
 2023-01-18 03:27:30 -05:00
Anusha GodavarthySurya a7a887ab05 SWDEV-373173 - Correct max VGPRs and VGPR Granularity in Occupancy calculation 
Change-Id: I36010f3991f809c61f0c4388b8daa8d3e9b8cc9d


[ROCm/clr commit: 27c5189bca]
 2023-01-18 03:27:21 -05:00
Maneesh Gupta a2a134968c SWDEV-1 - Use VERSION file instead of hipvars.pm for versioning 
Change-Id: I9974aec388c9a89f4ed79a974dea99ec1e8257b8


[ROCm/clr commit: e0516a6984]
 2023-01-18 02:39:12 -05:00
pghafari 5959057299 SWDEV-374361, SWDEV-374362, SWDEV-374364, SWDEV-374365 - error checking 
Change-Id: I0b729976ed794239fa54e1ad2965133b319d2f5d


[ROCm/clr commit: a9cbff0a49]
 2023-01-17 23:10:22 -05:00
sdashmiz 11f97823cd SWDEV-374374 - memset memory mapping should not change 
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I4cc3b1ac5a59fe5c9ae060f4d5d189dc63ca450c


[ROCm/clr commit: 52bf09aac6]
 2023-01-17 14:41:24 -05:00
German Andryeyev 36d240ff89 SWDEV-355281 - Use offset from FindMemObj 
Change-Id: I53ce2c1ef2e3a580b8b12312b693c2476f0885d2


[ROCm/clr commit: 39db0ec297]
 2023-01-17 10:01:49 -05:00
pghafari 829bbe4933 SWDEV-369570 - MaxSharedMemoryPerBloc check 
Change-Id: I74d216a5d9316758bb611eb241ba85222194ce8b


[ROCm/clr commit: 2e60edbe0e]
 2023-01-17 07:52:15 -05:00
pghafari 7261e8fa39 SWDEV-374380 - hipGraphAddMemcpyNode1D errorCheck 
Change-Id: I50501de139e3898783c1cc9c91c5ed3ed2564f3b


[ROCm/clr commit: 236a725d67]
 2023-01-17 07:49:23 -05:00
Satyanvesh Dittakavi f94a34e128 SWDEV-373231 - Support hip atomics header with HIPRTC 
Change-Id: Ic500dfb66ed5ef0c4b672dfd0595409d0e8caaf5


[ROCm/clr commit: 842b9d0b56]
 2023-01-17 00:31:07 -05:00
sdashmiz 42a08627ef SWDEV-360031 - check for stream capture finish. 
- stream capture should be done before any sync APIs.

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I3d65f67ee68777be71f97f48d460ccaefdd4e1af


[ROCm/clr commit: be966acb0c]
 2023-01-16 13:09:24 -05:00
sdashmiz 4f74c83b94 SWDEV-374390 - add correct error 
- null stream should return error on host function

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I17659ad7af0814091dbf6cb4a2cb2644514551f0


[ROCm/clr commit: 338307ef2c]
 2023-01-16 13:08:23 -05:00
Jaydeep Patel d74f646173 SWDEV-374360 - Handle free for external memory. 
Change-Id: Ibfaf30eef371499a3c1f931a73cce76c83d8f7f3


[ROCm/clr commit: 7eecbdd9db]
 2023-01-16 13:07:01 -05:00
Jaydeep Patel ffcff763d2 SWDEV-375366 - SWDEV-375351 - Handle HtoH case for graph mem cpy impl. 
Change-Id: I5a8c3c3c22db045f714b0443b8d70a8c6b4a8cea


[ROCm/clr commit: fdecc1b351]
 2023-01-16 11:37:57 -05:00
Jaydeep Patel c9fa0aad8b SWDEV-369961 - Add mappings for enum hipGraphInstantiateFlags and types. 
Change-Id: I03fa8221684b08a0c44e12aaf2eb7ce5281be629


[ROCm/clr commit: 8bd45ae5da]
 2023-01-15 12:17:21 +00:00
Ioannis Assiouras 1974ef22cf SWDEV-374403 - Added input sanity checks for hipLaunchCooperativeKernelMultiDevice and hipExtLaunchMultiKernelMultiDevice 
Change-Id: Iebef5ae68439d87549fdf9559de51c6c79c64392


[ROCm/clr commit: 0d2e0d1621]
 2023-01-13 19:48:42 -05:00
Matt Arsenault 967ad97993 SWDEV-1 - Use proper builtin for groupstaticsize 
Remove the now empty header for asm intrinsic wrappers.

Change-Id: I63495dc6ed899b1ea823062f2be2fb064af8d4f9


[ROCm/clr commit: 8615a89f24]
 2023-01-13 13:14:10 -05:00
German Andryeyev 9c811dc241 SWDEV-353281 - Initial support of memalloc in graph 
Add memory allocation support in graph. Current implementation uses
cache from mempool  to hold the allocations which belong to the graph.
Also the resource tracking is disabled at this moment because mempool
operates with hip::Stream objects, but graph has execution with
amd::HostQueue objects.

Change-Id: I54fe3250126d24f5a26ada975f37d429bb4ef17b


[ROCm/clr commit: eef47ca24a]
 2023-01-13 13:06:59 -05:00
Satyanvesh Dittakavi 1087f13ee1 SWDEV-369552 - SWDEV-369553 - SWDEV-369555 - Fix hipMemAdvise 
- API should return error if the size passed is more than the
bytes allocated
- Passing invalid device should return error except for the
advise hipMemAdviseSetReadMostly

Change-Id: I1c4c15136b825215bf1e1f5ee7a9a08e5895d870


[ROCm/clr commit: 873bc03034]
 2023-01-13 12:53:31 -05:00
Rakesh Roy 9045dbab4b SWDEV-374369 - Fix hipGraphAdd*Node* APIs invalid behavior 
- Return hipErrorInvalidValue if dependencies array contains a node from
  different graph

Change-Id: I0dcfaaaeb50a89848ac546a0b86b185977e2128c


[ROCm/clr commit: a427d3cd10]
 2023-01-13 12:09:42 -05:00
AravindanC 61f59d2285 SWDEV-352878 - Remove CLANG include dependencies 
Change-Id: I46bba0fdf21a3541e08ff0c465ff076d478094f9


[ROCm/clr commit: 2228383fcb]
 2023-01-13 07:41:10 -08:00
Satyanvesh Dittakavi 6035b0e214 SWDEV-376386 - Support __hip_move_dpp with hipRTC 
Change-Id: If9a6fe23d6df143a7f522823fca7183416048c6a


[ROCm/clr commit: c193503722]
 2023-01-13 00:05:31 -05:00
Anusha GodavarthySurya 57d351bed6 SWDEV-364576 - use hipLimitMallocHeapSize to set initial heap buffer size 
Change-Id: I2f1d3b229bc28571ce6c55f93f8ef73dda516b50


[ROCm/clr commit: 33eef6d95e]
 2023-01-12 23:34:29 -05:00
Matt Arsenault 1de57c06b3 SWDEV-1 - Directly call __builtin_amdgcn_fence 
The device libraries provide hip.bc, which only contains
__atomic_work_item_fence. This is identical to OpenCL's
atomic_work_item_fence, except prefixed with __. This only existed to
switch over the unknown values the OpenCL function provides. There's
no need to go through the wrapper here since it's using constant
values, and without it we can drop one of the bitcode libraries. I'm
guessing this was a holdover from before the fence builtin existed.

Change-Id: I8b04614f96194eafddeba295215c12c3856e6c42


[ROCm/clr commit: 3e54bad5b3]
 2023-01-12 12:04:09 -05:00
Matt Arsenault ac1201f598 SWDEV-1 - Remove unused intrinsic declaration 
The uses have moved to using the proper __builtin_amdgcn_ds_swizzle.

Change-Id: I82159ebf41fb91ac6a9d07b33311e569dce5e754


[ROCm/clr commit: 91b851fad7]
 2023-01-12 12:04:09 -05:00
Ioannis Assiouras bfa0b9f844 SWDEV-374405 - Added OpenGL interoperability APIs for nvidia 
Change-Id: I1d6ad5c610ab6ee805bd07dacea316b3242ed129


[ROCm/clr commit: e97dcfbe48]
 2023-01-12 05:22:14 -05:00
Jaydeep Patel d12bfbbb4d SWDEV-374383 - Check from and to if no of dependencies are more than 0, Check from and to node are belongs to graph pass in. 
Change-Id: I0cdafb497147f9ac7f84d40203a21e9eefd595a3


[ROCm/clr commit: bb486b04c6]
 2023-01-11 11:43:22 -05:00
Rakesh Roy 87db95fad7 SWDEV-368881 - Implement hipModuleLaunchCooperative* APIs 
- Add implementation for hipModuleLaunchCooperativeKernel, hipModuleLaunchCooperativeKernelMultiDevice APIs

Change-Id: I2a80264e458549211c34b413397a08b57d021147


[ROCm/clr commit: b321e2afc6]
 2023-01-10 13:50:20 -05:00
Ajay 433f99686b SWDEV-369556 - Unit_hipMemGetAddressRange_Negative cases 
- return value for invalid device ptr
- offset greater than size

Change-Id: I8bcf878c3c1c0a29836ea664bfb9048e1114b74e


[ROCm/clr commit: c6a7ce66bb]
 2023-01-10 06:57:54 -05:00
Maneesh Gupta 4f5f6a3696 SWDEV-345571 - Revert changes for warp shuffle functions 
This reverts commit 609598cd15 and 149afa9444.

Change-Id: I548f15055417453a7fd323a481ed410598830521


[ROCm/clr commit: 6c53a670c1]
 2023-01-09 22:56:52 -05:00
Jiabao Xie 3ab54974dc SWDEV-374375 - moving nullptr check into hipGraphNode::isValidNode 
Change-Id: Ic9264521d6f0b36ffc948ca9feeaa70eb6e98eb6


[ROCm/clr commit: 03200953e5]
 2023-01-09 16:27:38 -05:00
Jacob Lambert 507c87da5f SWDEV-356171 - Adding support for name lowering for bitcodes (-fgpu-rdc) via 
Comgr mangled name fetching APIs

Change-Id: I10ce2b1288c459e3e61218d68a270aba2148376e


[ROCm/clr commit: 7dd54c746e]
 2023-01-09 14:49:51 -05:00
kjayapra-amd 5057429e7a SWDEV-361374 - Adding support for hipPointerSetAttributes 
Change-Id: I56710b808854acefca07b3b5898deebee38063e9


[ROCm/clr commit: 0c8c08cf51]
 2023-01-09 12:36:57 -05:00
Juan Manuel MARTINEZ CAAMAÑO 8de9ca0382 SWDEV-290637 - Specify a working directory when calling hip_embed_pch.sh 
Consider the case where cmake is invoked as follows:

    cd <parent_dir>
    cmake -S<source_dir> -B<build_dir> ...

  If `WORKING_DIRECTORY` parameter is not specified in `execute_command`,
  `hip_pch.o` is created outside `<build_dir>`, in `<parent_dir>/hip_pch.o`.

Change-Id: I751f4390628315ad70c36148e09824c19c93ae9e


[ROCm/clr commit: c391af49dc]
 2023-01-09 03:17:07 -05:00
German 3afbe3a155 SWDEV-372757 - Don't destroy null queue in MT 
Skip destruction of the null queue for MT. Windows can destroy worker
thread on exit during the stream destruction, causing a race condition.

Change-Id: I3e4bc3ab2b477d38c0aec1fc59e6f1af0f8f6b0f


[ROCm/clr commit: f39655c0c8]
 2023-01-09 00:03:09 -05:00
Jaydeep Patel 149afa9444 SWDEV-375137 - Bypass defination of half and half2 alias for internal include of hip_fp16.h 
Change-Id: I5258a487d4c2d93e889a523fde81f1b3906d9318


[ROCm/clr commit: 695533d435]
 2023-01-06 21:34:51 -05:00
Jiabao Xie 078f931d73 SWDEV-374375 - Added checks to see if hip graph nodes are valid 
Change-Id: I9e6eabf0e4a9100de6f9d26bf5b815957f12d4f2


[ROCm/clr commit: e5490697cc]
 2023-01-06 16:58:56 -05:00
pghafari 24be73637f SWDEV-375135 - adding error string 
Change-Id: I73276462627a47d405c8439d8a843ac266fc5d38


[ROCm/clr commit: 7615fba2d5]
 2023-01-06 16:31:35 -05:00
pghafari bb765cafaf SWDEV-369042 - updating to GetError to match cuda 
Change-Id: I0ec2330443b26cb1c8cedba942f31fb1267cd09d


[ROCm/clr commit: 335a24d1a0]
 2023-01-06 05:33:41 -05:00
Juan Manuel MARTINEZ CAAMAÑO f91da83d6a SWDEV-290384 - Missing hiprtcResult case in hiprtcGetErrorString 
Change-Id: I11d18ff19f6f6f1b36febf87a586bc9ffb95af10


[ROCm/clr commit: 537df06c4f]
 2023-01-06 03:38:44 -05:00
Satyanvesh Dittakavi 54c5fa36d8 SWDEV-375020 - Revert "SWDEV-370552 - Improve hiprtc performance by passing the right flags to comgr" 
This reverts commit 96d28fd15d.

Reason: Adding "-Xclang" and "-disable-llvm-passes" in hiprtc
compilation seem to cause perf issues and memory fault in few apps.

Change-Id: I12ff46293c7b7afb24d570351736d884d2881b77


[ROCm/clr commit: 516acd4e60]
 2023-01-06 00:09:06 -05:00
Ajay 01f4d7eac3 SWDEV-369618 - hipOccupancyMaxPotentialBlockSizeVariableSMemWithFlags invalid flag scenario 
Change-Id: I07df2640be71a6b0aed160d54e80ffdeb85ec554


[ROCm/clr commit: 3e4ed8d917]
 2023-01-05 23:40:29 -05:00
Jaydeep Patel f9574cd645 SWDEV-374372 - Return invalid value if pitch is less than width in bytes. 
Change-Id: I33806d747cd344250d02e217de8e9b6d5a7f83c1


[ROCm/clr commit: 7c32f66e67]
 2023-01-05 10:40:14 -05:00
Jaydeep Patel f6a5cd9e33 SWDEV-374373 - Occupied size should be within range. 
Change-Id: I20e24c628c51154c2f8f36dca0a6fa4ead1ee6d0


[ROCm/clr commit: 67792dd858]
 2023-01-05 08:02:20 -05:00
Anusha GodavarthySurya 7f56e0e09c SWDEV-373173 - Correct max VGPRs and VGPR Granularity in Occupancy calculation for different asics 
Change-Id: Ib213ed8767a793a832776fba7c0811c2f023a8ad


[ROCm/clr commit: 067c7316ba]
 2023-01-04 01:34:40 -05:00
German Andryeyev d8f1606489 SWDEV-360031 - Erase destroyed stream from capture 
Parallel streams can be destroyed during capture. Make sure runtime
removes the destoryed streams from the list of parallel captured streams

Change-Id: I46b6cbb951e8711f0bf02f2826c3b890b2541ffe


[ROCm/clr commit: 38ad6234f9]
 2023-01-03 13:34:07 -05:00
Satyanvesh Dittakavi 47167d7e7a SWDEV-374371 - hipGraphAddMemsetNode should return error if width is 0 
Change-Id: I1cd4be271f65c9cade8dddb6d00191e1b74c96bc


[ROCm/clr commit: 409f23d905]
 2023-01-03 10:29:16 -05:00
sdashmiz 09a1db7005 SWDEV-370309 - GetNodes should do levelorder 
- GetNode should retrun nodes based on the dependency between them

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ie8ecdd976f8dc9d9b5dc2adc6ae8f879912c8169


[ROCm/clr commit: ce60d47b61]
 2023-01-03 04:54:55 -05:00