Marker events inside hcc_ops_trace.txt are from barriers so they are not meant to be stored in ops_patch_data map.
Added support for hipMemset events which are a kind of memory copy.
Change-Id: I213fe959bcd35ff0371613ba5bffd95bc53e06b5
[ROCm/rocprofiler commit: caa5f32300]
recordid cannot be just a counter. The code removed was doing
just that i.e. incrementing a counter. Recordid has to come
from recvals data structure. That code was left there since
a while when Evgeny and Rachida were trying to prototype this feature.
I am not sure why it was not spotted before.
Change-Id: Ia867066dcfca083fcd4111f2aefc2fec88c26314
[ROCm/rocprofiler commit: 4ba91a972c]
1st issue was that one of the ostream ops failed to print the
content of the struct.
2nd issue: get_ptr_type was called with args being src/dest
pointers while it should be the agents pointers for src/dest.
3rd issue: memcopies map used (recordid, procid, is_async)
as a key but this is not enough as some copies share same key,
so I added begin/end timestamps as a way to distinguish between them.
Change-Id: I7c6e80e74e30ea572f21612aaf0cf7efec6e91e6
[ROCm/rocprofiler commit: 761bd6a86b]
All packages should have a valid email for contact.
SWDEV-257322
Change-Id: I49107ff44b9aaf13ec6a20319a420146f6443907
[ROCm/rocprofiler commit: c684d61de8]
All packages should have a valid email for contact.
SWDEV-257328
Change-Id: I03ceefc46cf8da4486e19b1001abd4cd8cbcb3c5
[ROCm/rocprofiler commit: 71ce3fa617]
Add numa lib as this will be required with a static thunk
Look for static thunk of shared thunk cannot be found
Signed-off-by: Kent Russell <kent.russell@amd.com>
Change-Id: Idcaa0c785a0502c9f5fe42e2dfb9e0c1780f9d66
[ROCm/rocprofiler commit: 97c9efce38]
On Ubuntu 20.04, in Release mode, gcc fails with this error:
In file included from /usr/include/string.h:495,
from /opt/rocm/include/hsa/hsa_api_trace.h:57,
from ../rocprofiler/src/util/hsa_rsrc_factory.h:29,
from ../rocprofiler/src/util/hsa_rsrc_factory.cpp:25:
In function ‘char* strncpy(char*, const char*, size_t)’,
inlined from ‘const util::AgentInfo* util::HsaRsrcFactory::AddAgentInfo(hsa_agent_t)’ at ../rocprofiler/src/util/hsa_rsrc_factory.cpp:323:12:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:34: error: ‘char* __builtin___strncpy_chk(char*, const char*, long unsigned int, long unsigned int)’ specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
| ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../rocprofiler/src/util/hsa_rsrc_factory.cpp: In member function ‘const util::AgentInfo* util::HsaRsrcFactory::AddAgentInfo(hsa_agent_t)’:
../rocprofiler/src/util/hsa_rsrc_factory.cpp:322:39: note: length computed here
322 | const int gfxip_label_len = strlen(agent_info->name) - 2;
| ~~~~~~^~~~~~~~~~~~~~~~~~
The error is caused by the following 2 lines:
const int gfxip_label_len = strlen(agent_info->name) - 2;
strncpy(agent_info->gfxip, agent_info->name, gfxip_label_len);
The size argument to strncpy should not depend on the input string.
Since the terminating character is not considered (the copy is at
most len - 2 bytes), using memcpy is preferable. Also, make sure
the destination does not overflow by clamping the size.
Change-Id: I0c5cf7e0daf4cd6fcf7092efb1d9fd4c02a6c639
[ROCm/rocprofiler commit: 304d3366af]
Still needs valid email ID in the form of package_name.support@amd.com.
SWDEV-257328
Names as built (internal):
rocprofiler-dev_1.0.0.31000-crdnnv.437_amd64.deb
rocprofiler-dev-1.0.0.31000-crdnnv.436.el7.x86_64.rpm
Change-Id: Id90ce9c92dcc1655ddd04402af929f64f6d5a360
Signed-off-by: Cole Nelson <cole.nelson@amd.com>
(cherry picked from commit 8286d1a6de4b58a2c06048a5bcb865dc4ad819da)
[ROCm/rocprofiler commit: 76c1882653]
rachida
AMD
Ashutosh Misra
Laurent Morichetti
Chun Yang
Freddy Paul
Kent Russell
Evgeny
Cole Nelson