Commit gráf

6477 Commit-ok

Szerző SHA1 Üzenet Dátum
Rakesh Roy 62069a5ae8 SWDEV-342007 - Fix hipArray Allocation APIs
- Capture error status of ihipImageCreate
- Return hipErrorOutOfMemory when image creation fails

Change-Id: If127a515447cc362d55fccd3eae304271da252d5
2022-06-30 00:28:47 -04:00
Christophe Paquot bf5826ee93 SWDEV-322620 - Virtual Memory Management
Use correct granularity for VM address/size

Change-Id: I001f29eabe9503396bbec623df9d5155b882be4f
2022-06-29 15:59:56 -07:00
Saleel Kudchadker cf07633dc8 SWDEV-301667 - Early return if src == dst for 1D copy
Change-Id: Icaa334c6579bb5e70e92347f8bc37edcf5adf796
2022-06-28 14:21:40 -04:00
Ajay 8d1bd607f9 SWDEV-337331 - Windows: DD=0 graph child Node fixes
Change-Id: Icd7fc3967a202946d3428eba99a1bbf43b9772db
2022-06-28 11:57:11 -04:00
Sarbojit Sarkar 5bd8f8dbe6 SWDEV-341174 - fixed warning on cuda
Change-Id: I5d017bcc154a2985e23893c0d933438bf0fc1958
2022-06-27 04:49:53 -04:00
Sarbojit Sarkar 4b9ea686f6 SWDEV-342831 - Fix hipGetDeviceCount return
Change-Id: I3b0338a51027258319c1926ac02de8d0af01d498
2022-06-27 00:39:08 -04:00
Sarbojit Sarkar 1074b22c48 SWDEV-333073 - HIP_INIT_API to handle no return case
Change-Id: I78d43e88cc196047a4cb5d6fcf756339c0e46e80
2022-06-24 12:53:18 -04:00
Satyanvesh Dittakavi c6647487e0 SWDEV-336538 - Return hipErrorNotSupported for unsupported APIs
Change-Id: Ie54771c2f58eebacdc0248bc116ef093f99eb9b8
2022-06-23 07:31:31 -04:00
Ajay 2962d2ecf1 SWDEV-342542 - Support hipGetStreamDeviceId on Windows
Change-Id: I3f79fb4f3058cd7335c5ca2363cf1659a0a7f6ad
2022-06-22 12:18:03 -04:00
Satyanvesh Dittakavi b263ab3248 SWDEV-341360 - Handle named expressions with space in hipRTC
Change-Id: I1c26855d8a94e0a4d818664ca71094c6992221c9
2022-06-22 14:19:16 +00:00
sdashmiz 683b28d573 SWDEV-341993 - correct parameters checks
flags, ptr and stream

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I306be503e8c15db1641eaeeae73e349a99f871ae
2022-06-22 04:22:55 -04:00
kjayapra-amd 2731d03f03 SWDEV-339995 - Adding hiprtcGetBitcode and hiprtcBitcodeSize changes.
Change-Id: I378f1ac98de3b11fa3f74161abd036702c7b479b
2022-06-22 04:17:56 -04:00
Satyanvesh Dittakavi a39ab85e04 SWDEV-340226 - hiprtcLinkAddData should allow empty name
Change-Id: I2c9a53453223ee4899b0a5d05e1097bc7e0e428e
2022-06-22 04:15:32 -04:00
Rakesh Roy 21d7f35c84 SWDEV-342025 - Fix hipEventCreateWithFlags API
- Return hipErrorInvalidValue if hipEventInterprocess flag is set, but hipEventDisableTiming flag isn't set

Change-Id: Ifbb9d83b018c360f312083bb25dba1187bcdaefa
2022-06-21 10:59:17 -04:00
kjayapra-amd 5d385fa0e2 SWDEV-340226 - Fixing conversion to void* from size_t instead of size_t*.
Change-Id: Ib7e083395d4fbbe2a6f3012fce5b268e108ad62a
2022-06-21 06:28:06 -04:00
Sarbojit Sarkar 7f92a98a3c SWDEV-331066- Added hipDeviceSetLimit
Change-Id: I4de099387ad34ca7c195588274b546649038e2aa
2022-06-21 06:06:05 +00:00
Jaydeep 26d8603bf3 SWDEV-332607 - If pitch returned from hipMallocPitch is equal to pitch passed to hipMemset2D then height passed to hipMemset2D must be less than or equal to height passed to hipMallocPitch.
Change-Id: I5f9eb55cede5dff5a9e428d41fe081f043df7049
2022-06-21 00:10:19 -04:00
Maneesh Gupta 2bd0cb523e SWDEV-340918 - make hip_runtime.h work with g++
Change-Id: Ief3e6dc075837dfccae3defad7da696130ed05bd
2022-06-20 23:32:58 -04:00
Sourabh Betigeri 5ad38a32bf SWDEV-342067 - Fixes a minor coding error to loop through all the entries in the map
Change-Id: I837cb4868de2acd3e71ca9a745a62ed0bb2d1400
2022-06-20 19:20:38 -04:00
Ajay 7b38ee1574 SWDEV-334340 - clang_rt.lib not to search in default path
Change-Id: Idf493477bbf8ddde4b7754f64f44c9c5aea008a2
2022-06-19 22:54:03 -04:00
Jaydeep 1032581ded SWDEV-336548 - Check for valid hipArray pointer in hipFreeArray
Change-Id: Icf0d47eeca7b5dd390a6a9c53b622b3680688ca4
2022-06-18 00:56:33 -04:00
Sourabh Betigeri 3ca4c7edf7 SWDEV-341994 - Fixes to returns the right error code to match CUDA spec for hipHostUnregister()
Change-Id: Ied9b5a15e841d4c201042d116b0ed535f07c17fc
2022-06-17 12:16:52 -04:00
Jaydeep 0ad84364e0 SWDEV-336542 - Return InvalidValue error for hipArrayCubemap flag.
Change-Id: I4ca996d7643158d5ccf8cb48ceaead3ceaf9aedf
2022-06-17 00:25:18 -04:00
jaypatel 8d464a2e83 SWDEV-322688 - Added hip math constants header.
Change-Id: I9363f82159a53c6822e943c4950fc7f6c350b326
2022-06-16 23:56:45 -04:00
kjayapra-amd 5e61b9e762 SWDEV-340226 - Fixing minor issues related to hiprtc Link API changes.
Change-Id: I18e7ca2a467ccf14d95ffb37b5516dda74f98cf7
2022-06-16 06:06:38 -07:00
Satyanvesh Dittakavi bf4cf3c369 SWDEV-327563 - Fix the hip runtime library name to load in hiprtc on Windows
Change-Id: Ib4988dd8677da907bec8e59b1b4ce3e57aad2bb7
2022-06-16 00:45:43 -04:00
Satyanvesh Dittakavi f7d0850eb8 SWDEV-336532 - Convert Managed Memory in hipPointerGetAttributes on Nvidia platform
Change-Id: I3bc6180040b6ad48f06ffdc7d01ca6fd9fe32c0e
2022-06-16 00:43:15 -04:00
Jaydeep Patel ab8583b4d5 SWDEV-338376 - Added hipMemGetAllocationGranularity, hipMemCreate and hipMemRelease for CUDA
Change-Id: If8c6a00958bb39752eb202c30a7960d13de225ae
2022-06-15 23:59:56 -04:00
Ranjith Ramakrishnan 8f8367fd49 SWDEV-335990 - Use GNUInstallDirs
GNUInstallDirs is used to allow the user to customize the install paths
of HIP, rather than using hardcoded locations.
Minimum cmake version updated to 3.16.8

Depends-On: I521c44dc34404b136141682c2777257b23ffa6e8
Change-Id: I2cff642c469d6d1e8bb3f1a3c151e6a03fb5d55b
2022-06-15 23:49:54 -04:00
Jaydeep Patel a527c241a2 SWDEV-333581 - Pass free and/or total size_t as nullptr.
Change-Id: Ib83467a351b6df22ef641c0e82284c7e0fac32e3
2022-06-15 23:46:34 -04:00
sdashmiz e8194dca76 SWDEV-325711 - add Graph memory APIs skeleton
- hipDeviceGet/SetGraphMemAttr

- hipDeviceGraphMemTrim

- there is no memory pool for graphs currently

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I11db76ea7ea1c7732175fc93264448052357e8dc
2022-06-15 14:47:16 -04:00
Sourabh Betigeri c3db564e94 SWDEV-331301 - Fixes to return error if the childGraph topologies of instantiated childGraphNode and to-be updated childGraphNode do not match
Change-Id: I372317a4df13e5cd352f46525d820246fe4ca8f2
2022-06-15 13:39:15 -04:00
Jeremy Newton 112b6370a5 SWDEV-335990 - Use GNUInstallDirs
This is attempt two of bf4df229c9

GNUInstallDirs is used to allow the user to customize the install paths
of HIP, rather than using hardcoded locations.

See documentation for more information:
https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html

Note that libdir must be overriden to "lib" before including
GNUInstallDirs, because by default, cmake tries to detect the libdir
path, but ROCm packaging would like to use lib by default for all
targets. This does not stop the user (or distros) from overriding.

Also note this change does no take into account the changes needed to
non-cmake files, such as perl scripts, so not all paths combinations are
necessarily functional.

Signed-off-by: Jeremy Newton <Jeremy.Newton@amd.com>
Change-Id: I521c44dc34404b136141682c2777257b23ffa6e8
2022-06-15 13:14:47 -04:00
Saleel Kudchadker 1cea2c0412 SWDEV-335780 - Revert commit
This reverts commit f6e21144ae.

Change-Id: I589d495b448a5ecc7def9dbca3f70b033a962f45
2022-06-14 19:08:22 -04:00
Sourabh Betigeri 5549c8cd1b SWDEV-318237 SWDEV-330173 - Fixes kernel parameter corruption when multiple nodes of the same kernelNode exist
Change-Id: I6437593be46b7b5afc3d77cdd887ad4139978ad3
2022-06-14 18:06:21 -04:00
haoyuan2 cfe1efd6b0 SWDEV-338564 - fix test hang issue
only check task finish with valid queue

Change-Id: Ib2bd1360235a07f825a09c57453ccbff7951f17f
2022-06-14 15:34:30 -04:00
Sourabh Betigeri 2f9e92757c SWDEV-340453 - Fixes coding error. Missing condition in a negative scenario
Change-Id: Ic4b71e143ec883ca73a2511a367ac034444ec7de
2022-06-14 12:24:10 -04:00
sdashmiz 13c875eaf0 SWDEV-321698 - remove Memcpy1D type
- Memcpy1D node type is not complying with cuda

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: If8113f5e699de0c62d98effc4580a2e0fee9a950
2022-06-13 08:31:02 -04:00
Christophe Paquot faa7ee48ba SWDEV-322620 - Virtual Memory Management
Implements hipMemRetainAllocationHandle
HIP layer updates the svmPtr of the amd::memory
ROCCLR just manages the MemObjMap
This is because HIP knows the orignal (generic) address of the
physical memory whereas ROCCLR doesn't keep track of that

Change-Id: Ied26d7f814bc468f5cf586c967020737b9aa9e9f
2022-06-10 17:48:07 -04:00
agunashe 9e7b44511a SWDEV-337331 - Windows graph fixes iteration2
API fixed hipGraphAddDependencies

Change-Id: I1248c00d788c392c71e64c5070fe09653125bb34
2022-06-10 16:42:54 -04:00
sdashmiz 8d93ff521f SWDEV-334857 - hipModuleGetTexRef compatibilty issue
- make the defualt texref value compatible with cuda

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I2ae980e435f3b0fc15b237741e3f2b97c4257e12
2022-06-10 15:13:29 -04:00
Ajay de026633c0 SWDEV-327563 - support hipStreamWrite32/64 and hipStreamWait32/64 funcs
Windows complains about undefined symbol for
hipStreamWrite32/64 and hipStreamWait32/64 -
commit hash 08435a972b

Change-Id: I48b9a6591cab3a05baaedbc26030914dd930fb68
2022-06-09 20:59:46 -04:00
Ajay c06bfa6bef SWDEV-337331 - graph feature on Windows
Fixes for hipGraphInstantiate OutofMemory issue and
soft hang of hipStreamSynchronize.
Change-Id: Ic2bb97582c5978ef2e4eb3a1b124483aa412838e
2022-06-09 12:04:51 -04:00
sdashmiz efd2d55e9d SWDEV-318833 - Get and Set attribute for kernel nodes
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ie51aa4b56661cbb8c5b4eb1dbaad327377084ffb
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
2022-06-09 09:47:05 -04:00
Aakash Sudhanwa 43c650cf48 Revert "SWDEV-335990 - Use GNUInstallDirs"
This reverts commit bf4df229c9.

Reason for revert: <Breaking all the staging builds. this is breaking components which are using find_package(HIP)>

Change-Id: Ic7340fb461a5efdd170a0988731e0885538a11d6
2022-06-07 18:18:06 -04:00
Satyanvesh Dittakavi 3bdc72d6ca SWDEV-327030 - Fix incorrect checks to find components in CMake
Change-Id: Ib7b9bd82255af897a0f82bba8049c7d41379ae96
2022-06-07 04:41:52 -04:00
Jeremy Newton bf4df229c9 SWDEV-335990 - Use GNUInstallDirs
GNUInstallDirs is used to allow the user to customize the install paths
of HIP, rather than using hardcoded locations.

See documentation for more information:
https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html

Note that libdir must be overriden to "lib" before including
GNUInstallDirs, because by default, cmake tries to detect the libdir
path, but ROCm packaging would like to use lib by default for all
targets. This does not stop the user (or distros) from overriding.

Also note this change does no take into account the changes needed to
non-cmake files, such as perl scripts, so not all paths combinations are
necessarily functional.

Signed-off-by: Jeremy Newton <Jeremy.Newton@amd.com>
Change-Id: Iae80f47c47ea0a74fc1c221b6eea82b557601394
2022-06-06 23:43:05 -04:00
Rakesh Roy e2874d5e22 SWDEV-337776 - Fix hipStreamEndCapture API
- Return hipErrorInvalidValue when pGraph is nullptr

Change-Id: I8846f4448eb15117f98421632885330f132c4fce
2022-06-01 00:20:23 -04:00
Sourabh Betigeri 5a057af564 SWDEV-320640 - Fixes to return right error codes in hipStreamUpdateCaptureDependencies() for negative scenarios
Change-Id: I3c4c54f8955fa9bb17eb595544005fe9f0e8a5f0
2022-05-31 14:09:22 -04:00
pghafari 8e28413a9e SWDEV-337703 - nullptr check for hipMallocArray
Change-Id: I3b1077e236ccda346d337109014ef7fd2e693ec6
2022-05-31 11:19:59 -04:00