Commit Graph

5775 Commits

Author SHA1 Message Date
Rupam Chetia 656a2cb556 [dtest] Tests added for V3 and V4 Code Objects with Static Lds
- Added test for V3 Static Lds code object with sramecc/xnack settings.
- Added test for V4 Static Lds code object.

SWDEV-238517 for enhancing hip unit tests

Change-Id: Ibc4f7e12033dec231d6834ccdd983e3b9e001d60
2021-01-07 23:19:02 -05:00
Jatin Chaudhary 9e35810188 Populate HIP_CLANG_PATH if its not declared
Change-Id: Ibc1f2e9b3389b6cc7a58579cfb293999ad6e9398
2021-01-07 04:15:42 -05:00
Payam 1f9fd14a57 Cleaning lintian warning SWDEV-247996 Part3
Change-Id: I62e5bfc5f17eee12a7a0cfe8ed6fbc35c43ff8c3
2021-01-06 11:56:11 -05:00
agodavar 6838df46eb SWDEV-245381: Updated guarantee error messages to print based on BUILD_TYPE
Change-Id: Ifafbc075d6b9860da040c72859127c4e638a786f
2021-01-05 23:29:50 -05:00
DURGESH KROTTAPALLI 7e6d748f26 [dtest] Tests for hipMemcpy2D and hipMemcpy2DAsync APIs
Added following functional and negative scenario tests
for hipMemcpy2D and hipMemcpy2DAsync APIs
 1. Verifying D2H and H2D functionality
 2. Verifying D2D on same device and peer device
 3. Verifying using pinned host memory on same and peer GPU
 4. Negative test scenarios
 5. Verifying hipMemcpy2DAsync API along with kernel launch

SWDEV-238517  Enhancing hip unit tests

Change-Id: I8f447bc7f6bf13cb895f1809f5a2b501baa8782c
2021-01-05 23:23:09 -05:00
Tao Sang 8a2b0b7424 Remove hip-hcc codes: Part three
1.Rename include/hip/hcc_detail/ as include/hip/amd_detail/

2.Rename include/hip/nvcc_detail/ as include/hip/nvidia_detail/

3.Create __HIP_PLATFORM_AMD__ to replace __HIP_PLATFORM_HCC__

4.Create __HIP_PLATFORM_NVIDIA__ to replace __HIP_PLATFORM_NVCC__

After hcc_detail, nvcc_detail, __HIP_PLATFORM_HCC__ and __HIP_PLATFORM_NVCC__
have been removed from upstream, they will be removed from hip runtime.

Change-Id: I1ae457effd739d6c25bca203c1724b026be21fce
2021-01-05 10:39:31 -05:00
sumanthtg 2624a5654c [dtest] Tests for hipMemset3D/hipMemset3DAsync APIs
Negative, Functional and Regression scenarios for
 - hipMemset3D
 - hipMemset3DAsync

SWDEV-238517 for enhancing hip unit tests

Change-Id: Idc5604f728ca1a96ec13876e006120f7a3d69acf
2021-01-05 07:00:48 -05:00
Satyanvesh Dittakavi 15baf7ef6d SWDEV-263678 - fix rocHPCG mgpu perf drop
Change-Id: I33269fe4f6165d1ed172b19033ab9fcb92f338c3
2021-01-05 00:22:12 -05:00
cjatin 6faffdffd2 Add ELF Flags moved from rocclr
Change-Id: I5febe7bdca80517e9f9492d7930def72db83c14e
2021-01-04 13:43:16 -05:00
Jatin Chaudhary e14dbaeb6e Adding file command as dependency
Change-Id: Ic719c5ce8ad0d99f6a341b5b46927587080fcf2e
2021-01-04 00:03:53 -05:00
Sarbojit Sarkar f64af513a2 Revert "Fix hipmemset to match CUDA behavior"
This reverts commit 9ba5902be4.

Change-Id: I53052b25bac4956f3efd124eadc936197f2e466a
2021-01-01 00:11:58 -05:00
agodavar f3e350cd12 SWDEV-239065 Refactor hipcc, added new perl module hipvars
Change-Id: I2b71ceb2563501c7b2861cd0f2e23d01207b1bc2
2020-12-31 05:41:36 -05:00
agodavar 7dcf2769ae hipmemcpy2D handle height 0
Change-Id: I46bf89e81559c3bfccac0dd0ccd78eee9058c7e3
2020-12-31 01:41:56 -05:00
agodavar e7c85da68b SWDEV-265171 Remove hcc compiler support from hipcc
Change-Id: Ibd06e68dd1f079b2f9e46606bdbfc0a0a780b638
2020-12-30 06:26:09 -05:00
agodavar c5e3f955bf SWDEV-266089: hipStreamAddCallback argument validation
Change-Id: I3e61006796e88b4e2ba029118c95f3499959257b
2020-12-29 05:42:54 -05:00
Sarbojit Sarkar 567a95b4e4 SWDEV-262810: skip duplicate compile flag inclusion
Change-Id: I02ebfb3cbaf6ec25819de0c4952795c6cc949e4d
2020-12-20 23:26:55 -05:00
Sarbojit Sarkar 872d8b7fc6 SWDEV-265344: fix for dtest build issue
Change-Id: I561546cb792fc0b33c03b17ba2ccf62802f05656
2020-12-20 23:26:20 -05:00
agodavar d74777d2a7 SWDEV-263180 : Fix null ptr dereference
Change-Id: Iefc9fa3f195af45a5c5ebe075056246c930a6d84
2020-12-19 02:02:54 -05:00
jujiang 84db670474 SWDEV-265003-Fix hip faq
Change-Id: Ifd29fd9c20ecc905c63fa39fd0768eaca3953aac
2020-12-18 12:21:36 -05:00
Rahul Garg 9ba5902be4 Fix hipmemset to match CUDA behavior
Make hipMemset asynchronous with respect to the host unless
destination pointer refers to pinned host memory.

Change-Id: I5ba230e0cc622aa076dc94692a4c43a57dd2df7b
2020-12-17 19:13:31 +00:00
Evgeny 52b86dfc1c SWDEV-263773 : adding CMAKE_TESTING_TOOL cmake argument
Change-Id: I28df2344d000a0dbef07f45971a9dc92fe07fb27
2020-12-15 17:52:30 -05:00
Evgeny e54f2a1af1 SWDEV-259683 : hipprof: adding hipApiIdByName() method
Change-Id: I1ad2be76efc9fb690ed7c9c2b1091f7eb0c04a31
2020-12-15 15:42:10 -05:00
Satyanvesh Dittakavi f06393c75f SWDEV-258754 Fix seg fault hipMemset with device pointer mapped from hipHostRegister
Change-Id: Ifab66b67df172812ebb6eb25c2bac71821f4d614
2020-12-15 07:44:34 -05:00
Satyanvesh Dittakavi 40733e1fff Fix hipPointerGetAttributes
Modified hipPointerGetAttributes to support hipHostRegister ptrs and mapped device ptrs from hipHostRegister
Change-Id: I2f4cf12e09578768308f644123d6d4bdccbd77a8
2020-12-15 01:40:24 -05:00
jujiang b14bf9e98b SWDEV-249486-Add doxygeny for API hipExtModuleLaunchKernel
Change-Id: Id7451ef4f669238a38ed92ec72008326c85afc4a
2020-12-14 15:34:32 -05:00
Tony eab357b852 Correct parsing of target names and supported targets
Change-Id: I6aed72759e6fb4da6834aa80131897dad641e693
2020-12-14 18:20:56 +00:00
Sarbojit Sarkar 1ef88375c2 Updated review comment
Change-Id: Ic7f9f33dd23c975f2a7a0f0d485a3d2a457c62bb
2020-12-13 11:30:28 -05:00
Tao Sang a7aa84f73a Some improvements on hip cmake file
1.Fix unexpected repeated hip runtime lib building
2.Seperate test cmake from top cmake.

Change-Id: I1ae457effd639d6c25bca293c1724b026be21ecd
2020-12-11 13:32:15 -05:00
Aaron En Ye Shi d432615faa Fix hipTestFMA to support older compiler
The older compiler does not promote integral
arguments to double, instead it uses float.
This patch tries to support the old compiler
headers, and also the newer one.

Change-Id: I01e0b96a82ecddc6230cb5baf2573a318b25445b
2020-12-10 14:27:42 -05:00
Rahul Garg 584771e7a2 Handle overflow
Fixes SWDEV-261712

Change-Id: I730fcdca8c2640fde9cfdfe2f4b4cf4894807fed
2020-12-09 19:09:43 -05:00
Tao Sang 1cba7ec965 Remove hip-hcc codes: Part one
Remove hip-hcc codes from hip code base
Simplify hip CMakeLists.txt to exclude hip-hcc
Simplify cmake cmd for hip-rocclr building
Some minor fixes

Change-Id: I1ae357ecfd638d6c25bca293c1724b026be21ecd
2020-12-09 15:49:47 -05:00
Aaron En Ye Shi f7b5fea916 Add HIP Sample 2_Cookbook/17_llvm_ir_to_executable
HIP supports compiling kernels from LLVM IR into executable.
The device LLVM IR needs to be compiled into a fat binary
object. This device object is embedded into a host object using
llvm-mc directives. Then, any host linker may link the host and
device objects together into an executable. A README was added.

Change-Id: I8ebb6ae86b7ab4290f7cba2eea5584d73a7c453e
2020-12-09 15:48:53 -05:00
Aaron En Ye Shi b8b90f344c Add HIP Sample 2_Cookbook/16_assembly_to_executable
HIP supports compiling kernels from assembly into exec.
The device assembly needs to be compiled into a fat binary
object. This device object is embedded into a host object using
llvm-mc directives. Then, any host linker may link the host and
device objects together into an executable. A README is added.

Change-Id: I59d3a8b5363073810ffc3aa0d57f21b0df272369
2020-12-09 15:48:41 -05:00
Saleel Kudchadker 08a65054ea Honor hipEventDisableTiming event flag
Change-Id: Ia949db96e81b9af467f04ab40d143e8d6faa9394
2020-12-09 15:10:18 -05:00
Jatin Chaudhary 24b997119f Updating the gcnArchName to now have target id
Change-Id: Ibd5576e0fb5b46e8f212de4ec57cd96eb1d3c157
2020-12-09 01:22:08 -05:00
Aaron En Ye Shi 9c041b1984 Fix hipTestFMA to align with libcxx
The HIP-Clang math headers upstream have been updated
to perform type promotion on math function overloads.
If any argument has integral type, it will be cast to
double.

Change-Id: I38d9e6240c40c4092b946851469498b2ae6500ae
2020-12-08 10:48:29 -08:00
Jatin Chaudhary 19e234b420 Adding -Wl,@response_file and @response_file mechanism to hipcc
Change-Id: Ic2053a38034b9366cf82fc01b7ea6b52e0f17077
2020-12-07 13:38:35 -05:00
Jatin Chaudhary dfe6f1ef27 Adding checks for function, size and params in ihipModuleLaunchKernel to have common message for hipModuleLaunch and hipExtModuleLaunch
Change-Id: I11921ad753930872572571dbfd1c12daba83a725
2020-12-07 03:17:14 -05:00
Sudheer Kumar da6de84535 compiler argument update for nvcc
Change-Id: If40caf20543cc29301482deddfb03d6fccb6f3c9
2020-12-06 23:21:14 -05:00
sumanthtg 8ad39c41d8 [dtest] hipOccupancyMaxActiveBlocksPerMultiprocessorWithFlags() - Additional test
Additional test for flag

SWDEV-238517 for enhancing hip unit tests

Change-Id: Ieca443678c122e291b9d4cd16f7198505cd5d6c3
2020-12-06 23:19:23 -05:00
Satyanvesh Dittakavi 542d3219dc Modify atomicAdd float to use clang builtin
SWDEV-261229: Change atomicAdd float implementation to use clang builtin
along with deprecating atomicAddNoRet
Change-Id: I5e98034fec54ee1a2b85d5f56273e34945d49ea3
2020-12-03 23:59:10 -05:00
Saleel Kudchadker db7ed1a78c Add a new flag for profilingInfo to record gpu TS
Add a flag to record gpu TS in a marker, also disable marker flush
if there was already a marker submitted before.

Change-Id: I9cdf8e49137690c0050fe9370764dd059855a2f8
2020-12-03 13:45:39 -05:00
agodavar 273e83ff6c SWDEV-256810 : hipMemcpy2D API handle width, src/dst pitch 0
Change-Id: I4f60b220624f4235c0c3daf68adcd5a496e93696
2020-12-03 10:34:12 -05:00
Sarbojit Sarkar a08ddb4b53 SWDEV-258579: hipMemcpy2D better error handling
Change-Id: I09378d6e31da99451e22cbe9276a5ff1ad4a1840
2020-12-03 05:50:42 -05:00
agodavar ef415ec610 SWDEV-259210 : Handle invalid inputs for hipDeviceGetByPCIBusId and hipDeviceGetPCIBusId APIs
Change-Id: Iab48604941c4c715ee3357ace2e2d26dbc8cad33
2020-12-02 00:01:54 -05:00
Sourabh Betigeri 4b3c04c3b0 SWDEV-255397: Added new perf test for hipMemset* APIs
Change-Id: Icb12360ebde003e006cc4dceccac7ebe42712a3f
2020-12-01 12:30:58 -05:00
Yaxun (Sam) Liu b49d801c5d Update documentation for supported clang options
Change-Id: I5d7017cd5c4335959fe5bae322e90aa46cdbc672
2020-12-01 12:00:10 -05:00
Michael LIAO f3b63c004a Fix hostcall test build.
- As `long`/`ulong` on Windows has different bit sizes from Linux
  platforms, even compiled in 64-bit mode. Need to use portable data
  type `int64_t`/`uint64_t` as possible or use `long long` ones to
  match the prototype in LLVM IR.

Change-Id: I62fe16a2e53aa0f2f2b4069b8a1596b8db7050c9
2020-11-30 16:47:16 -05:00
Siu Chi Chan 703816a7e1 Update HIP docs
Purge all obsoleted information that is only relevant to HCC

Change-Id: Ice6ae174a73ccac9dfe2ca05027d1ecdb32558d7
2020-11-27 14:48:09 -05:00
Rupam Chetia 4b16d3896d [dtest] Tests for hipExtGetLinkTypeAndHopCount() API
1. Negative Test Cases
2. API functionality tests for hopcount and linktype using rocm-smi library.
3. API functionality test for hopcount when devices are reversed.
4. Disabling test case 7.
5. Implemented External Review Comments.
6. Created a new header file hipP2pLinkTypeAndHopFunc.h.
7. Removed test case 0x7 from directed test.
8. Put testMaskedDevice() under __linux__, placed TODO in line 404 (comments) and replaced '&=' with '='.

SWDEV-238517 for enhancing hip unit tests

Change-Id: I1ae256ecfd637d6c25bca293c1724b026be20eca
2020-11-26 09:30:38 -05:00