Commit Graph

5434 Commits

Author SHA1 Message Date
Jason Tang 67baf4f506 SWDEV-227909 - Add gcnArchName
Change-Id: Iea6d16b5d693dd0d900fa424d7a321c39315430e


[ROCm/hip commit: 1c0d737e1f]
2020-06-05 15:33:55 -04:00
kjayapra-amd 0bdff1ff07 SWDEV-234295 - Pass flag to ROCclr to not clear device programs during program::build()
Change-Id: I50b9fa1a96da6895f73fdf4a7c0d3f096b1188da


[ROCm/hip commit: 8941d19fe8]
2020-06-05 09:53:11 -04:00
rohit pathania 791e62287c [ dtest ] hipModuleLaunchKernel multiThreaded n multiGPU scenarios
1.Added hipModuleLaunchKernel multithreaded multi GPU scenario.
2.removed hipCtxCreate API from earlier test as it is deprecated.

SWDEV-238517 for enhancing hip unit tests

Change-Id: Id102d80887b6ff61a59938dbeb9fa2a26a3275b2


[ROCm/hip commit: cc6a87e9e3]
2020-06-05 09:40:58 -04:00
Lakhan Singh Thakur 55f368c3a0 [dtest] merge 'Adding the two test cases to cover scenarios observed in SWDEV-181598.'
SWDEV-238517 for enhancing hip unit tests

Change-Id: Ie61145b46c89b2e970af0ab11e22b6f6286ec90f


[ROCm/hip commit: fb77b2497c]
2020-06-05 09:10:23 -04:00
Aryan Salmanpour 1cdccedef9 Add support for setting hip stream priority
this change follows CUDA convention where lower number is greater priority

Change-Id: I72596a36449e818cbd8c175bf8519c51f46b1610


[ROCm/hip commit: 1bb86658cc]
2020-06-04 22:50:30 -04:00
Payam dac652e8df Observed softhang while running hipStreamAddCallbackCatch SWDEV-236746
Workaround hipStream deadlock issue as the same lock was used twice SWDEV-236746

Change-Id: Icc60104ce6edf4cfd2a3a889bab78a6caadd50b7


[ROCm/hip commit: a524f13c97]
2020-06-04 14:11:22 -04:00
Aaron En Ye Shi 9aa9282f89 Add gfx908 to hip-config.cmake
Support gfx908 as part of the default AMDGPU_TARGETS. MIGraphX requires this change.

Change-Id: I692f87f27829778e04f59c9ca655c6e8cbc00abc


[ROCm/hip commit: dc2caed525]
2020-06-04 11:00:09 -04:00
Siu Chi Chan b8db8cac9b add constexpr constructor for vector types
Change-Id: I45bb0537d6a24ee50b548c2fd8b4f20518764813


[ROCm/hip commit: 784ca6f43c]
2020-06-04 01:57:03 -04:00
Evgeny 037da0c744 adding hipGetStreamDeviceId() profiling API
Change-Id: I5ccf88ddac123260d7c17defefcf20ff3b2504e2


[ROCm/hip commit: cad3f805c0]
2020-06-03 18:57:49 -04:00
Aaron En Ye Shi 9dabdf86fe Add compiler-rt library for __fp16 and _Float16
Similar to HCC, link with compiler-rt to support __fp16 and _Float16 type conversions in ONNX models. This should resolve SWDEV-238491.

Change-Id: Iad8dcff568831719f501f562a04023326ae8036c


[ROCm/hip commit: 56392b4f8a]
2020-06-03 18:53:14 +00:00
Siu Chi Chan 20abb9dcc7 update device library path
fix device lib directory

add missing --hip-link switch for link phase

Change-Id: I4b2eeb32648ca3cec72ec1f4e3381ce1fc0a90a5


[ROCm/hip commit: f20748854e]
2020-06-03 14:44:23 -04:00
Jatin 7b52f0a1ea Adding changes for hipExtLaunchKernel for rocCLR
Change-Id: Iba52bc3bde7c37f3fb375a55ba0947e87b3cdc9b


[ROCm/hip commit: 2d517fdcc6]
2020-06-02 14:16:41 -04:00
Rahul Garg 1be23e215c Use right perl-which rpm package
Change-Id: I22106a7d1b4b50c99f945bc6416ff3bd8486d15c


[ROCm/hip commit: 88720e2e77]
2020-06-02 02:17:54 -04:00
Aaron En Ye Shi 5ef8eb7375 HIP-Clang Temporarily include HIP_HCC_FLAGS for PyT
Change-Id: I0f5895fba69f5bf0c6cc13e9402bdc44726dcc5a


[ROCm/hip commit: 13ac055fc2]
2020-06-01 15:28:04 -04:00
Aryan Salmanpour dee385497d Add support for missig hipStreamGetPriority API
Change-Id: I2be4b055e5f977eb6ecad0b1f5f9535e72345fe7


[ROCm/hip commit: 4a1536701f]
2020-06-01 13:33:14 -04:00
agodavar 76cb1b1644 hipMemset dont enqueue command if size bytes is 0
Change-Id: I63bf896f9f23edf254acdf7a8c11c92f8b5ac039


[ROCm/hip commit: 39ee03f64c]
2020-05-30 10:33:44 -04:00
Rahul Garg e97fb496f0 Add libfile-which-perl dependency SWDEV-237642
Change-Id: I0799fdcbc58a35c957a3bc69a8a1c6a013a3f57c


[ROCm/hip commit: 7259b70f60]
2020-05-29 20:04:23 -04:00
kjayapra-amd 6d2ec4c700 SWDEV-229840 - fixing return HIP_RETURN instances in hip.
Change-Id: I48763d7268bf5649bf2242c962c185f5f4af159c


[ROCm/hip commit: aae3e13296]
2020-05-29 09:43:58 -04:00
Aryan Salmanpour cddd09b85d [dtest] add a multi stream test for (SWDEV-237846)
Change-Id: I4a1d764df75af7019d0f38313e5e0a6a224818f8


[ROCm/hip commit: e44d7f578b]
2020-05-28 23:36:10 -04:00
jujiang e2693157fa Update document for hip_faq.md, hip_porting_guide.md and hip_terms2.md
Change-Id: I2c019f802ad70ed43f1608cfd3c9067f1573741e


[ROCm/hip commit: 0d64ed06e9]
2020-05-28 17:51:58 -04:00
Christophe Paquot e97106dda4 Revert "Call notifyCmdQueue when building the event wait list"
This reverts commit 9263f193d0.

Reason for revert: better fix in ROCclr

Change-Id: I9707e69adf42a662c08fe9b3ec7458655d838bdd


[ROCm/hip commit: 7e57136aba]
2020-05-28 17:01:10 -04:00
kjayapra-amd cdd32d1fd0 SWDEV-233927 - Crash if binary for current device is not found.
Change-Id: I57281ae6c09110f39155664fca5a83ea57bb62b4


[ROCm/hip commit: 0599855f0d]
2020-05-28 16:18:27 -04:00
Joseph Greathouse 6690e7a9e0 Fix a build error on signed/unsigned comparison
Change-Id: Ic79eb4c3ec5c6fd36cea7c4810d990619f08b9e1


[ROCm/hip commit: 1f25e4956c]
2020-05-28 14:27:16 -05:00
kjayapra-amd 7002be9c95 SWDEV-236465 - Return error code as soon as global creation fails.
Change-Id: I790b8b4fdd6ab8818bc5b6b9a79e6900b840372d


[ROCm/hip commit: db972c4f2a]
2020-05-28 13:28:23 -04:00
Joseph Greathouse 72de06128e Fix occupancy calculation functions in ROCclr path
The hipOccupancyMaxPotentialBlockSize API is meant to return the
number of threads for the highest-occupancy workgroup, and the number
of those workgroups. It was previously calculating the number of
maximum-sized workgroups that would fit on a single CU. This is
a mixture of the API we wanted (to calculate max potential block size)
and the MaxBlocksPerMultiprocessor function.

This patch fixes it up so that the internal occupancy calculation
function works for two uses: the traditional function that calculates
the maximum blocks per multiprocessor when a user passes in a fixed
block size (used for hipMaxBlocksPerMultiprocessor style functions)
and a function that calculates the size of a block that would lead
to maximum occupancy, and how many blocks of that size would be
needed to fill the whole GPU (for hipOccupancyMaxPotentialBlockSize
style functions).

This also updates the occupancy calculation function to prepare for
gfx10, which does not have SGPR-based occupancy limits.

Change-Id: Ie007b3f9d5ebc4e166b50a3a051498af35650f35


[ROCm/hip commit: ebe5054e04]
2020-05-28 10:22:10 -05:00
Evgeny 14b9967374 adding hipKernelNameRefByPtr function
Change-Id: Iefc18967b10394b85a207ffdb5bbfe5e3601474d


[ROCm/hip commit: ef7ff69ff0]
2020-05-28 10:59:48 -04:00
Matt Arsenault be81bc1593 Attempt to handle case where git isn't available
Git may not be available, and this may not be a git checkout, as would
happen in a release tarball. Doesn't really attempt to get a nicer
version formatting if some of the git subcommands fail.

Change-Id: Ib568cd1310983a43f2664ded72528d7e41f554c0


[ROCm/hip commit: 1983d720c2]
2020-05-28 09:23:24 -04:00
Saleel Kudchadker 3c9945976e Fix elapsed time calculation for null stream
SWDEV-237377 - This fixes time calculation where the event may
be recorded on Null stream and work submitted on other streams

Change-Id: Ie36310dea5cee2fed4a514ed01f04db4b47e571c


[ROCm/hip commit: fb2d7bcd2b]
2020-05-27 18:42:07 -04:00
Michael LIAO bb268f27fc [hip] Those texture interfaces are C interfaces should be always exposed.
Change-Id: Ie34f1420839b17486346149b1672e70ec0088b54


[ROCm/hip commit: f6addba699]
2020-05-27 15:03:59 -04:00
Christophe Paquot 9263f193d0 Call notifyCmdQueue when building the event wait list
SWDEV-237846

Change-Id: I8bf70e7ad19903767a080d8c6e516c83b0dc2545


[ROCm/hip commit: 3ba07f5e3c]
2020-05-27 12:53:46 -04:00
Sarbojit Sarkar 587471a46c [doc]shfl*sync update
1. Updated FAQ with shft*sync not supported hip_faq.md
2. Corrected some of input parameter description in hcc_details/hip_runtime_api.h
3. Redirect shfl*() to shfl_*_sync() for nvcc path where CUDA > 9.0

Change-Id: I3d8184db5fcc622852c9bad96b706348e8dfc16c


[ROCm/hip commit: 83b11f9a61]
2020-05-27 02:17:40 -04:00
Aryan Salmanpour 72a611f9e3 [dtest] add a test for hipExtStreamCreateWithCUMask API
Change-Id: Ib567e559c5ab7d04ac5c300fd7e15eedfc4fb6e6


[ROCm/hip commit: 9b6228f6c9]
2020-05-26 18:15:09 -04:00
Christophe Paquot 3f6aa846a4 hipDeviceSynchronize needs to sync NonBlocking streams as well
SWDEV-237167

Change-Id: Ie916d8f03ce91e8ef05a2b4edc580a7021520f6f


[ROCm/hip commit: f7ed87b02b]
2020-05-26 17:59:22 -04:00
Ramesh Errabolu 906404ef81 Remove dependency on hsa-ext-rocr-dev package
Change-Id: I1147a299c31ce1ae5978b7312d82fa83d796b019


[ROCm/hip commit: c98e8e4998]
2020-05-26 14:40:42 -05:00
Evgeny d55d242eb7 hip_prof: fixing printing pointer args
Change-Id: I93969723650f7c29d5c00a3809d3701c6a3dca44


[ROCm/hip commit: f9e086ae8a]
2020-05-25 13:17:16 -04:00
kjayapra-amd 542c7874a7 SWDEV - 237467 - Return proper hip error codes incase of ROCclr IPC API failures.
Change-Id: I2cc8da543f70bb3d8b82520fa9b2f509d20ce3c0


[ROCm/hip commit: b44ae437bc]
2020-05-23 10:51:37 -04:00
Dittakavi Satyanvesh 142f3e859b hipIpcCloseMemHandle checks the status of IpcDetach
Change-Id: Ifbe8e5bbda610a1007f881627d0da1c874d03682


[ROCm/hip commit: c068778062]
2020-05-23 08:47:36 -04:00
Mahesha Shivamallappa 5d530df13d Add support for cooperative group type - thread_block
Change-Id: If3770b6d6718a638b70f527ae2533d9ef3267ff4


[ROCm/hip commit: 01dae52d64]
2020-05-22 23:08:42 -04:00
Matt Arsenault 7e55714dd5 Remove ROCclr search hacks
find_package should now be the only way to import ROCclr. Also update
the build example comment.

The build scripts used 2 custom variables to manually specify the
build and source directories for where to find VDI. Once renamed to
ROCclr, these conflicted with the variables automatically set by
find_package(ROCclr). These hacks tried to satisfy this intermediate
step to try satisfying commit ordering problems to get through PSDB.

The INSTALL.md documentation should also be updated, but it's
completely missing any mention of ROCclr now, and still gives
directions for hcc.

Change-Id: I6fc94b6cb36241a9d4f22d24e49523367f803461


[ROCm/hip commit: a2d2709ec1]
2020-05-22 15:52:35 -04:00
Vlad Sytchenko b91cc2fbfb Reenable texture reference tests
Change-Id: I77024476cff77951d61dc48f7e30094d6b47266c


[ROCm/hip commit: 81ba0fcfd9]
2020-05-22 14:13:50 -04:00
Tao Sang 771f126190 Fix square build failure with static lib in Jenkin
When libamdhip64_static.a is built by Jenkin, sample square cannot been
built successfully because libamdhip64_static.a is archiveved in thin
mode. Thus in the patch it will be archiveved in full mode. Meanwhile
libamdhip64_static_temp.a will be useless and thus removed.

Change-Id: Ifd3882598ef0dc5e7af8db0e389e786025ceb455


[ROCm/hip commit: 470b89a6bf]
2020-05-22 11:49:52 -04:00
Aryan Salmanpour e0b47cf44f Add support for hipExtStreamCreateWithCUMask API
Change-Id: I369d0eaca493821c4badc6b18ac02daa2fddc95f


[ROCm/hip commit: 7dd5b19290]
2020-05-22 11:34:06 -04:00
Matt Arsenault 9156cf7be3 Don't search ROCclr_DIR for prof_protocol.h
This points to the cmake directory where the find module was found,
not a prefix for where it was found.

Based on the search below looking in roctracer, searching in ROCclr
for the header doesn't make much sense. The header should be either
provided by ROCclr xor roctracer. Having it possibly be provided by
two different dependencies is confusing, and a potential source of
version mismatch problems.

Change-Id: Ic2f6ec03f9a7b86225cf7e5c43f39a1360318a34


[ROCm/hip commit: d6aad8ae91]
2020-05-22 09:59:09 -04:00
Laurent Morichetti 02d5a7c4b9 load functions when registered if lazy load is disabled
Change-Id: I08c9684ca4ab86a6294ed9e670f3125c1a0cc6c4


[ROCm/hip commit: 22edde84d5]
2020-05-21 09:19:20 -04:00
Sarbojit Sarkar ca8de0f6c8 added null check
Change-Id: I7631965286bad5684bacb7e38c63031b5c691dc0


[ROCm/hip commit: 87d1101a33]
2020-05-20 23:08:55 -04:00
Saleel Kudchadker 7836dfd322 Fix elapsed time calc for hipEventElapsedTime
If the start and stop events have same command internally
then measure command end to command start
Change-Id: Ie70cfa37c06c06573f0ed58dab2bbe4434c1724b


[ROCm/hip commit: 50be95e169]
2020-05-20 16:02:48 -04:00
German Andryeyev 20e64e1450 Add a test case for async double memset
Change-Id: I8a1df610c8d3d942651f258e7812e8697067c347


[ROCm/hip commit: 4503d44e12]
2020-05-20 12:52:29 -04:00
Dittakavi Satyanvesh e9783da3c1 enable occupancy sample on HIP-Clang
Change-Id: I236daad743bbbc7f8daa41e8157a4ff73058518b


[ROCm/hip commit: 700474db6f]
2020-05-19 03:08:19 -04:00
agodavar e5c6555eee Fix hipMemset for unaligned ptr, correct offset required by ROCclr per aligment and testcase to validate unaligned ptr
Change-Id: Ib1a0f9d1556d09cf72a12a90cad2e27c6d9c6a1c


[ROCm/hip commit: 458a966aa1]
2020-05-16 02:38:14 -04:00
Christophe Paquot f0bd04856a [hip] Skip lang guess if -x <lang> is specified.
Change-Id: If5cbdd1e5d36d2d8b83f3eadd0598162691167aa


[ROCm/hip commit: 96704ddd00]
2020-05-15 17:07:40 -04:00