Commit Graph

5519 Commits

Author SHA1 Message Date
Jatin Chaudhary 6c217e7f69 Fixing/Disabling tests on nvcc path
Change-Id: I7ed4a1246943867482ff595d5f98bb25bd79074b


[ROCm/clr commit: d251c2db57]
2020-07-30 00:39:07 -04:00
Freddy Paul 0210995414 hip-rocclr:Remove dependency to rocm-utils
rocm-utils is a meta-pacakge that pull in lot more pacakges than
what is required for hip.

Correct dependency to set as of today will be rocminfo.

Change-Id: I065ca74b4520e0c9ce183d82d6026554ff43e1f0


[ROCm/clr commit: b0438e6e99]
2020-07-28 11:42:09 -04:00
Jason Tang aa179b01a3 SWDEV-243576 - Fix hipMemcpy regression.
If the queue device doesn't match the device on any memory object, use the queue device from the memory object.

Change-Id: I5fdcf00494f8391574f4443332c01788b8da44ef


[ROCm/clr commit: e430506f70]
2020-07-28 03:04:00 -04:00
Jatin Chaudhary 380e2fe752 Removing redundant .hipInfo Install
Change-Id: Id8f7a4668d8b6965a47a464c94c19bc1036f3537


[ROCm/clr commit: 78fcbab8c2]
2020-07-28 02:01:53 -04:00
Rahul Garg 47c57a5a82 Remove libhip_hcc symlinks to libamdhip64
Change-Id: I7b5b47fc7ca9760316c2424c16b454d7919c665c


[ROCm/clr commit: c919a88795]
2020-07-27 23:58:29 +00:00
jujiang e5b39e4056 SWDEV-242344-hipMemcpyAll failed on MGPU
Change-Id: I01671e322c84213964d3d48bd6b5dc704dba731a


[ROCm/clr commit: c1d65e57a1]
2020-07-27 13:30:30 -04:00
Tao Sang d7c4f9f492 Remove __gnu_h2f_ieee and __gnu_f2h_ieee
Change-Id: Ide24d245d851e20961020323e52f33322a33fff9


[ROCm/clr commit: e9cc570be8]
2020-07-23 14:50:24 -04:00
Vlad Sytchenko bddfc6a790 2D/3D copy optimizations
SWDEV-244798

If {src/dst} ptr is marked as hipMemoryTypeHost, check if the memory was
prepinned. If it was, upgrade the copy type to hipMemoryTypeDevice to
avoid extra pinning.

Change-Id: Id287ef5b14ae67dfbcf80c4caa1b08a311191948


[ROCm/clr commit: fe6b645f3b]
2020-07-23 11:24:16 -04:00
Tao Sang 073b1e28d5 Apply constexpr on global constant varaibles
When HIP_ENABLE_DEFERRED_LOADING=0, many global variables will be
referenced but they are not initialized in that early time. The patch
will use constexpr to initialze global constant varables in compile
time.

Change-Id: I9837c42e6bab38a894ece4e0f34b64f81b38fef0


[ROCm/clr commit: f7cc49c0b2]
2020-07-22 22:15:03 -04:00
kjayapra-amd db1fbf23d2 SWDEV-236178 - Remove use of old routines functions()/modules().
Change-Id: I3a1ed967227c91b0d8cdf39e1360ade685e0bc73


[ROCm/clr commit: fd783c1e88]
2020-07-22 14:55:02 -04:00
kjayapra-amd 7aa68bc3cb SWDEV-240800 - Adding initial support for hipDeviceGetP2PAttribute. Some attr support still pending.
Change-Id: I0611aed136270db497dfa374144f6f5e35352a8f


[ROCm/clr commit: 311fc8c513]
2020-07-22 14:54:34 -04:00
Payam d1e3736fc3 modify cmake to strip debug symbols from rel blds
Change-Id: Ia67261fc3c4a20f3f1bbe439a70384a3f6aefa91


[ROCm/clr commit: 274fded47d]
2020-07-22 11:53:54 -04:00
Tao Sang 25c98ea4de Support numa if libnume-dev is installed
Let rocclr decide numa dependence

Change-Id: I65bdfba7ec0d06b550f86632318bcfd1f765cfa9


[ROCm/clr commit: eba78710dc]
2020-07-22 08:55:28 -04:00
Satyanvesh Dittakavi 89d36cba5f SWDEV-244772 - Fix dtest hipMemcpyWithStreamMultiThread.cpp.
hipSetDevice is not used correctly to allocate on multiple devices in mGPU setup.
Due to which hipMalloc was called on the same device on multiple threads leading to out of memory issues on some devices with lesser memory.

Change-Id: I0e5b1bc028b9ecb11bd40c3a5edf715f8bd721ff


[ROCm/clr commit: 6f5e63ebac]
2020-07-22 00:52:14 -04:00
Saleel Kudchadker 2bf550d3c1 Print devPtr and size for hip*Symbol* api
Change-Id: I07be6949cca005700ee1d1708d86220c793c9728


[ROCm/clr commit: 603546cd45]
2020-07-21 13:49:10 -04:00
Rahul Garg 7654a45737 Handle size 0 symbols
Change-Id: Ie282b37cf6bbccae4611dfc17c5c7f31977feea7


[ROCm/clr commit: 19ede4fd23]
2020-07-21 10:09:26 -04:00
Aryan Salmanpour dfc8958316 Add missing stream null check for some hipStreamCreate APIs
Change-Id: I716d71e4ec59b0bd7922869bfa0ed908c22c289e


[ROCm/clr commit: e27d53043c]
2020-07-20 18:07:03 -04:00
jujiang 362faab3f5 SWDEV-242337-Fix hipHostRegister test failure for MGPU
Change-Id: I748dac0c5a47fa00184f065d9ef716573aa70b12


[ROCm/clr commit: 797d2761d4]
2020-07-20 11:40:49 -04:00
Sudheer Kumar 6549bf654e [dtest] Compare hipDeviceGetPCIBusId output with lscpi output
SWDEV-238517 for enhancing hip unit tests

Change-Id: I5507dd19fc22e7f8806655eefaa69fbd61c98f56


[ROCm/clr commit: 94c4462848]
2020-07-20 04:31:48 -04:00
German Andryeyev 9b9d4a9c3c Grab the event lock before fetching the last command
Hip applications assume that hipEventRecord called from multiple
threads will contain exactly the last queued command to the stream.

Change-Id: I1da3259f143d7670d0870d9a47c08e32336b2222


[ROCm/clr commit: 5ef00cf6e9]
2020-07-20 02:01:16 -04:00
Ashutosh Mishra 65cce73afe Adapting to static libaray changes for hipcc
Since the introduction of BUILD_SHARED_LIBS there is only one target created : libamdhip64
Which is static ( libamdhip64.a ) or Dynamic ( libamdhip64.so ) depending on whichever it is
being compiled for. After this change we do not have any target libamdhip64_static which is
mentioned in the hipcc for linking. Hence cleaning the same.

Change-Id: Ia45c145e17b111b3f6a32299a11962b10f1cc539


[ROCm/clr commit: 7d3d8c8e6d]
2020-07-17 14:42:07 -04:00
jujiang 0aef2093d9 SWDEV-243933-update HIP README document
Change-Id: Ie303698ae92c7fa1b1202c1ee06beda1005ba065


[ROCm/clr commit: 50b299da66]
2020-07-17 12:26:05 -04:00
Christophe Paquot d8042a02ad Remove use of setLastQueuedCommand
Change-Id: I07bf54dc09905d9a17b059a476df9282eb6f1f51


[ROCm/clr commit: a838e6e108]
2020-07-17 11:45:25 -04:00
Evgeny 5b974209a0 cleanup: unneeded '\'
Change-Id: I0276312fdb0e4829d678de4281ccfd12eb7f232e


[ROCm/clr commit: 49091c2463]
2020-07-16 01:57:07 -05:00
Ashutosh Mishra beda35b8af Adding "BUILD_SHARED_LIBS" flag to cmake files
JIRA : SWDEV-234471
With this change compilation of the ibamdhip64 to be decied by arguments to build_hip_on_rocclr.sh file
build_hip_on_rocclr.sh -r (current) shall conitnue to create libamdhip64.so;
build_hip_on_rocclr.sh -r a (new) shall create libamdhip64.a
other options remain the same

Changed the targets according to requirement of stage2 dependencies.
Changed find_lib with find_package

Adpated the review comments

Change-Id: I719918f73ab33cd8031a32db6fe9b8adaa1b4b87


[ROCm/clr commit: a77c7e21be]
2020-07-16 00:29:14 -04:00
Sudheer Kumar 31e62c5852 [dtest] Enhanced tests to cover multiple hipmemset and hipmemsetAsync apis
SWDEV-238517 for enhancing hip unit tests

Change-Id: Iba2c419a4487955f34b4f19abe174ef427d289d8


[ROCm/clr commit: 7d77902198]
2020-07-15 01:13:07 -04:00
sushantkumar14 14e9205334 [dtest] Half2 comparison related tests
Tests heq2, hne2, hle2, hge2, hlt2, hgt2 APIs for functionality
and NaN tests

SWDEV-238517 for enhancing hip unit tests

Change-Id: I88a9a8ead0d00a1261f3d650361d655f2f397e48


[ROCm/clr commit: fe3cd6ca27]
2020-07-14 23:53:55 -04:00
mshivama 3b311d6c70 Add support for few CUDA compatible reduction operations like __syncthreads_count()
Change-Id: I0917820058f0edad5c0bdd42dea37f06353fc63c


[ROCm/clr commit: 1c5537dde4]
2020-07-14 12:03:14 -04:00
Sarbojit Sarkar a4c135ec8a host pointer check [SWDEV-243104, SWDEV-243206]
Change-Id: Id58dabfe5c35e5f8e42d224e700a431a4a97d003


[ROCm/clr commit: 9ba3732180]
2020-07-14 07:16:12 -04:00
kjayapra-amd 7de79c9a40 SWDEV-240165 - Adding a simple test for IPC memory.
Change-Id: Ib33ac20412cafa779fe20ff4df8a76dc22d50421


[ROCm/clr commit: 6be6cd9ebd]
2020-07-13 10:29:04 -04:00
Tao Sang 5225aff583 Implement HIP_ENABLE_DEFERRED_LOADING in right way
Change-Id: Ia28dbdea5cde93b3ca69f44c6a3c18ec8a730d42


[ROCm/clr commit: 19d6a646bb]
2020-07-11 18:14:03 -04:00
kjayapra-amd 28b5e13757 SWDEV-240165 - Move all amd::MemObjMap_ reference to ROCclr and only allow base ptr to get ipc handle.
Change-Id: I4f11e56ba455a7ce5a066c0e9e49657c5220a211


[ROCm/clr commit: ff36244b9c]
2020-07-09 21:19:50 -04:00
German Andryeyev 7fea66c9e9 Host device context should return a valid queue
Host memory allocations use shared device context, which allows
to have access from any device. That breaks default queue detection.

Change-Id: I27ad1234d49ab0ea8f5edd6f2e3ffa93c47d4b1f


[ROCm/clr commit: ef75a3c1db]
2020-07-09 10:56:33 -04:00
sushantkumar14 985e113fdb [dtest] Added hipStreamGetPriority API test
SWDEV-238517 for enhancing hip unit tests

Change-Id: Icff175360815ba6e25a6954a67947b65caff3711


[ROCm/clr commit: 2dc42154c4]
2020-07-09 01:59:44 -04:00
jujiang 3eb6440e59 SWDEV-242207-Update deprecated APIs
Change-Id: I0c1c7f33f75232b210495241d0e5e7e6b90d45f0


[ROCm/clr commit: b90f3732ea]
2020-07-08 15:23:52 -04:00
jujiang da470ad95f SWDEV-241903-Add document HIP_logging.md
Change-Id: I348218218b305e845b7e26afaeb4e287bf0387de


[ROCm/clr commit: e73e0d2fb3]
2020-07-08 11:19:33 -04:00
Rahul Garg 6d8419f433 Bump version to 3.7
Change-Id: Id077c317573e95833c8bc7f16951df776de2a273


[ROCm/clr commit: 27002fd792]
2020-07-08 01:54:05 -04:00
Aryan Salmanpour c69f88fe04 add an error message before aborting if a wrong GPU target was used for compilation
Change-Id: I7b41e93d420dbc47978238a681f2956a0def01cb


[ROCm/clr commit: 8f862becd0]
2020-07-07 14:50:44 -04:00
Lakhan singh Thakur 4bf371401d [dtest] Enhancing hipStreamAddCallback() api test
-Scenario-1:: This test case is used to verify if the callback function
              called through  hipStreamAddCallback() api completes the
	      execution in order as hipStreamAddCallback() api queued
	      in their respective streams: hipStreamACb_AltEnqueue.cpp
-Scenario-2:: This test case tests if Host thread continues with next
              command after hipStreamAddCallback() api or wait for
	      callback() call to finish. Ideally Host thread should not
              wait for callback to
              finish: hipStreamACb_ThrdBehaviour.cpp
-Scenario-3:: Streams are launched in individual GPUs with different
              kernel Verify that all the kernels queued are executed
	      before the callback is hit: hipStreamACb_MStrm_Mgpu.cpp
-Scenario-4:: Checks the callback execution in the same order it was
              added. Also, it checks if the number of callbacks
	      executed are same as the number of callbacks added:
	      hipStreamACb_order.cpp
-Scenario-5:: This test case checks whether hipStreamSynchronize() is
              taking less time than the time taken by Callback()
	      function launched by hipStreamAddCallback() api :
	      hipStreamACb_StrmSyncTiming.cpp
-Scenario-6:: This test case is used to check if the runtime is ok when
              hipStreamAddCallback() is called back to back multiple
	      calls: hipStreamACb_MultiCalls.cpp
-Scenario-7:: This test case is used to check the behaviour of HIP when
              multiple hipStreaAddCallback() are called over multiple
	      Threads:hipStreamACb_MultiThread.cpp
              (Currently disabled)

SWDEV-238517 for enhancing hip unit tests

Change-Id: I9c7b7df6766c728b2b201df18726b9fbdd434c06


[ROCm/clr commit: 18f8b15523]
2020-07-07 00:43:32 -04:00
Michael LIAO 8ad59be46d [hipcc] Only add -x hip on HIP-Clang compilation.
Change-Id: I19704c713ad00f92196d7586498e62f80b8cd177


[ROCm/clr commit: b39195b639]
2020-07-06 15:16:51 -04:00
Yaxun (Sam) Liu aad28fd31d Add pow(float/double/_Float16,int)
Change-Id: Ie65d15cd3df9853a3bbd613d8c7188ae39c327c7


[ROCm/clr commit: b72e8b54e0]
2020-07-06 07:38:57 -04:00
Jatin Chaudhary 718c7142d0 Fix error: cannot pass object of non-trivial type string through variadic function when building in debug mode
Change-Id: Idd55ed422addc815fb56c57b05bd4afa9563f2ac


[ROCm/clr commit: 3173dbdec0]
2020-07-06 00:48:40 -04:00
Jason Tang 33b063d7d6 SWDEV-242879 - Not to use fixnames
Change-Id: I3d0e2f3fe6c773e020c8bf8cdfd75fd565d61505


[ROCm/clr commit: c371b4e3b0]
2020-07-02 08:15:07 -04:00
kjayapra-amd 5cf8c4331b SWDEV-236178 - Fixing func_attributes that was over written on redesign.
Change-Id: I157913ae4fa4a3a149817e901f10475b7750188b


[ROCm/clr commit: 2f963728f7]
2020-07-01 11:52:45 -04:00
German Andryeyev f2464edb74 Remove hipMemcpyDeviceToDevice check.
There is hipMemcpyDefault that requires validation also.

Change-Id: I5ae0ffa1c023b7774547acbdc049b84a0c2cb4c5


[ROCm/clr commit: 11b7842f71]
2020-06-30 12:59:54 -04:00
Ronak Chauhan 845c0a5b8a Support passing macros to hipLaunchKernelGGL
This makes hipLaunchKernelGGL take a variable argument list, that will be
expanded before being fed to hipLaunchKernelGGLInternal.

This is different from 4dfef9a25b.

We try to accomodate the case when a kernel template has multiple
type parameters.

Change-Id: I87577d402c92b0f3b51e298f8293f4065e1f6de8


[ROCm/clr commit: 133251a6e1]
2020-06-30 10:44:55 -04:00
Daniil Fukalov a2e2f9b8c6 Add __attribute__((const)) to grid related functions declarations
This is cherrypick of Daniil Fukalov's PR https://github.com/ROCm-Developer-Tools/HIP/pull/2110
which has been committed to master branch.

Make declarations consistent with https://github.com/RadeonOpenCompute/ROCm-Device-Libs/blob/amd-stg-open/ockl/src/workitem.cl
Without the attribute these functions don't have "readnone" LLVM IR attribute. Without it some optimizations fails, e.g. Loop Invariant Code Motion doesn't hoist these calls out of a loop.

Change-Id: Idb599570d142152cc4f6a3c8986384ad7f0c4729


[ROCm/clr commit: 359ea4fcaf]
2020-06-29 13:33:18 -04:00
Cole Nelson 684004ca35 packaging/hip-rocclr.txt: multi-version install broken because of 'hip_rocclr'
Versioning understands 'hip-rocclr' not the deprecated 'hip_rocclr'.
Remove this.

Leaving Provides hip-hcc until package shifts settle down.

SWDEV-242143:

Change-Id: I489fa28dd1394625bc6016a3adda4f73d02da202
Signed-off-by: Cole Nelson <cole.nelson@amd.com>


[ROCm/clr commit: 0b7703560a]
2020-06-25 14:17:16 -04:00
rohit pathania 6b04a13e52 [dtest] hipMemcpyWithStream API multithreaded test scenarios
1.hipMemcpyWithStream with one stream
2.hipMemcpyWithStream with two streams
3.hipMemcpyWithStream multiGPU with one stream
4.hipMemcpyWithStream with kind DtoH
5.hipMemcpyWithStream with HtoH
6.hipMemcpyWithStream with DtoD
7.hipMemcpyWithStream with Default kind
8.hipMemcpyWithStream with Default kind on same device
9.hipMemcpyWithStream with DtoD on same device

SWDEV-238517 for enhancing hip unit tests

Change-Id: I5f55a12bdd7c8d28fcb06db94a491c2ad5ee3004


[ROCm/clr commit: c14e95741b]
2020-06-25 12:51:23 -04:00
Ronak Nilesh Chauhan 179a9974f4 Revert "Support passing macros to hipLaunchKernelGGL"
This reverts commit 4dfef9a25b.

Reason for revert: This patch breaks ROCPrim tests

Change-Id: Ib2235f719861c9f4317c33e86b6c1f8bc669cfd4


[ROCm/clr commit: b15e835d9e]
2020-06-24 04:28:46 -04:00